Title: Fold PrimLen over a manifest string literal · Issue #343 · purescript-lua/purescript-lua · GitHub
Open Graph Title: Fold PrimLen over a manifest string literal · Issue #343 · purescript-lua/purescript-lua
X Title: Fold PrimLen over a manifest string literal · Issue #343 · purescript-lua/purescript-lua
Description: Problem PrimLen is the IR node for Lua's unary # operator — the element count of a table or the byte count of a string. Constant folding handles it over a manifest array but not over a manifest string. Verbatim from Language.PureScript.B...
Open Graph Description: Problem PrimLen is the IR node for Lua's unary # operator — the element count of a table or the byte count of a string. Constant folding handles it over a manifest array but not over a manifest str...
X Description: Problem PrimLen is the IR node for Lua's unary # operator — the element count of a table or the byte count of a string. Constant folding handles it over a manifest array but not over a manifest...
Opengraph URL: https://github.com/purescript-lua/purescript-lua/issues/343
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Fold PrimLen over a manifest string literal","articleBody":"## Problem\n\n`PrimLen` is the IR node for Lua's unary `#` operator — the element count of a table or the byte count of a string. Constant folding handles it over a manifest array but not over a manifest string. Verbatim from `Language.PureScript.Backend.IR.Optimizer`:\n\n```haskell\nreduceArrayRead ∷ Applicative m ⇒ RewriteRuleM m Ann\nreduceArrayRead =\n pure . \\case\n PrimLen ann (LiteralArray _ elements) →\n Just $ LiteralInt ann (fromIntegral (length elements))\n ArrayIndex ann (LiteralArray _ elements) index →\n setAnn ann \u003c$> elements !!? fromIntegral index\n _ → Nothing\n```\n\nThere is no `PrimLen ann (LiteralString _ s)` case, so a string length over a literal survives to the output. Since #247 lifted `Data.String.CodeUnits.length` into this node, the gap is now reachable from ordinary source. `Golden.LengthLift` calls `widthOf \"hello\"` where `widthOf = CodeUnits.length`, and the emitted Lua is:\n\n```lua\n local _ = Effect_Console_log(Data_Show_showIntImpl(#(\"hello\")))()\n```\n\nThe array case beside it folds all the way, from the same golden's `countOf [10, 20, 30]`:\n\n```lua\n local _ = Effect_Console_log(Data_Show_showIntImpl(3))()\n```\n\nSo `#(\"hello\")` should be `5`.\n\n## Approach\n\nAdd the `LiteralString` case. The subtlety is which length to use: in `pslua` a PureScript `String` is a Lua byte string holding UTF-8 (see `docs/QUIRKS.md`), so `#s` at runtime is the *byte* count of the encoded literal, not the character count of the Haskell `Text` the IR carries. Folding to `Text.length` would be wrong for any literal outside ASCII — `#(\"é\")` is 2, not 1. The fold must therefore measure the literal exactly as the printer encodes it, which is the same encoding decision the string printer already makes, including the lone-surrogate/WTF-8 path the codebase handles deliberately. Reusing that encoder rather than re-deriving a byte count is what keeps the fold and the emitted literal from disagreeing.\n\n`Data.String.CodeUnits.length` is the operation whose PureScript semantics this matches: it counts code units, and in this backend a code unit is a byte.\n\n## Verification / Measurement\n\nA folding unit test per class in the optimizer spec: an ASCII literal (`#\"hello\"` → `5`), a multi-byte literal where the byte count and the character count differ (so a `Text.length` implementation fails the test), and a lone-surrogate literal to pin agreement with the printer's escape path.\n\n`Golden.LengthLift`'s Lua golden then moves from `#(\"hello\")` to `5`, with its `eval/golden.txt` oracle unchanged at `5` — the oracle is what proves the fold computed the same number the runtime did.\n\n## Prerequisites / Relations\n\nIndependent. Follows #247, which made the node reachable from string source.\n","author":{"url":"https://github.com/Unisay","@type":"Person","name":"Unisay"},"datePublished":"2026-07-28T18:32:35Z","url":"https://github.com/purescript-lua/purescript-lua/issues/343"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:76e5ff63-59a7-6500-909e-1dfc03885881 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 905A:14ECB:500008:678913:6B00D945 |
| html-safe-nonce | 451836ada3338d64e530a128df060f7749f4607213dccede13557ac9a55de318 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MDVBOjE0RUNCOjUwMDAwODo2Nzg5MTM6NkIwMEQ5NDUiLCJ2aXNpdG9yX2lkIjoiMTM5NDY1MDcxODMxNjU4MzIzNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | cd67c2d4288c474ddc833e9541857dcadaf55dbce20a31db11cb692906c649ec |
| hovercard-subject-tag | issue:5001844937 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/purescript-lua/purescript-lua/343/issue_layout |
| twitter:image | https://opengraph.githubassets.com/71f4a1a248c909645e1d7e7aa6dd58c492e80105877a5b17f81d59489a4771e0/purescript-lua/purescript-lua/issues/343 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/71f4a1a248c909645e1d7e7aa6dd58c492e80105877a5b17f81d59489a4771e0/purescript-lua/purescript-lua/issues/343 |
| og:image:alt | Problem PrimLen is the IR node for Lua's unary # operator — the element count of a table or the byte count of a string. Constant folding handles it over a manifest array but not over a manifest str... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Unisay |
| hostname | github.com |
| expected-hostname | github.com |
| None | a481f62a1e04c9b9bdcb5628230682c66d59006f5b13b080f79cba84a176905b |
| turbo-cache-control | no-preview |
| go-import | github.com/purescript-lua/purescript-lua git https://github.com/purescript-lua/purescript-lua.git |
| octolytics-dimension-user_id | 131581790 |
| octolytics-dimension-user_login | purescript-lua |
| octolytics-dimension-repository_id | 587200487 |
| octolytics-dimension-repository_nwo | purescript-lua/purescript-lua |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 587200487 |
| octolytics-dimension-repository_network_root_nwo | purescript-lua/purescript-lua |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 84c8c5cc25e2fb7f2308428458538436baecc6d2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width