Title: Shed the magic-do effect thunk for any expression body, not only a call · Issue #342 · purescript-lua/purescript-lua · GitHub
Open Graph Title: Shed the magic-do effect thunk for any expression body, not only a call · Issue #342 · purescript-lua/purescript-lua
X Title: Shed the magic-do effect thunk for any expression body, not only a call · Issue #342 · purescript-lua/purescript-lua
Description: Problem An Effect/ST statement in pslua is represented as a thunk that magic-do runs by applying it to the EffectRunArg marker. When the foreign lifter has translated a runEffectFnN/runSTFnN wrapper, that application reduces to a literal...
Open Graph Description: Problem An Effect/ST statement in pslua is represented as a thunk that magic-do runs by applying it to the EffectRunArg marker. When the foreign lifter has translated a runEffectFnN/runSTFnN wrappe...
X Description: Problem An Effect/ST statement in pslua is represented as a thunk that magic-do runs by applying it to the EffectRunArg marker. When the foreign lifter has translated a runEffectFnN/runSTFnN wrappe...
Opengraph URL: https://github.com/purescript-lua/purescript-lua/issues/342
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Shed the magic-do effect thunk for any expression body, not only a call","articleBody":"## Problem\n\nAn Effect/ST statement in `pslua` is represented as a thunk that magic-do runs by applying it to the `EffectRunArg` marker. When the foreign lifter has translated a `runEffectFnN`/`runSTFnN` wrapper, that application reduces to a literal thunk applied to the marker, and code generation recognises the pattern and drops the redundant build-and-force — emitting `fn(a, …)` instead of `(function() return fn(a, …) end)()`. This is the effect-side payoff of lifting the uncurried wrappers.\n\nThe recogniser requires the thunk's body to be a call, `IR.AppN`, verbatim from `Language.PureScript.Backend.Lua`:\n\n```haskell\n IR.AppN\n _ann\n (IR.AbsN _ (IR.ParamUnused _ :| []) body@IR.AppN {})\n (IR.EffectRunArg _ :| []) →\n Right \u003c$> goExp body\n```\n\nIts own comment justifies the restriction by what the body must *lower to*, not by its being a call:\n\n```haskell\n -- The body is required to be an 'IR.AppN', which\n -- always lowers to an expression — so this never inlines a 'Let' (magic-do\n -- keeps such chunk boundaries thunked to bound locals per Lua function).\n```\n\nThe stated hazard is a `Let` body, which lowers to statements rather than an expression and so cannot be spliced into an expression position. But a call is not the only body that lowers to an expression: a projection (`ObjectProp`), an index read (`ArrayIndex`), a length read (`PrimLen`) and the primops all do too. The guard is therefore narrower than the reason for it, and every such body pays a closure allocation the recogniser exists to remove.\n\nThis is not hypothetical: it is what currently blocks lifting `Data.Array.ST.lengthImpl`, whose Lua body is `function(xs) return #xs end` — byte-identical to `Data.Array.length`, which #247 does lift. Because `lengthImpl` is typed `STFn1 (STArray h a) h Int`, its call is an effect statement, so a lifted length body keeps the thunk:\n\n```lua\n local before = (function() return #(arr) end)() -- lengthImpl allowlisted\n local before = Data_Array_ST_lengthImpl(arr) -- as shipped\n```\n\nThe lifted form is *worse* than the opaque foreign call it replaced — a closure allocation on top of the same call — which is why #247 shipped with `lengthImpl` off the lift allowlist even though its body translates.\n\n## Approach\n\nWiden the guard from \"the body is a call\" to \"the body lowers to an expression\". The cheap-read and primop nodes qualify; `Let`, `LetValues` and anything else the Lua backend lowers to a statement chunk do not, and must keep the thunk for the reason the existing comment gives. Since the backend already distinguishes the two — `goExp` returns `Left` for a chunk and `Right` for an expression — the discrimination can be taken from that result rather than duplicated as a syntactic whitelist, which keeps the two in step if a node changes category.\n\nWhether the widened shed is safe for a body reading *mutable* state needs one check before `lengthImpl` is allowlisted on top of it. The shed happens at code generation, after every IR rewrite, so no IR-level rule can reorder the exposed read; but the Lua-level optimizer (`Language.PureScript.Backend.Lua.Optimizer`) runs afterwards, and its licence to move or share a `#arr` read across a `pushImpl` statement has to be established rather than assumed. See `Note [PrimLen reads immutable values]` for the invariant at stake.\n\n## Verification / Measurement\n\nThe existing `Golden.LengthLift` module already contains the shape: `lengthsAroundPush` brackets a `push` with two `Data.Array.ST.length` reads. Its Lua golden currently pins both at a direct `Data_Array_ST_lengthImpl(arr)` and its `eval/golden.txt` oracle at `[3, 4]`, so widening the shed and then allowlisting `lengthImpl` should move the golden to a bare `local before = #(arr)` with the execution output unchanged — the oracle is what proves the two reads still see different lengths.\n\nA golden for a non-length cheap read under an effect thunk (a record field or array index behind an `EffectFn1`) would cover the widened guard independently of the `lengthImpl` follow-up.\n\n## Prerequisites / Relations\n\nIndependent, and the prerequisite for the third export #247 set out to lift. Extends the code-generation half of the wrapper lift from #198.\n","author":{"url":"https://github.com/Unisay","@type":"Person","name":"Unisay"},"datePublished":"2026-07-28T18:32:27Z","url":"https://github.com/purescript-lua/purescript-lua/issues/342"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:5de9bd1e-880c-4160-d236-cb3831ef7afd |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | A600:34DB8F:66483D:8A7317:6B00D937 |
| html-safe-nonce | 951b0fc4fb620f026b05ec0b38a532d869e570a787303061329d1f448c67151e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNjAwOjM0REI4Rjo2NjQ4M0Q6OEE3MzE3OjZCMDBEOTM3IiwidmlzaXRvcl9pZCI6IjYzNDgxNTQxOTE0ODcyMjgyMTUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | e84227f3eb7c752066868f2049f99c240a87811824ff2d343959dcf3ec68f7f3 |
| hovercard-subject-tag | issue:5001843982 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/purescript-lua/purescript-lua/342/issue_layout |
| twitter:image | https://opengraph.githubassets.com/b2ed005a850ff9827bf9ea2d0e11008ba5ec88fbddcd761b4fa80ba63735e278/purescript-lua/purescript-lua/issues/342 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b2ed005a850ff9827bf9ea2d0e11008ba5ec88fbddcd761b4fa80ba63735e278/purescript-lua/purescript-lua/issues/342 |
| og:image:alt | Problem An Effect/ST statement in pslua is represented as a thunk that magic-do runs by applying it to the EffectRunArg marker. When the foreign lifter has translated a runEffectFnN/runSTFnN wrappe... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Unisay |
| hostname | github.com |
| expected-hostname | github.com |
| None | a481f62a1e04c9b9bdcb5628230682c66d59006f5b13b080f79cba84a176905b |
| turbo-cache-control | no-preview |
| go-import | github.com/purescript-lua/purescript-lua git https://github.com/purescript-lua/purescript-lua.git |
| octolytics-dimension-user_id | 131581790 |
| octolytics-dimension-user_login | purescript-lua |
| octolytics-dimension-repository_id | 587200487 |
| octolytics-dimension-repository_nwo | purescript-lua/purescript-lua |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 587200487 |
| octolytics-dimension-repository_network_root_nwo | purescript-lua/purescript-lua |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 84c8c5cc25e2fb7f2308428458538436baecc6d2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width