René's URL Explorer Experiment


Title: Shed the magic-do effect thunk for any expression body, not only a call · Issue #342 · purescript-lua/purescript-lua · GitHub

Open Graph Title: Shed the magic-do effect thunk for any expression body, not only a call · Issue #342 · purescript-lua/purescript-lua

X Title: Shed the magic-do effect thunk for any expression body, not only a call · Issue #342 · purescript-lua/purescript-lua

Description: Problem An Effect/ST statement in pslua is represented as a thunk that magic-do runs by applying it to the EffectRunArg marker. When the foreign lifter has translated a runEffectFnN/runSTFnN wrapper, that application reduces to a literal...

Open Graph Description: Problem An Effect/ST statement in pslua is represented as a thunk that magic-do runs by applying it to the EffectRunArg marker. When the foreign lifter has translated a runEffectFnN/runSTFnN wrappe...

X Description: Problem An Effect/ST statement in pslua is represented as a thunk that magic-do runs by applying it to the EffectRunArg marker. When the foreign lifter has translated a runEffectFnN/runSTFnN wrappe...

Opengraph URL: https://github.com/purescript-lua/purescript-lua/issues/342

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Shed the magic-do effect thunk for any expression body, not only a call","articleBody":"## Problem\n\nAn Effect/ST statement in `pslua` is represented as a thunk that magic-do runs by applying it to the `EffectRunArg` marker. When the foreign lifter has translated a `runEffectFnN`/`runSTFnN` wrapper, that application reduces to a literal thunk applied to the marker, and code generation recognises the pattern and drops the redundant build-and-force — emitting `fn(a, …)` instead of `(function() return fn(a, …) end)()`. This is the effect-side payoff of lifting the uncurried wrappers.\n\nThe recogniser requires the thunk's body to be a call, `IR.AppN`, verbatim from `Language.PureScript.Backend.Lua`:\n\n```haskell\n  IR.AppN\n    _ann\n    (IR.AbsN _ (IR.ParamUnused _ :| []) body@IR.AppN {})\n    (IR.EffectRunArg _ :| []) →\n      Right \u003c$> goExp body\n```\n\nIts own comment justifies the restriction by what the body must *lower to*, not by its being a call:\n\n```haskell\n  -- The body is required to be an 'IR.AppN', which\n  -- always lowers to an expression — so this never inlines a 'Let' (magic-do\n  -- keeps such chunk boundaries thunked to bound locals per Lua function).\n```\n\nThe stated hazard is a `Let` body, which lowers to statements rather than an expression and so cannot be spliced into an expression position. But a call is not the only body that lowers to an expression: a projection (`ObjectProp`), an index read (`ArrayIndex`), a length read (`PrimLen`) and the primops all do too. The guard is therefore narrower than the reason for it, and every such body pays a closure allocation the recogniser exists to remove.\n\nThis is not hypothetical: it is what currently blocks lifting `Data.Array.ST.lengthImpl`, whose Lua body is `function(xs) return #xs end` — byte-identical to `Data.Array.length`, which #247 does lift. Because `lengthImpl` is typed `STFn1 (STArray h a) h Int`, its call is an effect statement, so a lifted length body keeps the thunk:\n\n```lua\n  local before = (function() return #(arr) end)()   -- lengthImpl allowlisted\n  local before = Data_Array_ST_lengthImpl(arr)      -- as shipped\n```\n\nThe lifted form is *worse* than the opaque foreign call it replaced — a closure allocation on top of the same call — which is why #247 shipped with `lengthImpl` off the lift allowlist even though its body translates.\n\n## Approach\n\nWiden the guard from \"the body is a call\" to \"the body lowers to an expression\". The cheap-read and primop nodes qualify; `Let`, `LetValues` and anything else the Lua backend lowers to a statement chunk do not, and must keep the thunk for the reason the existing comment gives. Since the backend already distinguishes the two — `goExp` returns `Left` for a chunk and `Right` for an expression — the discrimination can be taken from that result rather than duplicated as a syntactic whitelist, which keeps the two in step if a node changes category.\n\nWhether the widened shed is safe for a body reading *mutable* state needs one check before `lengthImpl` is allowlisted on top of it. The shed happens at code generation, after every IR rewrite, so no IR-level rule can reorder the exposed read; but the Lua-level optimizer (`Language.PureScript.Backend.Lua.Optimizer`) runs afterwards, and its licence to move or share a `#arr` read across a `pushImpl` statement has to be established rather than assumed. See `Note [PrimLen reads immutable values]` for the invariant at stake.\n\n## Verification / Measurement\n\nThe existing `Golden.LengthLift` module already contains the shape: `lengthsAroundPush` brackets a `push` with two `Data.Array.ST.length` reads. Its Lua golden currently pins both at a direct `Data_Array_ST_lengthImpl(arr)` and its `eval/golden.txt` oracle at `[3, 4]`, so widening the shed and then allowlisting `lengthImpl` should move the golden to a bare `local before = #(arr)` with the execution output unchanged — the oracle is what proves the two reads still see different lengths.\n\nA golden for a non-length cheap read under an effect thunk (a record field or array index behind an `EffectFn1`) would cover the widened guard independently of the `lengthImpl` follow-up.\n\n## Prerequisites / Relations\n\nIndependent, and the prerequisite for the third export #247 set out to lift. Extends the code-generation half of the wrapper lift from #198.\n","author":{"url":"https://github.com/Unisay","@type":"Person","name":"Unisay"},"datePublished":"2026-07-28T18:32:27Z","url":"https://github.com/purescript-lua/purescript-lua/issues/342"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:5de9bd1e-880c-4160-d236-cb3831ef7afd
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idA600:34DB8F:66483D:8A7317:6B00D937
html-safe-nonce951b0fc4fb620f026b05ec0b38a532d869e570a787303061329d1f448c67151e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNjAwOjM0REI4Rjo2NjQ4M0Q6OEE3MzE3OjZCMDBEOTM3IiwidmlzaXRvcl9pZCI6IjYzNDgxNTQxOTE0ODcyMjgyMTUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace84227f3eb7c752066868f2049f99c240a87811824ff2d343959dcf3ec68f7f3
hovercard-subject-tagissue:5001843982
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/purescript-lua/purescript-lua/342/issue_layout
twitter:imagehttps://opengraph.githubassets.com/b2ed005a850ff9827bf9ea2d0e11008ba5ec88fbddcd761b4fa80ba63735e278/purescript-lua/purescript-lua/issues/342
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b2ed005a850ff9827bf9ea2d0e11008ba5ec88fbddcd761b4fa80ba63735e278/purescript-lua/purescript-lua/issues/342
og:image:altProblem An Effect/ST statement in pslua is represented as a thunk that magic-do runs by applying it to the EffectRunArg marker. When the foreign lifter has translated a runEffectFnN/runSTFnN wrappe...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameUnisay
hostnamegithub.com
expected-hostnamegithub.com
Nonea481f62a1e04c9b9bdcb5628230682c66d59006f5b13b080f79cba84a176905b
turbo-cache-controlno-preview
go-importgithub.com/purescript-lua/purescript-lua git https://github.com/purescript-lua/purescript-lua.git
octolytics-dimension-user_id131581790
octolytics-dimension-user_loginpurescript-lua
octolytics-dimension-repository_id587200487
octolytics-dimension-repository_nwopurescript-lua/purescript-lua
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id587200487
octolytics-dimension-repository_network_root_nwopurescript-lua/purescript-lua
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release84c8c5cc25e2fb7f2308428458538436baecc6d2
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/purescript-lua/purescript-lua/issues/342#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript-lua%2Fpurescript-lua%2Fissues%2F342
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript-lua%2Fpurescript-lua%2Fissues%2F342
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=purescript-lua%2Fpurescript-lua
Reloadhttps://github.com/purescript-lua/purescript-lua/issues/342
Reloadhttps://github.com/purescript-lua/purescript-lua/issues/342
Reloadhttps://github.com/purescript-lua/purescript-lua/issues/342
purescript-luahttps://github.com/purescript-lua
purescript-luahttps://github.com/purescript-lua/purescript-lua
Codehttps://github.com/purescript-lua/purescript-lua
Issues48 (48)https://github.com/purescript-lua/purescript-lua/issues
Pull requestshttps://github.com/purescript-lua/purescript-lua/pulls
Discussionshttps://github.com/purescript-lua/purescript-lua/discussions
Actionshttps://github.com/purescript-lua/purescript-lua/actions
Projectshttps://github.com/purescript-lua/purescript-lua/projects
Security and qualityhttps://github.com/purescript-lua/purescript-lua/security
Insightshttps://github.com/purescript-lua/purescript-lua/insights
https://github.com/purescript-lua/purescript-lua
New issuehttps://github.com/login?return_to=https://github.com/purescript-lua/purescript-lua/issues/342
New issuehttps://github.com/login?return_to=https://github.com/purescript-lua/purescript-lua/issues/342
Shed the magic-do effect thunk for any expression body, not only a callhttps://github.com/purescript-lua/purescript-lua/issues/342#top
OptimisationA Compiler Optimisationhttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22Optimisation%22
area: codegenLua code generation / printinghttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22area%3A%20codegen%22
enhancementNew feature or requesthttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22enhancement%22
https://github.com/Unisay
Unisayhttps://github.com/Unisay
on Jul 28, 2026https://github.com/purescript-lua/purescript-lua/issues/342#issue-5001843982
#247https://github.com/purescript-lua/purescript-lua/issues/247
#247https://github.com/purescript-lua/purescript-lua/issues/247
#247https://github.com/purescript-lua/purescript-lua/issues/247
#198https://github.com/purescript-lua/purescript-lua/issues/198
Unisayhttps://github.com/Unisay
enhancementNew feature or requesthttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22enhancement%22
area: codegenLua code generation / printinghttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22area%3A%20codegen%22
OptimisationA Compiler Optimisationhttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22Optimisation%22
on Jul 28, 2026https://github.com/purescript-lua/purescript-lua/issues/342#event-28616792839
https://github.com/Unisay
Unisayhttps://github.com/Unisay
on Jul 30, 2026https://github.com/purescript-lua/purescript-lua/issues/342#issuecomment-5129574107
#359https://github.com/purescript-lua/purescript-lua/issues/359
#359https://github.com/purescript-lua/purescript-lua/issues/359
Sign up for freehttps://github.com/signup?return_to=https://github.com/purescript-lua/purescript-lua/issues/342
Sign in to commenthttps://github.com/login?return_to=https://github.com/purescript-lua/purescript-lua/issues/342
OptimisationA Compiler Optimisationhttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22Optimisation%22
area: codegenLua code generation / printinghttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22area%3A%20codegen%22
enhancementNew feature or requesthttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22enhancement%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.