Title: Strengthen fired-proof oracle in the #214/#225 unpacking properties (countFreeRef on a bound name is vacuous) · Issue #322 · purescript-lua/purescript-lua · GitHub
Open Graph Title: Strengthen fired-proof oracle in the #214/#225 unpacking properties (countFreeRef on a bound name is vacuous) · Issue #322 · purescript-lua/purescript-lua
X Title: Strengthen fired-proof oracle in the #214/#225 unpacking properties (countFreeRef on a bound name is vacuous) · Issue #322 · purescript-lua/purescript-lua
Description: Problem The through-a-let unpacking suites for constructors (#214) and literal arrays (#225) each carry a property titled "eliminates the binding without growing the reference multiset", whose first assertion is meant to prove the rewrit...
Open Graph Description: Problem The through-a-let unpacking suites for constructors (#214) and literal arrays (#225) each carry a property titled "eliminates the binding without growing the reference multiset", whose firs...
X Description: Problem The through-a-let unpacking suites for constructors (#214) and literal arrays (#225) each carry a property titled "eliminates the binding without growing the reference multiset", ...
Opengraph URL: https://github.com/purescript-lua/purescript-lua/issues/322
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Strengthen fired-proof oracle in the #214/#225 unpacking properties (countFreeRef on a bound name is vacuous)","articleBody":"## Problem\n\nThe through-a-`let` unpacking suites for constructors (#214) and literal arrays (#225) each carry a property titled \"eliminates the binding without growing the reference multiset\", whose first assertion is meant to prove the rewrite fired:\n\n```haskell\noptimized = optimizedExpression original\ncountFreeRef (Local (Name \"v\")) optimized === 0\n```\n\nBut `countFreeRef` counts *free* references, and a reference to a name its enclosing `Let` still binds is not free — the traversal tracks bound names and skips them (see the `Let` case of `countFreeRefs` in `Language.PureScript.Backend.IR.Types`). So when the rule *declines* and leaves the binding in place, the count is 0 all the same: the assertion passes whether the rule fired or not. The property still checks the reference-multiset submap condition, but its \"proof the rule fired\" half is vacuous, so a regression that silently disables `propagateKnownCtorThroughLet` or `propagateKnownArrayThroughLet` on these shapes would not be caught here (it would surface only indirectly, via golden churn).\n\n## Approach\n\nReplace the vacuous assertion with a shape oracle that distinguishes fired from declined. The record twin added for #240 does this with an allocation count — a recursive count of aggregate nodes (`LiteralObject`/`ObjectUpdate` there; `Ctor` and `LiteralArray` respectively here) asserted to be 0 after optimization:\n\n```haskell\ncountObjectAllocations optimized === 0\n```\n\n(`countObjectAllocations` in `test/Language/PureScript/Backend/IR/Optimizer/Spec.hs`, next to `let1`.) Generalize that helper over the node kinds it counts, or add per-kind siblings, and use it in both older properties. The multiset-submap half of each property stays as is.\n\n## Prerequisites / Relations\n\nNone — an independent test-quality fix. The shape-oracle pattern to copy (`countObjectAllocations`) landed with #240 (closed); the affected suites belong to #214 and #225 (both closed).\n\n## Verification\n\nTemporarily disabling each propagate rule must turn its strengthened property red; with the rules active, both properties stay green across seeds.\n","author":{"url":"https://github.com/Unisay","@type":"Person","name":"Unisay"},"datePublished":"2026-07-27T17:59:45Z","url":"https://github.com/purescript-lua/purescript-lua/issues/322"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:dd7a82a6-2cf4-1897-42e7-31d2e76467c7 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | C198:23CF06:808C5B:A7C6C1:6B00D93E |
| html-safe-nonce | 587e497b22804cb5d2b758822e8613e2216022fa72732da6491de65029ac997a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMTk4OjIzQ0YwNjo4MDhDNUI6QTdDNkMxOjZCMDBEOTNFIiwidmlzaXRvcl9pZCI6IjM1MTM1OTE2NTQzNDQ4NzQzMDIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 1b30d3708191ba0568f3ad0aa8e80177ee3461cf9b735c08af4d66d4e07bf289 |
| hovercard-subject-tag | issue:4990856046 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/purescript-lua/purescript-lua/322/issue_layout |
| twitter:image | https://opengraph.githubassets.com/f5d8f5506f8fb35731bdd2eec1dd510baa6ad9eb1ef1e18dab04447becb2eb2b/purescript-lua/purescript-lua/issues/322 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/f5d8f5506f8fb35731bdd2eec1dd510baa6ad9eb1ef1e18dab04447becb2eb2b/purescript-lua/purescript-lua/issues/322 |
| og:image:alt | Problem The through-a-let unpacking suites for constructors (#214) and literal arrays (#225) each carry a property titled "eliminates the binding without growing the reference multiset", whose firs... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Unisay |
| hostname | github.com |
| expected-hostname | github.com |
| None | a481f62a1e04c9b9bdcb5628230682c66d59006f5b13b080f79cba84a176905b |
| turbo-cache-control | no-preview |
| go-import | github.com/purescript-lua/purescript-lua git https://github.com/purescript-lua/purescript-lua.git |
| octolytics-dimension-user_id | 131581790 |
| octolytics-dimension-user_login | purescript-lua |
| octolytics-dimension-repository_id | 587200487 |
| octolytics-dimension-repository_nwo | purescript-lua/purescript-lua |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 587200487 |
| octolytics-dimension-repository_network_root_nwo | purescript-lua/purescript-lua |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 84c8c5cc25e2fb7f2308428458538436baecc6d2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width