Title: Remove or re-wire fromIR's apparently dead topLevelNames parameter · Issue #320 · purescript-lua/purescript-lua · GitHub
Open Graph Title: Remove or re-wire fromIR's apparently dead topLevelNames parameter · Issue #320 · purescript-lua/purescript-lua
X Title: Remove or re-wire fromIR's apparently dead topLevelNames parameter · Issue #320 · purescript-lua/purescript-lua
Description: Problem Language.PureScript.Backend.Lua.fromIR takes a topLevelNames :: Set Lua.Name parameter that selects, for a local reference whose qualified form is a known top-level name, the module-table read M.name instead of a plain variable —...
Open Graph Description: Problem Language.PureScript.Backend.Lua.fromIR takes a topLevelNames :: Set Lua.Name parameter that selects, for a local reference whose qualified form is a known top-level name, the module-table r...
X Description: Problem Language.PureScript.Backend.Lua.fromIR takes a topLevelNames :: Set Lua.Name parameter that selects, for a local reference whose qualified form is a known top-level name, the module-table r...
Opengraph URL: https://github.com/purescript-lua/purescript-lua/issues/320
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Remove or re-wire fromIR's apparently dead topLevelNames parameter","articleBody":"## Problem\n\n`Language.PureScript.Backend.Lua.fromIR` takes a `topLevelNames :: Set Lua.Name` parameter that selects, for a local reference whose qualified form is a known top-level name, the module-table read `M.name` instead of a plain variable — and analogously selects `SelfField` self-references for recursive groups. Every call site in `fromUberModule` passes it empty (`Set.empty`/`mempty`), and the internal recursion only propagates the parameter, so the branches keyed on it appear unreachable:\n\n```haskell\nexp ← asExpression \u003c$> fromIR foreigns Set.empty Set.empty modname irExp\n...\nIR.Local name\n | topLevelName ← qualifyName modname (fromName name)\n , Set.member topLevelName topLevelNames →\n pure . Right $\n Lua.varField (Lua.varName Fixture.moduleName) topLevelName\n```\n\n(Quoted from `main` after #239, which added the separate unboxed-cells set — the second `Set.empty` — and kept the existing parameter untouched.)\n\n## Approach\n\nVerify the parameter is genuinely dead (no caller constructs a non-empty set; git history shows what used to), then either remove it together with the two branches it feeds, or re-wire the actual top-level name set through if some caller was supposed to pass one and silently regressed. Removal simplifies `fromIR`'s signature and deletes an untestable code path; re-wiring would need a test demonstrating a shape that requires it.\n\n## Relations\n\nObserved while adding the unboxed-cells parameter in #239. Pure internal cleanup unless the investigation turns up a latent mis-lowering, in which case it becomes a bug with a reproduction.\n\n## Verification\n\nIf removed: the full suite stays green and no golden moves (proving the branches never fired). If re-wired: a new golden demonstrating the shape that needs the module-table read.\n","author":{"url":"https://github.com/Unisay","@type":"Person","name":"Unisay"},"datePublished":"2026-07-27T12:27:30Z","url":"https://github.com/purescript-lua/purescript-lua/issues/320"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:764c2014-271e-b361-eedc-32750df7fa9d |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | BF5E:24FC21:8123A3:A87D87:6B00D93A |
| html-safe-nonce | 9933f5a8e7438359e9e5993e7b0b5a70ab90ebb59a19ec826e47b0eb6dcc494e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRjVFOjI0RkMyMTo4MTIzQTM6QTg3RDg3OjZCMDBEOTNBIiwidmlzaXRvcl9pZCI6IjM2NzIzNzg0MTIwNDkxNjA1MDYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 97bf01c2edc631a769ed0df741938a2272bc52c879a764b572d4281509d2dd5c |
| hovercard-subject-tag | issue:4987859871 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/purescript-lua/purescript-lua/320/issue_layout |
| twitter:image | https://opengraph.githubassets.com/7f7c64f5779d30ffa89a3995f7ac2960686206efb06f97fc762f205f22737c3d/purescript-lua/purescript-lua/issues/320 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/7f7c64f5779d30ffa89a3995f7ac2960686206efb06f97fc762f205f22737c3d/purescript-lua/purescript-lua/issues/320 |
| og:image:alt | Problem Language.PureScript.Backend.Lua.fromIR takes a topLevelNames :: Set Lua.Name parameter that selects, for a local reference whose qualified form is a known top-level name, the module-table r... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Unisay |
| hostname | github.com |
| expected-hostname | github.com |
| None | a481f62a1e04c9b9bdcb5628230682c66d59006f5b13b080f79cba84a176905b |
| turbo-cache-control | no-preview |
| go-import | github.com/purescript-lua/purescript-lua git https://github.com/purescript-lua/purescript-lua.git |
| octolytics-dimension-user_id | 131581790 |
| octolytics-dimension-user_login | purescript-lua |
| octolytics-dimension-repository_id | 587200487 |
| octolytics-dimension-repository_nwo | purescript-lua/purescript-lua |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 587200487 |
| octolytics-dimension-repository_network_root_nwo | purescript-lua/purescript-lua |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 84c8c5cc25e2fb7f2308428458538436baecc6d2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width