René's URL Explorer Experiment


Title: Remove or re-wire fromIR's apparently dead topLevelNames parameter · Issue #320 · purescript-lua/purescript-lua · GitHub

Open Graph Title: Remove or re-wire fromIR's apparently dead topLevelNames parameter · Issue #320 · purescript-lua/purescript-lua

X Title: Remove or re-wire fromIR's apparently dead topLevelNames parameter · Issue #320 · purescript-lua/purescript-lua

Description: Problem Language.PureScript.Backend.Lua.fromIR takes a topLevelNames :: Set Lua.Name parameter that selects, for a local reference whose qualified form is a known top-level name, the module-table read M.name instead of a plain variable —...

Open Graph Description: Problem Language.PureScript.Backend.Lua.fromIR takes a topLevelNames :: Set Lua.Name parameter that selects, for a local reference whose qualified form is a known top-level name, the module-table r...

X Description: Problem Language.PureScript.Backend.Lua.fromIR takes a topLevelNames :: Set Lua.Name parameter that selects, for a local reference whose qualified form is a known top-level name, the module-table r...

Opengraph URL: https://github.com/purescript-lua/purescript-lua/issues/320

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Remove or re-wire fromIR's apparently dead topLevelNames parameter","articleBody":"## Problem\n\n`Language.PureScript.Backend.Lua.fromIR` takes a `topLevelNames :: Set Lua.Name` parameter that selects, for a local reference whose qualified form is a known top-level name, the module-table read `M.name` instead of a plain variable — and analogously selects `SelfField` self-references for recursive groups. Every call site in `fromUberModule` passes it empty (`Set.empty`/`mempty`), and the internal recursion only propagates the parameter, so the branches keyed on it appear unreachable:\n\n```haskell\nexp ← asExpression \u003c$> fromIR foreigns Set.empty Set.empty modname irExp\n...\nIR.Local name\n  | topLevelName ← qualifyName modname (fromName name)\n  , Set.member topLevelName topLevelNames →\n      pure . Right $\n        Lua.varField (Lua.varName Fixture.moduleName) topLevelName\n```\n\n(Quoted from `main` after #239, which added the separate unboxed-cells set — the second `Set.empty` — and kept the existing parameter untouched.)\n\n## Approach\n\nVerify the parameter is genuinely dead (no caller constructs a non-empty set; git history shows what used to), then either remove it together with the two branches it feeds, or re-wire the actual top-level name set through if some caller was supposed to pass one and silently regressed. Removal simplifies `fromIR`'s signature and deletes an untestable code path; re-wiring would need a test demonstrating a shape that requires it.\n\n## Relations\n\nObserved while adding the unboxed-cells parameter in #239. Pure internal cleanup unless the investigation turns up a latent mis-lowering, in which case it becomes a bug with a reproduction.\n\n## Verification\n\nIf removed: the full suite stays green and no golden moves (proving the branches never fired). If re-wired: a new golden demonstrating the shape that needs the module-table read.\n","author":{"url":"https://github.com/Unisay","@type":"Person","name":"Unisay"},"datePublished":"2026-07-27T12:27:30Z","url":"https://github.com/purescript-lua/purescript-lua/issues/320"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:764c2014-271e-b361-eedc-32750df7fa9d
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idBF5E:24FC21:8123A3:A87D87:6B00D93A
html-safe-nonce9933f5a8e7438359e9e5993e7b0b5a70ab90ebb59a19ec826e47b0eb6dcc494e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRjVFOjI0RkMyMTo4MTIzQTM6QTg3RDg3OjZCMDBEOTNBIiwidmlzaXRvcl9pZCI6IjM2NzIzNzg0MTIwNDkxNjA1MDYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac97bf01c2edc631a769ed0df741938a2272bc52c879a764b572d4281509d2dd5c
hovercard-subject-tagissue:4987859871
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/purescript-lua/purescript-lua/320/issue_layout
twitter:imagehttps://opengraph.githubassets.com/7f7c64f5779d30ffa89a3995f7ac2960686206efb06f97fc762f205f22737c3d/purescript-lua/purescript-lua/issues/320
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7f7c64f5779d30ffa89a3995f7ac2960686206efb06f97fc762f205f22737c3d/purescript-lua/purescript-lua/issues/320
og:image:altProblem Language.PureScript.Backend.Lua.fromIR takes a topLevelNames :: Set Lua.Name parameter that selects, for a local reference whose qualified form is a known top-level name, the module-table r...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameUnisay
hostnamegithub.com
expected-hostnamegithub.com
Nonea481f62a1e04c9b9bdcb5628230682c66d59006f5b13b080f79cba84a176905b
turbo-cache-controlno-preview
go-importgithub.com/purescript-lua/purescript-lua git https://github.com/purescript-lua/purescript-lua.git
octolytics-dimension-user_id131581790
octolytics-dimension-user_loginpurescript-lua
octolytics-dimension-repository_id587200487
octolytics-dimension-repository_nwopurescript-lua/purescript-lua
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id587200487
octolytics-dimension-repository_network_root_nwopurescript-lua/purescript-lua
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release84c8c5cc25e2fb7f2308428458538436baecc6d2
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/purescript-lua/purescript-lua/issues/320#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript-lua%2Fpurescript-lua%2Fissues%2F320
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript-lua%2Fpurescript-lua%2Fissues%2F320
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=purescript-lua%2Fpurescript-lua
Reloadhttps://github.com/purescript-lua/purescript-lua/issues/320
Reloadhttps://github.com/purescript-lua/purescript-lua/issues/320
Reloadhttps://github.com/purescript-lua/purescript-lua/issues/320
purescript-luahttps://github.com/purescript-lua
purescript-luahttps://github.com/purescript-lua/purescript-lua
Codehttps://github.com/purescript-lua/purescript-lua
Issues48 (48)https://github.com/purescript-lua/purescript-lua/issues
Pull requestshttps://github.com/purescript-lua/purescript-lua/pulls
Discussionshttps://github.com/purescript-lua/purescript-lua/discussions
Actionshttps://github.com/purescript-lua/purescript-lua/actions
Projectshttps://github.com/purescript-lua/purescript-lua/projects
Security and qualityhttps://github.com/purescript-lua/purescript-lua/security
Insightshttps://github.com/purescript-lua/purescript-lua/insights
https://github.com/purescript-lua/purescript-lua
New issuehttps://github.com/login?return_to=https://github.com/purescript-lua/purescript-lua/issues/320
New issuehttps://github.com/login?return_to=https://github.com/purescript-lua/purescript-lua/issues/320
Remove or re-wire fromIR's apparently dead topLevelNames parameterhttps://github.com/purescript-lua/purescript-lua/issues/320#top
area: codegenLua code generation / printinghttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22area%3A%20codegen%22
choreMaintenance / infrastructurehttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22chore%22
https://github.com/Unisay
Unisayhttps://github.com/Unisay
on Jul 27, 2026https://github.com/purescript-lua/purescript-lua/issues/320#issue-4987859871
#239https://github.com/purescript-lua/purescript-lua/issues/239
#239https://github.com/purescript-lua/purescript-lua/issues/239
Unisayhttps://github.com/Unisay
area: codegenLua code generation / printinghttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22area%3A%20codegen%22
choreMaintenance / infrastructurehttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22chore%22
on Jul 27, 2026https://github.com/purescript-lua/purescript-lua/issues/320#event-28536919155
Sign up for freehttps://github.com/signup?return_to=https://github.com/purescript-lua/purescript-lua/issues/320
Sign in to commenthttps://github.com/login?return_to=https://github.com/purescript-lua/purescript-lua/issues/320
area: codegenLua code generation / printinghttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22area%3A%20codegen%22
choreMaintenance / infrastructurehttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22chore%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.