Title: Case column choice ignores MatchHistory: decided matches are free but can lose the tie-break · Issue #312 · purescript-lua/purescript-lua · GitHub
Open Graph Title: Case column choice ignores MatchHistory: decided matches are free but can lose the tie-break · Issue #312 · purescript-lua/purescript-lua
X Title: Case column choice ignores MatchHistory: decided matches are free but can lose the tie-break · Issue #312 · purescript-lua/purescript-lua
Description: Problem matchChosenByHeuristic (lib/Language/PureScript/Backend/IR.hs) picks which outstanding pattern test of a clause the decision tree emits next, scoring candidates with Maranget's pbaN composite (#311). It never consults MatchHistor...
Open Graph Description: Problem matchChosenByHeuristic (lib/Language/PureScript/Backend/IR.hs) picks which outstanding pattern test of a clause the decision tree emits next, scoring candidates with Maranget's pbaN composi...
X Description: Problem matchChosenByHeuristic (lib/Language/PureScript/Backend/IR.hs) picks which outstanding pattern test of a clause the decision tree emits next, scoring candidates with Maranget's pbaN com...
Opengraph URL: https://github.com/purescript-lua/purescript-lua/issues/312
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Case column choice ignores MatchHistory: decided matches are free but can lose the tie-break","articleBody":"## Problem\n\n`matchChosenByHeuristic` (`lib/Language/PureScript/Backend/IR.hs`) picks which outstanding pattern test of a clause the decision tree emits next, scoring candidates with Maranget's `pbaN` composite (#311). It never consults `MatchHistory` — the per-path record of already-performed tests that `mkClause` applies *after* the pick to prune tests whose outcome is decided. On such a path a decided match is free to pick: a known-true match just continues the clause, a known-false one falls through to the next clause, neither emits anything. But the heuristic can tie-break to a fresh test instead, and the fresh test gets emitted even when the clause is already doomed by its decided sibling — producing a test whose success branch is immediately the no-match failure.\n\nThe pbaN unit test (\"tests the column with fewer distinct patterns first\", `test/Language/PureScript/Backend/IR/Spec.hs`) exhibits one. Matrix: `'a','p' -> 1 | 'b','p' -> 2 | 'c','p' -> 3 | 'd','p' -> 4 | 'a','q' -> 5`. In the branch where `'p' == 'y'` has already failed, the clause `('d','p')` ties on all pbaN components (needed prefix 2 vs 2, distinct patterns 2 vs 2, sub-tests 0 vs 0) and leftmost picks the fresh `'d' == 'x'` — although the clause's other match `'p' == 'y'` is known false on this path, so the clause cannot succeed regardless. The asserted tree carries the resulting arm verbatim:\n\n```haskell\n( ifThenElse\n (literalChar 'd' `eq` literalChar 'x')\n (exception \"No patterns matched\")\n ...\n```\n\nA test whose success arm is the failure. With the decided match picked first, the clause is dismissed for free and that branch shrinks from 3 tests (`'d'=='x'`, `'a'=='x'`, `'q'=='y'`) to 2.\n\n## Approach\n\nThread the current `MatchHistory` into the pick (it lives in `mkClause`, which already partially applies the heuristic over the remaining clauses): before pbaN scoring, take any outstanding match whose `testOutcome` under the history is `TestKnownTrue` or `TestKnownFalse` — emitting it costs nothing and it may discharge or dismiss the clause outright. Only undecided matches are scored with pbaN. Tree construction and the pruning in `testFocus` stay as they are; the pruning simply gets consulted one step earlier.\n\n## Prerequisites / Relations\n\nIndependent; refines the column choice merged in #311 without changing the composite itself. Orthogonal to #184 (extending `MatchHistory` with negative knowledge for literals): #184 makes the history richer, this makes the pick aware of it — they compose.\n\n## Verification / Measurement\n\nThe pbaN unit test's negative branch loses the `if 'd'=='x' then exception` arm (expected tree updated to the 7-test shape, red before the change). Eval goldens across the corpus stay unchanged (only tree shape may move); structural golden churn reviewed for shrinkage. Code-size and counter deltas through the bench harness (#172).\n","author":{"url":"https://github.com/Unisay","@type":"Person","name":"Unisay"},"datePublished":"2026-07-27T08:03:16Z","url":"https://github.com/purescript-lua/purescript-lua/issues/312"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:957e125f-584b-13c1-ddfb-d913c846f66e |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | D03A:1F44:BA764:F60EE:6B00DB6F |
| html-safe-nonce | 89676682875df17e6a6efd4f57c0a4ca1e22aa12a9a0e31d46a8ab2919cda213 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMDNBOjFGNDQ6QkE3NjQ6RjYwRUU6NkIwMERCNkYiLCJ2aXNpdG9yX2lkIjoiNjcxNjYzNTI3NDYyNzU1MTgzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | c9c8b9a72b3fc0763b561fecf2dc20fca8ce4d87bef0179934f14b3b5767c92c |
| hovercard-subject-tag | issue:4985761880 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/purescript-lua/purescript-lua/312/issue_layout |
| twitter:image | https://opengraph.githubassets.com/bafedf3727bace31573f7bbedd5a4430401fccbc707401e15f80a196d029bc68/purescript-lua/purescript-lua/issues/312 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/bafedf3727bace31573f7bbedd5a4430401fccbc707401e15f80a196d029bc68/purescript-lua/purescript-lua/issues/312 |
| og:image:alt | Problem matchChosenByHeuristic (lib/Language/PureScript/Backend/IR.hs) picks which outstanding pattern test of a clause the decision tree emits next, scoring candidates with Maranget's pbaN composi... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Unisay |
| hostname | github.com |
| expected-hostname | github.com |
| None | 043c3f30fbcbe2c6c8e729e10cbbbc90c406546f9fbbb67c648d38f6b7d16daf |
| turbo-cache-control | no-preview |
| go-import | github.com/purescript-lua/purescript-lua git https://github.com/purescript-lua/purescript-lua.git |
| octolytics-dimension-user_id | 131581790 |
| octolytics-dimension-user_login | purescript-lua |
| octolytics-dimension-repository_id | 587200487 |
| octolytics-dimension-repository_nwo | purescript-lua/purescript-lua |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 587200487 |
| octolytics-dimension-repository_network_root_nwo | purescript-lua/purescript-lua |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 5425dc24e8bd8d6fca9641a12afc984825a43875 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width