Title: Optimizer: never duplicate a reference-constructing expression (allocation/identity guard) · Issue #284 · purescript-lua/purescript-lua · GitHub
Open Graph Title: Optimizer: never duplicate a reference-constructing expression (allocation/identity guard) · Issue #284 · purescript-lua/purescript-lua
X Title: Optimizer: never duplicate a reference-constructing expression (allocation/identity guard) · Issue #284 · purescript-lua/purescript-lua
Description: Problem Several inlining paths can duplicate an expression whose root constructs a fresh table. Duplication multiplies allocations and changes object identity — observable at the FFI boundary, where Lua == on tables is identity. The cost...
Open Graph Description: Problem Several inlining paths can duplicate an expression whose root constructs a fresh table. Duplication multiplies allocations and changes object identity — observable at the FFI boundary, wher...
X Description: Problem Several inlining paths can duplicate an expression whose root constructs a fresh table. Duplication multiplies allocations and changes object identity — observable at the FFI boundary, wher...
Opengraph URL: https://github.com/purescript-lua/purescript-lua/issues/284
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Optimizer: never duplicate a reference-constructing expression (allocation/identity guard)","articleBody":"## Problem\n\nSeveral inlining paths can duplicate an expression whose root constructs a fresh table. Duplication multiplies allocations and changes object identity — observable at the FFI boundary, where Lua `==` on tables is identity. The cost model already encodes the discipline in two places — `Ctor` is deliberately `NonTrivial` (\"keeps a nullary singleton (`Ctor []`) shared through a binding instead of re-allocated at every use site\"), and `isNonRecursiveLiteral` admits only scalars — but three holes remain:\n\n1. Empty table literals are classified `Trivial`, so the Deref tier duplicates them at any use count:\n\n```haskell\n-- complexityOf\nLiteralArray _ann exprs\n | null exprs → Trivial\nLiteralObject _ann props\n | null props → Trivial\n```\n\n2. `resolveDictionaryProp` pastes a field's value per site with only a size gate, so a table-valued field is re-constructed at every site:\n\n```haskell\n{unit = {}}.unit ⟶ {} -- a fresh table per use site\n```\n\n3. The whole-binding `Always` paste duplicates anything, and the Linker annotates foreign accessors `Just Always` by default — so for a table-valued foreign export the hole is open by default, not by user request.\n\nToday the prelude covers the one known instance with `@inline unit never` (prelude v7.3.1); any other table-valued FFI constant in any fork is one forgotten pragma away from per-site reallocation and broken identity.\n\n## Approach\n\nAn `allocatesAtRoot` predicate — root-level `LiteralObject`/`LiteralArray` of any size (`Ctor` already lands `NonTrivial`) — consulted by every duplicating paste path: reclassify empty table literals out of `Trivial`, gate the `resolveDictionaryProp` field paste, and let the guard take precedence over `Always`. The precedence flip is the deliberate part: duplicated *work* is something a user can sign for (behaviour-preserving in a pure language), duplicated *identity* is not — no amount of re-evaluation brings back pointer equality. Use-once relocation stays admitted on every path: one allocation, moved, is identity-safe.\n\n## Prerequisites / Relations\n\nMakes the prelude's `@inline unit never` unnecessary for correctness; composes with #283 / purescript-lua/purescript-lua-prelude#15, which removes the shared value for unit entirely (either alone suffices for unit; this guard protects the general class). Golden churn expected where `{}` is currently re-emitted per site — overlaps with #275 (zero-method dictionaries threaded as empty-table arguments), which wants those sites gone rather than shared.\n\n## Verification / Measurement\n\nUnit test: a top-level `LiteralObject []` binding annotated `Just Always` and used at two or more sites survives as a shared binding (today it is pasted per site). Full golden run: eval goldens byte-identical; structural churn reviewed for shared-`{}` bindings appearing where constructors were previously duplicated.\n","author":{"url":"https://github.com/Unisay","@type":"Person","name":"Unisay"},"datePublished":"2026-07-16T11:36:00Z","url":"https://github.com/purescript-lua/purescript-lua/issues/284"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:b504e49f-fd0e-488a-36ad-42ae550187ec |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 9AFA:76F02:8162E8:A8C333:6B00DB6D |
| html-safe-nonce | 937baa01a2a4c551783b1948fe8b233f1f3809bfe1b8004ddef70c533e5c97a2 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QUZBOjc2RjAyOjgxNjJFODpBOEMzMzM6NkIwMERCNkQiLCJ2aXNpdG9yX2lkIjoiNjc1NDQ1OTc0Njk1NjI3MDQ0NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | ec960fbab6f17e727ba67e7e75e9ae493b75aea570ade811169465d98d4fdbc1 |
| hovercard-subject-tag | issue:4901584714 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/purescript-lua/purescript-lua/284/issue_layout |
| twitter:image | https://opengraph.githubassets.com/3974a055a90e8a43d6386ab2253b1341cb3b5a857656afa46123c3e70ae0e978/purescript-lua/purescript-lua/issues/284 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/3974a055a90e8a43d6386ab2253b1341cb3b5a857656afa46123c3e70ae0e978/purescript-lua/purescript-lua/issues/284 |
| og:image:alt | Problem Several inlining paths can duplicate an expression whose root constructs a fresh table. Duplication multiplies allocations and changes object identity — observable at the FFI boundary, wher... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Unisay |
| hostname | github.com |
| expected-hostname | github.com |
| None | 043c3f30fbcbe2c6c8e729e10cbbbc90c406546f9fbbb67c648d38f6b7d16daf |
| turbo-cache-control | no-preview |
| go-import | github.com/purescript-lua/purescript-lua git https://github.com/purescript-lua/purescript-lua.git |
| octolytics-dimension-user_id | 131581790 |
| octolytics-dimension-user_login | purescript-lua |
| octolytics-dimension-repository_id | 587200487 |
| octolytics-dimension-repository_nwo | purescript-lua/purescript-lua |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 587200487 |
| octolytics-dimension-repository_network_root_nwo | purescript-lua/purescript-lua |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 5425dc24e8bd8d6fca9641a12afc984825a43875 |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width