Title: Inline a single-use, header-free ForeignImport into a once-evaluated use site · Issue #251 · purescript-lua/purescript-lua · GitHub
Open Graph Title: Inline a single-use, header-free ForeignImport into a once-evaluated use site · Issue #251 · purescript-lua/purescript-lua
X Title: Inline a single-use, header-free ForeignImport into a once-evaluated use site · Issue #251 · purescript-lua/purescript-lua
Description: Problem The IR inliner categorically refuses to inline a ForeignImport binding, even when it is referenced exactly once (not (isForeignImport expr) in the optimizer's top-level inlining decision; Note [Inline annotations and inlining heu...
Open Graph Description: Problem The IR inliner categorically refuses to inline a ForeignImport binding, even when it is referenced exactly once (not (isForeignImport expr) in the optimizer's top-level inlining decision; N...
X Description: Problem The IR inliner categorically refuses to inline a ForeignImport binding, even when it is referenced exactly once (not (isForeignImport expr) in the optimizer's top-level inlining decisio...
Opengraph URL: https://github.com/purescript-lua/purescript-lua/issues/251
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Inline a single-use, header-free ForeignImport into a once-evaluated use site","articleBody":"## Problem\n\nThe IR inliner categorically refuses to inline a `ForeignImport` binding, even when it is referenced exactly once (`not (isForeignImport expr)` in the optimizer's top-level inlining decision; Note [Inline annotations and inlining heuristics]). As a blanket rule the veto is correct: a textually single use may sit under a lambda, where pasting the import re-evaluates the foreign source per call and mints fresh table identities. That is the #175 class, pinned by the `Golden.ForeignSharing` eval oracle.\n\nThe blanket form is blind to evaluation frequency, though. In a module whose only reference to the foreign table is a projection in a once-evaluated position, the fold is sound, and today's output keeps a dead outer table alive:\n\n```lua\nlocal Golden_ForeignSharing_Token_foreign = { token = {} }\nreturn { token = Golden_ForeignSharing_Token_foreign.token }\n```\n\ncould be `return { token = {} }`: the same single allocation at init, the same identity, one dead table constructor and one hash read less.\n\n## Approach\n\nRelax the veto to inline a `ForeignImport` when three conditions hold: it has exactly one reference; its parsed source has no header statements (a header may carry side effects whose order relative to other init statements must not move, while a header-free constructor is pure, so its evaluation commutes with intervening init effects); and the path from the referencing expression's root to the occurrence crosses only multiplicity-one positions (application heads and arguments, table-constructor rows, projection bases). Crossing an `Abs` (0..N evaluations; IR lazy thunks are lambdas, so the same test excludes them), an `IfThenElse` branch or an `and`/`or` right operand (0..1), or a loop body (N) declines. The soundness argument in one line: identity is minted per evaluation of the constructor, so preserving evaluation cardinality preserves identity.\n\nNo new fold is needed downstream: the inlined import lowers to a field access into the table constructor, which is the live trigger of `reduceTableDefinitionAccessor` (#140) and the scope-call fold (#159); those finish the job.\n\nLow priority. The multiplicity-one condition confines the fold to init-position code, so the win is one table allocation and one hash read per fully-projected single-use foreign module, plus cleaner output. Hot sites are exactly the ones where the fold is unsound; they are served by promotion (#174) and the accessor-default revisit (#248) instead.\n\n## Verification / Measurement\n\n`Golden.ForeignSharing.Token` and `Golden.TestReturnTableField` collapse to a direct export-table row. The `Golden.ForeignSharing.Test` eval oracle still prints \"shared\": its import has two references after beta reduction, so the veto holds there on the reference count alone, and the projection under the lambda stays a read of the hoisted shared table. Eval goldens unchanged corpus-wide.\n\n## Prerequisites / Relations\n\nIndependent. Refines the #175 fix rather than reverting it; the #140 and #159 rewrite rules are the downstream consumers. #248 covers the multi-use side of foreign-reference cost.\n","author":{"url":"https://github.com/Unisay","@type":"Person","name":"Unisay"},"datePublished":"2026-07-12T11:19:17Z","url":"https://github.com/purescript-lua/purescript-lua/issues/251"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:789b81b1-4253-6b25-d6bf-bb0e58e71234 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | DFC2:25A204:7F4DEC:AA0D11:6B00DB67 |
| html-safe-nonce | a4e3e8fee9a248057f8e438805f8fb6a8afbc0fd72f000b2d61d86b2f626a2f3 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERkMyOjI1QTIwNDo3RjRERUM6QUEwRDExOjZCMDBEQjY3IiwidmlzaXRvcl9pZCI6IjU0MTI3MjI0MDQ3NTEzNjcwMTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | b6e1d72a794442751cb425f40562d81bdb2fa4ec81672c3521af06c988438b6f |
| hovercard-subject-tag | issue:4866816363 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/purescript-lua/purescript-lua/251/issue_layout |
| twitter:image | https://opengraph.githubassets.com/c9df47484bd7b424e87ec40222371eff8a291857e45d8d61f29caa8a2267d458/purescript-lua/purescript-lua/issues/251 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c9df47484bd7b424e87ec40222371eff8a291857e45d8d61f29caa8a2267d458/purescript-lua/purescript-lua/issues/251 |
| og:image:alt | Problem The IR inliner categorically refuses to inline a ForeignImport binding, even when it is referenced exactly once (not (isForeignImport expr) in the optimizer's top-level inlining decision; N... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Unisay |
| hostname | github.com |
| expected-hostname | github.com |
| None | 043c3f30fbcbe2c6c8e729e10cbbbc90c406546f9fbbb67c648d38f6b7d16daf |
| turbo-cache-control | no-preview |
| go-import | github.com/purescript-lua/purescript-lua git https://github.com/purescript-lua/purescript-lua.git |
| octolytics-dimension-user_id | 131581790 |
| octolytics-dimension-user_login | purescript-lua |
| octolytics-dimension-repository_id | 587200487 |
| octolytics-dimension-repository_nwo | purescript-lua/purescript-lua |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 587200487 |
| octolytics-dimension-repository_network_root_nwo | purescript-lua/purescript-lua |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 5425dc24e8bd8d6fca9641a12afc984825a43875 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width