René's URL Explorer Experiment


Title: Revisit the foreign-accessor `@inline always` default: stage-2 promotion made the shared form free · Issue #248 · purescript-lua/purescript-lua · GitHub

Open Graph Title: Revisit the foreign-accessor `@inline always` default: stage-2 promotion made the shared form free · Issue #248 · purescript-lua/purescript-lua

X Title: Revisit the foreign-accessor `@inline always` default: stage-2 promotion made the shared form free · Issue #248 · purescript-lua/purescript-lua

Description: Problem The linker binds every foreign name to an ObjectProp accessor annotated @inline always by default (Note [Inline annotations and inlining heuristics]), so each use site re-materializes a field read off the foreign table: Data_Show...

Open Graph Description: Problem The linker binds every foreign name to an ObjectProp accessor annotated @inline always by default (Note [Inline annotations and inlining heuristics]), so each use site re-materializes a fie...

X Description: Problem The linker binds every foreign name to an ObjectProp accessor annotated @inline always by default (Note [Inline annotations and inlining heuristics]), so each use site re-materializes a fie...

Opengraph URL: https://github.com/purescript-lua/purescript-lua/issues/248

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Revisit the foreign-accessor `@inline always` default: stage-2 promotion made the shared form free","articleBody":"## Problem\n\nThe linker binds every foreign name to an `ObjectProp` accessor annotated `@inline always` by default (Note [Inline annotations and inlining heuristics]), so each use site re-materializes a field read off the foreign table: `Data_Show_foreign.showIntImpl(x)`. The default buys wrapper transparency, but per-use cost has always mildly favored the shared form for multi-use names, and stage 2 of #174 (PR #246) made the gap decisive: an accessor kept as a binding is now promoted to a chunk local, so every use is a register or upvalue access with zero table reads, while the dissolved form still pays a field read per site. Promotion also drops `M` entirely from most modules, which leaves foreign accessor reads as the only inter-binding references still going through a table, and stage-1 caching cannot reach them because it caches `M.x` shapes only.\n\n## Approach\n\nDecide a better default for accessors with more than one use site, keeping `always` where it still wins. Candidate shapes: flip the effective default to `never` when the accessor has multiple uses (single-use names stay dissolved: no binding, no local slot), or drop the forced annotation and teach the use-count heuristic that a field read repeated N times is worth a shared binding. Constraints: ForeignLift-lifted accessors must keep `always`, since their bodies exist to beta-reduce at saturated sites; the alias bindings consume the promotion locals budget, so selection should flow through Promote's existing accounting; DCE is unaffected either way, since a `never` accessor is still an `ObjectProp` that prunes when unreachable; and magic-do recognition of Effect/ST chains must still fire after the flip changes which shape reaches it (#182, #228). Fork-side per-name pragmas remain the escape hatch in both directions, and #176 (flip `@inline unit always`) becomes a special case: with the flip plus promotion, every `unit` use is a reference to one promoted local holding the singleton.\n\n## Verification / Measurement\n\nGoldens: a multi-use accessor materializes as a promoted local (`local Data_Show_showIntImpl = Data_Show_foreign.showIntImpl`) and call sites reference it; single-use accessors keep today's dissolved shape; eval goldens unchanged. The field-read-versus-local microbenchmark from ADR 0001 (2.4x on PUC 5.1) bounds the per-read win.\n\n## Prerequisites / Relations\n\nRequires stage 2 (#174, PR #246). Related: #176 (unit-specific flip, allocation-motivated), #175 (why per-site duplication of table values is unsound), #171 (dissolving an alias to an `@inline always` binding multiplies the body across use sites).\n","author":{"url":"https://github.com/Unisay","@type":"Person","name":"Unisay"},"datePublished":"2026-07-12T10:53:39Z","url":"https://github.com/purescript-lua/purescript-lua/issues/248"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:39c82889-c6da-7eb3-b8e4-196f1d6e0276
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idDFEE:395430:7C9075:A6E66D:6B00DB6B
html-safe-nonce87740ea28cc641d5a830736fbfbca091bf8f51efdb91d1aaade70c69406dcac0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERkVFOjM5NTQzMDo3QzkwNzU6QTZFNjZEOjZCMDBEQjZCIiwidmlzaXRvcl9pZCI6IjE4NTA3MDcwNjYxMTM1NDcxMTUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac551d508d8c4a8964b294b2447173309c222081791026b7e35a62d12cb69b50aa
hovercard-subject-tagissue:4866741013
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/purescript-lua/purescript-lua/248/issue_layout
twitter:imagehttps://opengraph.githubassets.com/921a7b2e852899879433dfd7b2d2cda69a450567a3be1d8d7e845dcad0f999d6/purescript-lua/purescript-lua/issues/248
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/921a7b2e852899879433dfd7b2d2cda69a450567a3be1d8d7e845dcad0f999d6/purescript-lua/purescript-lua/issues/248
og:image:altProblem The linker binds every foreign name to an ObjectProp accessor annotated @inline always by default (Note [Inline annotations and inlining heuristics]), so each use site re-materializes a fie...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameUnisay
hostnamegithub.com
expected-hostnamegithub.com
None043c3f30fbcbe2c6c8e729e10cbbbc90c406546f9fbbb67c648d38f6b7d16daf
turbo-cache-controlno-preview
go-importgithub.com/purescript-lua/purescript-lua git https://github.com/purescript-lua/purescript-lua.git
octolytics-dimension-user_id131581790
octolytics-dimension-user_loginpurescript-lua
octolytics-dimension-repository_id587200487
octolytics-dimension-repository_nwopurescript-lua/purescript-lua
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id587200487
octolytics-dimension-repository_network_root_nwopurescript-lua/purescript-lua
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5425dc24e8bd8d6fca9641a12afc984825a43875
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/purescript-lua/purescript-lua/issues/248#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript-lua%2Fpurescript-lua%2Fissues%2F248
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript-lua%2Fpurescript-lua%2Fissues%2F248
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=purescript-lua%2Fpurescript-lua
Reloadhttps://github.com/purescript-lua/purescript-lua/issues/248
Reloadhttps://github.com/purescript-lua/purescript-lua/issues/248
Reloadhttps://github.com/purescript-lua/purescript-lua/issues/248
purescript-luahttps://github.com/purescript-lua
purescript-luahttps://github.com/purescript-lua/purescript-lua
Codehttps://github.com/purescript-lua/purescript-lua
Issues48 (48)https://github.com/purescript-lua/purescript-lua/issues
Pull requestshttps://github.com/purescript-lua/purescript-lua/pulls
Discussionshttps://github.com/purescript-lua/purescript-lua/discussions
Actionshttps://github.com/purescript-lua/purescript-lua/actions
Projectshttps://github.com/purescript-lua/purescript-lua/projects
Security and qualityhttps://github.com/purescript-lua/purescript-lua/security
Insightshttps://github.com/purescript-lua/purescript-lua/insights
https://github.com/purescript-lua/purescript-lua
New issuehttps://github.com/login?return_to=https://github.com/purescript-lua/purescript-lua/issues/248
New issuehttps://github.com/login?return_to=https://github.com/purescript-lua/purescript-lua/issues/248
#255https://github.com/purescript-lua/purescript-lua/pull/255
Revisit the foreign-accessor @inline always default: stage-2 promotion made the shared form freehttps://github.com/purescript-lua/purescript-lua/issues/248#top
#255https://github.com/purescript-lua/purescript-lua/pull/255
OptimisationA Compiler Optimisationhttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22Optimisation%22
area: irIR / optimizer / DCE / inlinerhttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22area%3A%20ir%22
enhancementNew feature or requesthttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22enhancement%22
https://github.com/Unisay
Unisayhttps://github.com/Unisay
on Jul 12, 2026https://github.com/purescript-lua/purescript-lua/issues/248#issue-4866741013
#174https://github.com/purescript-lua/purescript-lua/issues/174
#246https://github.com/purescript-lua/purescript-lua/pull/246
#182https://github.com/purescript-lua/purescript-lua/issues/182
#228https://github.com/purescript-lua/purescript-lua/issues/228
#176https://github.com/purescript-lua/purescript-lua/issues/176
#174https://github.com/purescript-lua/purescript-lua/issues/174
#246https://github.com/purescript-lua/purescript-lua/pull/246
#176https://github.com/purescript-lua/purescript-lua/issues/176
#175https://github.com/purescript-lua/purescript-lua/issues/175
#171https://github.com/purescript-lua/purescript-lua/issues/171
Unisayhttps://github.com/Unisay
enhancementNew feature or requesthttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22enhancement%22
area: irIR / optimizer / DCE / inlinerhttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22area%3A%20ir%22
OptimisationA Compiler Optimisationhttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22Optimisation%22
on Jul 12, 2026https://github.com/purescript-lua/purescript-lua/issues/248#event-27872493234
Unisayhttps://github.com/Unisay
on Jul 12, 2026https://github.com/purescript-lua/purescript-lua/issues/248#event-27875400190
perf: rebuild sharing for multi-use foreign accessor reads (#248)https://github.com/purescript-lua/purescript-lua/commit/98043eb8f01b2b94ca145db91f239aa6d15c3d84
#248https://github.com/purescript-lua/purescript-lua/issues/248
98043ebhttps://github.com/purescript-lua/purescript-lua/commit/98043eb8f01b2b94ca145db91f239aa6d15c3d84
Unisayhttps://github.com/Unisay
completedhttps://github.com/purescript-lua/purescript-lua/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#255https://github.com/purescript-lua/purescript-lua/pull/255
on Jul 12, 2026https://github.com/purescript-lua/purescript-lua/issues/248#event-27875535699
Unisayhttps://github.com/Unisay
on Jul 12, 2026https://github.com/purescript-lua/purescript-lua/issues/248#event-27875535727
Merge pull request #255 from purescript-lua/issue-248/foreign-accesso…https://github.com/purescript-lua/purescript-lua/commit/74ccc53937ca31bfaf0f88275e8dff9008c564de
#255https://github.com/purescript-lua/purescript-lua/pull/255
74ccc53https://github.com/purescript-lua/purescript-lua/commit/74ccc53937ca31bfaf0f88275e8dff9008c564de
Sign up for freehttps://github.com/signup?return_to=https://github.com/purescript-lua/purescript-lua/issues/248
Sign in to commenthttps://github.com/login?return_to=https://github.com/purescript-lua/purescript-lua/issues/248
OptimisationA Compiler Optimisationhttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22Optimisation%22
area: irIR / optimizer / DCE / inlinerhttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22area%3A%20ir%22
enhancementNew feature or requesthttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22enhancement%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.