Title: Reassociate associative operator chains and coalesce constants · Issue #235 · purescript-lua/purescript-lua · GitHub
Open Graph Title: Reassociate associative operator chains and coalesce constants · Issue #235 · purescript-lua/purescript-lua
X Title: Reassociate associative operator chains and coalesce constants · Issue #235 · purescript-lua/purescript-lua
Description: Problem constantFolding folds a primop only when every operand is a literal. A chain like 1 + x + 2 + y + 3 keeps all three literals separate because x and y sit between them, even though + is associative and the constants could coalesce...
Open Graph Description: Problem constantFolding folds a primop only when every operand is a literal. A chain like 1 + x + 2 + y + 3 keeps all three literals separate because x and y sit between them, even though + is asso...
X Description: Problem constantFolding folds a primop only when every operand is a literal. A chain like 1 + x + 2 + y + 3 keeps all three literals separate because x and y sit between them, even though + is asso...
Opengraph URL: https://github.com/purescript-lua/purescript-lua/issues/235
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Reassociate associative operator chains and coalesce constants","articleBody":"## Problem\n\n`constantFolding` folds a primop only when every operand is a literal. A chain like `1 + x + 2 + y + 3` keeps all three literals separate because `x` and `y` sit between them, even though `+` is associative and the constants could coalesce to `6`. The same holds for `*`, for string `..`, and for a resolved user `Semigroup` `append`. Flattening the operator spine n-ary and folding adjacent literals within it coalesces such chains (a `2 * … * 60 * … * 42` product collapses to one constant).\n\n## Approach\n\nA reassociation rewrite for the Int-backed associative primops (`PrimAdd`, `PrimMul`) plus `PrimConcat`, and for a resolved `Semigroup.append`: flatten the operator spine, gather the literal operands respecting associativity, fold them, and rebuild. Float arithmetic stays out even if lifted later: IEEE `+`/`*` are not associative, and no per-constant guard makes reassociation around a variable sound. Short-circuiting `&&`/`||` are excluded, since reassociating them would change evaluation. Numeric folding stays inside the Lua-5.1 precision limits already documented in Note [Folding primops follows Lua 5.1]: coalesce only where the folded constant is exactly representable (int within ±2^53), never introducing a value the runtime cannot hold.\n\n## Prerequisites / Relations\n\nIndependent. Reuses the constant-folding machinery in `IR/Optimizer.hs` and its Lua-5.1 semantics guard. Unrelated to the inlining and loop issues.\n\n## Verification / Measurement\n\n`1 + x + 2` folds its constants (to the associativity-correct equivalent of `x + 3`) in a focused optimizer test; a chain mixing a non-associative or short-circuit operator is left untouched. A guard test that a fold which would exceed the Lua-5.1 int/float range does not fire. Eval goldens unchanged; structural goldens shrink where constant chains appear.\n","author":{"url":"https://github.com/Unisay","@type":"Person","name":"Unisay"},"datePublished":"2026-07-11T12:02:44Z","url":"https://github.com/purescript-lua/purescript-lua/issues/235"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:5a5d826e-1de6-578a-59f3-1d66e2488d99 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | BDE4:683FF:97FBF0:C5272D:6B00DFBD |
| html-safe-nonce | dac1f35641fca2193263fbf2078efa909eaa4605a061d492a80333a9076aab01 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCREU0OjY4M0ZGOjk3RkJGMDpDNTI3MkQ6NkIwMERGQkQiLCJ2aXNpdG9yX2lkIjoiNzcwOTQxMDg3MTU2MjI2NDUwOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | af2d5bc57382be81dd2127a3c11d1c045788b9f79a4e1704f5d88274b41e41ff |
| hovercard-subject-tag | issue:4862140251 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/purescript-lua/purescript-lua/235/issue_layout |
| twitter:image | https://opengraph.githubassets.com/623f9fff7ca7c62416880e41fe710918286cf92f625e979ae8e8b2f2314edf75/purescript-lua/purescript-lua/issues/235 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/623f9fff7ca7c62416880e41fe710918286cf92f625e979ae8e8b2f2314edf75/purescript-lua/purescript-lua/issues/235 |
| og:image:alt | Problem constantFolding folds a primop only when every operand is a literal. A chain like 1 + x + 2 + y + 3 keeps all three literals separate because x and y sit between them, even though + is asso... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Unisay |
| hostname | github.com |
| expected-hostname | github.com |
| None | 043c3f30fbcbe2c6c8e729e10cbbbc90c406546f9fbbb67c648d38f6b7d16daf |
| turbo-cache-control | no-preview |
| go-import | github.com/purescript-lua/purescript-lua git https://github.com/purescript-lua/purescript-lua.git |
| octolytics-dimension-user_id | 131581790 |
| octolytics-dimension-user_login | purescript-lua |
| octolytics-dimension-repository_id | 587200487 |
| octolytics-dimension-repository_nwo | purescript-lua/purescript-lua |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 587200487 |
| octolytics-dimension-repository_network_root_nwo | purescript-lua/purescript-lua |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 5425dc24e8bd8d6fca9641a12afc984825a43875 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width