René's URL Explorer Experiment


Title: Constant-fold ordering comparisons on ASCII Char literals · Issue #222 · purescript-lua/purescript-lua · GitHub

Open Graph Title: Constant-fold ordering comparisons on ASCII Char literals · Issue #222 · purescript-lua/purescript-lua

X Title: Constant-fold ordering comparisons on ASCII Char literals · Issue #222 · purescript-lua/purescript-lua

Description: What The IR constant folder evaluates equality on Char literals but leaves ordering comparisons (<, <=, >, >=) on Char literals alone, even when both operands are ASCII. Extend it to evaluate ordering on two ASCII Char literals at compil...

Open Graph Description: What The IR constant folder evaluates equality on Char literals but leaves ordering comparisons (<, <=, >, >=) on Char literals alone, even when both operands are ASCII. Extend it to evaluate order...

X Description: What The IR constant folder evaluates equality on Char literals but leaves ordering comparisons (<, <=, >, >=) on Char literals alone, even when both operands are ASCII. Extend it to ev...

Opengraph URL: https://github.com/purescript-lua/purescript-lua/issues/222

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Constant-fold ordering comparisons on ASCII Char literals","articleBody":"## What\n\nThe IR constant folder evaluates equality on `Char` literals but leaves ordering comparisons (`\u003c`, `\u003c=`, `>`, `>=`) on `Char` literals alone, even when both operands are ASCII. Extend it to evaluate ordering on two ASCII `Char` literals at compile time.\n\n## Observed\n\nIn `test/ps/output/Golden.CharLiterals.Test/golden.lua`, `show ('\\t' \u003c '\\n')` compiles to a runtime branch on a constant condition:\n\n```lua\nlocal v = \"Data.Ordering∷Ordering.LT\" == (function()\n  if \"\\t\" \u003c \"\\n\" then\n    return \"Data.Ordering∷Ordering.LT\"\n  else\n    return \"Data.Ordering∷Ordering.GT\"\n  end\nend)()\nif v then return \"true\" elseif false == v then return \"false\" else return error(\"No patterns matched\") end\n```\n\n`\"\\t\" \u003c \"\\n\"` compares two compile-time constants (bytes 9 and 10), so the whole block could fold to `\"true\"`. The sibling `show ('\\n' == '\\n')` one line above already folds to `\"true\"`, which is what makes the unfolded ordering stand out.\n\n## Why it is unfolded today (deliberate)\n\n`numericCompare`, inside `foldPrimBinOp` in `lib/Language/PureScript/Backend/IR/Optimizer.hs`, folds `PrimLt`/`PrimLe`/`PrimGt`/`PrimGe` only for `(LiteralInt, LiteralInt)` and `(LiteralFloat, LiteralFloat)`. Note [Folding primops follows Lua 5.1] records the reason: an IR `Char`/`String` literal carries a semantic Unicode value, but Lua orders strings by bytes, so folding with the host's `Ord` could disagree with the runtime on non-ASCII operands. Equality still folds because byte-equality and codepoint-equality coincide; only ordering is held back.\n\n## The refinement\n\nFor two `Char` literals whose codepoints are both below U+0080, the single-byte Lua representation orders identically to the codepoint, so host-side folding matches the runtime exactly. Gate the new fold on the ASCII range.\n\nNon-ASCII chars and `String` literals stay out of scope. Their byte order can diverge from codepoint order, and strings add length and multi-byte questions on top. They can be a later follow-up if they ever earn it.\n\n## Proposed implementation\n\nAdd one arm to `numericCompare`:\n\n```haskell\n(LiteralChar _ x, LiteralChar _ y)\n  | isAscii x, isAscii y → Just (compare x y)   -- isAscii from Data.Char\n```\n\nThe existing downstream folds then cascade: `if True then LT else GT` becomes `LT`, `\"…LT\" == \"…LT\"` becomes `True`, `if True then \"true\"` becomes `\"true\"`, collapsing the CharLiterals example to `log(\"true\")()`.\n\n## Test (ASCII-correctness is the point)\n\nWork test-first. The test has to prove two things, not one:\n\n1. An ASCII pair folds: `'\\t' \u003c '\\n'` reduces to a boolean literal.\n2. A non-ASCII pair is left untouched: comparing two chars with codepoints at or above U+0080 does not fold. This is the soundness guard, and it is the reason to write a dedicated test rather than lean on the golden alone.\n\nA focused `Optimizer` unit test covers both cases directly. The `Golden.CharLiterals.Test` golden also moves, since its final `log` collapses to `log(\"true\")()`.\n\n## Payoff\n\nSmall in practice. Two literal chars compared at compile time is rare in real code, so this is a completeness fix rather than a performance one. It surfaced while reviewing #180 (PR #219), where the dictionary-method inlining folded everything around this comparison but not the comparison itself.\n","author":{"url":"https://github.com/Unisay","@type":"Person","name":"Unisay"},"datePublished":"2026-07-10T09:03:19Z","url":"https://github.com/purescript-lua/purescript-lua/issues/222"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:f0c7c8fe-88f7-26bc-03f7-ad941d618402
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idA57E:76F02:8F0053:BA101E:6B00DFBD
html-safe-nonce5c55ccbe79d0caf6f9e4c5f0993552e6a0b11455adbc5d12489679ee42506c0b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNTdFOjc2RjAyOjhGMDA1MzpCQTEwMUU6NkIwMERGQkQiLCJ2aXNpdG9yX2lkIjoiMjQwMzgyNjI3MTMxMzg1MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacfb4984098c1abf6222b5981600659b4bba6be9381c861ce99dae2f2e8bf39382
hovercard-subject-tagissue:4853609653
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/purescript-lua/purescript-lua/222/issue_layout
twitter:imagehttps://opengraph.githubassets.com/210f92f9a3721ea4431b638811209d58b7a4feea4285681f42f80b36d953dd96/purescript-lua/purescript-lua/issues/222
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/210f92f9a3721ea4431b638811209d58b7a4feea4285681f42f80b36d953dd96/purescript-lua/purescript-lua/issues/222
og:image:altWhat The IR constant folder evaluates equality on Char literals but leaves ordering comparisons (<, <=, >, >=) on Char literals alone, even when both operands are ASCII. Extend it to evaluate order...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameUnisay
hostnamegithub.com
expected-hostnamegithub.com
None043c3f30fbcbe2c6c8e729e10cbbbc90c406546f9fbbb67c648d38f6b7d16daf
turbo-cache-controlno-preview
go-importgithub.com/purescript-lua/purescript-lua git https://github.com/purescript-lua/purescript-lua.git
octolytics-dimension-user_id131581790
octolytics-dimension-user_loginpurescript-lua
octolytics-dimension-repository_id587200487
octolytics-dimension-repository_nwopurescript-lua/purescript-lua
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id587200487
octolytics-dimension-repository_network_root_nwopurescript-lua/purescript-lua
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5425dc24e8bd8d6fca9641a12afc984825a43875
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/purescript-lua/purescript-lua/issues/222#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript-lua%2Fpurescript-lua%2Fissues%2F222
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript-lua%2Fpurescript-lua%2Fissues%2F222
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=purescript-lua%2Fpurescript-lua
Reloadhttps://github.com/purescript-lua/purescript-lua/issues/222
Reloadhttps://github.com/purescript-lua/purescript-lua/issues/222
Reloadhttps://github.com/purescript-lua/purescript-lua/issues/222
purescript-luahttps://github.com/purescript-lua
purescript-luahttps://github.com/purescript-lua/purescript-lua
Codehttps://github.com/purescript-lua/purescript-lua
Issues48 (48)https://github.com/purescript-lua/purescript-lua/issues
Pull requestshttps://github.com/purescript-lua/purescript-lua/pulls
Discussionshttps://github.com/purescript-lua/purescript-lua/discussions
Actionshttps://github.com/purescript-lua/purescript-lua/actions
Projectshttps://github.com/purescript-lua/purescript-lua/projects
Security and qualityhttps://github.com/purescript-lua/purescript-lua/security
Insightshttps://github.com/purescript-lua/purescript-lua/insights
https://github.com/purescript-lua/purescript-lua
New issuehttps://github.com/login?return_to=https://github.com/purescript-lua/purescript-lua/issues/222
New issuehttps://github.com/login?return_to=https://github.com/purescript-lua/purescript-lua/issues/222
#288https://github.com/purescript-lua/purescript-lua/pull/288
Constant-fold ordering comparisons on ASCII Char literalshttps://github.com/purescript-lua/purescript-lua/issues/222#top
#288https://github.com/purescript-lua/purescript-lua/pull/288
OptimisationA Compiler Optimisationhttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22Optimisation%22
area: irIR / optimizer / DCE / inlinerhttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22area%3A%20ir%22
https://github.com/Unisay
Unisayhttps://github.com/Unisay
on Jul 10, 2026https://github.com/purescript-lua/purescript-lua/issues/222#issue-4853609653
#180https://github.com/purescript-lua/purescript-lua/issues/180
#219https://github.com/purescript-lua/purescript-lua/pull/219
Unisayhttps://github.com/Unisay
area: irIR / optimizer / DCE / inlinerhttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22area%3A%20ir%22
OptimisationA Compiler Optimisationhttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22Optimisation%22
on Jul 10, 2026https://github.com/purescript-lua/purescript-lua/issues/222#event-27808760979
https://github.com/Unisay
Unisayhttps://github.com/Unisay
on Jul 23, 2026https://github.com/purescript-lua/purescript-lua/issues/222#issuecomment-5056091915
#288https://github.com/purescript-lua/purescript-lua/pull/288
Unisayhttps://github.com/Unisay
completedhttps://github.com/purescript-lua/purescript-lua/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Jul 23, 2026https://github.com/purescript-lua/purescript-lua/issues/222#event-28370616483
Unisayhttps://github.com/Unisay
on Jul 23, 2026https://github.com/purescript-lua/purescript-lua/issues/222#event-28372149116
feat(optimizer): fold ordering on ASCII char literals (#222)https://github.com/purescript-lua/purescript-lua/commit/c4cc4e280a3ad9d2f9bd39fc2ee6c21da3a918f3
#222https://github.com/purescript-lua/purescript-lua/issues/222
c4cc4e2https://github.com/purescript-lua/purescript-lua/commit/c4cc4e280a3ad9d2f9bd39fc2ee6c21da3a918f3
Merge pull request #288 from purescript-lua/issue-222/fold-ascii-char…https://github.com/purescript-lua/purescript-lua/commit/922c40a21695a496ade9caf22b101937654635d2
#288https://github.com/purescript-lua/purescript-lua/pull/288
922c40ahttps://github.com/purescript-lua/purescript-lua/commit/922c40a21695a496ade9caf22b101937654635d2
Sign up for freehttps://github.com/signup?return_to=https://github.com/purescript-lua/purescript-lua/issues/222
Sign in to commenthttps://github.com/login?return_to=https://github.com/purescript-lua/purescript-lua/issues/222
OptimisationA Compiler Optimisationhttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22Optimisation%22
area: irIR / optimizer / DCE / inlinerhttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22area%3A%20ir%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.