Title: MagicDo: recognize Effect/ST chains by qualified name at translation instead of by shape (removes the post-DCE ordering constraint) · Issue #182 · purescript-lua/purescript-lua · GitHub
Open Graph Title: MagicDo: recognize Effect/ST chains by qualified name at translation instead of by shape (removes the post-DCE ordering constraint) · Issue #182 · purescript-lua/purescript-lua
X Title: MagicDo: recognize Effect/ST chains by qualified name at translation instead of by shape (removes the post-DCE ordering constraint) · Issue #182 · purescript-lua/purescript-lua
Description: Problem Two layers. Fragility: magicDo recognizes Effect/ST chains by syntactic shape, late in the pipeline. Any new rewrite that changes chain shapes — and the #178–#180 series changes them massively — can silently starve it. A miss is ...
Open Graph Description: Problem Two layers. Fragility: magicDo recognizes Effect/ST chains by syntactic shape, late in the pipeline. Any new rewrite that changes chain shapes — and the #178–#180 series changes them massiv...
X Description: Problem Two layers. Fragility: magicDo recognizes Effect/ST chains by syntactic shape, late in the pipeline. Any new rewrite that changes chain shapes — and the #178–#180 series changes them massiv...
Opengraph URL: https://github.com/purescript-lua/purescript-lua/issues/182
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"MagicDo: recognize Effect/ST chains by qualified name at translation instead of by shape (removes the post-DCE ordering constraint)","articleBody":"## Problem\n\nTwo layers.\n\n1. Fragility: magicDo recognizes Effect/ST chains by syntactic shape, late in the pipeline. Any new rewrite that changes chain shapes — and the #178–#180 series changes them massively — can silently starve it. A miss is not an error but a quiet fallback to thunk-nested closures (the 63x cost class) that only a benchmark would notice.\n2. Ordering constraint: the pipeline comment states magicDo must run after DCE (the statements it introduces for `discard` look like dead `let _ =` bindings) and after the optimize fixpoint (the shapes must survive it). Consequently no optimize+dce round can legally run after magicDo — a tax on pipeline evolution that grows with every new pass.\n\n## Approach\n\nRecognize `bind`/`pure`/`discard` applications of Effect/ST by qualified name (the `Effect.bindEffect` dictionary, the `pureE`/`bindE` foreigns, their ST counterparts) at CoreFn→IR translation — the same QName-keyed technique as the #178 allowlist — and mark them with dedicated annotations (or normalize to a canonical form). magicDo then consumes marks instead of guessing shapes: a mark lives on the node and survives any rewrite, a \"dead\" `let _ =` carrying an effect mark stops being a DCE candidate, and the ordering constraint dissolves — running a fixpoint after magicDo becomes legal.\n\n## Design record: first-class Effect in the IR — considered and deferred\n\nThe alternative is making Effect structural: `EffectBind`/`EffectPure` IR constructors, as purs-backend-es does (together with its `UncurriedEffectApp`). Deferred because: recognition is symbol-driven either way (CoreFn carries no reliable types, so \"this is Effect\" is a QName question regardless of representation); the current thunk encoding keeps Effect values pure values, so every optimizer pass stays sound on plain lambda calculus without effect-awareness; and new IR constructors tax every traversal (uniquify, countFreeRefs, alphaEq, linter, DCE, the rewrite driver, lowering).\n\nRevisit conditions: (a) effect-loop fusion becomes a goal — compiling `forE`/`whileE`/`tailRecM`-over-Effect into native loops on top of #181 is shorter with structural effect nodes; (b) magicDo keeps missing chains systematically despite marks, as visible in #172.\n\n## Prerequisites / Relations\n\nIndependent in the dependency graph — no hard prerequisites. It is an enabler: recognising Effect/ST by qualified name removes the post-DCE / post-fixpoint ordering constraint, so an optimize+dce fixpoint may legally run after magicDo. That restored pipeline freedom is what the #178–#180 inlining series benefits from. Reuses the same QName-keyed recognition as the #178 allowlist. Relates to #172, which would carry the miss counter (and is also the trigger for revisit condition (b) above).\n\n## Verification / Measurement\n\n#172 tracks a magicDo-miss counter on the goldens as a smoke check: zero Effect chains left in thunk form.\n","author":{"url":"https://github.com/Unisay","@type":"Person","name":"Unisay"},"datePublished":"2026-07-06T10:43:21Z","url":"https://github.com/purescript-lua/purescript-lua/issues/182"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:841b1f4e-d329-e00c-74fc-e348cc063de7 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | D436:16AB79:5664D5:6F843E:6B00DB67 |
| html-safe-nonce | 05b1e6d9752afcb4d87ca06f1ec53683a49a96a76e41ad0f4da0daf63566d6af |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENDM2OjE2QUI3OTo1NjY0RDU6NkY4NDNFOjZCMDBEQjY3IiwidmlzaXRvcl9pZCI6IjYxMDQyMTgyMDM5MDExODg5NjciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 25a79daf0f76454a5093b06d1016521f803e1fff7a9b1f5b0b63d9efa24d16fb |
| hovercard-subject-tag | issue:4818334451 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/purescript-lua/purescript-lua/182/issue_layout |
| twitter:image | https://opengraph.githubassets.com/297881a98b0a8d0fcd2d81eef0a9c8e46c43768d79275fe2efe4c9e9b7b479b1/purescript-lua/purescript-lua/issues/182 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/297881a98b0a8d0fcd2d81eef0a9c8e46c43768d79275fe2efe4c9e9b7b479b1/purescript-lua/purescript-lua/issues/182 |
| og:image:alt | Problem Two layers. Fragility: magicDo recognizes Effect/ST chains by syntactic shape, late in the pipeline. Any new rewrite that changes chain shapes — and the #178–#180 series changes them massiv... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Unisay |
| hostname | github.com |
| expected-hostname | github.com |
| None | 043c3f30fbcbe2c6c8e729e10cbbbc90c406546f9fbbb67c648d38f6b7d16daf |
| turbo-cache-control | no-preview |
| go-import | github.com/purescript-lua/purescript-lua git https://github.com/purescript-lua/purescript-lua.git |
| octolytics-dimension-user_id | 131581790 |
| octolytics-dimension-user_login | purescript-lua |
| octolytics-dimension-repository_id | 587200487 |
| octolytics-dimension-repository_nwo | purescript-lua/purescript-lua |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 587200487 |
| octolytics-dimension-repository_network_root_nwo | purescript-lua/purescript-lua |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 5425dc24e8bd8d6fca9641a12afc984825a43875 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width