René's URL Explorer Experiment


Title: reduceObjectProp leaks the FFI @inline always annotation onto unrelated bindings, forcing unconditional duplication · Issue #169 · purescript-lua/purescript-lua · GitHub

Open Graph Title: reduceObjectProp leaks the FFI @inline always annotation onto unrelated bindings, forcing unconditional duplication · Issue #169 · purescript-lua/purescript-lua

X Title: reduceObjectProp leaks the FFI @inline always annotation onto unrelated bindings, forcing unconditional duplication · Issue #169 · purescript-lua/purescript-lua

Description: Problem Regression from #153 (reduceObjectProp, merged in #157). The Linker synthesizes exactly one shape carrying Just Inline.Always: a foreign name's alias binding, QName moduleName name = ObjectProp (Just Always) (Ref foreign) (PropNa...

Open Graph Description: Problem Regression from #153 (reduceObjectProp, merged in #157). The Linker synthesizes exactly one shape carrying Just Inline.Always: a foreign name's alias binding, QName moduleName name = Object...

X Description: Problem Regression from #153 (reduceObjectProp, merged in #157). The Linker synthesizes exactly one shape carrying Just Inline.Always: a foreign name's alias binding, QName moduleName name = Ob...

Opengraph URL: https://github.com/purescript-lua/purescript-lua/issues/169

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"reduceObjectProp leaks the FFI @inline always annotation onto unrelated bindings, forcing unconditional duplication","articleBody":"## Problem\n\nRegression from #153 (`reduceObjectProp`, merged in #157). The Linker synthesizes exactly one shape carrying `Just Inline.Always`: a foreign name's alias binding, `QName moduleName name = ObjectProp (Just Always) (Ref foreign) (PropName name)` (see Note [Foreign bindings structure emitted by the Linker] in `Linker.hs`). `isInlinableExpr` treats that annotation as \"always duplicate this expression at every use site\", bypassing the use-count check entirely.\n\n`reduceObjectProp` folds `ObjectProp _ann (LiteralObject _ props) prop` to `List.lookup prop props`, returning the field's value verbatim, annotation included. When a record literal has a field that happens to be one of these Linker-synthesized `Always`-marked foreign aliases, and something elsewhere projects that same field back out, the projection's result inherits `Just Always` even though the outer projection itself was never annotated. That annotation then becomes the root annotation of whatever binding the projection belongs to, making `isInlinableExpr` return `True` regardless of how many times that binding is actually used.\n\nConcretely, in `Golden.TailRecM2Shadow.Test`, the `Semiring Int` dictionary literal has `add: Data.Semiring.foreign.intAdd` as a field. The module's own top-level `add` binding projects that field out of the (inlined) dictionary and is referenced twice. Before #157, `add`'s root annotation stayed `Nothing`, so `add` correctly stayed a single shared top-level binding. After #157, the fold gives `add`'s root the dictionary field's own `Just Always`, so `add` is unconditionally duplicated at both call sites, and DCE then drops the now-unreferenced `Data.Semiring.foreign` table entirely — the foreign function's raw source ends up duplicated inline at each call site instead of one shared entry in the foreign import table:\n\n```lua\n-- before\nM.Golden_TailRecM2Shadow_Test_add = M.Data_Semiring_foreign.intAdd\na = M.Golden_TailRecM2Shadow_Test_add(o_S_31.a)(o_S_31.b)\n\n-- after\na = (function(x) return function(y) return x + y end end)(o_S_31.a)(o_S_31.b)\n```\n\nFor a foreign function with a nontrivial implementation this duplicates real code at every call site instead of one shared table entry.\n\n## Approach\n\nThe folded result must not inherit an annotation that was never meant to describe it. `reduceObjectProp` should discard the projected field's own annotation rather than letting it become the root annotation of the rewrite's result.\n\n## Prerequisites / Relations\n\nOptimizer bug, independent in the dependency graph. Related to #171 — both concern the interaction of the Linker's auto-`@inline always` annotation with the inliner — but distinct: this one is an annotation leak in `reduceObjectProp`, whereas #171 is the bare-`Ref` alias interaction.\n\n## Verification / Measurement\n\nProjecting a field whose value is an `Always`-marked foreign alias no longer marks the enclosing binding inlinable. In `Golden.TailRecM2Shadow.Test`, `add` stays a single shared top-level binding (`M.Golden_TailRecM2Shadow_Test_add = M.Data_Semiring_foreign.intAdd`) referenced from both call sites, rather than the foreign lambda being duplicated inline at each.\n","author":{"url":"https://github.com/Unisay","@type":"Person","name":"Unisay"},"datePublished":"2026-07-05T20:45:55Z","url":"https://github.com/purescript-lua/purescript-lua/issues/169"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:eaf74f51-e816-b8d7-c134-827df2f44623
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idA56E:7A60E:90005A:BC2129:6B00DFBD
html-safe-nonce4ba0c189e0a3b1e52ba719b295d5852ab14bad69cc4ac93545f69811592239cd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNTZFOjdBNjBFOjkwMDA1QTpCQzIxMjk6NkIwMERGQkQiLCJ2aXNpdG9yX2lkIjoiNDAzNzk3MjY3Njg5NDA1NjM4MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8cdeed6afade6cfa6bd49acf4c1597821532efccd80ca33d735fe228d990b50a
hovercard-subject-tagissue:4814378300
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/purescript-lua/purescript-lua/169/issue_layout
twitter:imagehttps://opengraph.githubassets.com/003540ece17edc4d30277fabd3676ef13d7830030d7333c920ddc62b7dcbbe09/purescript-lua/purescript-lua/issues/169
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/003540ece17edc4d30277fabd3676ef13d7830030d7333c920ddc62b7dcbbe09/purescript-lua/purescript-lua/issues/169
og:image:altProblem Regression from #153 (reduceObjectProp, merged in #157). The Linker synthesizes exactly one shape carrying Just Inline.Always: a foreign name's alias binding, QName moduleName name = Object...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameUnisay
hostnamegithub.com
expected-hostnamegithub.com
None043c3f30fbcbe2c6c8e729e10cbbbc90c406546f9fbbb67c648d38f6b7d16daf
turbo-cache-controlno-preview
go-importgithub.com/purescript-lua/purescript-lua git https://github.com/purescript-lua/purescript-lua.git
octolytics-dimension-user_id131581790
octolytics-dimension-user_loginpurescript-lua
octolytics-dimension-repository_id587200487
octolytics-dimension-repository_nwopurescript-lua/purescript-lua
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id587200487
octolytics-dimension-repository_network_root_nwopurescript-lua/purescript-lua
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5425dc24e8bd8d6fca9641a12afc984825a43875
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/purescript-lua/purescript-lua/issues/169#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript-lua%2Fpurescript-lua%2Fissues%2F169
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript-lua%2Fpurescript-lua%2Fissues%2F169
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=purescript-lua%2Fpurescript-lua
Reloadhttps://github.com/purescript-lua/purescript-lua/issues/169
Reloadhttps://github.com/purescript-lua/purescript-lua/issues/169
Reloadhttps://github.com/purescript-lua/purescript-lua/issues/169
purescript-luahttps://github.com/purescript-lua
purescript-luahttps://github.com/purescript-lua/purescript-lua
Codehttps://github.com/purescript-lua/purescript-lua
Issues48 (48)https://github.com/purescript-lua/purescript-lua/issues
Pull requestshttps://github.com/purescript-lua/purescript-lua/pulls
Discussionshttps://github.com/purescript-lua/purescript-lua/discussions
Actionshttps://github.com/purescript-lua/purescript-lua/actions
Projectshttps://github.com/purescript-lua/purescript-lua/projects
Security and qualityhttps://github.com/purescript-lua/purescript-lua/security
Insightshttps://github.com/purescript-lua/purescript-lua/insights
https://github.com/purescript-lua/purescript-lua
New issuehttps://github.com/login?return_to=https://github.com/purescript-lua/purescript-lua/issues/169
New issuehttps://github.com/login?return_to=https://github.com/purescript-lua/purescript-lua/issues/169
#193https://github.com/purescript-lua/purescript-lua/pull/193
reduceObjectProp leaks the FFI @inline always annotation onto unrelated bindings, forcing unconditional duplicationhttps://github.com/purescript-lua/purescript-lua/issues/169#top
#193https://github.com/purescript-lua/purescript-lua/pull/193
https://github.com/Unisay
area: irIR / optimizer / DCE / inlinerhttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22area%3A%20ir%22
bugSomething isn't workinghttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com/Unisay
Unisayhttps://github.com/Unisay
on Jul 5, 2026https://github.com/purescript-lua/purescript-lua/issues/169#issue-4814378300
#153https://github.com/purescript-lua/purescript-lua/issues/153
#157https://github.com/purescript-lua/purescript-lua/pull/157
#157https://github.com/purescript-lua/purescript-lua/pull/157
#157https://github.com/purescript-lua/purescript-lua/pull/157
#171https://github.com/purescript-lua/purescript-lua/issues/171
#171https://github.com/purescript-lua/purescript-lua/issues/171
Unisayhttps://github.com/Unisay
on Jul 6, 2026https://github.com/purescript-lua/purescript-lua/issues/169#event-27606251586
Closing audit: prove the cumulative win of the optimisation series #187https://github.com/purescript-lua/purescript-lua/issues/187
Unisayhttps://github.com/Unisay
bugSomething isn't workinghttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22bug%22
area: irIR / optimizer / DCE / inlinerhttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22area%3A%20ir%22
on Jul 6, 2026https://github.com/purescript-lua/purescript-lua/issues/169#event-27606832425
Unisayhttps://github.com/Unisay
on Jul 6, 2026https://github.com/purescript-lua/purescript-lua/issues/169#event-27611495455
Unisayhttps://github.com/Unisay
on Jul 6, 2026https://github.com/purescript-lua/purescript-lua/issues/169#event-27623601433
fix: keep the projection's annotation when folding a record projection (https://github.com/purescript-lua/purescript-lua/commit/55837858c418fc1c8947bfceba92da71a2dd62d3
5583785https://github.com/purescript-lua/purescript-lua/commit/55837858c418fc1c8947bfceba92da71a2dd62d3
Unisayhttps://github.com/Unisay
completedhttps://github.com/purescript-lua/purescript-lua/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#193https://github.com/purescript-lua/purescript-lua/pull/193
on Jul 6, 2026https://github.com/purescript-lua/purescript-lua/issues/169#event-27624227609
Sign up for freehttps://github.com/signup?return_to=https://github.com/purescript-lua/purescript-lua/issues/169
Sign in to commenthttps://github.com/login?return_to=https://github.com/purescript-lua/purescript-lua/issues/169
Unisayhttps://github.com/Unisay
area: irIR / optimizer / DCE / inlinerhttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22area%3A%20ir%22
bugSomething isn't workinghttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.