René's URL Explorer Experiment


Title: collectDataDeclarations classifies types by constructor adjacency, so a reordered CoreFn would silently break pattern matching · Issue #168 · purescript-lua/purescript-lua · GitHub

Open Graph Title: collectDataDeclarations classifies types by constructor adjacency, so a reordered CoreFn would silently break pattern matching · Issue #168 · purescript-lua/purescript-lua

X Title: collectDataDeclarations classifies types by constructor adjacency, so a reordered CoreFn would silently break pattern matching · Issue #168 · purescript-lua/purescript-lua

Description: Problem collectDataDeclarations (lib/Language/PureScript/Backend/IR.hs) decides whether a type is a ProductType or a SumType by grouping the module's constructor list with List.groupBy, which only merges adjacent elements. The classifica...

Open Graph Description: Problem collectDataDeclarations (lib/Language/PureScript/Backend/IR.hs) decides whether a type is a ProductType or a SumType by grouping the module's constructor list with List.groupBy, which only ...

X Description: Problem collectDataDeclarations (lib/Language/PureScript/Backend/IR.hs) decides whether a type is a ProductType or a SumType by grouping the module's constructor list with List.groupBy, which o...

Opengraph URL: https://github.com/purescript-lua/purescript-lua/issues/168

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"collectDataDeclarations classifies types by constructor adjacency, so a reordered CoreFn would silently break pattern matching","articleBody":"## Problem\n\n`collectDataDeclarations` (`lib/Language/PureScript/Backend/IR.hs`) decides whether a type is a `ProductType` or a `SumType` by grouping the module's constructor list with `List.groupBy`, which only merges adjacent elements. The classification is therefore correct only under an invariant pslua does not control and never checks: upstream `purs` happens to list all constructors of one type consecutively in `moduleBindings`.\n\nIf a future `purs` version reorders those declarations, a two-constructor sum type splits into two single-element groups, each classified as `ProductType`, and one entry overwrites the other in the resulting map. The damage lands entirely on the matcher side: `AlgebraicType` has exactly one live consumer, the pattern compiler, which emits the `reflectCtor == ctorId` tag test for `SumType` and skips it for `ProductType`. A misclassified match stops testing tags, so its first clause always wins — no compile error, no load error, just wrong answers. Constructed values still look correctly tagged at runtime because the code generator tags every value regardless, which makes the failure especially confusing to debug.\n\n## Approach\n\nRemove the order dependence entirely: build the map with `Map.fromListWith (\u003c>)` keyed by module and type name, and classify by the size of the merged constructor set.\n\nWhile in there, drop the dead tag from product-type values. The Lua code generator ignores the `AlgebraicType` field that every `IR.Ctor` node carries (the `_algebraicTy` wildcard in `lib/Language/PureScript/Backend/Lua.hs`) and emits the `[\"$ctor\"] = \"...\"` row into every constructed table; no compiled match ever reads that field for a `ProductType` constructor, so every product value allocates a string field nothing consumes. Emit the row only for `SumType` constructors.\n\n## Prerequisites / Relations\n\nLatent correctness bug, independent. The product-tag change touches the FFI contract, so it must come with a sweep of the package-set foreign files confirming no FFI peeks at `$ctor`.\n\n## Verification / Measurement\n\nA CoreFn with non-adjacent constructors of the same type still compiles to correct pattern matching (the sum-type tag test is emitted rather than the first clause silently winning). Product-type allocations no longer carry the unread `$ctor` field, and the eval goldens remain the semantic net that the field's removal changes no runtime behaviour.\n","author":{"url":"https://github.com/Unisay","@type":"Person","name":"Unisay"},"datePublished":"2026-07-05T20:45:25Z","url":"https://github.com/purescript-lua/purescript-lua/issues/168"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:b8f1dade-4922-5a50-6e50-7f069c1051cd
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idB830:A99C2:B14B67:E580C3:6B00E661
html-safe-nonce791d2216af2de81a321e387788a5ad3bd850ce0dbe6f895313273fc40986ee44
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCODMwOkE5OUMyOkIxNEI2NzpFNTgwQzM6NkIwMEU2NjEiLCJ2aXNpdG9yX2lkIjoiODQ1MzAyMjE3NjUyMTAyNzUzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac81c219633e53da66b560cb9abcb170b6197a26178f7a59601736aef95085e6f4
hovercard-subject-tagissue:4814376984
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/purescript-lua/purescript-lua/168/issue_layout
twitter:imagehttps://opengraph.githubassets.com/d491963d7b44d59ad7f9b84af36088f53d4b3912927bbae4b234e44f50a52005/purescript-lua/purescript-lua/issues/168
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d491963d7b44d59ad7f9b84af36088f53d4b3912927bbae4b234e44f50a52005/purescript-lua/purescript-lua/issues/168
og:image:altProblem collectDataDeclarations (lib/Language/PureScript/Backend/IR.hs) decides whether a type is a ProductType or a SumType by grouping the module's constructor list with List.groupBy, which only ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameUnisay
hostnamegithub.com
expected-hostnamegithub.com
None27088b6977484d0d3321d9a11c907c6d6637b315cfa359ef7952dbf6292f9b14
turbo-cache-controlno-preview
go-importgithub.com/purescript-lua/purescript-lua git https://github.com/purescript-lua/purescript-lua.git
octolytics-dimension-user_id131581790
octolytics-dimension-user_loginpurescript-lua
octolytics-dimension-repository_id587200487
octolytics-dimension-repository_nwopurescript-lua/purescript-lua
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id587200487
octolytics-dimension-repository_network_root_nwopurescript-lua/purescript-lua
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release624179fb8b88d26ba5bba08894eb60a1c5a1d93d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/purescript-lua/purescript-lua/issues/168#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript-lua%2Fpurescript-lua%2Fissues%2F168
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript-lua%2Fpurescript-lua%2Fissues%2F168
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=purescript-lua%2Fpurescript-lua
Reloadhttps://github.com/purescript-lua/purescript-lua/issues/168
Reloadhttps://github.com/purescript-lua/purescript-lua/issues/168
Reloadhttps://github.com/purescript-lua/purescript-lua/issues/168
purescript-luahttps://github.com/purescript-lua
purescript-luahttps://github.com/purescript-lua/purescript-lua
Codehttps://github.com/purescript-lua/purescript-lua
Issues48 (48)https://github.com/purescript-lua/purescript-lua/issues
Pull requestshttps://github.com/purescript-lua/purescript-lua/pulls
Discussionshttps://github.com/purescript-lua/purescript-lua/discussions
Actionshttps://github.com/purescript-lua/purescript-lua/actions
Projectshttps://github.com/purescript-lua/purescript-lua/projects
Security and qualityhttps://github.com/purescript-lua/purescript-lua/security
Insightshttps://github.com/purescript-lua/purescript-lua/insights
https://github.com/purescript-lua/purescript-lua
New issuehttps://github.com/login?return_to=https://github.com/purescript-lua/purescript-lua/issues/168
New issuehttps://github.com/login?return_to=https://github.com/purescript-lua/purescript-lua/issues/168
#192https://github.com/purescript-lua/purescript-lua/pull/192
collectDataDeclarations classifies types by constructor adjacency, so a reordered CoreFn would silently break pattern matchinghttps://github.com/purescript-lua/purescript-lua/issues/168#top
#192https://github.com/purescript-lua/purescript-lua/pull/192
https://github.com/Unisay
area: codegenLua code generation / printinghttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22area%3A%20codegen%22
area: irIR / optimizer / DCE / inlinerhttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22area%3A%20ir%22
bugSomething isn't workinghttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com/Unisay
Unisayhttps://github.com/Unisay
on Jul 5, 2026https://github.com/purescript-lua/purescript-lua/issues/168#issue-4814376984
Unisayhttps://github.com/Unisay
bugSomething isn't workinghttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22bug%22
area: codegenLua code generation / printinghttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22area%3A%20codegen%22
area: irIR / optimizer / DCE / inlinerhttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22area%3A%20ir%22
on Jul 5, 2026https://github.com/purescript-lua/purescript-lua/issues/168#event-27580466903
Unisayhttps://github.com/Unisay
on Jul 6, 2026https://github.com/purescript-lua/purescript-lua/issues/168#event-27606250103
Closing audit: prove the cumulative win of the optimisation series #187https://github.com/purescript-lua/purescript-lua/issues/187
Unisayhttps://github.com/Unisay
on Jul 6, 2026https://github.com/purescript-lua/purescript-lua/issues/168#event-27622182932
Unisayhttps://github.com/Unisay
completedhttps://github.com/purescript-lua/purescript-lua/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#192https://github.com/purescript-lua/purescript-lua/pull/192
on Jul 6, 2026https://github.com/purescript-lua/purescript-lua/issues/168#event-27622235722
Unisayhttps://github.com/Unisay
on Jul 6, 2026https://github.com/purescript-lua/purescript-lua/issues/168#event-27622235725
Merge pull request #192 from purescript-lua/issue-168/order-independe…https://github.com/purescript-lua/purescript-lua/commit/7252f348fcf0ad7784bc1204fe4939054ae0ff18
#192https://github.com/purescript-lua/purescript-lua/pull/192
7252f34https://github.com/purescript-lua/purescript-lua/commit/7252f348fcf0ad7784bc1204fe4939054ae0ff18
Sign up for freehttps://github.com/signup?return_to=https://github.com/purescript-lua/purescript-lua/issues/168
Sign in to commenthttps://github.com/login?return_to=https://github.com/purescript-lua/purescript-lua/issues/168
Unisayhttps://github.com/Unisay
area: codegenLua code generation / printinghttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22area%3A%20codegen%22
area: irIR / optimizer / DCE / inlinerhttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22area%3A%20ir%22
bugSomething isn't workinghttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.