René's URL Explorer Experiment


Title: Top-level inliner reads pre-pass reference counts: can duplicate arbitrary bindings, and recounts the whole module per binding · Issue #163 · purescript-lua/purescript-lua · GitHub

Open Graph Title: Top-level inliner reads pre-pass reference counts: can duplicate arbitrary bindings, and recounts the whole module per binding · Issue #163 · purescript-lua/purescript-lua

X Title: Top-level inliner reads pre-pass reference counts: can duplicate arbitrary bindings, and recounts the whole module per binding · Issue #163 · purescript-lua/purescript-lua

Description: optimizeModule.withBinding (lib/Language/PureScript/Backend/IR/Optimizer.hs) decides whether a top-level Standalone binding may be inlined as "used once" by consulting uberModuleFreeRefs. Two problems live in that one let. Problem one: t...

Open Graph Description: optimizeModule.withBinding (lib/Language/PureScript/Backend/IR/Optimizer.hs) decides whether a top-level Standalone binding may be inlined as "used once" by consulting uberModuleFreeRefs. Two probl...

X Description: optimizeModule.withBinding (lib/Language/PureScript/Backend/IR/Optimizer.hs) decides whether a top-level Standalone binding may be inlined as "used once" by consulting uberModuleFreeRefs....

Opengraph URL: https://github.com/purescript-lua/purescript-lua/issues/163

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Top-level inliner reads pre-pass reference counts: can duplicate arbitrary bindings, and recounts the whole module per binding","articleBody":"`optimizeModule.withBinding` (`lib/Language/PureScript/Backend/IR/Optimizer.hs`) decides whether a top-level `Standalone` binding may be inlined as \"used once\" by consulting `uberModuleFreeRefs`. Two problems live in that one `let`.\n\nProblem one: the counts are stale. `uberModuleFreeRefs` is computed from `uberModuleExprs = (bindingExprs =\u003c\u003c uberModuleBindings) \u003c> map snd exports`, where `uberModuleBindings` is the record field of the original module the pass started from. But the fold (`foldrM`) walks the topo-sorted binding list from the dependents' end, and every inlining substitutes into the already-processed accumulator. Those substitutions are invisible to the count. The undercount scenario:\n\n1. `g = Ref f` is referenced from N sites; `f` is referenced only by `g`, so its original count is 1. Aliases of this shape are common: re-exports, dictionary aliases, newtype-erased constructor wrappers.\n2. `g` is a `Ref`, so `isInlinableExpr` inlines it into all N sites. `f` now has N references in the accumulator.\n3. When the fold reaches `f`, the stale count still says 1, `isUsedOnce` fires, and `f`'s body (of arbitrary size, which is the whole point of the used-once rule) is copied into all N sites and its binding dropped.\n\nSemantics survive (the IR is pure), but the guarantee \"used once, therefore safe to inline regardless of size\" is exactly what this heuristic exists to provide, and it does not hold. The error direction matters: an overcount only misses an inlining opportunity and DCE cleans up later, while an undercount duplicates code irreversibly, because the binding is gone by the time the next fixpoint round recounts.\n\nProblem two: the recount is quadratic. The `let` sits inside the per-binding closure, so every `Standalone` binding that reaches the `isUsedOnce` check forces a fresh `countFreeRefs` fold over every expression in the module: O(bindings × module size) per optimize pass, multiplied by the optimize+dce fixpoint iterations. For a whole-program `UberModule` this is the dominant cost of the pass.\n\nStatus: found by code inspection during an architecture audit, not yet pinned by a failing test. A unit test can drive `optimizedUberModule` directly with the alias shape above and assert the large body appears once in the output.\n\nFix directions, cheapest first:\n\n- Count once per `optimizeModule` invocation and maintain the map incrementally: on inlining a binding, add the inlinee's own free-ref counts multiplied by the number of insertions, and remove the dropped binding's contribution.\n- Longer term, occurrence annotations on binders computed by a single analysis pass (GHC's OccAnal shape). `inlineLocalBindings` has the same point-query cost profile (`countFreeRef` per binding per `Let` node per fixpoint round) and would share the infrastructure.\n","author":{"url":"https://github.com/Unisay","@type":"Person","name":"Unisay"},"datePublished":"2026-07-04T20:27:37Z","url":"https://github.com/purescript-lua/purescript-lua/issues/163"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:1645c283-3a69-a85b-fd0b-dbf6daf00881
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8DD2:3DD488:72A8AD:931DA7:6B00E45F
html-safe-nonce6c01e845bffc6b55ab3c0e73b0791993d89131e06831ed1424ddf5286372ff7c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4REQyOjNERDQ4ODo3MkE4QUQ6OTMxREE3OjZCMDBFNDVGIiwidmlzaXRvcl9pZCI6Ijc1NjYyNjM1NTc2Mzg2NDY3MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac108d36aef6eb3920db6da56f29b046b80b94cc0907c5bd75b720a5f8aaa3fba3
hovercard-subject-tagissue:4810446686
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/purescript-lua/purescript-lua/163/issue_layout
twitter:imagehttps://opengraph.githubassets.com/bd50ccfad7969a653f0c3bb8101a305ead7ecc13a9320ba302b587d8afa2b934/purescript-lua/purescript-lua/issues/163
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/bd50ccfad7969a653f0c3bb8101a305ead7ecc13a9320ba302b587d8afa2b934/purescript-lua/purescript-lua/issues/163
og:image:altoptimizeModule.withBinding (lib/Language/PureScript/Backend/IR/Optimizer.hs) decides whether a top-level Standalone binding may be inlined as "used once" by consulting uberModuleFreeRefs. Two probl...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameUnisay
hostnamegithub.com
expected-hostnamegithub.com
None27088b6977484d0d3321d9a11c907c6d6637b315cfa359ef7952dbf6292f9b14
turbo-cache-controlno-preview
go-importgithub.com/purescript-lua/purescript-lua git https://github.com/purescript-lua/purescript-lua.git
octolytics-dimension-user_id131581790
octolytics-dimension-user_loginpurescript-lua
octolytics-dimension-repository_id587200487
octolytics-dimension-repository_nwopurescript-lua/purescript-lua
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id587200487
octolytics-dimension-repository_network_root_nwopurescript-lua/purescript-lua
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release624179fb8b88d26ba5bba08894eb60a1c5a1d93d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/purescript-lua/purescript-lua/issues/163#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript-lua%2Fpurescript-lua%2Fissues%2F163
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript-lua%2Fpurescript-lua%2Fissues%2F163
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=purescript-lua%2Fpurescript-lua
Reloadhttps://github.com/purescript-lua/purescript-lua/issues/163
Reloadhttps://github.com/purescript-lua/purescript-lua/issues/163
Reloadhttps://github.com/purescript-lua/purescript-lua/issues/163
purescript-luahttps://github.com/purescript-lua
purescript-luahttps://github.com/purescript-lua/purescript-lua
Codehttps://github.com/purescript-lua/purescript-lua
Issues48 (48)https://github.com/purescript-lua/purescript-lua/issues
Pull requestshttps://github.com/purescript-lua/purescript-lua/pulls
Discussionshttps://github.com/purescript-lua/purescript-lua/discussions
Actionshttps://github.com/purescript-lua/purescript-lua/actions
Projectshttps://github.com/purescript-lua/purescript-lua/projects
Security and qualityhttps://github.com/purescript-lua/purescript-lua/security
Insightshttps://github.com/purescript-lua/purescript-lua/insights
https://github.com/purescript-lua/purescript-lua
New issuehttps://github.com/login?return_to=https://github.com/purescript-lua/purescript-lua/issues/163
New issuehttps://github.com/login?return_to=https://github.com/purescript-lua/purescript-lua/issues/163
Top-level inliner reads pre-pass reference counts: can duplicate arbitrary bindings, and recounts the whole module per bindinghttps://github.com/purescript-lua/purescript-lua/issues/163#top
https://github.com/Unisay
area: irIR / optimizer / DCE / inlinerhttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22area%3A%20ir%22
bugSomething isn't workinghttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22bug%22
duplicateThis issue or pull request already existshttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22duplicate%22
https://github.com/Unisay
Unisayhttps://github.com/Unisay
on Jul 4, 2026https://github.com/purescript-lua/purescript-lua/issues/163#issue-4810446686
Unisayhttps://github.com/Unisay
on Jul 4, 2026https://github.com/purescript-lua/purescript-lua/issues/163#event-27562808807
Unisayhttps://github.com/Unisay
bugSomething isn't workinghttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22bug%22
duplicateThis issue or pull request already existshttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22duplicate%22
area: irIR / optimizer / DCE / inlinerhttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22area%3A%20ir%22
on Jul 5, 2026https://github.com/purescript-lua/purescript-lua/issues/163#event-27570299926
https://github.com/Unisay
Unisayhttps://github.com/Unisay
on Jul 5, 2026https://github.com/purescript-lua/purescript-lua/issues/163#issuecomment-4885380040
#142https://github.com/purescript-lua/purescript-lua/issues/142
#143https://github.com/purescript-lua/purescript-lua/issues/143
#143https://github.com/purescript-lua/purescript-lua/issues/143
Unisayhttps://github.com/Unisay
not plannedhttps://github.com/purescript-lua/purescript-lua/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Anot-planned
on Jul 5, 2026https://github.com/purescript-lua/purescript-lua/issues/163#event-27570397682
Sign up for freehttps://github.com/signup?return_to=https://github.com/purescript-lua/purescript-lua/issues/163
Sign in to commenthttps://github.com/login?return_to=https://github.com/purescript-lua/purescript-lua/issues/163
Unisayhttps://github.com/Unisay
area: irIR / optimizer / DCE / inlinerhttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22area%3A%20ir%22
bugSomething isn't workinghttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22bug%22
duplicateThis issue or pull request already existshttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22duplicate%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.