Title: Fold record-literal projection in the IR, not on the Lua AST · Issue #153 · purescript-lua/purescript-lua · GitHub
Open Graph Title: Fold record-literal projection in the IR, not on the Lua AST · Issue #153 · purescript-lua/purescript-lua
X Title: Fold record-literal projection in the IR, not on the Lua AST · Issue #153 · purescript-lua/purescript-lua
Description: The Lua optimizer rule reduceTableDefinitionAccessor (added in #140) folds a field access into a table literal, rewriting { foo = 1, bar = 2 }.foo to 1. It fires only when the constructor is unambiguous: every row must be name-value (all...
Open Graph Description: The Lua optimizer rule reduceTableDefinitionAccessor (added in #140) folds a field access into a table literal, rewriting { foo = 1, bar = 2 }.foo to 1. It fires only when the constructor is unambi...
X Description: The Lua optimizer rule reduceTableDefinitionAccessor (added in #140) folds a field access into a table literal, rewriting { foo = 1, bar = 2 }.foo to 1. It fires only when the constructor is unambi...
Opengraph URL: https://github.com/purescript-lua/purescript-lua/issues/153
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Fold record-literal projection in the IR, not on the Lua AST","articleBody":"The Lua optimizer rule `reduceTableDefinitionAccessor` (added in #140) folds a field access into a table literal, rewriting `{ foo = 1, bar = 2 }.foo` to `1`. It fires only when the constructor is unambiguous: every row must be name-value (`all isNameValue`) and no field name may repeat. Both guards are there because the Lua table constructor is ambiguous at that level. A key-value row can carry an arbitrary expression key (`[\"foo\"] = …`, `[k] = …`) that a name-keyed lookup cannot see, string and number keys coerce, and a repeated key resolves to the last assignment while a first-match fold would return the earliest.\n\nNone of that ambiguity exists one layer up, in the IR. `LiteralObject` carries `[(PropName, Exp)]`, where `PropName` is a static label with no computed-key form, and PureScript's type system already forbids duplicate labels in a record literal. The optimizer assumes well-typed IR anyway (see Note [IR is assumed well-typed]). So the equivalent IR rewrite needs no guards at all:\n\n```haskell\nObjectProp _ (LiteralObject _ props) prop -> lookup prop props\n```\n\nDoing the fold in the IR is also better placed than the Lua-AST version:\n\n- It runs inside the `optimize+dce` fixpoint, so the folded value feeds straight back into constant folding, inlining, and dead-code elimination.\n- It has a live trigger. `LiteralObject` is a non-recursive literal, so `inlineLocalBindings` inlines `let r = { foo: 1, bar: 2 } in r.foo` into the projection site, producing `ObjectProp (LiteralObject …) foo` mid-fixpoint. That is created by the inliner on ordinary code, not a rare source shape.\n- It shrinks the IR before magicDo, flatten-deep-binds, and lowering, so the emitted Lua is already clean.\n\nProposal:\n\n- Add the rewrite (e.g. `reduceObjectProp`) to the rule chain in `optimizedExpressionM`.\n- Delete the Lua-AST `reduceTableDefinitionAccessor` and its spec as superseded. This supersedes the guard added in #140; that hardening was correct while the rule lived on the Lua AST.\n- Optionally handle `ObjectProp (ObjectUpdate obj patches) prop`: if `prop` is among the patches use the patched value, otherwise recurse into `obj`.\n\nEvaluation order: the fold drops the evaluation of the discarded fields (`bar` above). That is the same move the current Lua-AST rule already makes, and it is consistent with the project's policy that DCE drops unused bindings unconditionally. The eval goldens remain the semantic oracle.\n\nFound while reviewing the #140 guard: the guards are a symptom of doing a high-level, semantic optimization at the wrong altitude.\n","author":{"url":"https://github.com/Unisay","@type":"Person","name":"Unisay"},"datePublished":"2026-07-04T08:32:03Z","url":"https://github.com/purescript-lua/purescript-lua/issues/153"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:0e93ef8d-e295-9e84-4e39-8125871eb3ca |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | C952:3C21B:954B6F:C29E7C:6B00DFB7 |
| html-safe-nonce | 6fc81ce4a050521811534afe181def31990b979cb9dbf825f3b1f9c4f1fea182 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOTUyOjNDMjFCOjk1NEI2RjpDMjlFN0M6NkIwMERGQjciLCJ2aXNpdG9yX2lkIjoiNDQ3NjE5ODk0ODk5ODAxMjg1NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 6d4b3f3cd4bd02927b2f59dd07a409b916aa4e17481fe4b4399faa70fbe088e0 |
| hovercard-subject-tag | issue:4808275625 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/purescript-lua/purescript-lua/153/issue_layout |
| twitter:image | https://opengraph.githubassets.com/e99c173f2ac4cf07760d3db76f1d688ef3581549fa4d3616feac37d6919df7f5/purescript-lua/purescript-lua/issues/153 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e99c173f2ac4cf07760d3db76f1d688ef3581549fa4d3616feac37d6919df7f5/purescript-lua/purescript-lua/issues/153 |
| og:image:alt | The Lua optimizer rule reduceTableDefinitionAccessor (added in #140) folds a field access into a table literal, rewriting { foo = 1, bar = 2 }.foo to 1. It fires only when the constructor is unambi... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Unisay |
| hostname | github.com |
| expected-hostname | github.com |
| None | 043c3f30fbcbe2c6c8e729e10cbbbc90c406546f9fbbb67c648d38f6b7d16daf |
| turbo-cache-control | no-preview |
| go-import | github.com/purescript-lua/purescript-lua git https://github.com/purescript-lua/purescript-lua.git |
| octolytics-dimension-user_id | 131581790 |
| octolytics-dimension-user_login | purescript-lua |
| octolytics-dimension-repository_id | 587200487 |
| octolytics-dimension-repository_nwo | purescript-lua/purescript-lua |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 587200487 |
| octolytics-dimension-repository_network_root_nwo | purescript-lua/purescript-lua |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 5425dc24e8bd8d6fca9641a12afc984825a43875 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width