René's URL Explorer Experiment


Title: Fold record-literal projection in the IR, not on the Lua AST · Issue #153 · purescript-lua/purescript-lua · GitHub

Open Graph Title: Fold record-literal projection in the IR, not on the Lua AST · Issue #153 · purescript-lua/purescript-lua

X Title: Fold record-literal projection in the IR, not on the Lua AST · Issue #153 · purescript-lua/purescript-lua

Description: The Lua optimizer rule reduceTableDefinitionAccessor (added in #140) folds a field access into a table literal, rewriting { foo = 1, bar = 2 }.foo to 1. It fires only when the constructor is unambiguous: every row must be name-value (all...

Open Graph Description: The Lua optimizer rule reduceTableDefinitionAccessor (added in #140) folds a field access into a table literal, rewriting { foo = 1, bar = 2 }.foo to 1. It fires only when the constructor is unambi...

X Description: The Lua optimizer rule reduceTableDefinitionAccessor (added in #140) folds a field access into a table literal, rewriting { foo = 1, bar = 2 }.foo to 1. It fires only when the constructor is unambi...

Opengraph URL: https://github.com/purescript-lua/purescript-lua/issues/153

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Fold record-literal projection in the IR, not on the Lua AST","articleBody":"The Lua optimizer rule `reduceTableDefinitionAccessor` (added in #140) folds a field access into a table literal, rewriting `{ foo = 1, bar = 2 }.foo` to `1`. It fires only when the constructor is unambiguous: every row must be name-value (`all isNameValue`) and no field name may repeat. Both guards are there because the Lua table constructor is ambiguous at that level. A key-value row can carry an arbitrary expression key (`[\"foo\"] = …`, `[k] = …`) that a name-keyed lookup cannot see, string and number keys coerce, and a repeated key resolves to the last assignment while a first-match fold would return the earliest.\n\nNone of that ambiguity exists one layer up, in the IR. `LiteralObject` carries `[(PropName, Exp)]`, where `PropName` is a static label with no computed-key form, and PureScript's type system already forbids duplicate labels in a record literal. The optimizer assumes well-typed IR anyway (see Note [IR is assumed well-typed]). So the equivalent IR rewrite needs no guards at all:\n\n```haskell\nObjectProp _ (LiteralObject _ props) prop  ->  lookup prop props\n```\n\nDoing the fold in the IR is also better placed than the Lua-AST version:\n\n- It runs inside the `optimize+dce` fixpoint, so the folded value feeds straight back into constant folding, inlining, and dead-code elimination.\n- It has a live trigger. `LiteralObject` is a non-recursive literal, so `inlineLocalBindings` inlines `let r = { foo: 1, bar: 2 } in r.foo` into the projection site, producing `ObjectProp (LiteralObject …) foo` mid-fixpoint. That is created by the inliner on ordinary code, not a rare source shape.\n- It shrinks the IR before magicDo, flatten-deep-binds, and lowering, so the emitted Lua is already clean.\n\nProposal:\n\n- Add the rewrite (e.g. `reduceObjectProp`) to the rule chain in `optimizedExpressionM`.\n- Delete the Lua-AST `reduceTableDefinitionAccessor` and its spec as superseded. This supersedes the guard added in #140; that hardening was correct while the rule lived on the Lua AST.\n- Optionally handle `ObjectProp (ObjectUpdate obj patches) prop`: if `prop` is among the patches use the patched value, otherwise recurse into `obj`.\n\nEvaluation order: the fold drops the evaluation of the discarded fields (`bar` above). That is the same move the current Lua-AST rule already makes, and it is consistent with the project's policy that DCE drops unused bindings unconditionally. The eval goldens remain the semantic oracle.\n\nFound while reviewing the #140 guard: the guards are a symptom of doing a high-level, semantic optimization at the wrong altitude.\n","author":{"url":"https://github.com/Unisay","@type":"Person","name":"Unisay"},"datePublished":"2026-07-04T08:32:03Z","url":"https://github.com/purescript-lua/purescript-lua/issues/153"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:0e93ef8d-e295-9e84-4e39-8125871eb3ca
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idC952:3C21B:954B6F:C29E7C:6B00DFB7
html-safe-nonce6fc81ce4a050521811534afe181def31990b979cb9dbf825f3b1f9c4f1fea182
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOTUyOjNDMjFCOjk1NEI2RjpDMjlFN0M6NkIwMERGQjciLCJ2aXNpdG9yX2lkIjoiNDQ3NjE5ODk0ODk5ODAxMjg1NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6d4b3f3cd4bd02927b2f59dd07a409b916aa4e17481fe4b4399faa70fbe088e0
hovercard-subject-tagissue:4808275625
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/purescript-lua/purescript-lua/153/issue_layout
twitter:imagehttps://opengraph.githubassets.com/e99c173f2ac4cf07760d3db76f1d688ef3581549fa4d3616feac37d6919df7f5/purescript-lua/purescript-lua/issues/153
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e99c173f2ac4cf07760d3db76f1d688ef3581549fa4d3616feac37d6919df7f5/purescript-lua/purescript-lua/issues/153
og:image:altThe Lua optimizer rule reduceTableDefinitionAccessor (added in #140) folds a field access into a table literal, rewriting { foo = 1, bar = 2 }.foo to 1. It fires only when the constructor is unambi...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameUnisay
hostnamegithub.com
expected-hostnamegithub.com
None043c3f30fbcbe2c6c8e729e10cbbbc90c406546f9fbbb67c648d38f6b7d16daf
turbo-cache-controlno-preview
go-importgithub.com/purescript-lua/purescript-lua git https://github.com/purescript-lua/purescript-lua.git
octolytics-dimension-user_id131581790
octolytics-dimension-user_loginpurescript-lua
octolytics-dimension-repository_id587200487
octolytics-dimension-repository_nwopurescript-lua/purescript-lua
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id587200487
octolytics-dimension-repository_network_root_nwopurescript-lua/purescript-lua
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5425dc24e8bd8d6fca9641a12afc984825a43875
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/purescript-lua/purescript-lua/issues/153#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript-lua%2Fpurescript-lua%2Fissues%2F153
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript-lua%2Fpurescript-lua%2Fissues%2F153
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=purescript-lua%2Fpurescript-lua
Reloadhttps://github.com/purescript-lua/purescript-lua/issues/153
Reloadhttps://github.com/purescript-lua/purescript-lua/issues/153
Reloadhttps://github.com/purescript-lua/purescript-lua/issues/153
purescript-luahttps://github.com/purescript-lua
purescript-luahttps://github.com/purescript-lua/purescript-lua
Codehttps://github.com/purescript-lua/purescript-lua
Issues48 (48)https://github.com/purescript-lua/purescript-lua/issues
Pull requestshttps://github.com/purescript-lua/purescript-lua/pulls
Discussionshttps://github.com/purescript-lua/purescript-lua/discussions
Actionshttps://github.com/purescript-lua/purescript-lua/actions
Projectshttps://github.com/purescript-lua/purescript-lua/projects
Security and qualityhttps://github.com/purescript-lua/purescript-lua/security
Insightshttps://github.com/purescript-lua/purescript-lua/insights
https://github.com/purescript-lua/purescript-lua
New issuehttps://github.com/login?return_to=https://github.com/purescript-lua/purescript-lua/issues/153
New issuehttps://github.com/login?return_to=https://github.com/purescript-lua/purescript-lua/issues/153
#157https://github.com/purescript-lua/purescript-lua/pull/157
Fold record-literal projection in the IR, not on the Lua ASThttps://github.com/purescript-lua/purescript-lua/issues/153#top
#157https://github.com/purescript-lua/purescript-lua/pull/157
https://github.com/Unisay
area: irIR / optimizer / DCE / inlinerhttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22area%3A%20ir%22
enhancementNew feature or requesthttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22enhancement%22
https://github.com/Unisay
Unisayhttps://github.com/Unisay
on Jul 4, 2026https://github.com/purescript-lua/purescript-lua/issues/153#issue-4808275625
#140https://github.com/purescript-lua/purescript-lua/issues/140
reduceTableDefinitionAccessor ignores TableRowKV rows and duplicate fields (folds to Nil) #140https://github.com/purescript-lua/purescript-lua/issues/140
#140https://github.com/purescript-lua/purescript-lua/issues/140
Unisayhttps://github.com/Unisay
enhancementNew feature or requesthttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22enhancement%22
area: irIR / optimizer / DCE / inlinerhttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22area%3A%20ir%22
on Jul 4, 2026https://github.com/purescript-lua/purescript-lua/issues/153#event-27553116628
Unisayhttps://github.com/Unisay
on Jul 4, 2026https://github.com/purescript-lua/purescript-lua/issues/153#event-27553251293
Unisayhttps://github.com/Unisay
completedhttps://github.com/purescript-lua/purescript-lua/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#157https://github.com/purescript-lua/purescript-lua/pull/157
on Jul 5, 2026https://github.com/purescript-lua/purescript-lua/issues/153#event-27580429945
Sign up for freehttps://github.com/signup?return_to=https://github.com/purescript-lua/purescript-lua/issues/153
Sign in to commenthttps://github.com/login?return_to=https://github.com/purescript-lua/purescript-lua/issues/153
Unisayhttps://github.com/Unisay
area: irIR / optimizer / DCE / inlinerhttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22area%3A%20ir%22
enhancementNew feature or requesthttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22enhancement%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.