René's URL Explorer Experiment


Title: Lua optimizer rule pushDeclarationsDownTheInnerScope loses sharing and delays evaluation of let-bound values · Issue #136 · purescript-lua/purescript-lua · GitHub

Open Graph Title: Lua optimizer rule pushDeclarationsDownTheInnerScope loses sharing and delays evaluation of let-bound values · Issue #136 · purescript-lua/purescript-lua

X Title: Lua optimizer rule pushDeclarationsDownTheInnerScope loses sharing and delays evaluation of let-bound values · Issue #136 · purescript-lua/purescript-lua

Description: pushDeclarationsDownTheInnerScope (lib/Language/PureScript/Backend/Lua/Optimizer.hs) rewrites function(a) local t = expensive(a); return function(b) ... t ... end end into function(a) return function(b) local t = expensive(a); ... t ... ...

Open Graph Description: pushDeclarationsDownTheInnerScope (lib/Language/PureScript/Backend/Lua/Optimizer.hs) rewrites function(a) local t = expensive(a); return function(b) ... t ... end end into function(a) return functi...

X Description: pushDeclarationsDownTheInnerScope (lib/Language/PureScript/Backend/Lua/Optimizer.hs) rewrites function(a) local t = expensive(a); return function(b) ... t ... end end into function(a) return functi...

Opengraph URL: https://github.com/purescript-lua/purescript-lua/issues/136

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Lua optimizer rule pushDeclarationsDownTheInnerScope loses sharing and delays evaluation of let-bound values","articleBody":"`pushDeclarationsDownTheInnerScope` (`lib/Language/PureScript/Backend/Lua/Optimizer.hs`) rewrites\n\n```lua\nfunction(a) local t = expensive(a); return function(b) ... t ... end end\n```\n\ninto\n\n```lua\nfunction(a) return function(b) local t = expensive(a); ... t ... end end\n```\n\nwhenever an outer function body consists of `local` declarations followed by `return function ... end`. The rule dates back to the initial commit and its motivation is not documented anywhere (the spec only pins the mechanics).\n\nTwo consequences:\n\n## 1. Sharing is lost\n\nBefore the rewrite, `expensive(a)` runs once per partial application; after it, once per call of the inner function. PureScript's strict semantics make `let` the standard tool for sharing work across calls, so the degradation can be asymptotic:\n\n```purescript\nmemoized :: Int -> Int\nmemoized = let table = buildBigTable 1000 in \\n -> lookup table n\n```\n\ncompiles to exactly the outer-locals-then-return-function shape this rule matches, and after the rewrite `buildBigTable` runs on every call of `memoized n`.\n\n## 2. Evaluation is delayed, which is observable\n\nIn a strict language the let is evaluated when the outer function is applied. Moving the declaration into the inner function delays it until full application, so effects escape their intended timing. The clearest case is an error:\n\n```purescript\nf = \\a -> let checked = validate a in \\b -> use checked b\n```\n\n`f badInput` should raise at partial application; after the rewrite the raise happens only when the result is applied to `b`. Since generated code also uses `error` for pattern-match failures, this shifts where a crash surfaces.\n\n## What the rule actually pessimizes\n\nDisabling the rule and regenerating the goldens shows it was hitting type-class dictionary resolution: 16 `golden.lua` files change, all in the same direction. Typical diff (`MaybeChain`, `TailRecM2Shadow`):\n\n```diff\n     apply = (function()\n+      local bind = M.Control_Bind_bind(M.Effect_monadEffect.Bind1())\n       return function(f)\n-        local bind = M.Control_Bind_bind(M.Effect_monadEffect.Bind1())\n         return function(a)\n```\n\nWith the rule on, `bind`/`pure` were resolved on every call of the partially applied function; without it, once. All eval goldens (the hand-verified runtime oracle) pass unchanged.\n\n## Decision\n\n- The rule is disabled (removed from `rewriteRulesInOrder`, definition kept) and stays disabled.\n- The idiomatic replacement is a float-in pass at the IR level, where usage information is available: sink a `Let` binding toward its use site (into an `IfThenElse` branch that is the only user, next to a sole use), but never across a lambda, following the same discipline GHC's FloatIn applies (see Peyton Jones, Partain, Santos, \"Let-floating: moving bindings to give faster programs\", 1996). That recovers the legitimate part of what this rule may have been after (upvalue-to-local conversion, fewer live upvalues under Lua 5.1's limit of 60 per function) without touching evaluation timing or sharing.\n- Prerequisite for the float-in pass: the \"rename shadowed names first\" pipeline restructuring, so the new pass does not have to re-implement the De Bruijn index bookkeeping that produced #37, #56, and #134.\n\nFound during a backend audit on 2026-07-02.\n","author":{"url":"https://github.com/Unisay","@type":"Person","name":"Unisay"},"datePublished":"2026-07-02T09:32:17Z","url":"https://github.com/purescript-lua/purescript-lua/issues/136"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:88907827-42b8-1276-6c2c-fc8a15aaf2bf
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idAB50:DB09F:AB8BD1:DC3B3F:6B00F82C
html-safe-nonceea9c3df6786d1505461dd63d24c8348c6d3325684285c06865c96d75478f3a53
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQjUwOkRCMDlGOkFCOEJEMTpEQzNCM0Y6NkIwMEY4MkMiLCJ2aXNpdG9yX2lkIjoiMjAxNTg3Nzg4ODk3NjQxODg2MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac3d287ee0ce6297485b865d0a4dfa957df3f7413c976ba94c42696deddee4ec7f
hovercard-subject-tagissue:4793120819
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/purescript-lua/purescript-lua/136/issue_layout
twitter:imagehttps://opengraph.githubassets.com/00cd4b244810a468e2906e4f984f4a2bb63fac10b74d902b3bea0d719f887c72/purescript-lua/purescript-lua/issues/136
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/00cd4b244810a468e2906e4f984f4a2bb63fac10b74d902b3bea0d719f887c72/purescript-lua/purescript-lua/issues/136
og:image:altpushDeclarationsDownTheInnerScope (lib/Language/PureScript/Backend/Lua/Optimizer.hs) rewrites function(a) local t = expensive(a); return function(b) ... t ... end end into function(a) return functi...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameUnisay
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-preview
go-importgithub.com/purescript-lua/purescript-lua git https://github.com/purescript-lua/purescript-lua.git
octolytics-dimension-user_id131581790
octolytics-dimension-user_loginpurescript-lua
octolytics-dimension-repository_id587200487
octolytics-dimension-repository_nwopurescript-lua/purescript-lua
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id587200487
octolytics-dimension-repository_network_root_nwopurescript-lua/purescript-lua
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/purescript-lua/purescript-lua/issues/136#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript-lua%2Fpurescript-lua%2Fissues%2F136
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript-lua%2Fpurescript-lua%2Fissues%2F136
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=purescript-lua%2Fpurescript-lua
Reloadhttps://github.com/purescript-lua/purescript-lua/issues/136
Reloadhttps://github.com/purescript-lua/purescript-lua/issues/136
Reloadhttps://github.com/purescript-lua/purescript-lua/issues/136
purescript-luahttps://github.com/purescript-lua
purescript-luahttps://github.com/purescript-lua/purescript-lua
Codehttps://github.com/purescript-lua/purescript-lua
Issues48 (48)https://github.com/purescript-lua/purescript-lua/issues
Pull requestshttps://github.com/purescript-lua/purescript-lua/pulls
Discussionshttps://github.com/purescript-lua/purescript-lua/discussions
Actionshttps://github.com/purescript-lua/purescript-lua/actions
Projectshttps://github.com/purescript-lua/purescript-lua/projects
Security and qualityhttps://github.com/purescript-lua/purescript-lua/security
Insightshttps://github.com/purescript-lua/purescript-lua/insights
https://github.com/purescript-lua/purescript-lua
New issuehttps://github.com/login?return_to=https://github.com/purescript-lua/purescript-lua/issues/136
New issuehttps://github.com/login?return_to=https://github.com/purescript-lua/purescript-lua/issues/136
#151https://github.com/purescript-lua/purescript-lua/pull/151
Lua optimizer rule pushDeclarationsDownTheInnerScope loses sharing and delays evaluation of let-bound valueshttps://github.com/purescript-lua/purescript-lua/issues/136#top
#151https://github.com/purescript-lua/purescript-lua/pull/151
https://github.com/Unisay
bugSomething isn't workinghttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com/Unisay
Unisayhttps://github.com/Unisay
on Jul 2, 2026https://github.com/purescript-lua/purescript-lua/issues/136#issue-4793120819
Undefined variable in compiled code #37https://github.com/purescript-lua/purescript-lua/issues/37
Codegen: 'Unexpected bound reference Local b index 1' compiling Data.Array.foldRecM (index inflated by optimizer) #56https://github.com/purescript-lua/purescript-lua/issues/56
IR DCE mishandles Let bindings: no unshift after dropping a dead shadowing binder, body scope resolved in reverse #134https://github.com/purescript-lua/purescript-lua/issues/134
Unisayhttps://github.com/Unisay
bugSomething isn't workinghttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22bug%22
on Jul 2, 2026https://github.com/purescript-lua/purescript-lua/issues/136#event-27471359215
Unisayhttps://github.com/Unisay
on Jul 2, 2026https://github.com/purescript-lua/purescript-lua/issues/136#event-27474086005
Merge pull request #137 from purescript-lua/chore/disable-push-declar…https://github.com/purescript-lua/purescript-lua/commit/f68c23fafd4521a7dbdece037d4b4adae54a1074
#137https://github.com/purescript-lua/purescript-lua/pull/137
f68c23fhttps://github.com/purescript-lua/purescript-lua/commit/f68c23fafd4521a7dbdece037d4b4adae54a1074
https://github.com/Unisay
Unisayhttps://github.com/Unisay
on Jul 2, 2026https://github.com/purescript-lua/purescript-lua/issues/136#issuecomment-4869153407
#139https://github.com/purescript-lua/purescript-lua/issues/139
#138https://github.com/purescript-lua/purescript-lua/issues/138
Unisayhttps://github.com/Unisay
on Jul 3, 2026https://github.com/purescript-lua/purescript-lua/issues/136#event-27530276156
Unisayhttps://github.com/Unisay
completedhttps://github.com/purescript-lua/purescript-lua/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#151https://github.com/purescript-lua/purescript-lua/pull/151
on Jul 3, 2026https://github.com/purescript-lua/purescript-lua/issues/136#event-27542538253
Sign up for freehttps://github.com/signup?return_to=https://github.com/purescript-lua/purescript-lua/issues/136
Sign in to commenthttps://github.com/login?return_to=https://github.com/purescript-lua/purescript-lua/issues/136
Unisayhttps://github.com/Unisay
bugSomething isn't workinghttps://github.com/purescript-lua/purescript-lua/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.