Title: [fork-ffi] prelude: showNumberImpl — showNumberImpl delegates the core formatting to Lua's tostring, which… · Issue #100 · purescript-lua/purescript-lua · GitHub
Open Graph Title: [fork-ffi] prelude: showNumberImpl — showNumberImpl delegates the core formatting to Lua's tostring, which… · Issue #100 · purescript-lua/purescript-lua
X Title: [fork-ffi] prelude: showNumberImpl — showNumberImpl delegates the core formatting to Lua's tostring, which… · Issue #100 · purescript-lua/purescript-lua
Description: Package: purescript-lua-prelude File: src/Data/Show.lua Function: showNumberImpl Class: show-escaping Severity: medium showNumberImpl delegates the core formatting to Lua's tostring, which uses the default %.14g format. PureScript's Show...
Open Graph Description: Package: purescript-lua-prelude File: src/Data/Show.lua Function: showNumberImpl Class: show-escaping Severity: medium showNumberImpl delegates the core formatting to Lua's tostring, which uses the...
X Description: Package: purescript-lua-prelude File: src/Data/Show.lua Function: showNumberImpl Class: show-escaping Severity: medium showNumberImpl delegates the core formatting to Lua's tostring, which uses...
Opengraph URL: https://github.com/purescript-lua/purescript-lua/issues/100
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[fork-ffi] prelude: showNumberImpl — showNumberImpl delegates the core formatting to Lua's tostring, which…","articleBody":"**Package:** purescript-lua-prelude \n**File:** `src/Data/Show.lua` \n**Function:** `showNumberImpl` \n**Class:** show-escaping **Severity:** medium\n\nshowNumberImpl delegates the core formatting to Lua's tostring, which uses the default %.14g format. PureScript's Show Number must reproduce JavaScript's Number.prototype.toString (the upstream JS FFI is `var str = n.toString(); return isNaN(str + \".0\") ? str : str + \".0\";`). Lua's %.14g diverges from JS in two independent ways. (1) Precision: it prints at most 14 significant digits, so `show (1.0/3.0)` yields \"0.33333333333333\" where PureScript/JS yields \"0.3333333333333333\" (16-17 sig digits, shortest round-trip). The Lua result does not even round-trip back to the same Double. (2) Number formatting: Lua switches to scientific notation far earlier than JS and zero-pads exponents to >=2 digits with an explicit sign. Concretely `show (1.0e-5)` gives Lua \"1e-05\" but JS \"0.00001\"; `show (1.0e-7)` gives Lua \"1e-07\" but JS \"1e-7\". The trailing-\".0\" logic itself is correct (it appends .0 only when there is no '.'/'e'/'E', matching the JS isNaN trick), but it operates on an already-wrong base string. The divergence is latent: the test suite's `testNumberShow` foreign import has no .lua implementation (only Utils.js exists, and it only defines throwErr), so no eval golden currently exercises Number show formatting under Lua 5.1.\n\n**Current (Lua):**\n```lua\nshowNumberImpl = (function(n)\n if n ~= n then return \"NaN\" end\n if n == math.huge then return \"Infinity\" end\n if n == -math.huge then return \"-Infinity\" end\n local str = tostring(n)\n if str:find(\"[.eE]\") then return str end\n return str .. \".0\"\nend)\n```\n\n**Expected:** PureScript/JS show: 1.0/3.0 -> \"0.3333333333333333\"; 1.0e-5 -> \"0.00001\"; 1.0e-7 -> \"1e-7\"; 1.0e21 -> \"1e+21\"; 100.0 -> \"100.0\"; 0.1 -> \"0.1\". Lua tostring currently gives: 1.0/3.0 -> \"0.33333333333333\"; 1.0e-5 -> \"1e-05\"; 1.0e-7 -> \"1e-07\". NaN/Infinity/-Infinity and the .0 suffix logic are already correct.\n\n**Proposed fix:**\n```lua\nReplace the bare `tostring(n)` with a base string produced by a shortest-round-trip search and then normalize the result to JS conventions, instead of relying on %.14g. Step 1 (precision): build str by trying string.format(\"%.\"..p..\"g\", n) for p = 1..17 and taking the first whose tonumber() equals n. Step 2 (formatting): %g alone is not sufficient because the shortest round-trip can pick scientific form for plain integers (e.g. 100 -> \"1e+02\") and zero-pads exponents; post-process to match JS: when the decimal exponent is in JS's plain-decimal range (roughly -6 \u003c= exp \u003c 21) emit fixed/decimal notation, otherwise emit `mantissa e+/-EXP` with the exponent's leading zeros stripped (keep the sign, so e-7 not e-07 and e+21 not e+021). Keep the existing NaN/Infinity/-Infinity guards and the trailing-\".0\" rule (append \".0\" only when the final string contains no '.', 'e', or 'E'). Fully emulating Number.prototype.toString in Lua 5.1 is non-trivial; at minimum the shortest-round-trip search fixes the precision loss, and the exponent-normalization fixes the e-07/e-7 mismatch.\n```\n\n_Found by the FFI audit; reproduced under Lua 5.1._","author":{"url":"https://github.com/Unisay","@type":"Person","name":"Unisay"},"datePublished":"2026-06-15T11:24:21Z","url":"https://github.com/purescript-lua/purescript-lua/issues/100"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:acd40a9d-fce5-46a8-40db-de94b157e7f3 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 921C:3A347:68DB60:8CF3CF:6B00D60B |
| html-safe-nonce | 604f06f3c5bbef62ee6debd4830a505f1c0afc288d9b6a7cfc750026c83e0d47 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MjFDOjNBMzQ3OjY4REI2MDo4Q0YzQ0Y6NkIwMEQ2MEIiLCJ2aXNpdG9yX2lkIjoiNjkxNjQ1MjU2NDYwMzAzMzEwMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 6c95c3f64c5f87f1e0082aafe66820b0dc3aa1bcc27673580339f719412bfd31 |
| hovercard-subject-tag | issue:4664609770 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/purescript-lua/purescript-lua/100/issue_layout |
| twitter:image | https://opengraph.githubassets.com/329d9d2e6398b47104280712032c617d7026a8bd557e1f791531763e049ba36f/purescript-lua/purescript-lua/issues/100 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/329d9d2e6398b47104280712032c617d7026a8bd557e1f791531763e049ba36f/purescript-lua/purescript-lua/issues/100 |
| og:image:alt | Package: purescript-lua-prelude File: src/Data/Show.lua Function: showNumberImpl Class: show-escaping Severity: medium showNumberImpl delegates the core formatting to Lua's tostring, which uses the... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Unisay |
| hostname | github.com |
| expected-hostname | github.com |
| None | a481f62a1e04c9b9bdcb5628230682c66d59006f5b13b080f79cba84a176905b |
| turbo-cache-control | no-preview |
| go-import | github.com/purescript-lua/purescript-lua git https://github.com/purescript-lua/purescript-lua.git |
| octolytics-dimension-user_id | 131581790 |
| octolytics-dimension-user_login | purescript-lua |
| octolytics-dimension-repository_id | 587200487 |
| octolytics-dimension-repository_nwo | purescript-lua/purescript-lua |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 587200487 |
| octolytics-dimension-repository_network_root_nwo | purescript-lua/purescript-lua |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 84c8c5cc25e2fb7f2308428458538436baecc6d2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width