René's URL Explorer Experiment


Title: [fork-ffi] prelude: showNumberImpl — showNumberImpl delegates the core formatting to Lua's tostring, which… · Issue #100 · purescript-lua/purescript-lua · GitHub

Open Graph Title: [fork-ffi] prelude: showNumberImpl — showNumberImpl delegates the core formatting to Lua's tostring, which… · Issue #100 · purescript-lua/purescript-lua

X Title: [fork-ffi] prelude: showNumberImpl — showNumberImpl delegates the core formatting to Lua's tostring, which… · Issue #100 · purescript-lua/purescript-lua

Description: Package: purescript-lua-prelude File: src/Data/Show.lua Function: showNumberImpl Class: show-escaping Severity: medium showNumberImpl delegates the core formatting to Lua's tostring, which uses the default %.14g format. PureScript's Show...

Open Graph Description: Package: purescript-lua-prelude File: src/Data/Show.lua Function: showNumberImpl Class: show-escaping Severity: medium showNumberImpl delegates the core formatting to Lua's tostring, which uses the...

X Description: Package: purescript-lua-prelude File: src/Data/Show.lua Function: showNumberImpl Class: show-escaping Severity: medium showNumberImpl delegates the core formatting to Lua's tostring, which uses...

Opengraph URL: https://github.com/purescript-lua/purescript-lua/issues/100

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[fork-ffi] prelude: showNumberImpl — showNumberImpl delegates the core formatting to Lua's tostring, which…","articleBody":"**Package:** purescript-lua-prelude  \n**File:** `src/Data/Show.lua`  \n**Function:** `showNumberImpl`  \n**Class:** show-escaping  **Severity:** medium\n\nshowNumberImpl delegates the core formatting to Lua's tostring, which uses the default %.14g format. PureScript's Show Number must reproduce JavaScript's Number.prototype.toString (the upstream JS FFI is `var str = n.toString(); return isNaN(str + \".0\") ? str : str + \".0\";`). Lua's %.14g diverges from JS in two independent ways. (1) Precision: it prints at most 14 significant digits, so `show (1.0/3.0)` yields \"0.33333333333333\" where PureScript/JS yields \"0.3333333333333333\" (16-17 sig digits, shortest round-trip). The Lua result does not even round-trip back to the same Double. (2) Number formatting: Lua switches to scientific notation far earlier than JS and zero-pads exponents to >=2 digits with an explicit sign. Concretely `show (1.0e-5)` gives Lua \"1e-05\" but JS \"0.00001\"; `show (1.0e-7)` gives Lua \"1e-07\" but JS \"1e-7\". The trailing-\".0\" logic itself is correct (it appends .0 only when there is no '.'/'e'/'E', matching the JS isNaN trick), but it operates on an already-wrong base string. The divergence is latent: the test suite's `testNumberShow` foreign import has no .lua implementation (only Utils.js exists, and it only defines throwErr), so no eval golden currently exercises Number show formatting under Lua 5.1.\n\n**Current (Lua):**\n```lua\nshowNumberImpl = (function(n)\n  if n ~= n then return \"NaN\" end\n  if n == math.huge then return \"Infinity\" end\n  if n == -math.huge then return \"-Infinity\" end\n  local str = tostring(n)\n  if str:find(\"[.eE]\") then return str end\n  return str .. \".0\"\nend)\n```\n\n**Expected:** PureScript/JS show: 1.0/3.0 -> \"0.3333333333333333\"; 1.0e-5 -> \"0.00001\"; 1.0e-7 -> \"1e-7\"; 1.0e21 -> \"1e+21\"; 100.0 -> \"100.0\"; 0.1 -> \"0.1\". Lua tostring currently gives: 1.0/3.0 -> \"0.33333333333333\"; 1.0e-5 -> \"1e-05\"; 1.0e-7 -> \"1e-07\". NaN/Infinity/-Infinity and the .0 suffix logic are already correct.\n\n**Proposed fix:**\n```lua\nReplace the bare `tostring(n)` with a base string produced by a shortest-round-trip search and then normalize the result to JS conventions, instead of relying on %.14g. Step 1 (precision): build str by trying string.format(\"%.\"..p..\"g\", n) for p = 1..17 and taking the first whose tonumber() equals n. Step 2 (formatting): %g alone is not sufficient because the shortest round-trip can pick scientific form for plain integers (e.g. 100 -> \"1e+02\") and zero-pads exponents; post-process to match JS: when the decimal exponent is in JS's plain-decimal range (roughly -6 \u003c= exp \u003c 21) emit fixed/decimal notation, otherwise emit `mantissa e+/-EXP` with the exponent's leading zeros stripped (keep the sign, so e-7 not e-07 and e+21 not e+021). Keep the existing NaN/Infinity/-Infinity guards and the trailing-\".0\" rule (append \".0\" only when the final string contains no '.', 'e', or 'E'). Fully emulating Number.prototype.toString in Lua 5.1 is non-trivial; at minimum the shortest-round-trip search fixes the precision loss, and the exponent-normalization fixes the e-07/e-7 mismatch.\n```\n\n_Found by the FFI audit; reproduced under Lua 5.1._","author":{"url":"https://github.com/Unisay","@type":"Person","name":"Unisay"},"datePublished":"2026-06-15T11:24:21Z","url":"https://github.com/purescript-lua/purescript-lua/issues/100"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:acd40a9d-fce5-46a8-40db-de94b157e7f3
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id921C:3A347:68DB60:8CF3CF:6B00D60B
html-safe-nonce604f06f3c5bbef62ee6debd4830a505f1c0afc288d9b6a7cfc750026c83e0d47
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MjFDOjNBMzQ3OjY4REI2MDo4Q0YzQ0Y6NkIwMEQ2MEIiLCJ2aXNpdG9yX2lkIjoiNjkxNjQ1MjU2NDYwMzAzMzEwMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6c95c3f64c5f87f1e0082aafe66820b0dc3aa1bcc27673580339f719412bfd31
hovercard-subject-tagissue:4664609770
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/purescript-lua/purescript-lua/100/issue_layout
twitter:imagehttps://opengraph.githubassets.com/329d9d2e6398b47104280712032c617d7026a8bd557e1f791531763e049ba36f/purescript-lua/purescript-lua/issues/100
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/329d9d2e6398b47104280712032c617d7026a8bd557e1f791531763e049ba36f/purescript-lua/purescript-lua/issues/100
og:image:altPackage: purescript-lua-prelude File: src/Data/Show.lua Function: showNumberImpl Class: show-escaping Severity: medium showNumberImpl delegates the core formatting to Lua's tostring, which uses the...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameUnisay
hostnamegithub.com
expected-hostnamegithub.com
Nonea481f62a1e04c9b9bdcb5628230682c66d59006f5b13b080f79cba84a176905b
turbo-cache-controlno-preview
go-importgithub.com/purescript-lua/purescript-lua git https://github.com/purescript-lua/purescript-lua.git
octolytics-dimension-user_id131581790
octolytics-dimension-user_loginpurescript-lua
octolytics-dimension-repository_id587200487
octolytics-dimension-repository_nwopurescript-lua/purescript-lua
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id587200487
octolytics-dimension-repository_network_root_nwopurescript-lua/purescript-lua
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release84c8c5cc25e2fb7f2308428458538436baecc6d2
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/purescript-lua/purescript-lua/issues/100#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript-lua%2Fpurescript-lua%2Fissues%2F100
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript-lua%2Fpurescript-lua%2Fissues%2F100
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=purescript-lua%2Fpurescript-lua
Reloadhttps://github.com/purescript-lua/purescript-lua/issues/100
Reloadhttps://github.com/purescript-lua/purescript-lua/issues/100
Reloadhttps://github.com/purescript-lua/purescript-lua/issues/100
purescript-luahttps://github.com/purescript-lua
purescript-luahttps://github.com/purescript-lua/purescript-lua
Codehttps://github.com/purescript-lua/purescript-lua
Issues48 (48)https://github.com/purescript-lua/purescript-lua/issues
Pull requestshttps://github.com/purescript-lua/purescript-lua/pulls
Discussionshttps://github.com/purescript-lua/purescript-lua/discussions
Actionshttps://github.com/purescript-lua/purescript-lua/actions
Projectshttps://github.com/purescript-lua/purescript-lua/projects
Security and qualityhttps://github.com/purescript-lua/purescript-lua/security
Insightshttps://github.com/purescript-lua/purescript-lua/insights
https://github.com/purescript-lua/purescript-lua
New issuehttps://github.com/login?return_to=https://github.com/purescript-lua/purescript-lua/issues/100
New issuehttps://github.com/login?return_to=https://github.com/purescript-lua/purescript-lua/issues/100
[fork-ffi] prelude: showNumberImpl — showNumberImpl delegates the core formatting to Lua's tostring, which…https://github.com/purescript-lua/purescript-lua/issues/100#top
https://github.com/Unisay
https://github.com/Unisay
Unisayhttps://github.com/Unisay
on Jun 15, 2026https://github.com/purescript-lua/purescript-lua/issues/100#issue-4664609770
Unisayhttps://github.com/Unisay
on Jun 15, 2026https://github.com/purescript-lua/purescript-lua/issues/100#event-26757557233
https://github.com/Unisay
Unisayhttps://github.com/Unisay
on Jun 15, 2026https://github.com/purescript-lua/purescript-lua/issues/100#issuecomment-4708081132
Unisayhttps://github.com/Unisay
not plannedhttps://github.com/purescript-lua/purescript-lua/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Anot-planned
on Jun 15, 2026https://github.com/purescript-lua/purescript-lua/issues/100#event-26757679894
Sign up for freehttps://github.com/signup?return_to=https://github.com/purescript-lua/purescript-lua/issues/100
Sign in to commenthttps://github.com/login?return_to=https://github.com/purescript-lua/purescript-lua/issues/100
Unisayhttps://github.com/Unisay
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.