René's URL Explorer Experiment


Title: catchException catches all exceptions rather than just Error exceptions · Issue #27 · purescript/purescript-exceptions · GitHub

Open Graph Title: catchException catches all exceptions rather than just Error exceptions · Issue #27 · purescript/purescript-exceptions

X Title: catchException catches all exceptions rather than just Error exceptions · Issue #27 · purescript/purescript-exceptions

Description: It seems clear that this package is intended to catch Error exceptions. However, catchException does this: try { return t(); } catch (e) { if (e instanceof Error || Object.prototype.toString.call(e) === "[object Error]") { return c(e)();...

Open Graph Description: It seems clear that this package is intended to catch Error exceptions. However, catchException does this: try { return t(); } catch (e) { if (e instanceof Error || Object.prototype.toString.call(e...

X Description: It seems clear that this package is intended to catch Error exceptions. However, catchException does this: try { return t(); } catch (e) { if (e instanceof Error || Object.prototype.toString.call(e...

Opengraph URL: https://github.com/purescript/purescript-exceptions/issues/27

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"catchException catches all exceptions rather than just Error exceptions","articleBody":"It seems clear that this package is intended to catch `Error` exceptions. However, `catchException` does this:\r\n\r\n```\r\ntry {\r\n        return t();\r\n      } catch (e) {\r\n        if (e instanceof Error || Object.prototype.toString.call(e) === \"[object Error]\") {\r\n          return c(e)();\r\n        } else {\r\n          return c(new Error(e.toString()))();\r\n        }\r\n}\r\n```\r\n\r\nThat is, if the exception is determined to not be an `Error` exception, it attempts to convert the exception to an `Error` exception. This conversion itself throws for both `null` and `undefined`, which are possible values. Furthermore, this implementation prevents users from catching other types of exceptions in an obvious way (they would have to use a different catch before this one).\r\n\r\nSuggestion: just rethrow the exception if it is not `Error`.","author":{"url":"https://github.com/eric-corumdigital","@type":"Person","name":"eric-corumdigital"},"datePublished":"2018-04-06T17:43:38Z","url":"https://github.com/purescript/purescript-exceptions/issues/27"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:b2c75be2-0421-b952-ce14-ffe32cfd9d2d
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8822:19F84C:E66569:12816E5:6B00F736
html-safe-nonce63a35d5ef021ab89d7f16e94bb00ddb00054449decc4d88468c95cfe20762526
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4ODIyOjE5Rjg0QzpFNjY1Njk6MTI4MTZFNTo2QjAwRjczNiIsInZpc2l0b3JfaWQiOiI2Mzg0MzY1NjAxOTI1NjkxMTkwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac9bfbcc47f1f6e58f351ebe1299ad6850e71f1310a13713f30e8bb0b6e6d17ef8
hovercard-subject-tagissue:312060239
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/purescript/purescript-exceptions/27/issue_layout
twitter:imagehttps://opengraph.githubassets.com/bc7a66963cd705d4e4ef4f5c973c2ddc016492ca7c8cc89ffda6bc1d557d7458/purescript/purescript-exceptions/issues/27
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/bc7a66963cd705d4e4ef4f5c973c2ddc016492ca7c8cc89ffda6bc1d557d7458/purescript/purescript-exceptions/issues/27
og:image:altIt seems clear that this package is intended to catch Error exceptions. However, catchException does this: try { return t(); } catch (e) { if (e instanceof Error || Object.prototype.toString.call(e...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameeric-corumdigital
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-preview
go-importgithub.com/purescript/purescript-exceptions git https://github.com/purescript/purescript-exceptions.git
octolytics-dimension-user_id6556677
octolytics-dimension-user_loginpurescript
octolytics-dimension-repository_id17921509
octolytics-dimension-repository_nwopurescript/purescript-exceptions
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id17921509
octolytics-dimension-repository_network_root_nwopurescript/purescript-exceptions
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/purescript/purescript-exceptions/issues/27#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript%2Fpurescript-exceptions%2Fissues%2F27
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript%2Fpurescript-exceptions%2Fissues%2F27
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=purescript%2Fpurescript-exceptions
Reloadhttps://github.com/purescript/purescript-exceptions/issues/27
Reloadhttps://github.com/purescript/purescript-exceptions/issues/27
Reloadhttps://github.com/purescript/purescript-exceptions/issues/27
purescripthttps://github.com/purescript
purescript-exceptionshttps://github.com/purescript/purescript-exceptions
Codehttps://github.com/purescript/purescript-exceptions
Issues1 (1)https://github.com/purescript/purescript-exceptions/issues
Pull requestshttps://github.com/purescript/purescript-exceptions/pulls
Actionshttps://github.com/purescript/purescript-exceptions/actions
Security and qualityhttps://github.com/purescript/purescript-exceptions/security
Insightshttps://github.com/purescript/purescript-exceptions/insights
https://github.com/purescript/purescript-exceptions
New issuehttps://github.com/login?return_to=https://github.com/purescript/purescript-exceptions/issues/27
New issuehttps://github.com/login?return_to=https://github.com/purescript/purescript-exceptions/issues/27
catchException catches all exceptions rather than just Error exceptionshttps://github.com/purescript/purescript-exceptions/issues/27#top
status: needs more infoThis issue needs more info before any action can be done.https://github.com/purescript/purescript-exceptions/issues?q=state%3Aopen%20label%3A%22status%3A%20needs%20more%20info%22
https://github.com/eric-corumdigital
eric-corumdigitalhttps://github.com/eric-corumdigital
on Apr 6, 2018https://github.com/purescript/purescript-exceptions/issues/27#issue-312060239
https://github.com/JordanMartinez
JordanMartinezhttps://github.com/JordanMartinez
on Oct 14, 2020https://github.com/purescript/purescript-exceptions/issues/27#issuecomment-708085779
https://github.com/hdgarrood
hdgarroodhttps://github.com/hdgarrood
on Oct 16, 2020https://github.com/purescript/purescript-exceptions/issues/27#issuecomment-710578876
https://github.com/kl0tl
kl0tlhttps://github.com/kl0tl
on Dec 17, 2020https://github.com/purescript/purescript-exceptions/issues/27#issuecomment-747750600
https://github.com/tc39/proposal-error-causehttps://github.com/tc39/proposal-error-cause
JordanMartinezhttps://github.com/JordanMartinez
status: needs more infoThis issue needs more info before any action can be done.https://github.com/purescript/purescript-exceptions/issues?q=state%3Aopen%20label%3A%22status%3A%20needs%20more%20info%22
on Dec 4, 2021https://github.com/purescript/purescript-exceptions/issues/27#event-5715263159
https://github.com/jmp-0x7C0
jmp-0x7C0https://github.com/jmp-0x7C0
on Aug 31, 2022https://github.com/purescript/purescript-exceptions/issues/27#issuecomment-1233397722
https://github.com/tc39/proposal-error-causehttps://github.com/tc39/proposal-error-cause
https://github.com/JordanMartinez
JordanMartinezhttps://github.com/JordanMartinez
on Sep 10, 2022https://github.com/purescript/purescript-exceptions/issues/27#issuecomment-1242690277
https://caniuse.com/mdn-javascript_builtins_error_causehttps://caniuse.com/mdn-javascript_builtins_error_cause
https://github.com/garyb
garybhttps://github.com/garyb
on Sep 10, 2022https://github.com/purescript/purescript-exceptions/issues/27#issuecomment-1242728859
Sign up for freehttps://github.com/signup?return_to=https://github.com/purescript/purescript-exceptions/issues/27
Sign in to commenthttps://github.com/login?return_to=https://github.com/purescript/purescript-exceptions/issues/27
status: needs more infoThis issue needs more info before any action can be done.https://github.com/purescript/purescript-exceptions/issues?q=state%3Aopen%20label%3A%22status%3A%20needs%20more%20info%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.