| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:7c4f56b5-ffd0-f3a5-50f1-4ad41b66723a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9DE6:BBAAA:BD665A:FB55A7:6B00F095 |
| html-safe-nonce | f66af4562eb1b01d6b5d4b47e3d5ea5dca2f4bdb3a2c82ab0f514c5e9e3edeed |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5REU2OkJCQUFBOkJENjY1QTpGQjU1QTc6NkIwMEYwOTUiLCJ2aXNpdG9yX2lkIjoiNjU4MzE0MzQ3NDQzMjg5NzE3MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 85733b4a93ed8125c70a5cf5971f45d1e5f92d260d833c7cdcecb5f0e396b3c5 |
| hovercard-subject-tag | pull_request:1575291886 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/purescript/purescript/4513/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/adf609e355ab0a8923317735620180d83842092d4d36883748664279be367f6f/purescript/purescript/pull/4513 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/adf609e355ab0a8923317735620180d83842092d4d36883748664279be367f6f/purescript/purescript/pull/4513 |
| og:image:alt | Description of the change
Fixes #4495
Fixes #4487
A second cleaner take on #4494 using the idea I mentioned in the last comment of that PR.
With the advent of VTAs, all type class instances can be ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | JordanMartinez |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc |
| turbo-cache-control | no-cache |
| go-import | github.com/purescript/purescript git https://github.com/purescript/purescript.git |
| octolytics-dimension-user_id | 6556677 |
| octolytics-dimension-user_login | purescript |
| octolytics-dimension-repository_id | 13206906 |
| octolytics-dimension-repository_nwo | purescript/purescript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 13206906 |
| octolytics-dimension-repository_network_root_nwo | purescript/purescript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9983dd5da06943f833c971dd5b6bc988e2858be5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/purescript/purescript/pull/4513#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript%2Fpurescript%2Fpull%2F4513 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript%2Fpurescript%2Fpull%2F4513 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=purescript%2Fpurescript |
| Reload | https://github.com/purescript/purescript/pull/4513 |
| Reload | https://github.com/purescript/purescript/pull/4513 |
| Reload | https://github.com/purescript/purescript/pull/4513 |
| purescript | https://github.com/purescript |
| purescript | https://github.com/purescript/purescript |
| Code | https://github.com/purescript/purescript |
| Issues280 (280) | https://github.com/purescript/purescript/issues |
| Pull requests27 (27) | https://github.com/purescript/purescript/pulls |
| Actions | https://github.com/purescript/purescript/actions |
| Projects | https://github.com/purescript/purescript/projects |
| Wiki | https://github.com/purescript/purescript/wiki |
| Security and quality | https://github.com/purescript/purescript/security |
| Insights | https://github.com/purescript/purescript/insights |
| https://github.com/purescript/purescript |
| JordanMartinez | https://github.com/JordanMartinez |
| master | https://github.com/purescript/purescript/tree/master |
| jam/4487-4495-drop-unused | https://github.com/purescript/purescript/tree/jam/4487-4495-drop-unused |
| Conversation | https://github.com/purescript/purescript/pull/4513 |
| Commits48 (48) | https://github.com/purescript/purescript/pull/4513/commits |
| Checks | https://github.com/purescript/purescript/pull/4513/checks |
| Files changed | https://github.com/purescript/purescript/pull/4513/files |
| Drop UnusableDeclaration; update NoInstanceFound error | https://github.com/purescript/purescript/pull/4513#top |
| JordanMartinez | https://github.com/JordanMartinez |
| master | https://github.com/purescript/purescript/tree/master |
| jam/4487-4495-drop-unused | https://github.com/purescript/purescript/tree/jam/4487-4495-drop-unused |
|
| https://github.com/JordanMartinez |
| JordanMartinez | https://github.com/JordanMartinez |
| Oct 26, 2023 | https://github.com/purescript/purescript/pull/4513#issue-1964048123 |
| Please reload this page | https://github.com/purescript/purescript/pull/4513 |
| #4495 | https://github.com/purescript/purescript/issues/4495 |
| #4487 | https://github.com/purescript/purescript/issues/4487 |
| #4494 | https://github.com/purescript/purescript/pull/4494 |
| these problems are avoided | https://github.com/purescript/purescript/pull/4494#issuecomment-1668526160 |
| Please reload this page | https://github.com/purescript/purescript/pull/4513 |
| JordanMartinez | https://github.com/JordanMartinez |
| October 25, 2023 23:46 | https://github.com/purescript/purescript/pull/4513#commits-pushed-f715733 |
|
| https://github.com/JordanMartinez |
| Fix moveQuantifiersToFront | https://github.com/purescript/purescript/pull/4513/commits/f71573396e79e4fc235380f33be691eb20c96352 |
| f715733 | https://github.com/purescript/purescript/pull/4513/commits/f71573396e79e4fc235380f33be691eb20c96352 |
|
| https://github.com/JordanMartinez |
| Add sets of member type vars to solve via VTAs | https://github.com/purescript/purescript/pull/4513/commits/4a1cebd93ec8043a53b9adc66687d8576bc79995 |
| 4a1cebd | https://github.com/purescript/purescript/pull/4513/commits/4a1cebd93ec8043a53b9adc66687d8576bc79995 |
|
| https://github.com/JordanMartinez |
| Update NoInstanceFound to list vta-required args for members | https://github.com/purescript/purescript/pull/4513/commits/2da4b42a7df9c02821cb52e4c74e33dbd9aa7a37 |
| 2da4b42 | https://github.com/purescript/purescript/pull/4513/commits/2da4b42a7df9c02821cb52e4c74e33dbd9aa7a37 |
|
| https://github.com/JordanMartinez |
| Clarify that type vars are from type class | https://github.com/purescript/purescript/pull/4513/commits/3be03d0724b66dfbc3c5139411a1812109aa4084 |
| 3be03d0 | https://github.com/purescript/purescript/pull/4513/commits/3be03d0724b66dfbc3c5139411a1812109aa4084 |
|
| https://github.com/JordanMartinez |
| Add changelog entry | https://github.com/purescript/purescript/pull/4513/commits/bcac10040f6299f54ae6c53182af4902327d8f38 |
| bcac100 | https://github.com/purescript/purescript/pull/4513/commits/bcac10040f6299f54ae6c53182af4902327d8f38 |
|
| https://github.com/JordanMartinez |
| Rename UnknownFromVTAs constructor; update doc | https://github.com/purescript/purescript/pull/4513/commits/0c1eeb853dd81bc99da78143c8188f8d42372373 |
| 0c1eeb8 | https://github.com/purescript/purescript/pull/4513/commits/0c1eeb853dd81bc99da78143c8188f8d42372373 |
| https://github.com/JordanMartinez |
| JordanMartinez | https://github.com/JordanMartinez |
|
Oct 26, 2023
| https://github.com/purescript/purescript/pull/4513#pullrequestreview-1700190834 |
|
View reviewed changes
| https://github.com/purescript/purescript/pull/4513/files/0c1eeb853dd81bc99da78143c8188f8d42372373 |
| src/Language/PureScript/Sugar/TypeClasses.hs | https://github.com/purescript/purescript/pull/4513/files/0c1eeb853dd81bc99da78143c8188f8d42372373#diff-0edd663be1872372f2778c45797cc5c0c5d3ba5d9d467a48156b3725c7f4af4d |
| Please reload this page | https://github.com/purescript/purescript/pull/4513 |
|
| https://github.com/JordanMartinez |
| Drop redundant blank line | https://github.com/purescript/purescript/pull/4513/commits/9bd69b28eef26b952d016b4961976d80577e8167 |
| 9bd69b2 | https://github.com/purescript/purescript/pull/4513/commits/9bd69b28eef26b952d016b4961976d80577e8167 |
| https://github.com/JordanMartinez |
| JordanMartinez | https://github.com/JordanMartinez |
|
Oct 26, 2023
| https://github.com/purescript/purescript/pull/4513#pullrequestreview-1700198071 |
|
View reviewed changes
| https://github.com/purescript/purescript/pull/4513/files/0c1eeb853dd81bc99da78143c8188f8d42372373 |
| src/Language/PureScript/Environment.hs | https://github.com/purescript/purescript/pull/4513/files/0c1eeb853dd81bc99da78143c8188f8d42372373#diff-76f23f16b137c65cfb2e87445479ba6abf13660627ee96f83e96104350044009 |
| Please reload this page | https://github.com/purescript/purescript/pull/4513 |
| https://github.com/JordanMartinez |
| JordanMartinez | https://github.com/JordanMartinez |
|
Oct 26, 2023
| https://github.com/purescript/purescript/pull/4513#ref-pullrequest-1818769228 |
|
Drop UnusableDeclaration; update related errors
#4494
| https://github.com/purescript/purescript/pull/4494 |
| JordanMartinez | https://github.com/JordanMartinez |
| October 26, 2023 12:56 | https://github.com/purescript/purescript/pull/4513#commits-pushed-05af578 |
|
| https://github.com/JordanMartinez |
| Inline computeVtasNeededForMember | https://github.com/purescript/purescript/pull/4513/commits/05af578ad00d489917fc6fdf29863c380315703c |
| 05af578 | https://github.com/purescript/purescript/pull/4513/commits/05af578ad00d489917fc6fdf29863c380315703c |
|
| https://github.com/JordanMartinez |
| Add other missing tests from original PR | https://github.com/purescript/purescript/pull/4513/commits/ec1c48d75b661b636f1641ad71f57febe348c9a0 |
| ec1c48d | https://github.com/purescript/purescript/pull/4513/commits/ec1c48d75b661b636f1641ad71f57febe348c9a0 |
| https://github.com/JordanMartinez |
| JordanMartinez | https://github.com/JordanMartinez |
| Oct 26, 2023 | https://github.com/purescript/purescript/pull/4513#issuecomment-1781808244 |
| Please reload this page | https://github.com/purescript/purescript/pull/4513 |
| https://github.com/JordanMartinez |
| JordanMartinez | https://github.com/JordanMartinez |
| Oct 26, 2023 | https://github.com/purescript/purescript/pull/4513#issuecomment-1781851126 |
| Please reload this page | https://github.com/purescript/purescript/pull/4513 |
| JordanMartinez | https://github.com/JordanMartinez |
| October 27, 2023 05:17 | https://github.com/purescript/purescript/pull/4513#commits-pushed-6d3c52c |
|
| https://github.com/JordanMartinez |
| Delete .test-modules; regenerate outputs | https://github.com/purescript/purescript/pull/4513/commits/6d3c52cfea09fff2a51a2c0bf1729cff86724683 |
| 6d3c52c | https://github.com/purescript/purescript/pull/4513/commits/6d3c52cfea09fff2a51a2c0bf1729cff86724683 |
|
| https://github.com/JordanMartinez |
| Prevent any crashes by dropping unsafe Maybe usage | https://github.com/purescript/purescript/pull/4513/commits/6f9803c518d922ad50d0454814b10f0874916961 |
| 6f9803c | https://github.com/purescript/purescript/pull/4513/commits/6f9803c518d922ad50d0454814b10f0874916961 |
|
| https://github.com/JordanMartinez |
| Cleanup code | https://github.com/purescript/purescript/pull/4513/commits/5876f764075f5553298faa35258e63bec9c8eb09 |
| 5876f76 | https://github.com/purescript/purescript/pull/4513/commits/5876f764075f5553298faa35258e63bec9c8eb09 |
|
| https://github.com/JordanMartinez |
| Break cycle in mod deps | https://github.com/purescript/purescript/pull/4513/commits/0e31db2a957341187321bb5edb32aecdf9cd1189 |
| 0e31db2 | https://github.com/purescript/purescript/pull/4513/commits/0e31db2a957341187321bb5edb32aecdf9cd1189 |
|
| https://github.com/JordanMartinez |
| Compute vta-requiring members in desugar too | https://github.com/purescript/purescript/pull/4513/commits/c4c6bfe9e54b86cc162032986b028428167d569f |
| c4c6bfe | https://github.com/purescript/purescript/pull/4513/commits/c4c6bfe9e54b86cc162032986b028428167d569f |
|
| https://github.com/JordanMartinez |
| Encapsulate more correctness in mkTypeClassData variant | https://github.com/purescript/purescript/pull/4513/commits/149b26062917265c4c8ad56a042aa08ba9ae514a |
| 149b260 | https://github.com/purescript/purescript/pull/4513/commits/149b26062917265c4c8ad56a042aa08ba9ae514a |
| https://github.com/JordanMartinez |
| JordanMartinez | https://github.com/JordanMartinez |
| Oct 27, 2023 | https://github.com/purescript/purescript/pull/4513#issuecomment-1782776187 |
| Please reload this page | https://github.com/purescript/purescript/pull/4513 |
|
| https://github.com/JordanMartinez |
| Drop unused import | https://github.com/purescript/purescript/pull/4513/commits/d5851ea1db08f641a3b5d853d22357c45d1ea822 |
| d5851ea | https://github.com/purescript/purescript/pull/4513/commits/d5851ea1db08f641a3b5d853d22357c45d1ea822 |
| https://github.com/JordanMartinez |
| JordanMartinez | https://github.com/JordanMartinez |
| Oct 27, 2023 | https://github.com/purescript/purescript/pull/4513#issuecomment-1782826341 |
| Please reload this page | https://github.com/purescript/purescript/pull/4513 |
| this thread | https://github.com/purescript/purescript/pull/4513#discussion_r1373526940 |
| a type class whose member's type signature uses a type synonym | https://github.com/purescript/purescript-st/blob/v6.2.0/src/Control/Monad/ST/Class.purs#L10-L11 |
| Please reload this page | https://github.com/purescript/purescript/pull/4513 |
| JordanMartinez | https://github.com/JordanMartinez |
| October 27, 2023 07:24 | https://github.com/purescript/purescript/pull/4513#commits-pushed-a59c21f |
|
| https://github.com/JordanMartinez |
| Revert "Drop unused import" | https://github.com/purescript/purescript/pull/4513/commits/a59c21f1c7d69abf5044edfd8e35af2ea7dc1355 |
| a59c21f | https://github.com/purescript/purescript/pull/4513/commits/a59c21f1c7d69abf5044edfd8e35af2ea7dc1355 |
| d5851ea | https://github.com/purescript/purescript/commit/d5851ea1db08f641a3b5d853d22357c45d1ea822 |
|
| https://github.com/JordanMartinez |
| Revert "Encapsulate more correctness in mkTypeClassData variant" | https://github.com/purescript/purescript/pull/4513/commits/4e54057a09d1a7f292b15d69005272ae0b22af9c |
| 4e54057 | https://github.com/purescript/purescript/pull/4513/commits/4e54057a09d1a7f292b15d69005272ae0b22af9c |
| 149b260 | https://github.com/purescript/purescript/commit/149b26062917265c4c8ad56a042aa08ba9ae514a |
|
| https://github.com/JordanMartinez |
| Revert "Compute vta-requiring members in desugar too" | https://github.com/purescript/purescript/pull/4513/commits/c35cda9126eee2a28cd516b8d9399591526a8778 |
| c35cda9 | https://github.com/purescript/purescript/pull/4513/commits/c35cda9126eee2a28cd516b8d9399591526a8778 |
| c4c6bfe | https://github.com/purescript/purescript/commit/c4c6bfe9e54b86cc162032986b028428167d569f |
|
| https://github.com/JordanMartinez |
| Revert "Break cycle in mod deps" | https://github.com/purescript/purescript/pull/4513/commits/1f1d1dde9e1ce1e7794f9443564a6fb322559f29 |
| 1f1d1dd | https://github.com/purescript/purescript/pull/4513/commits/1f1d1dde9e1ce1e7794f9443564a6fb322559f29 |
| 0e31db2 | https://github.com/purescript/purescript/commit/0e31db2a957341187321bb5edb32aecdf9cd1189 |
|
| https://github.com/JordanMartinez |
| Update changelog to account for type synonym issue | https://github.com/purescript/purescript/pull/4513/commits/85d3c6bd0e12614bd4fa08ce4bdf9a67d6e97583 |
| 85d3c6b | https://github.com/purescript/purescript/pull/4513/commits/85d3c6bd0e12614bd4fa08ce4bdf9a67d6e97583 |
| https://github.com/JordanMartinez |
| JordanMartinez | https://github.com/JordanMartinez |
| Oct 27, 2023 | https://github.com/purescript/purescript/pull/4513#issuecomment-1782834317 |
| Please reload this page | https://github.com/purescript/purescript/pull/4513 |
|
| https://github.com/JordanMartinez |
| Have at least 2 instances in test | https://github.com/purescript/purescript/pull/4513/commits/8865d953f6ae198aba2f73b38fbf92b39e438a47 |
| 8865d95 | https://github.com/purescript/purescript/pull/4513/commits/8865d953f6ae198aba2f73b38fbf92b39e438a47 |
| JordanMartinez | https://github.com/JordanMartinez |
| October 27, 2023 12:04 | https://github.com/purescript/purescript/pull/4513#commits-pushed-33c6cd9 |
|
| https://github.com/JordanMartinez |
| Regenerate golden outputs | https://github.com/purescript/purescript/pull/4513/commits/33c6cd994777f22c2c322fce359a444f9aa97f5c |
| 33c6cd9 | https://github.com/purescript/purescript/pull/4513/commits/33c6cd994777f22c2c322fce359a444f9aa97f5c |
|
| https://github.com/JordanMartinez |
| Drop replaceTypeSyn; mv code to Environment | https://github.com/purescript/purescript/pull/4513/commits/96cf0bc5bed58fe259ffbd82036215686407e4a5 |
| 96cf0bc | https://github.com/purescript/purescript/pull/4513/commits/96cf0bc5bed58fe259ffbd82036215686407e4a5 |
|
| https://github.com/JordanMartinez |
| Reduce diff | https://github.com/purescript/purescript/pull/4513/commits/dd28d21086c81103c183f5b2b2155bc54923425c |
| dd28d21 | https://github.com/purescript/purescript/pull/4513/commits/dd28d21086c81103c183f5b2b2155bc54923425c |
|
| https://github.com/JordanMartinez |
| Fix whitespace | https://github.com/purescript/purescript/pull/4513/commits/d458b1d3f7ae973d92122cde75d2723067d02e4a |
| d458b1d | https://github.com/purescript/purescript/pull/4513/commits/d458b1d3f7ae973d92122cde75d2723067d02e4a |
| https://github.com/JordanMartinez |
| JordanMartinez | https://github.com/JordanMartinez |
| Oct 27, 2023 | https://github.com/purescript/purescript/pull/4513#issuecomment-1783396652 |
| @rhendric | https://github.com/rhendric |
| Please reload this page | https://github.com/purescript/purescript/pull/4513 |
| https://github.com/JordanMartinez |
| JordanMartinez | https://github.com/JordanMartinez |
|
Oct 27, 2023
| https://github.com/purescript/purescript/pull/4513#pullrequestreview-1702445458 |
|
View reviewed changes
| https://github.com/purescript/purescript/pull/4513/files/d458b1d3f7ae973d92122cde75d2723067d02e4a |
| tests/purs/failing/ClassHeadNoVTA6.out | https://github.com/purescript/purescript/pull/4513/files/d458b1d3f7ae973d92122cde75d2723067d02e4a#diff-b85449de279338f15b6d2a5f98b9b11ddb03762d3ffc64860e7944f183808a80 |
| Please reload this page | https://github.com/purescript/purescript/pull/4513 |
| JordanMartinez | https://github.com/JordanMartinez |
| October 27, 2023 15:12 | https://github.com/purescript/purescript/pull/4513#commits-pushed-a10f521 |
|
| https://github.com/JordanMartinez |
| Fix weeder lint: drop replaceAllTypeSynonymsM | https://github.com/purescript/purescript/pull/4513/commits/a10f521004bd08f86ecb29dbf740fcc12891026c |
| a10f521 | https://github.com/purescript/purescript/pull/4513/commits/a10f521004bd08f86ecb29dbf740fcc12891026c |
|
| https://github.com/JordanMartinez |
| Update cl entry for ty var set example | https://github.com/purescript/purescript/pull/4513/commits/c200a58ea3dac6a4cc9de4d4985a0ff8752bc29f |
| c200a58 | https://github.com/purescript/purescript/pull/4513/commits/c200a58ea3dac6a4cc9de4d4985a0ff8752bc29f |
| https://github.com/rhendric |
| rhendric | https://github.com/rhendric |
|
Oct 30, 2023
| https://github.com/purescript/purescript/pull/4513#pullrequestreview-1705163696 |
|
View reviewed changes
| https://github.com/purescript/purescript/pull/4513/files/c200a58ea3dac6a4cc9de4d4985a0ff8752bc29f |
| rhendric | https://github.com/rhendric |
| https://github.com/purescript/purescript/pull/4513#pullrequestreview-1705163696 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/purescript/purescript/pull/4513 |
| src/Language/PureScript/Environment.hs | https://github.com/purescript/purescript/pull/4513/files/c200a58ea3dac6a4cc9de4d4985a0ff8752bc29f#diff-76f23f16b137c65cfb2e87445479ba6abf13660627ee96f83e96104350044009 |
| Please reload this page | https://github.com/purescript/purescript/pull/4513 |
| src/Language/PureScript/TypeChecker/Entailment.hs | https://github.com/purescript/purescript/pull/4513/files/c200a58ea3dac6a4cc9de4d4985a0ff8752bc29f#diff-882f8f8c804b84dfa001aea5a0b9a9d979eb1e99ca4b7d844f790a5bca328e43 |
| Please reload this page | https://github.com/purescript/purescript/pull/4513 |
| src/Language/PureScript/Types.hs | https://github.com/purescript/purescript/pull/4513/files/8865d953f6ae198aba2f73b38fbf92b39e438a47#diff-c729de5c413c46568211a59754eaded85a656aa9d7b4bddeb0fbf27ce7aab534 |
| Please reload this page | https://github.com/purescript/purescript/pull/4513 |
| src/Language/PureScript/Types.hs | https://github.com/purescript/purescript/pull/4513/files/c200a58ea3dac6a4cc9de4d4985a0ff8752bc29f#diff-c729de5c413c46568211a59754eaded85a656aa9d7b4bddeb0fbf27ce7aab534 |
| Please reload this page | https://github.com/purescript/purescript/pull/4513 |
| src/Language/PureScript/Types.hs | https://github.com/purescript/purescript/pull/4513/files/c200a58ea3dac6a4cc9de4d4985a0ff8752bc29f#diff-c729de5c413c46568211a59754eaded85a656aa9d7b4bddeb0fbf27ce7aab534 |
| Please reload this page | https://github.com/purescript/purescript/pull/4513 |
| src/Language/PureScript/Types.hs | https://github.com/purescript/purescript/pull/4513/files/c200a58ea3dac6a4cc9de4d4985a0ff8752bc29f#diff-c729de5c413c46568211a59754eaded85a656aa9d7b4bddeb0fbf27ce7aab534 |
| Please reload this page | https://github.com/purescript/purescript/pull/4513 |
| JordanMartinez | https://github.com/JordanMartinez |
| October 31, 2023 05:41 | https://github.com/purescript/purescript/pull/4513#commits-pushed-b96802d |
|
| https://github.com/JordanMartinez |
| Typo | https://github.com/purescript/purescript/pull/4513/commits/b96802d97f0b3e13eaaf361937e0af4de0a65fc7 |
| b96802d | https://github.com/purescript/purescript/pull/4513/commits/b96802d97f0b3e13eaaf361937e0af4de0a65fc7 |
|
| https://github.com/JordanMartinez |
| Use freeTypeVariables | https://github.com/purescript/purescript/pull/4513/commits/a92e35c512c6936f77dea3abcaeb67a6d123feff |
| a92e35c | https://github.com/purescript/purescript/pull/4513/commits/a92e35c512c6936f77dea3abcaeb67a6d123feff |
|
| https://github.com/JordanMartinez |
| Include 'ty' in genPureName | https://github.com/purescript/purescript/pull/4513/commits/e9a09b0ba15bc7e2502d41413446eaec399d42b9 |
| e9a09b0 | https://github.com/purescript/purescript/pull/4513/commits/e9a09b0ba15bc7e2502d41413446eaec399d42b9 |
|
| https://github.com/JordanMartinez |
| Drop renameTypeVars; provide default ann | https://github.com/purescript/purescript/pull/4513/commits/ea149f65afe7fdbbdc29a584c58a897c91dc804d |
| ea149f6 | https://github.com/purescript/purescript/pull/4513/commits/ea149f65afe7fdbbdc29a584c58a897c91dc804d |
|
| https://github.com/JordanMartinez |
| Just use Maybe (Set (NonEmpty Text)) | https://github.com/purescript/purescript/pull/4513/commits/638b9be12a51d1d6cd642e2c9d3b803dc7355df2 |
| 638b9be | https://github.com/purescript/purescript/pull/4513/commits/638b9be12a51d1d6cd642e2c9d3b803dc7355df2 |
|
| https://github.com/JordanMartinez |
| Preserve ty arg order | https://github.com/purescript/purescript/pull/4513/commits/d3ea219e7bbb4aa70c964880c08f3e42aa691a36 |
| d3ea219 | https://github.com/purescript/purescript/pull/4513/commits/d3ea219e7bbb4aa70c964880c08f3e42aa691a36 |
|
| https://github.com/JordanMartinez |
| Fix comment | https://github.com/purescript/purescript/pull/4513/commits/151a7a958c556053f134754f1dca86612cbf2387 |
| 151a7a9 | https://github.com/purescript/purescript/pull/4513/commits/151a7a958c556053f134754f1dca86612cbf2387 |
|
| https://github.com/JordanMartinez |
| Update outputs due to previous change | https://github.com/purescript/purescript/pull/4513/commits/c11e950090cdc1c1003f9015b979307aa1d65295 |
| c11e950 | https://github.com/purescript/purescript/pull/4513/commits/c11e950090cdc1c1003f9015b979307aa1d65295 |
| https://github.com/rhendric |
| rhendric | https://github.com/rhendric |
|
Nov 1, 2023
| https://github.com/purescript/purescript/pull/4513#pullrequestreview-1708769503 |
|
View reviewed changes
| https://github.com/purescript/purescript/pull/4513/files/c11e950090cdc1c1003f9015b979307aa1d65295 |
| src/Language/PureScript/Errors.hs | https://github.com/purescript/purescript/pull/4513/files/c11e950090cdc1c1003f9015b979307aa1d65295#diff-11e3ee9ff014e25b38a3dfdaa1fa18c8d0ca9dab1860d355abad0034978ea04c |
| Please reload this page | https://github.com/purescript/purescript/pull/4513 |
| src/Language/PureScript/TypeChecker/Entailment.hs | https://github.com/purescript/purescript/pull/4513/files/c11e950090cdc1c1003f9015b979307aa1d65295#diff-882f8f8c804b84dfa001aea5a0b9a9d979eb1e99ca4b7d844f790a5bca328e43 |
| Please reload this page | https://github.com/purescript/purescript/pull/4513 |
| src/Language/PureScript/AST/Declarations.hs | https://github.com/purescript/purescript/pull/4513/files/c11e950090cdc1c1003f9015b979307aa1d65295#diff-9267ab8dd06eb9d5cfbe1ee1a10256c079bf14ad50bf89d1fc26460c639bbad8 |
| Please reload this page | https://github.com/purescript/purescript/pull/4513 |
| src/Language/PureScript/Environment.hs | https://github.com/purescript/purescript/pull/4513/files/c11e950090cdc1c1003f9015b979307aa1d65295#diff-76f23f16b137c65cfb2e87445479ba6abf13660627ee96f83e96104350044009 |
| Please reload this page | https://github.com/purescript/purescript/pull/4513 |
| JordanMartinez | https://github.com/JordanMartinez |
| November 1, 2023 18:09 | https://github.com/purescript/purescript/pull/4513#commits-pushed-d74d9e7 |
|
| https://github.com/JordanMartinez |
| Fix vta info; split VTA6 into smaller tests | https://github.com/purescript/purescript/pull/4513/commits/d74d9e7d957c98425e72f0768e19eb61cce75824 |
| d74d9e7 | https://github.com/purescript/purescript/pull/4513/commits/d74d9e7d957c98425e72f0768e19eb61cce75824 |
|
| https://github.com/JordanMartinez |
| Add multicovering set example to passing tests | https://github.com/purescript/purescript/pull/4513/commits/6f89c749b3fdd4c4c8521523ccbe0f881fb55f4a |
| 6f89c74 | https://github.com/purescript/purescript/pull/4513/commits/6f89c749b3fdd4c4c8521523ccbe0f881fb55f4a |
|
| https://github.com/JordanMartinez |
| Wording suggestions; <&> | https://github.com/purescript/purescript/pull/4513/commits/434269989f66af33e4f900c25f20dee9df4366a0 |
| 4342699 | https://github.com/purescript/purescript/pull/4513/commits/434269989f66af33e4f900c25f20dee9df4366a0 |
| https://github.com/rhendric |
| rhendric | https://github.com/rhendric |
|
Nov 3, 2023
| https://github.com/purescript/purescript/pull/4513#pullrequestreview-1711802552 |
|
View reviewed changes
| https://github.com/purescript/purescript/pull/4513/files/434269989f66af33e4f900c25f20dee9df4366a0 |
| rhendric | https://github.com/rhendric |
| https://github.com/purescript/purescript/pull/4513#pullrequestreview-1711802552 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/purescript/purescript/pull/4513 |
| src/Language/PureScript/Environment.hs | https://github.com/purescript/purescript/pull/4513/files/c11e950090cdc1c1003f9015b979307aa1d65295#diff-76f23f16b137c65cfb2e87445479ba6abf13660627ee96f83e96104350044009 |
| Please reload this page | https://github.com/purescript/purescript/pull/4513 |
| CHANGELOG.d/feature_replace-unused-declarations.md | https://github.com/purescript/purescript/pull/4513/files/c11e950090cdc1c1003f9015b979307aa1d65295#diff-174d402105a962dfa46cc9650d85d0a9813ce51797a6efebb0cfb4547eddee36 |
| Please reload this page | https://github.com/purescript/purescript/pull/4513 |
| CHANGELOG.d/feature_replace-unused-declarations.md | https://github.com/purescript/purescript/pull/4513/files/c11e950090cdc1c1003f9015b979307aa1d65295#diff-174d402105a962dfa46cc9650d85d0a9813ce51797a6efebb0cfb4547eddee36 |
| Please reload this page | https://github.com/purescript/purescript/pull/4513 |
| CHANGELOG.d/feature_replace-unused-declarations.md | https://github.com/purescript/purescript/pull/4513/files/c11e950090cdc1c1003f9015b979307aa1d65295#diff-174d402105a962dfa46cc9650d85d0a9813ce51797a6efebb0cfb4547eddee36 |
| Please reload this page | https://github.com/purescript/purescript/pull/4513 |
| JordanMartinez | https://github.com/JordanMartinez |
| November 3, 2023 01:03 | https://github.com/purescript/purescript/pull/4513#commits-pushed-c3ea072 |
|
| https://github.com/JordanMartinez |
| Add another test | https://github.com/purescript/purescript/pull/4513/commits/c3ea07292edbf07d26a3128a0377c246ac548a0d |
| c3ea072 | https://github.com/purescript/purescript/pull/4513/commits/c3ea07292edbf07d26a3128a0377c246ac548a0d |
|
| https://github.com/JordanMartinez |
|
| https://github.com/rhendric |
| Apply Ryan's edits | https://github.com/purescript/purescript/pull/4513/commits/0f6c128474161a4b71e9d818c955aabc40201e04 |
| 0f6c128 | https://github.com/purescript/purescript/pull/4513/commits/0f6c128474161a4b71e9d818c955aabc40201e04 |
|
| https://github.com/JordanMartinez |
| Drop type synonym exception | https://github.com/purescript/purescript/pull/4513/commits/1caee6d3b499041629fe3f22cc57681077020b30 |
| 1caee6d | https://github.com/purescript/purescript/pull/4513/commits/1caee6d3b499041629fe3f22cc57681077020b30 |
| https://github.com/rhendric |
| rhendric | https://github.com/rhendric |
|
Nov 3, 2023
| https://github.com/purescript/purescript/pull/4513#pullrequestreview-1711924218 |
|
View reviewed changes
| https://github.com/purescript/purescript/pull/4513/files/1caee6d3b499041629fe3f22cc57681077020b30 |
| https://github.com/JordanMartinez |
| JordanMartinez | https://github.com/JordanMartinez |
| Nov 3, 2023 | https://github.com/purescript/purescript/pull/4513#issuecomment-1792534434 |
| Please reload this page | https://github.com/purescript/purescript/pull/4513 |
|
| https://github.com/JordanMartinez |
| Add changelog entry for moveQuantifiersToFront | https://github.com/purescript/purescript/pull/4513/commits/ea09a4e1e6158891b2defee7f93852c6785a79bb |
| ea09a4e | https://github.com/purescript/purescript/pull/4513/commits/ea09a4e1e6158891b2defee7f93852c6785a79bb |
| https://github.com/JordanMartinez |
| JordanMartinez | https://github.com/JordanMartinez |
| 4f4672d | https://github.com/purescript/purescript/commit/4f4672d26d024ee4eb855eccd93dc48e6f5eb036 |
| Nov 3, 2023 | https://github.com/purescript/purescript/pull/4513#event-10858022669 |
| https://github.com/JordanMartinez |
| JordanMartinez | https://github.com/JordanMartinez |
| November 3, 2023 16:03 | https://github.com/purescript/purescript/pull/4513#event-10858022848 |
| https://github.co/hiddenchars |
| https://github.com/purescript/purescript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript%2Fpurescript%2Fpull%2F4513 |
|
| https://github.com/rhendric |
|
rhendric
| https://github.com/rhendric |
|
| https://github.com/purescript/purescript/pull/4513/files/1caee6d3b499041629fe3f22cc57681077020b30 |
| Please reload this page | https://github.com/purescript/purescript/pull/4513 |
|
Is moveQuantifiersToFront still needed?
| https://github.com/purescript/purescript/issues/4495 |
|
0.15.10 doesn't allow class methods without class type variables in signature
| https://github.com/purescript/purescript/issues/4487 |
| Please reload this page | https://github.com/purescript/purescript/pull/4513 |
|
| https://github.com/JordanMartinez |
|
| https://github.com/rhendric |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |