| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:ea7463cd-73dc-49a6-6537-6f0b24a1bae6 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BF9C:785A9:72049D:9272C8:6B00E361 |
| html-safe-nonce | 41a1e84d726ee24b7b86f312c4c4580faf0904cbc83572366e262c35ecbac7e1 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRjlDOjc4NUE5OjcyMDQ5RDo5MjcyQzg6NkIwMEUzNjEiLCJ2aXNpdG9yX2lkIjoiNzQzNDE4MTU5MzM0Mzc3OTY4MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 1ee9b326fb12b8633074263918822848ef3e7da85341ada0781e4f096238dcd7 |
| hovercard-subject-tag | pull_request:691578219 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/purescript/purescript/4157/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/c80f9bcd433e7077843e16dee3418171588b4742e860361bbca246fdb44601d8/purescript/purescript/pull/4157 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c80f9bcd433e7077843e16dee3418171588b4742e860361bbca246fdb44601d8/purescript/purescript/pull/4157 |
| og:image:alt | Description of the change
As Jordan noticed in #4121 (comment) we incorrectly infer the arity of foreign data types whose kind contains parens (and type synonyms) while checking their role declarat... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | kl0tl |
| hostname | github.com |
| expected-hostname | github.com |
| None | 27088b6977484d0d3321d9a11c907c6d6637b315cfa359ef7952dbf6292f9b14 |
| turbo-cache-control | no-cache |
| go-import | github.com/purescript/purescript git https://github.com/purescript/purescript.git |
| octolytics-dimension-user_id | 6556677 |
| octolytics-dimension-user_login | purescript |
| octolytics-dimension-repository_id | 13206906 |
| octolytics-dimension-repository_nwo | purescript/purescript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 13206906 |
| octolytics-dimension-repository_network_root_nwo | purescript/purescript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 624179fb8b88d26ba5bba08894eb60a1c5a1d93d |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/purescript/purescript/pull/4157#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript%2Fpurescript%2Fpull%2F4157 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript%2Fpurescript%2Fpull%2F4157 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=purescript%2Fpurescript |
| Reload | https://github.com/purescript/purescript/pull/4157 |
| Reload | https://github.com/purescript/purescript/pull/4157 |
| Reload | https://github.com/purescript/purescript/pull/4157 |
| purescript | https://github.com/purescript |
| purescript | https://github.com/purescript/purescript |
| Code | https://github.com/purescript/purescript |
| Issues280 (280) | https://github.com/purescript/purescript/issues |
| Pull requests28 (28) | https://github.com/purescript/purescript/pulls |
| Actions | https://github.com/purescript/purescript/actions |
| Projects | https://github.com/purescript/purescript/projects |
| Wiki | https://github.com/purescript/purescript/wiki |
| Security and quality | https://github.com/purescript/purescript/security |
| Insights | https://github.com/purescript/purescript/insights |
| https://github.com/purescript/purescript |
| JordanMartinez | https://github.com/JordanMartinez |
| purescript:master | https://github.com/purescript/purescript/tree/master |
| kl0tl:check-role-declarations-arity-during-typechecking | https://github.com/kl0tl/purescript/tree/check-role-declarations-arity-during-typechecking |
| Conversation | https://github.com/purescript/purescript/pull/4157 |
| Commits5 (5) | https://github.com/purescript/purescript/pull/4157/commits |
| Checks | https://github.com/purescript/purescript/pull/4157/checks |
| Files changed | https://github.com/purescript/purescript/pull/4157/files |
| Check role declarations arity during type checking | https://github.com/purescript/purescript/pull/4157#top |
| JordanMartinez | https://github.com/JordanMartinez |
| purescript:master | https://github.com/purescript/purescript/tree/master |
| kl0tl:check-role-declarations-arity-during-typechecking | https://github.com/kl0tl/purescript/tree/check-role-declarations-arity-during-typechecking |
|
| https://github.com/kl0tl |
| kl0tl | https://github.com/kl0tl |
| Jul 16, 2021 | https://github.com/purescript/purescript/pull/4157#issue-946398327 |
| Please reload this page | https://github.com/purescript/purescript/pull/4157 |
| #4121 (comment) | https://github.com/purescript/purescript/pull/4121#discussion_r667256491 |
| Please reload this page | https://github.com/purescript/purescript/pull/4157 |
| kl0tl | https://github.com/kl0tl |
| July 16, 2021 17:30 | https://github.com/purescript/purescript/pull/4157#commits-pushed-aea0da5 |
|
| https://github.com/kl0tl |
| Check role declarations arity during type checking | https://github.com/purescript/purescript/pull/4157/commits/aea0da5fc6dea892c67ccacd398cc40885218e77 |
| aea0da5 | https://github.com/purescript/purescript/pull/4157/commits/aea0da5fc6dea892c67ccacd398cc40885218e77 |
|
| https://github.com/kl0tl |
| Add changelog entry | https://github.com/purescript/purescript/pull/4157/commits/232c63c6d3a5b50b407f5f29871a40396a281a7e |
| 232c63c | https://github.com/purescript/purescript/pull/4157/commits/232c63c6d3a5b50b407f5f29871a40396a281a7e |
| https://github.com/kl0tl |
| kl0tl | https://github.com/kl0tl |
|
Jul 16, 2021
| https://github.com/purescript/purescript/pull/4157#ref-pullrequest-930713959 |
|
Display roles in HTML docs
#4121
| https://github.com/purescript/purescript/pull/4121 |
| https://github.com/rhendric |
| rhendric | https://github.com/rhendric |
| Jul 16, 2021 | https://github.com/purescript/purescript/pull/4157#issuecomment-881574023 |
| Please reload this page | https://github.com/purescript/purescript/pull/4157 |
|
| https://github.com/kl0tl |
| fixup! Check role declarations arity during type checking | https://github.com/purescript/purescript/pull/4157/commits/c66ae6d10fecca0ace46cd1eb136cb2e37559822 |
| c66ae6d | https://github.com/purescript/purescript/pull/4157/commits/c66ae6d10fecca0ace46cd1eb136cb2e37559822 |
| https://github.com/kl0tl |
| kl0tl | https://github.com/kl0tl |
| force-pushed | https://github.com/purescript/purescript/compare/3d2134d728e8724d00d4dc7ff836e20e138b2d25..c66ae6d10fecca0ace46cd1eb136cb2e37559822 |
| 3d2134d | https://github.com/purescript/purescript/commit/3d2134d728e8724d00d4dc7ff836e20e138b2d25 |
| c66ae6d | https://github.com/purescript/purescript/commit/c66ae6d10fecca0ace46cd1eb136cb2e37559822 |
|
Compare
| https://github.com/purescript/purescript/compare/3d2134d728e8724d00d4dc7ff836e20e138b2d25..c66ae6d10fecca0ace46cd1eb136cb2e37559822 |
| July 16, 2021 23:56 | https://github.com/purescript/purescript/pull/4157#event-5033213981 |
| https://github.com/kl0tl |
| kl0tl | https://github.com/kl0tl |
|
Jul 16, 2021
| https://github.com/purescript/purescript/pull/4157#pullrequestreview-708804746 |
|
View reviewed changes
| https://github.com/purescript/purescript/pull/4157/files/c66ae6d10fecca0ace46cd1eb136cb2e37559822 |
| tests/purs/failing/CoercibleRoleMismatch1.out | https://github.com/purescript/purescript/pull/4157/files/c66ae6d10fecca0ace46cd1eb136cb2e37559822#diff-ba8180994d237116bc772b4e39a6e31fc4c9f5ca66e3ce14602d4614acd23c6c |
| kl0tl | https://github.com/kl0tl |
| Jul 16, 2021 | https://github.com/purescript/purescript/pull/4157#discussion_r671574963 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/purescript/purescript/pull/4157 |
| rhendric | https://github.com/rhendric |
| Jul 17, 2021 | https://github.com/purescript/purescript/pull/4157#discussion_r671604805 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/purescript/purescript/pull/4157 |
| kl0tl | https://github.com/kl0tl |
| Jul 17, 2021 | https://github.com/purescript/purescript/pull/4157#discussion_r671698466 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/purescript/purescript/pull/4157 |
| https://github.com/kl0tl |
| kl0tl | https://github.com/kl0tl |
| Jul 16, 2021 | https://github.com/purescript/purescript/pull/4157#issuecomment-881777042 |
| Please reload this page | https://github.com/purescript/purescript/pull/4157 |
|
| https://github.com/kl0tl |
| Eliminate redundant declaration hints from error messages | https://github.com/purescript/purescript/pull/4157/commits/23e667b2744ce48ab31719ca07acc3dcf8dfe983 |
| 23e667b | https://github.com/purescript/purescript/pull/4157/commits/23e667b2744ce48ab31719ca07acc3dcf8dfe983 |
|
Add a hint for errors in foreign data type declarations
#4161
| https://github.com/purescript/purescript/pull/4161 |
|
Add golden tests for self cycles in type class declarations, kind declarations and foreign data type declarations
#4162
| https://github.com/purescript/purescript/pull/4162 |
| https://github.com/JordanMartinez |
| JordanMartinez | https://github.com/JordanMartinez |
| Jul 21, 2021 | https://github.com/purescript/purescript/pull/4157#issuecomment-884179132 |
| Please reload this page | https://github.com/purescript/purescript/pull/4157 |
|
| https://github.com/kl0tl |
| Merge remote-tracking branch 'upstream/master' into check-role-declar… | https://github.com/purescript/purescript/pull/4157/commits/146b795fb9084994bd12b971dd559b2a1e0911f4 |
| 146b795 | https://github.com/purescript/purescript/pull/4157/commits/146b795fb9084994bd12b971dd559b2a1e0911f4 |
| https://github.com/JordanMartinez |
| JordanMartinez | https://github.com/JordanMartinez |
| Jul 23, 2021 | https://github.com/purescript/purescript/pull/4157#issuecomment-885809387 |
| Please reload this page | https://github.com/purescript/purescript/pull/4157 |
| https://github.com/JordanMartinez |
| JordanMartinez | https://github.com/JordanMartinez |
|
Nov 13, 2021
| https://github.com/purescript/purescript/pull/4157#pullrequestreview-805391753 |
|
View reviewed changes
| https://github.com/purescript/purescript/pull/4157/files/146b795fb9084994bd12b971dd559b2a1e0911f4 |
| JordanMartinez | https://github.com/JordanMartinez |
| https://github.com/purescript/purescript/pull/4157#pullrequestreview-805391753 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/purescript/purescript/pull/4157 |
| src/Language/PureScript/TypeChecker/Roles.hs | https://github.com/purescript/purescript/pull/4157/files/146b795fb9084994bd12b971dd559b2a1e0911f4#diff-b557ad206132a701a62ca86da4171980163d61448725bab6a618cbfc4effd647 |
| JordanMartinez | https://github.com/JordanMartinez |
| Nov 13, 2021 | https://github.com/purescript/purescript/pull/4157#discussion_r748750539 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| CoercibleRoleMismatch1.purs | https://github.com/purescript/purescript/blob/146b795fb9084994bd12b971dd559b2a1e0911f4/tests/purs/failing/CoercibleRoleMismatch1.purs |
| CoercibleRoleMismatch1.out | https://github.com/purescript/purescript/pull/4157/files?w=0#diff-ba8180994d237116bc772b4e39a6e31fc4c9f5ca66e3ce14602d4614acd23c6cR3 |
| Please reload this page | https://github.com/purescript/purescript/pull/4157 |
| JordanMartinez | https://github.com/JordanMartinez |
| Nov 16, 2021 | https://github.com/purescript/purescript/pull/4157#discussion_r749934050 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/purescript/purescript/pull/4157 |
| https://github.com/JordanMartinez |
| JordanMartinez | https://github.com/JordanMartinez |
|
Nov 16, 2021
| https://github.com/purescript/purescript/pull/4157#pullrequestreview-806853701 |
|
View reviewed changes
| https://github.com/purescript/purescript/pull/4157/files/146b795fb9084994bd12b971dd559b2a1e0911f4 |
| https://github.com/JordanMartinez |
| JordanMartinez | https://github.com/JordanMartinez |
| 375bcdc | https://github.com/purescript/purescript/commit/375bcdce4fc3d98bbac44dc63292ef86e9b3ecbc |
| Nov 16, 2021 | https://github.com/purescript/purescript/pull/4157#event-5622599860 |
| https://github.co/hiddenchars |
| https://github.com/purescript/purescript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript%2Fpurescript%2Fpull%2F4157 |
|
| https://github.com/rhendric |
|
rhendric
| https://github.com/rhendric |
|
| https://github.com/purescript/purescript/pull/4157/files/c66ae6d10fecca0ace46cd1eb136cb2e37559822 |
|
| https://github.com/JordanMartinez |
|
JordanMartinez
| https://github.com/JordanMartinez |
|
| https://github.com/purescript/purescript/pull/4157/files/146b795fb9084994bd12b971dd559b2a1e0911f4 |
| Please reload this page | https://github.com/purescript/purescript/pull/4157 |
| Please reload this page | https://github.com/purescript/purescript/pull/4157 |
|
| https://github.com/kl0tl |
|
| https://github.com/rhendric |
|
| https://github.com/JordanMartinez |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |