René's URL Explorer Experiment


Title: Fix incomplete type traversals by rhendric · Pull Request #4155 · purescript/purescript · GitHub

Open Graph Title: Fix incomplete type traversals by rhendric · Pull Request #4155 · purescript/purescript

X Title: Fix incomplete type traversals by rhendric · Pull Request #4155 · purescript/purescript

Description: A strongly-typed language that compiles to JavaScript - Fix incomplete type traversals by rhendric · Pull Request #4155 · purescript/purescript

Open Graph Description: Description of the change Our type traversals were ignoring the optional kind in Skolem types; assuming that wasn't intentional, this fixes it. It also fixes a double application of the travers...

X Description: Description of the change Our type traversals were ignoring the optional kind in Skolem types; assuming that wasn't intentional, this fixes it. It also fixes a double application of the tra...

Opengraph URL: https://github.com/purescript/purescript/pull/4155

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e3edf3e6-3370-7ce3-a48b-13ce83154cfd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id82DC:2C75BB:40B2FA:57AB75:6AFBEC5C
html-safe-nonce741681ae00c265f67849be5ec9922279d5f680e9df7bbf22fbf3d1e86bb3260c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MkRDOjJDNzVCQjo0MEIyRkE6NTdBQjc1OjZBRkJFQzVDIiwidmlzaXRvcl9pZCI6IjM4MTA3NTcyNzYxNjM4OTQzNjUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacc3e111db705076d5582eec87feaf5458c014e4504c516bb57a4794603bfc335f
hovercard-subject-tagpull_request:689496408
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/purescript/purescript/4155/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f7bdd4daf508d5bbc1be06dfb297baec3f91381fd3c38313cd9b934b6b323008/purescript/purescript/pull/4155
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f7bdd4daf508d5bbc1be06dfb297baec3f91381fd3c38313cd9b934b6b323008/purescript/purescript/pull/4155
og:image:altDescription of the change Our type traversals were ignoring the optional kind in Skolem types; assuming that wasn't intentional, this fixes it. It also fixes a double application of the travers...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamerhendric
hostnamegithub.com
expected-hostnamegithub.com
None744d4381b1c4dbd6d8736c7d7e5bbe7dc11217584e457a3555020c631764e8ec
turbo-cache-controlno-cache
go-importgithub.com/purescript/purescript git https://github.com/purescript/purescript.git
octolytics-dimension-user_id6556677
octolytics-dimension-user_loginpurescript
octolytics-dimension-repository_id13206906
octolytics-dimension-repository_nwopurescript/purescript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id13206906
octolytics-dimension-repository_network_root_nwopurescript/purescript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasedf859c48a4c8b4c0009c19bb4e82101aacb4b998
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/purescript/purescript/pull/4155#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript%2Fpurescript%2Fpull%2F4155
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript%2Fpurescript%2Fpull%2F4155
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=purescript%2Fpurescript
Reloadhttps://github.com/purescript/purescript/pull/4155
Reloadhttps://github.com/purescript/purescript/pull/4155
Reloadhttps://github.com/purescript/purescript/pull/4155
purescripthttps://github.com/purescript
purescripthttps://github.com/purescript/purescript
Codehttps://github.com/purescript/purescript
Issues280 (280)https://github.com/purescript/purescript/issues
Pull requests27 (27)https://github.com/purescript/purescript/pulls
Actionshttps://github.com/purescript/purescript/actions
Projectshttps://github.com/purescript/purescript/projects
Wikihttps://github.com/purescript/purescript/wiki
Security and qualityhttps://github.com/purescript/purescript/security
Insightshttps://github.com/purescript/purescript/pulse
https://github.com/purescript/purescript
rhendrichttps://github.com/rhendric
purescript:masterhttps://github.com/purescript/purescript/tree/master
rhendric:rhendric/fix-type-traversalshttps://github.com/rhendric/purescript/tree/rhendric/fix-type-traversals
Conversationhttps://github.com/purescript/purescript/pull/4155
Commits1 (1)https://github.com/purescript/purescript/pull/4155/commits
Checkshttps://github.com/purescript/purescript/pull/4155/checks
Files changedhttps://github.com/purescript/purescript/pull/4155/files
Fix incomplete type traversalshttps://github.com/purescript/purescript/pull/4155#top
rhendrichttps://github.com/rhendric
purescript:masterhttps://github.com/purescript/purescript/tree/master
rhendric:rhendric/fix-type-traversalshttps://github.com/rhendric/purescript/tree/rhendric/fix-type-traversals
https://github.com/rhendric
rhendrichttps://github.com/rhendric
Jul 14, 2021https://github.com/purescript/purescript/pull/4155#issue-943937974
Please reload this pagehttps://github.com/purescript/purescript/pull/4155
https://github.com/rhendric
rhendrichttps://github.com/rhendric
July 14, 2021 01:41https://github.com/purescript/purescript/pull/4155#event-5017002924
https://github.com/rhendric
rhendrichttps://github.com/rhendric
Jul 14, 2021https://github.com/purescript/purescript/pull/4155#issuecomment-879556590
@kl0tlhttps://github.com/kl0tl
@natefaubionhttps://github.com/natefaubion
Please reload this pagehttps://github.com/purescript/purescript/pull/4155
https://github.com/kl0tl
kl0tlhttps://github.com/kl0tl
Jul 16, 2021https://github.com/purescript/purescript/pull/4155#issuecomment-881351675
Please reload this pagehttps://github.com/purescript/purescript/pull/4155
https://github.com/rhendric
rhendrichttps://github.com/rhendric
Jul 16, 2021https://github.com/purescript/purescript/pull/4155#issuecomment-881594855
Please reload this pagehttps://github.com/purescript/purescript/pull/4155
purescript/src/Language/PureScript/Errors.hshttps://github.com/purescript/purescript/blob/2b9c7a668ca6520f4847afcf66768a5019be8402/src/Language/PureScript/Errors.hs#L1495
2b9c7a6https://github.com/purescript/purescript/commit/2b9c7a668ca6520f4847afcf66768a5019be8402
purescript/src/Language/PureScript/Errors.hshttps://github.com/purescript/purescript/blob/2b9c7a668ca6520f4847afcf66768a5019be8402/src/Language/PureScript/Errors.hs#L884
2b9c7a6https://github.com/purescript/purescript/commit/2b9c7a668ca6520f4847afcf66768a5019be8402
Please reload this pagehttps://github.com/purescript/purescript/pull/4155
https://github.com/rhendric
rhendrichttps://github.com/rhendric
force-pushedhttps://github.com/purescript/purescript/compare/cff6e8c0b957c23095743295251c844ef229244f..6aaee0e12a34ac78036ae85063efe81d29001d3e
cff6e8chttps://github.com/purescript/purescript/commit/cff6e8c0b957c23095743295251c844ef229244f
6aaee0ehttps://github.com/purescript/purescript/commit/6aaee0e12a34ac78036ae85063efe81d29001d3e
Compare https://github.com/purescript/purescript/compare/cff6e8c0b957c23095743295251c844ef229244f..6aaee0e12a34ac78036ae85063efe81d29001d3e
December 21, 2021 18:06https://github.com/purescript/purescript/pull/4155#event-5800566737
https://github.com/rhendric
rhendrichttps://github.com/rhendric
December 21, 2021 18:46https://github.com/purescript/purescript/pull/4155#event-5800737484
https://github.com/rhendric
rhendrichttps://github.com/rhendric
Dec 21, 2021 https://github.com/purescript/purescript/pull/4155#pullrequestreview-837761699
View reviewed changes https://github.com/purescript/purescript/pull/4155/files
rhendrichttps://github.com/rhendric
https://github.com/purescript/purescript/pull/4155#pullrequestreview-837761699
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/purescript/purescript/pull/4155
lib/purescript-cst/src/Language/PureScript/Types.hshttps://github.com/purescript/purescript/pull/4155/files#diff-68fae6202e089c8baba0d52274c3790349487996e80b87b5a712019592e57736
rhendrichttps://github.com/rhendric
Dec 21, 2021https://github.com/purescript/purescript/pull/4155#discussion_r773369197
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/purescript/purescript/pull/4155
src/Language/PureScript/Errors.hshttps://github.com/purescript/purescript/pull/4155/files#diff-11e3ee9ff014e25b38a3dfdaa1fa18c8d0ca9dab1860d355abad0034978ea04c
rhendrichttps://github.com/rhendric
Dec 21, 2021https://github.com/purescript/purescript/pull/4155#discussion_r773372982
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
purescript/src/Language/PureScript/Pretty/Types.hshttps://github.com/purescript/purescript/blob/d2fb21b7c5fd3014c306a46f4591d709651c1034/src/Language/PureScript/Pretty/Types.hs#L73
d2fb21bhttps://github.com/purescript/purescript/commit/d2fb21b7c5fd3014c306a46f4591d709651c1034
Please reload this pagehttps://github.com/purescript/purescript/pull/4155
src/Language/PureScript/TypeChecker/Entailment/Coercible.hshttps://github.com/purescript/purescript/pull/4155/files#diff-ca87b88ffdf5465c97539e5ce459780dd17f452de3b6931b218d81575414c5df
Please reload this pagehttps://github.com/purescript/purescript/pull/4155
https://github.com/rhendric
rhendrichttps://github.com/rhendric
force-pushedhttps://github.com/purescript/purescript/compare/47bf081f6d723593d15cd8e06a993d982fc6b500..bceab3535208b5e363fb01d7ba594e89104868c7
47bf081https://github.com/purescript/purescript/commit/47bf081f6d723593d15cd8e06a993d982fc6b500
bceab35https://github.com/purescript/purescript/commit/bceab3535208b5e363fb01d7ba594e89104868c7
Compare https://github.com/purescript/purescript/compare/47bf081f6d723593d15cd8e06a993d982fc6b500..bceab3535208b5e363fb01d7ba594e89104868c7
February 27, 2022 05:05https://github.com/purescript/purescript/pull/4155#event-6148841284
https://github.com/rhendric
rhendrichttps://github.com/rhendric
Feb 27, 2022 https://github.com/purescript/purescript/pull/4155#pullrequestreview-894463452
View reviewed changes https://github.com/purescript/purescript/pull/4155/files
lib/purescript-cst/src/Language/PureScript/Types.hshttps://github.com/purescript/purescript/pull/4155/files#diff-68fae6202e089c8baba0d52274c3790349487996e80b87b5a712019592e57736
rhendrichttps://github.com/rhendric
Feb 27, 2022https://github.com/purescript/purescript/pull/4155#discussion_r815389804
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#4149https://github.com/purescript/purescript/pull/4149
@natefaubionhttps://github.com/natefaubion
Please reload this pagehttps://github.com/purescript/purescript/pull/4155
natefaubionhttps://github.com/natefaubion
Feb 27, 2022https://github.com/purescript/purescript/pull/4155#discussion_r815453500
Please reload this pagehttps://github.com/purescript/purescript/pull/4155
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/purescript/purescript/pull/4155
rhendrichttps://github.com/rhendric
Feb 28, 2022https://github.com/purescript/purescript/pull/4155#discussion_r815554654
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/purescript/purescript/pull/4155
JordanMartinezhttps://github.com/JordanMartinez
May 12, 2022https://github.com/purescript/purescript/pull/4155#discussion_r871288219
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/purescript/purescript/pull/4155
rhendrichttps://github.com/rhendric
May 13, 2022https://github.com/purescript/purescript/pull/4155#discussion_r872019493
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/purescript/purescript/pull/4155
https://github.com/rhendric
rhendrichttps://github.com/rhendric
force-pushedhttps://github.com/purescript/purescript/compare/bceab3535208b5e363fb01d7ba594e89104868c7..bba194f61d2dcad4ba8c009bcf1a04703b60679c
bceab35https://github.com/purescript/purescript/commit/bceab3535208b5e363fb01d7ba594e89104868c7
bba194fhttps://github.com/purescript/purescript/commit/bba194f61d2dcad4ba8c009bcf1a04703b60679c
Compare https://github.com/purescript/purescript/compare/bceab3535208b5e363fb01d7ba594e89104868c7..bba194f61d2dcad4ba8c009bcf1a04703b60679c
April 20, 2022 20:45https://github.com/purescript/purescript/pull/4155#event-6466156329
https://github.com/rhendric
Fix incomplete type traversalshttps://github.com/purescript/purescript/pull/4155/commits/2c7138186a39e843e2807ae95e80c37bd84e9dbb
2c71381https://github.com/purescript/purescript/pull/4155/commits/2c7138186a39e843e2807ae95e80c37bd84e9dbb
https://github.com/rhendric
rhendrichttps://github.com/rhendric
force-pushedhttps://github.com/purescript/purescript/compare/bba194f61d2dcad4ba8c009bcf1a04703b60679c..2c7138186a39e843e2807ae95e80c37bd84e9dbb
bba194fhttps://github.com/purescript/purescript/commit/bba194f61d2dcad4ba8c009bcf1a04703b60679c
2c71381https://github.com/purescript/purescript/commit/2c7138186a39e843e2807ae95e80c37bd84e9dbb
Compare https://github.com/purescript/purescript/compare/bba194f61d2dcad4ba8c009bcf1a04703b60679c..2c7138186a39e843e2807ae95e80c37bd84e9dbb
April 22, 2022 18:46https://github.com/purescript/purescript/pull/4155#event-6480783724
https://github.com/rhendric
rhendrichttps://github.com/rhendric
vAnyhttps://github.com/purescript/purescript/milestone/35
May 11, 2022https://github.com/purescript/purescript/pull/4155#event-6592871581
https://github.com/JordanMartinez
JordanMartinezhttps://github.com/JordanMartinez
May 13, 2022 https://github.com/purescript/purescript/pull/4155#pullrequestreview-972310414
View reviewed changes https://github.com/purescript/purescript/pull/4155/files/2c7138186a39e843e2807ae95e80c37bd84e9dbb
https://github.com/rhendric
rhendrichttps://github.com/rhendric
a7ae87fhttps://github.com/purescript/purescript/commit/a7ae87fc29cdb6ca57a5b512c3482f11c1e6a1d2
May 15, 2022https://github.com/purescript/purescript/pull/4155#event-6612003830
https://github.com/rhendric
rhendrichttps://github.com/rhendric
May 15, 2022 22:21https://github.com/purescript/purescript/pull/4155#event-6612003882
https://github.com/rhendric
rhendrichttps://github.com/rhendric
May 16, 2022 https://github.com/purescript/purescript/pull/4155#ref-pullrequest-1236496815
Drop dependency on microlens libraries #4327 https://github.com/purescript/purescript/pull/4327
https://github.com/hdgarrood
hdgarroodhttps://github.com/hdgarrood
May 22, 2022https://github.com/purescript/purescript/pull/4155#issuecomment-1133989380
@rhendrichttps://github.com/rhendric
#1647https://github.com/purescript/purescript/issues/1647
Please reload this pagehttps://github.com/purescript/purescript/pull/4155
https://github.com/rhendric
rhendrichttps://github.com/rhendric
May 23, 2022https://github.com/purescript/purescript/pull/4155#issuecomment-1134025589
Please reload this pagehttps://github.com/purescript/purescript/pull/4155
https://github.com/hdgarrood
hdgarroodhttps://github.com/hdgarrood
May 23, 2022https://github.com/purescript/purescript/pull/4155#issuecomment-1134885827
Please reload this pagehttps://github.com/purescript/purescript/pull/4155
https://github.com/hdgarrood
hdgarroodhttps://github.com/hdgarrood
May 23, 2022https://github.com/purescript/purescript/pull/4155#issuecomment-1134896055
#4337https://github.com/purescript/purescript/pull/4337
Please reload this pagehttps://github.com/purescript/purescript/pull/4155
https://github.com/rhendric
rhendrichttps://github.com/rhendric
May 23, 2022https://github.com/purescript/purescript/pull/4155#issuecomment-1135006971
#4337https://github.com/purescript/purescript/pull/4337
Please reload this pagehttps://github.com/purescript/purescript/pull/4155
https://github.com/hdgarrood
hdgarroodhttps://github.com/hdgarrood
May 23, 2022https://github.com/purescript/purescript/pull/4155#issuecomment-1135012715
Please reload this pagehttps://github.com/purescript/purescript/pull/4155
https://github.co/hiddenchars
https://github.com/purescript/purescript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript%2Fpurescript%2Fpull%2F4155
https://github.com/natefaubion
natefaubion https://github.com/natefaubion
https://github.com/purescript/purescript/pull/4155/files/bceab3535208b5e363fb01d7ba594e89104868c7
https://github.com/JordanMartinez
JordanMartinez https://github.com/JordanMartinez
https://github.com/purescript/purescript/pull/4155/files/2c7138186a39e843e2807ae95e80c37bd84e9dbb
Please reload this pagehttps://github.com/purescript/purescript/pull/4155
vAny https://github.com/purescript/purescript/milestone/35
Please reload this pagehttps://github.com/purescript/purescript/pull/4155
https://github.com/rhendric
https://github.com/kl0tl
https://github.com/hdgarrood
https://github.com/natefaubion
https://github.com/JordanMartinez
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.