| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:8774707d-a189-0e19-3359-420ef948d846 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A736:76F02:51F930:6BB36B:6B00CD37 |
| html-safe-nonce | 3bc29fd6f7902305080ab020237c16a611777e5c1e5244f645eeb486f2c50c4d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNzM2Ojc2RjAyOjUxRjkzMDo2QkIzNkI6NkIwMENEMzciLCJ2aXNpdG9yX2lkIjoiNDg4NzAxNDU1OTQzMDI2NjE2NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 7c5eaf18bdfc67474f00c8e059eaf32477702188d25f60f321d8ac16b6a88b2b |
| hovercard-subject-tag | pull_request:678349992 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/purescript/purescript/4121/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/b267f02d1b74e6ec7a6b24144a553ff9c1c71ad9b6c1bf1001d4643925c179de/purescript/purescript/pull/4121 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b267f02d1b74e6ec7a6b24144a553ff9c1c71ad9b6c1bf1001d4643925c179de/purescript/purescript/pull/4121 |
| og:image:alt | Description of the change
Fixes #4116
WIP but should help continue the discussion already started.
Checklist:
Added the change to the changelog's "Unreleased" section with a refere... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | JordanMartinez |
| hostname | github.com |
| expected-hostname | github.com |
| None | 85bbdfe2b6ba16e234513bc6ceff5d848ef8449820c900692a2b4e67061931e5 |
| turbo-cache-control | no-cache |
| go-import | github.com/purescript/purescript git https://github.com/purescript/purescript.git |
| octolytics-dimension-user_id | 6556677 |
| octolytics-dimension-user_login | purescript |
| octolytics-dimension-repository_id | 13206906 |
| octolytics-dimension-repository_nwo | purescript/purescript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 13206906 |
| octolytics-dimension-repository_network_root_nwo | purescript/purescript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4943239a6d2c591325dad6e5c313e1cafda877f6 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/purescript/purescript/pull/4121#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript%2Fpurescript%2Fpull%2F4121 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript%2Fpurescript%2Fpull%2F4121 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=purescript%2Fpurescript |
| Reload | https://github.com/purescript/purescript/pull/4121 |
| Reload | https://github.com/purescript/purescript/pull/4121 |
| Reload | https://github.com/purescript/purescript/pull/4121 |
| purescript | https://github.com/purescript |
| purescript | https://github.com/purescript/purescript |
| Code | https://github.com/purescript/purescript |
| Issues280 (280) | https://github.com/purescript/purescript/issues |
| Pull requests28 (28) | https://github.com/purescript/purescript/pulls |
| Actions | https://github.com/purescript/purescript/actions |
| Projects | https://github.com/purescript/purescript/projects |
| Wiki | https://github.com/purescript/purescript/wiki |
| Security and quality | https://github.com/purescript/purescript/security |
| Insights | https://github.com/purescript/purescript/insights |
| https://github.com/purescript/purescript |
| JordanMartinez | https://github.com/JordanMartinez |
| purescript:master | https://github.com/purescript/purescript/tree/master |
| Conversation | https://github.com/purescript/purescript/pull/4121 |
| Commits57 (57) | https://github.com/purescript/purescript/pull/4121/commits |
| Checks | https://github.com/purescript/purescript/pull/4121/checks |
| Files changed | https://github.com/purescript/purescript/pull/4121/files |
| Display roles in HTML docs | https://github.com/purescript/purescript/pull/4121#top |
| JordanMartinez | https://github.com/JordanMartinez |
| purescript:master | https://github.com/purescript/purescript/tree/master |
|
| https://github.com/JordanMartinez |
| JordanMartinez | https://github.com/JordanMartinez |
| Jun 26, 2021 | https://github.com/purescript/purescript/pull/4121#issue-930713959 |
| Please reload this page | https://github.com/purescript/purescript/pull/4121 |
| #4116 | https://github.com/purescript/purescript/issues/4116 |
| Please reload this page | https://github.com/purescript/purescript/pull/4121 |
| https://github.com/JordanMartinez |
| JordanMartinez | https://github.com/JordanMartinez |
|
Jun 26, 2021
| https://github.com/purescript/purescript/pull/4121#pullrequestreview-693315558 |
|
View reviewed changes
| https://github.com/purescript/purescript/pull/4121/files |
| lib/purescript-cst/src/Language/PureScript/AST/Exported.hs | https://github.com/purescript/purescript/pull/4121/files#diff-868af51ac9d5e151958449c5e6334c9392108f34d396f379a9ef4041bac2950a |
| Please reload this page | https://github.com/purescript/purescript/pull/4121 |
| https://github.com/JordanMartinez |
| JordanMartinez | https://github.com/JordanMartinez |
|
Jun 26, 2021
| https://github.com/purescript/purescript/pull/4121#pullrequestreview-693315601 |
|
View reviewed changes
| https://github.com/purescript/purescript/pull/4121/files |
| lib/purescript-cst/src/Language/PureScript/AST/Exported.hs | https://github.com/purescript/purescript/pull/4121/files#diff-868af51ac9d5e151958449c5e6334c9392108f34d396f379a9ef4041bac2950a |
| Please reload this page | https://github.com/purescript/purescript/pull/4121 |
| https://github.com/JordanMartinez |
| JordanMartinez | https://github.com/JordanMartinez |
|
Jun 26, 2021
| https://github.com/purescript/purescript/pull/4121#pullrequestreview-693315667 |
|
View reviewed changes
| https://github.com/purescript/purescript/pull/4121/files |
| src/Language/PureScript/Docs/Convert/Single.hs | https://github.com/purescript/purescript/pull/4121/files#diff-97cca15f573a3e8c1a92bfc229f27ca324e8c6982bc3215414d48a329f97974d |
| Please reload this page | https://github.com/purescript/purescript/pull/4121 |
| https://github.com/JordanMartinez |
| JordanMartinez | https://github.com/JordanMartinez |
|
Jun 26, 2021
| https://github.com/purescript/purescript/pull/4121#pullrequestreview-693315716 |
|
View reviewed changes
| https://github.com/purescript/purescript/pull/4121/files |
| src/Language/PureScript/Docs/Convert/Single.hs | https://github.com/purescript/purescript/pull/4121/files#diff-97cca15f573a3e8c1a92bfc229f27ca324e8c6982bc3215414d48a329f97974d |
| Please reload this page | https://github.com/purescript/purescript/pull/4121 |
| https://github.com/JordanMartinez |
| JordanMartinez | https://github.com/JordanMartinez |
| Jun 28, 2021 | https://github.com/purescript/purescript/pull/4121#issuecomment-869964599 |
| renderDeclaration | https://github.com/purescript/purescript/blob/master/src/Language/PureScript/Docs/AsHtml.hs#L153 |
| the args back into a P.Type' | https://github.com/purescript/purescript/blob/master/src/Language/PureScript/Docs/Render.hs#L46 |
| typeApp | https://github.com/purescript/purescript/blob/master/src/Language/PureScript/Docs/Render.hs#L131-L139 |
| convertPrettyPrintType | https://github.com/purescript/purescript/blob/master/src/Language/PureScript/Docs/RenderedCode/RenderType.hs#L156-L157 |
| RenderedCode value | https://github.com/purescript/purescript/blob/master/src/Language/PureScript/Docs/RenderedCode/Types.hs#L237-L243 |
| RenderedCodeElement values | https://github.com/purescript/purescript/blob/master/src/Language/PureScript/Docs/RenderedCode/Types.hs#L193-L201 |
| renderType' | https://github.com/purescript/purescript/blob/master/src/Language/PureScript/Docs/RenderedCode/RenderType.hs#L159-L162 |
| matchType | https://github.com/purescript/purescript/blob/master/src/Language/PureScript/Docs/RenderedCode/RenderType.hs#L133-L145 |
| matchTypeAtom | https://github.com/purescript/purescript/blob/master/src/Language/PureScript/Docs/RenderedCode/RenderType.hs#L128-L131 |
| typeLiterals | https://github.com/purescript/purescript/blob/master/src/Language/PureScript/Docs/RenderedCode/RenderType.hs#L32-L56 |
| convertToHtml function | https://github.com/purescript/purescript/blob/master/src/Language/PureScript/Docs/AsHtml.hs#L192-L217 |
| PrettyPrintType's TypeVar | https://github.com/purescript/purescript/blob/master/src/Language/PureScript/Pretty/Types.hs#L45 |
| Please reload this page | https://github.com/purescript/purescript/pull/4121 |
| https://github.com/JordanMartinez |
| JordanMartinez | https://github.com/JordanMartinez |
|
Jun 29, 2021
| https://github.com/purescript/purescript/pull/4121#ref-issue-924874795 |
|
Include role information in HTML docs
#4116
| https://github.com/purescript/purescript/issues/4116 |
| https://github.com/JordanMartinez |
| JordanMartinez | https://github.com/JordanMartinez |
| Jul 2, 2021 | https://github.com/purescript/purescript/pull/4121#issuecomment-872700797 |
| clickable a tag | https://github.com/purescript/purescript/issues/4116#issuecomment-868313507 |
| not-styleable-but-accessible tooltip | https://github.com/purescript/purescript/issues/4116#issuecomment-864087258 |
| display the role next to its corresponding type parameter | https://github.com/purescript/purescript/issues/4116#issuecomment-864138257 |
| making it clear that this is not part of the PureScript syntax | https://github.com/purescript/purescript/issues/4116#issuecomment-864141758 |
| isn't selectable if one should want to copy/paste the declaration into source code | https://github.com/purescript/purescript/issues/4116#issuecomment-864476706 |
| https://user-images.githubusercontent.com/8413037/124219898-c723a280-dab1-11eb-8e97-a78f8ed2b916.png |
| Please reload this page | https://github.com/purescript/purescript/pull/4121 |
| https://github.com/MonoidMusician |
| MonoidMusician | https://github.com/MonoidMusician |
| Jul 2, 2021 | https://github.com/purescript/purescript/pull/4121#issuecomment-873100603 |
| Please reload this page | https://github.com/purescript/purescript/pull/4121 |
| https://github.com/rhendric |
| rhendric | https://github.com/rhendric |
| Jul 2, 2021 | https://github.com/purescript/purescript/pull/4121#issuecomment-873139868 |
| Please reload this page | https://github.com/purescript/purescript/pull/4121 |
| https://github.com/JordanMartinez |
| JordanMartinez | https://github.com/JordanMartinez |
| Jul 2, 2021 | https://github.com/purescript/purescript/pull/4121#issuecomment-873148368 |
| @rhendric | https://github.com/rhendric |
| Please reload this page | https://github.com/purescript/purescript/pull/4121 |
| https://github.com/rhendric |
| rhendric | https://github.com/rhendric |
| Jul 2, 2021 | https://github.com/purescript/purescript/pull/4121#issuecomment-873151847 |
| Please reload this page | https://github.com/purescript/purescript/pull/4121 |
| https://github.com/JordanMartinez |
| JordanMartinez | https://github.com/JordanMartinez |
| Jul 2, 2021 | https://github.com/purescript/purescript/pull/4121#issuecomment-873171378 |
| Please reload this page | https://github.com/purescript/purescript/pull/4121 |
| https://user-images.githubusercontent.com/8413037/124313194-5c13b380-db25-11eb-80cc-4c69bc4de4b9.png |
| https://user-images.githubusercontent.com/8413037/124313255-78175500-db25-11eb-9f60-6cc41b619f20.png |
| Roles.md | https://github.com/purescript/documentation/blob/master/language/Roles.md |
| Please reload this page | https://github.com/purescript/purescript/pull/4121 |
| https://github.com/JordanMartinez |
| JordanMartinez | https://github.com/JordanMartinez |
|
Jul 2, 2021
| https://github.com/purescript/purescript/pull/4121#pullrequestreview-698409454 |
|
View reviewed changes
| https://github.com/purescript/purescript/pull/4121/files |
| src/Language/PureScript/Docs/AsHtml.hs | https://github.com/purescript/purescript/pull/4121/files#diff-16c0a1c056486d893387d4b887d1cab9275ccc2208941fb88ea33a6add5c8a9b |
| Please reload this page | https://github.com/purescript/purescript/pull/4121 |
| https://github.com/JordanMartinez |
| JordanMartinez | https://github.com/JordanMartinez |
|
Jul 2, 2021
| https://github.com/purescript/purescript/pull/4121#pullrequestreview-698409825 |
|
View reviewed changes
| https://github.com/purescript/purescript/pull/4121/files |
| src/Language/PureScript/Docs/AsMarkdown.hs | https://github.com/purescript/purescript/pull/4121/files#diff-7a1e7ab4273fba4237e27d8b642393613906941c89eafb1afd22659d4fb2a219 |
| Please reload this page | https://github.com/purescript/purescript/pull/4121 |
| https://github.com/JordanMartinez |
| JordanMartinez | https://github.com/JordanMartinez |
|
Jul 2, 2021
| https://github.com/purescript/purescript/pull/4121#pullrequestreview-698410757 |
|
View reviewed changes
| https://github.com/purescript/purescript/pull/4121/files |
| src/Language/PureScript/Docs/RenderedCode/RenderType.hs | https://github.com/purescript/purescript/pull/4121/files#diff-632cd22840fb5cdbf387061e7984756ac9575f8c38b03f370f1ca054b299f96a |
| Please reload this page | https://github.com/purescript/purescript/pull/4121 |
| https://github.com/rhendric |
| rhendric | https://github.com/rhendric |
| Jul 2, 2021 | https://github.com/purescript/purescript/pull/4121#issuecomment-873173607 |
| Please reload this page | https://github.com/purescript/purescript/pull/4121 |
| https://github.com/JordanMartinez |
| JordanMartinez | https://github.com/JordanMartinez |
| Jul 2, 2021 | https://github.com/purescript/purescript/pull/4121#issuecomment-873193650 |
| https://user-images.githubusercontent.com/8413037/124315690-27a1f680-db29-11eb-9666-a52b0f222303.png |
| Please reload this page | https://github.com/purescript/purescript/pull/4121 |
| https://github.com/JordanMartinez |
| JordanMartinez | https://github.com/JordanMartinez |
| Jul 2, 2021 | https://github.com/purescript/purescript/pull/4121#issuecomment-873200171 |
| IDE.State.hs | https://github.com/purescript/purescript/blob/master/src/Language/PureScript/Ide/State.hs#L334 |
| first | https://github.com/purescript/purescript/blob/master/src/Language/PureScript/Linter.hs#L37 |
| second | https://github.com/purescript/purescript/blob/master/src/Language/PureScript/Linter.hs#L167 |
| Sugar.Names.hs | https://github.com/purescript/purescript/blob/master/src/Language/PureScript/Sugar/Names.hs#L155 |
| Please reload this page | https://github.com/purescript/purescript/pull/4121 |
| https://github.com/JordanMartinez |
| JordanMartinez | https://github.com/JordanMartinez |
| Jul 2, 2021 | https://github.com/purescript/purescript/pull/4121#issuecomment-873218396 |
| #4126 | https://github.com/purescript/purescript/pull/4126 |
| Please reload this page | https://github.com/purescript/purescript/pull/4121 |
| https://github.com/JordanMartinez |
| JordanMartinez | https://github.com/JordanMartinez |
| Jul 2, 2021 | https://github.com/purescript/purescript/pull/4121#issuecomment-873225025 |
| Please reload this page | https://github.com/purescript/purescript/pull/4121 |
| https://github.com/JordanMartinez |
| JordanMartinez | https://github.com/JordanMartinez |
| Jul 6, 2021 | https://github.com/purescript/purescript/pull/4121#issuecomment-874716768 |
| https://user-images.githubusercontent.com/8413037/124599624-b90bb400-de1a-11eb-9478-0822093f793f.png |
| https://user-images.githubusercontent.com/8413037/124599709-d17bce80-de1a-11eb-89d9-51f24c8cf271.png |
| Please reload this page | https://github.com/purescript/purescript/pull/4121 |
| https://github.com/JordanMartinez |
| JordanMartinez | https://github.com/JordanMartinez |
|
Jul 6, 2021
| https://github.com/purescript/purescript/pull/4121#ref-issue-937856330 |
|
Still omit uninteresting kind signatures from HTML docs when redundant parenthesis are involved
#4136
| https://github.com/purescript/purescript/issues/4136 |
| https://github.com/JordanMartinez |
| JordanMartinez | https://github.com/JordanMartinez |
| Jul 6, 2021 | https://github.com/purescript/purescript/pull/4121#issuecomment-874790498 |
| Please reload this page | https://github.com/purescript/purescript/pull/4121 |
| https://github.com/kl0tl |
| kl0tl | https://github.com/kl0tl |
|
Jul 9, 2021
| https://github.com/purescript/purescript/pull/4121#pullrequestreview-703111546 |
|
View reviewed changes
| https://github.com/purescript/purescript/pull/4121/files |
| src/Language/PureScript/Docs/AsHtml.hs | https://github.com/purescript/purescript/pull/4121/files#diff-16c0a1c056486d893387d4b887d1cab9275ccc2208941fb88ea33a6add5c8a9b |
| Please reload this page | https://github.com/purescript/purescript/pull/4121 |
| src/Language/PureScript/Docs/AsMarkdown.hs | https://github.com/purescript/purescript/pull/4121/files#diff-7a1e7ab4273fba4237e27d8b642393613906941c89eafb1afd22659d4fb2a219 |
| Please reload this page | https://github.com/purescript/purescript/pull/4121 |
| src/Language/PureScript/Docs/Convert/Single.hs | https://github.com/purescript/purescript/pull/4121/files#diff-97cca15f573a3e8c1a92bfc229f27ca324e8c6982bc3215414d48a329f97974d |
| Please reload this page | https://github.com/purescript/purescript/pull/4121 |
| tests/TestDocs.hs | https://github.com/purescript/purescript/pull/4121/files#diff-721fa0189394ab7fd6a15fb120b06cca0b8197b671cd2ae278b2b75d9d8a9c83 |
| Please reload this page | https://github.com/purescript/purescript/pull/4121 |
| tests/purs/docs/src/DocCommentsMerge.purs | https://github.com/purescript/purescript/pull/4121/files#diff-e342b38b9646cbbbc4d1671248fff6d8c20157773c26d9b0a782ad7cf04af149 |
| Please reload this page | https://github.com/purescript/purescript/pull/4121 |
| tests/purs/docs/src/KindSignatureDocs.purs | https://github.com/purescript/purescript/pull/4121/files#diff-fa6a4832bd0a1b45c001cc6d6e6efb94eb4af112bd6683b9fab7a7bb50d3c8b8 |
| Please reload this page | https://github.com/purescript/purescript/pull/4121 |
| src/Language/PureScript/Docs/Convert.hs | https://github.com/purescript/purescript/pull/4121/files#diff-9b52decea9d01fdfd7863575436794e1ed0d627bb7f8627174fba56e6d8a8cb8 |
| Please reload this page | https://github.com/purescript/purescript/pull/4121 |
| src/Language/PureScript/Docs/Convert.hs | https://github.com/purescript/purescript/pull/4121/files#diff-9b52decea9d01fdfd7863575436794e1ed0d627bb7f8627174fba56e6d8a8cb8 |
| Please reload this page | https://github.com/purescript/purescript/pull/4121 |
| JordanMartinez | https://github.com/JordanMartinez |
| July 12, 2021 13:56 | https://github.com/purescript/purescript/pull/4121#commits-pushed-8ca7fe4 |
|
| https://github.com/JordanMartinez |
| Include role declarations in list of ordered exports | https://github.com/purescript/purescript/pull/4121/commits/8ca7fe4d5a5e4d3ccaab0d0fdae7db2eb45f7e0e |
| 8ca7fe4 | https://github.com/purescript/purescript/pull/4121/commits/8ca7fe4d5a5e4d3ccaab0d0fdae7db2eb45f7e0e |
|
| https://github.com/JordanMartinez |
| Insert roles in doc decl augmentation pass | https://github.com/purescript/purescript/pull/4121/commits/8b32827bd115735b5fa90ccef0eb94ecd18b2e0a |
| 8b32827 | https://github.com/purescript/purescript/pull/4121/commits/8b32827bd115735b5fa90ccef0eb94ecd18b2e0a |
|
| https://github.com/JordanMartinez |
| Render role annotations in HTML docs but not markdown docs | https://github.com/purescript/purescript/pull/4121/commits/cea75cabaa8fbcbbcbf7a40df6262ed904dc3255 |
| cea75ca | https://github.com/purescript/purescript/pull/4121/commits/cea75cabaa8fbcbbcbf7a40df6262ed904dc3255 |
|
| https://github.com/JordanMartinez |
| Fix test by adding new arg to data constructor | https://github.com/purescript/purescript/pull/4121/commits/d51a42e0a0cd6360d46c44db9b1dcac708a5ee10 |
| d51a42e | https://github.com/purescript/purescript/pull/4121/commits/d51a42e0a0cd6360d46c44db9b1dcac708a5ee10 |
|
| https://github.com/JordanMartinez |
| Add test: verify expected role declarations match actual ones | https://github.com/purescript/purescript/pull/4121/commits/2801a3ea6f50525c85749fc0debbff635436e353 |
| 2801a3e | https://github.com/purescript/purescript/pull/4121/commits/2801a3ea6f50525c85749fc0debbff635436e353 |
|
| https://github.com/JordanMartinez |
| Type synonyms cannot have role declarations | https://github.com/purescript/purescript/pull/4121/commits/c273f6f2f8ae01b72f2c7d575fe34432ca4be9da |
| c273f6f | https://github.com/purescript/purescript/pull/4121/commits/c273f6f2f8ae01b72f2c7d575fe34432ca4be9da |
|
| https://github.com/JordanMartinez |
| Merge remote-tracking branch 'upstream/master' into addRolesToDocs | https://github.com/purescript/purescript/pull/4121/commits/73ff5f6ca95e2c31fa4ab01db5a5cee44ca9b78e |
| 73ff5f6 | https://github.com/purescript/purescript/pull/4121/commits/73ff5f6ca95e2c31fa4ab01db5a5cee44ca9b78e |
| https://github.com/kl0tl |
| kl0tl | https://github.com/kl0tl |
|
Jul 16, 2021
| https://github.com/purescript/purescript/pull/4121#ref-pullrequest-946398327 |
|
Check role declarations arity during type checking
#4157
| https://github.com/purescript/purescript/pull/4157 |
| https://github.com/kl0tl |
| kl0tl | https://github.com/kl0tl |
| Jul 16, 2021 | https://github.com/purescript/purescript/pull/4121#issuecomment-881571653 |
| https://user-images.githubusercontent.com/2788549/125978412-8cc006be-520f-400b-a648-54b5a6b9ec8d.png |
| https://user-images.githubusercontent.com/2788549/125978418-78a8ddd0-d823-4e6e-88bd-cc6c349d8621.png |
| Please reload this page | https://github.com/purescript/purescript/pull/4121 |
| JordanMartinez | https://github.com/JordanMartinez |
| July 17, 2021 07:36 | https://github.com/purescript/purescript/pull/4121#commits-pushed-03d1144 |
|
| https://github.com/JordanMartinez |
| Add tests for FFI declarations' kind signatures | https://github.com/purescript/purescript/pull/4121/commits/03d1144dace43fc25149a71bcb4c212688916850 |
| 03d1144 | https://github.com/purescript/purescript/pull/4121/commits/03d1144dace43fc25149a71bcb4c212688916850 |
|
| https://github.com/JordanMartinez |
| Verify that FFI declarations with redundant parens are accounted for | https://github.com/purescript/purescript/pull/4121/commits/5e102a09d21809e50443cd9e84d60eaa4b5f6f60 |
| 5e102a0 | https://github.com/purescript/purescript/pull/4121/commits/5e102a09d21809e50443cd9e84d60eaa4b5f6f60 |
|
| https://github.com/JordanMartinez |
| Account for sort annotations in all kind sigs, not just inferred ones | https://github.com/purescript/purescript/pull/4121/commits/187093c7789eb97c57184f03c1dcdbf8bd36af42 |
| 187093c | https://github.com/purescript/purescript/pull/4121/commits/187093c7789eb97c57184f03c1dcdbf8bd36af42 |
| https://github.com/JordanMartinez |
| JordanMartinez | https://github.com/JordanMartinez |
| Jul 17, 2021 | https://github.com/purescript/purescript/pull/4121#issuecomment-881909220 |
| @kl0tl | https://github.com/kl0tl |
| here | https://github.com/purescript/purescript/pull/4137#issuecomment-881575727 |
| Please reload this page | https://github.com/purescript/purescript/pull/4121 |
|
| https://github.com/JordanMartinez |
| Use kind Constraint for class docs test, not Type | https://github.com/purescript/purescript/pull/4121/commits/1b4deaf3dd3e02d3cc5a112756895dc4b320a037 |
| 1b4deaf | https://github.com/purescript/purescript/pull/4121/commits/1b4deaf3dd3e02d3cc5a112756895dc4b320a037 |
| https://github.com/JordanMartinez |
| JordanMartinez | https://github.com/JordanMartinez |
| Jul 17, 2021 | https://github.com/purescript/purescript/pull/4121#issuecomment-881923137 |
| Please reload this page | https://github.com/purescript/purescript/pull/4121 |
| JordanMartinez | https://github.com/JordanMartinez |
| July 17, 2021 18:08 | https://github.com/purescript/purescript/pull/4121#commits-pushed-7cf5774 |
|
| https://github.com/JordanMartinez |
| Test all possible variations of doc comment merging | https://github.com/purescript/purescript/pull/4121/commits/7cf577490a4919af1cb0341a1146d3874ba58109 |
| 7cf5774 | https://github.com/purescript/purescript/pull/4121/commits/7cf577490a4919af1cb0341a1146d3874ba58109 |
|
| https://github.com/JordanMartinez |
| Render role in markdown as subscript; reference values via constants | https://github.com/purescript/purescript/pull/4121/commits/0623409a0d5368ffdbd6868f6834d0f35421b453 |
| 0623409 | https://github.com/purescript/purescript/pull/4121/commits/0623409a0d5368ffdbd6868f6834d0f35421b453 |
|
| https://github.com/JordanMartinez |
| Update changelog to clarify the FFI declaration rendering situation | https://github.com/purescript/purescript/pull/4121/commits/86da8c3b6186f5057560d747c3fb1ace4761a12b |
| 86da8c3 | https://github.com/purescript/purescript/pull/4121/commits/86da8c3b6186f5057560d747c3fb1ace4761a12b |
|
| https://github.com/JordanMartinez |
| Add changelog entry for sort annotation fix | https://github.com/purescript/purescript/pull/4121/commits/7d95e0d437588a23bd516aa02096a0a65a98ef41 |
| 7d95e0d | https://github.com/purescript/purescript/pull/4121/commits/7d95e0d437588a23bd516aa02096a0a65a98ef41 |
|
| https://github.com/JordanMartinez |
| Revert "Add changelog entry for sort annotation fix" | https://github.com/purescript/purescript/pull/4121/commits/38f5f489fe992f59196f69589a5f9419546a7d19 |
| 38f5f48 | https://github.com/purescript/purescript/pull/4121/commits/38f5f489fe992f59196f69589a5f9419546a7d19 |
| 7d95e0d | https://github.com/purescript/purescript/commit/7d95e0d437588a23bd516aa02096a0a65a98ef41 |
|
| https://github.com/JordanMartinez |
| Revert "Account for sort annotations in all kind sigs, not just infer… | https://github.com/purescript/purescript/pull/4121/commits/8bf99f71f83aefa878aa566d4540d2fe355861ab |
| 8bf99f7 | https://github.com/purescript/purescript/pull/4121/commits/8bf99f71f83aefa878aa566d4540d2fe355861ab |
| 187093c | https://github.com/purescript/purescript/commit/187093c7789eb97c57184f03c1dcdbf8bd36af42 |
| https://github.com/JordanMartinez |
| JordanMartinez | https://github.com/JordanMartinez |
|
Jul 20, 2021
| https://github.com/purescript/purescript/pull/4121#pullrequestreview-711030450 |
|
View reviewed changes
| https://github.com/purescript/purescript/pull/4121/files/8bf99f71f83aefa878aa566d4540d2fe355861ab |
| tests/TestDocs.hs | https://github.com/purescript/purescript/pull/4121/files/8bf99f71f83aefa878aa566d4540d2fe355861ab#diff-721fa0189394ab7fd6a15fb120b06cca0b8197b671cd2ae278b2b75d9d8a9c83 |
| JordanMartinez | https://github.com/JordanMartinez |
| Jul 20, 2021 | https://github.com/purescript/purescript/pull/4121#discussion_r673464317 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #4157 | https://github.com/purescript/purescript/pull/4157 |
| Please reload this page | https://github.com/purescript/purescript/pull/4121 |
|
| https://github.com/JordanMartinez |
| Add note: intentionally not dropping sort ann for explicit kind sigs | https://github.com/purescript/purescript/pull/4121/commits/d548e8788609be85a5ea4c4e9356a200a1cb9d0f |
| d548e87 | https://github.com/purescript/purescript/pull/4121/commits/d548e8788609be85a5ea4c4e9356a200a1cb9d0f |
| https://github.com/JordanMartinez |
| JordanMartinez | https://github.com/JordanMartinez |
| Jul 21, 2021 | https://github.com/purescript/purescript/pull/4121#issuecomment-884177833 |
| #4160 | https://github.com/purescript/purescript/issues/4160 |
| #4157 | https://github.com/purescript/purescript/pull/4157 |
| Please reload this page | https://github.com/purescript/purescript/pull/4121 |
| https://github.com/JordanMartinez |
| JordanMartinez | https://github.com/JordanMartinez |
| Jul 23, 2021 | https://github.com/purescript/purescript/pull/4121#issuecomment-885409460 |
| @kl0tl | https://github.com/kl0tl |
| Please reload this page | https://github.com/purescript/purescript/pull/4121 |
| https://github.com/kl0tl |
| kl0tl | https://github.com/kl0tl |
|
Jul 23, 2021
| https://github.com/purescript/purescript/pull/4121#pullrequestreview-713801793 |
|
View reviewed changes
| https://github.com/purescript/purescript/pull/4121/files/d548e8788609be85a5ea4c4e9356a200a1cb9d0f |
| kl0tl | https://github.com/kl0tl |
| https://github.com/purescript/purescript/pull/4121#pullrequestreview-713801793 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #4157 | https://github.com/purescript/purescript/pull/4157 |
| Please reload this page | https://github.com/purescript/purescript/pull/4121 |
| CHANGELOG.d/feature_display roles in html docs.md | https://github.com/purescript/purescript/pull/4121/files/d548e8788609be85a5ea4c4e9356a200a1cb9d0f#diff-7b5675db92064246ddea2e1fc8d8f363c6c3e5ccfb6dbd739a682ad7420cfec2 |
| Please reload this page | https://github.com/purescript/purescript/pull/4121 |
| JordanMartinez | https://github.com/JordanMartinez |
| July 23, 2021 11:02 | https://github.com/purescript/purescript/pull/4121#commits-pushed-34cef73 |
|
| https://github.com/JordanMartinez |
| Revert "Render role in markdown as subscript; reference values via co… | https://github.com/purescript/purescript/pull/4121/commits/34cef73035840158bfdb52986c3bfda8cfa917cb |
| 34cef73 | https://github.com/purescript/purescript/pull/4121/commits/34cef73035840158bfdb52986c3bfda8cfa917cb |
| 0623409 | https://github.com/purescript/purescript/commit/0623409a0d5368ffdbd6868f6834d0f35421b453 |
|
| https://github.com/JordanMartinez |
|
| https://github.com/kl0tl |
| Fix typo | https://github.com/purescript/purescript/pull/4121/commits/d7e01f88c25213a436d7dad40eaa89f8c4184d68 |
| d7e01f8 | https://github.com/purescript/purescript/pull/4121/commits/d7e01f88c25213a436d7dad40eaa89f8c4184d68 |
| https://github.com/JordanMartinez |
| JordanMartinez | https://github.com/JordanMartinez |
| Jul 23, 2021 | https://github.com/purescript/purescript/pull/4121#issuecomment-885833135 |
| Please reload this page | https://github.com/purescript/purescript/pull/4121 |
| https://github.com/JordanMartinez |
| JordanMartinez | https://github.com/JordanMartinez |
| Jul 23, 2021 | https://github.com/purescript/purescript/pull/4121#issuecomment-885843761 |
| Please reload this page | https://github.com/purescript/purescript/pull/4121 |
| JordanMartinez | https://github.com/JordanMartinez |
| November 15, 2021 22:13 | https://github.com/purescript/purescript/pull/4121#commits-pushed-f76bde4 |
|
| https://github.com/JordanMartinez |
| Merge remote-tracking branch 'upstream/master' into addRolesToDocs | https://github.com/purescript/purescript/pull/4121/commits/f76bde4a07ba1535831a1ba11dd85aa706d9e059 |
| f76bde4 | https://github.com/purescript/purescript/pull/4121/commits/f76bde4a07ba1535831a1ba11dd85aa706d9e059 |
|
| https://github.com/JordanMartinez |
| Re-enable FFI role declaration tests | https://github.com/purescript/purescript/pull/4121/commits/263d819367091dc1ebc33fee148517ed29c375b3 |
| 263d819 | https://github.com/purescript/purescript/pull/4121/commits/263d819367091dc1ebc33fee148517ed29c375b3 |
| https://github.com/JordanMartinez |
| JordanMartinez | https://github.com/JordanMartinez |
| Nov 16, 2021 | https://github.com/purescript/purescript/pull/4121#issuecomment-969914980 |
| Please reload this page | https://github.com/purescript/purescript/pull/4121 |
| https://github.com/rhendric |
| rhendric | https://github.com/rhendric |
|
Nov 17, 2021
| https://github.com/purescript/purescript/pull/4121#pullrequestreview-809053980 |
|
View reviewed changes
| https://github.com/purescript/purescript/pull/4121/files/263d819367091dc1ebc33fee148517ed29c375b3 |
| src/Language/PureScript/Docs/AsMarkdown.hs | https://github.com/purescript/purescript/pull/4121/files#diff-7a1e7ab4273fba4237e27d8b642393613906941c89eafb1afd22659d4fb2a219 |
| Please reload this page | https://github.com/purescript/purescript/pull/4121 |
| https://github.com/JordanMartinez |
| JordanMartinez | https://github.com/JordanMartinez |
| 2c78eb6 | https://github.com/purescript/purescript/commit/2c78eb614cb1f3556737900e57d0e7395158791e |
| Nov 17, 2021 | https://github.com/purescript/purescript/pull/4121#event-5634795295 |
| https://github.com/JordanMartinez |
| JordanMartinez | https://github.com/JordanMartinez |
| November 17, 2021 21:27 | https://github.com/purescript/purescript/pull/4121#event-5634795808 |
| https://github.co/hiddenchars |
| https://github.com/purescript/purescript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript%2Fpurescript%2Fpull%2F4121 |
|
| https://github.com/kl0tl |
|
kl0tl
| https://github.com/kl0tl |
|
| https://github.com/purescript/purescript/pull/4121/files/d548e8788609be85a5ea4c4e9356a200a1cb9d0f |
|
| https://github.com/rhendric |
|
rhendric
| https://github.com/rhendric |
|
| https://github.com/purescript/purescript/pull/4121/files/263d819367091dc1ebc33fee148517ed29c375b3 |
|
| https://github.com/hdgarrood |
|
hdgarrood
| https://github.com/hdgarrood |
|
| https://github.com/purescript/purescript/pull/4121/files/ccbf4edfa74b5acf20475208a1b98a9e20225520 |
| Please reload this page | https://github.com/purescript/purescript/pull/4121 |
|
Include role information in HTML docs
| https://github.com/purescript/purescript/issues/4116 |
| Please reload this page | https://github.com/purescript/purescript/pull/4121 |
|
| https://github.com/JordanMartinez |
|
| https://github.com/MonoidMusician |
|
| https://github.com/rhendric |
|
| https://github.com/kl0tl |
|
| https://github.com/hdgarrood |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |