René's URL Explorer Experiment


Title: Fix CoreFn FromJSON version parsing and add test by paulyoung · Pull Request #3877 · purescript/purescript · GitHub

Open Graph Title: Fix CoreFn FromJSON version parsing and add test by paulyoung · Pull Request #3877 · purescript/purescript

X Title: Fix CoreFn FromJSON version parsing and add test by paulyoung · Pull Request #3877 · purescript/purescript

Description: A strongly-typed language that compiles to JavaScript - Fix CoreFn FromJSON version parsing and add test by paulyoung · Pull Request #3877 · purescript/purescript

Open Graph Description: I noticed that a value of 0.13.6 in corefn.json was being parsed as 0. This fixes that, and adds a test. This bug appears to have been around since #3049, so about 3 years 😎

X Description: I noticed that a value of 0.13.6 in corefn.json was being parsed as 0. This fixes that, and adds a test. This bug appears to have been around since #3049, so about 3 years 😎

Opengraph URL: https://github.com/purescript/purescript/pull/3877

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:00c1f54e-77aa-0986-e2f8-caa5a55dc17d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBDA4:2EDE49:1149507:180B349:6AFC0416
html-safe-nonce76624479da43093527a98d1dcf8ff62c9114936cbd284b4814a8bc02c55aaf29
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCREE0OjJFREU0OToxMTQ5NTA3OjE4MEIzNDk6NkFGQzA0MTYiLCJ2aXNpdG9yX2lkIjoiNDAxNzU0MzA5MzcxOTY2MzYzOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb25c1d63d67c76d34af0ac9bd87c6dc8034bff49271b773c9fa5bb1ce444d76b
hovercard-subject-tagpull_request:419016819
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/purescript/purescript/3877/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/4c18956882fb0a02215ec09010fc82e2218ec3527fba333cf4c10ac3a5d5ca4e/purescript/purescript/pull/3877
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4c18956882fb0a02215ec09010fc82e2218ec3527fba333cf4c10ac3a5d5ca4e/purescript/purescript/pull/3877
og:image:altI noticed that a value of 0.13.6 in corefn.json was being parsed as 0. This fixes that, and adds a test. This bug appears to have been around since #3049, so about 3 years 😎
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepaulyoung
hostnamegithub.com
expected-hostnamegithub.com
Nonefa74413a1d84dac536fcca0740780bcbd3207bafec0e51873b73ff8e8cca032f
turbo-cache-controlno-cache
go-importgithub.com/purescript/purescript git https://github.com/purescript/purescript.git
octolytics-dimension-user_id6556677
octolytics-dimension-user_loginpurescript
octolytics-dimension-repository_id13206906
octolytics-dimension-repository_nwopurescript/purescript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id13206906
octolytics-dimension-repository_network_root_nwopurescript/purescript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb3b5633a74535d9c23385512d534c66c8fde1907
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/purescript/purescript/pull/3877#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript%2Fpurescript%2Fpull%2F3877
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript%2Fpurescript%2Fpull%2F3877
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=purescript%2Fpurescript
Reloadhttps://github.com/purescript/purescript/pull/3877
Reloadhttps://github.com/purescript/purescript/pull/3877
Reloadhttps://github.com/purescript/purescript/pull/3877
purescripthttps://github.com/purescript
purescripthttps://github.com/purescript/purescript
Codehttps://github.com/purescript/purescript
Issues280 (280)https://github.com/purescript/purescript/issues
Pull requests27 (27)https://github.com/purescript/purescript/pulls
Actionshttps://github.com/purescript/purescript/actions
Projectshttps://github.com/purescript/purescript/projects
Wikihttps://github.com/purescript/purescript/wiki
Security and qualityhttps://github.com/purescript/purescript/security
Insightshttps://github.com/purescript/purescript/pulse
https://github.com/purescript/purescript
hdgarroodhttps://github.com/hdgarrood
purescript:masterhttps://github.com/purescript/purescript/tree/master
paulyoung:paulyoung/fix-corefn-version-parsinghttps://github.com/paulyoung/purescript/tree/paulyoung/fix-corefn-version-parsing
Conversationhttps://github.com/purescript/purescript/pull/3877
Commits2 (2)https://github.com/purescript/purescript/pull/3877/commits
Checkshttps://github.com/purescript/purescript/pull/3877/checks
Files changedhttps://github.com/purescript/purescript/pull/3877/files
Fix CoreFn FromJSON version parsing and add testhttps://github.com/purescript/purescript/pull/3877#top
hdgarroodhttps://github.com/hdgarrood
purescript:masterhttps://github.com/purescript/purescript/tree/master
paulyoung:paulyoung/fix-corefn-version-parsinghttps://github.com/paulyoung/purescript/tree/paulyoung/fix-corefn-version-parsing
https://github.com/paulyoung
paulyounghttps://github.com/paulyoung
May 16, 2020https://github.com/purescript/purescript/pull/3877#issue-619546507
#3049https://github.com/purescript/purescript/pull/3049
Please reload this pagehttps://github.com/purescript/purescript/pull/3877
https://github.com/paulyoung
Fix CoreFn version parsing and add testhttps://github.com/purescript/purescript/pull/3877/commits/082ff92d9cd6eeec4797a7fff77f1c2860d2638e
082ff92https://github.com/purescript/purescript/pull/3877/commits/082ff92d9cd6eeec4797a7fff77f1c2860d2638e
https://github.com/paulyoung
paulyounghttps://github.com/paulyoung
May 16, 2020 https://github.com/purescript/purescript/pull/3877#pullrequestreview-413105042
View reviewed changes https://github.com/purescript/purescript/pull/3877/files/082ff92d9cd6eeec4797a7fff77f1c2860d2638e
tests/TestCoreFn.hshttps://github.com/purescript/purescript/pull/3877/files/082ff92d9cd6eeec4797a7fff77f1c2860d2638e#diff-aae152207e87b02ce20d39d1374595d0f0bad85fa9d350f33d1a9c50ee414487
paulyounghttps://github.com/paulyoung
May 16, 2020https://github.com/purescript/purescript/pull/3877#discussion_r426186691
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/purescript/purescript/pull/3877
https://github.com/paulyoung
paulyounghttps://github.com/paulyoung
May 16, 2020https://github.com/purescript/purescript/pull/3877#event-3343916673
https://github.com/kritzcreek
kritzcreekhttps://github.com/kritzcreek
May 17, 2020 https://github.com/purescript/purescript/pull/3877#pullrequestreview-413130525
View reviewed changes https://github.com/purescript/purescript/pull/3877/files/082ff92d9cd6eeec4797a7fff77f1c2860d2638e
kritzcreekhttps://github.com/kritzcreek
https://github.com/purescript/purescript/pull/3877#pullrequestreview-413130525
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/purescript/purescript/pull/3877
src/Language/PureScript/CoreFn/FromJSON.hshttps://github.com/purescript/purescript/pull/3877/files/082ff92d9cd6eeec4797a7fff77f1c2860d2638e#diff-9dc0a73ee6af7a5408bcd0349f10bd3046861254b810bfcb66b88d8a6dd991ca
kritzcreekhttps://github.com/kritzcreek
May 17, 2020https://github.com/purescript/purescript/pull/3877#discussion_r426222276
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/purescript/purescript/pull/3877
paulyounghttps://github.com/paulyoung
May 17, 2020https://github.com/purescript/purescript/pull/3877#discussion_r426266302
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/purescript/purescript/pull/3877
kritzcreekhttps://github.com/kritzcreek
May 17, 2020https://github.com/purescript/purescript/pull/3877#discussion_r426288163
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@hdgarroodhttps://github.com/hdgarrood
Please reload this pagehttps://github.com/purescript/purescript/pull/3877
hdgarroodhttps://github.com/hdgarrood
May 17, 2020https://github.com/purescript/purescript/pull/3877#discussion_r426311118
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/purescript/purescript/pull/3877
kritzcreekhttps://github.com/kritzcreek
May 18, 2020https://github.com/purescript/purescript/pull/3877#discussion_r426382917
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/purescript/purescript/pull/3877
https://github.com/paulyoung
Move parseVersion' to CoreFn.FromJSON modulehttps://github.com/purescript/purescript/pull/3877/commits/ef275187a699860f2a22b5a4bb2e21965000fc90
ef27518https://github.com/purescript/purescript/pull/3877/commits/ef275187a699860f2a22b5a4bb2e21965000fc90
https://github.com/kritzcreek
kritzcreekhttps://github.com/kritzcreek
May 18, 2020 https://github.com/purescript/purescript/pull/3877#pullrequestreview-413304300
View reviewed changes https://github.com/purescript/purescript/pull/3877/files/ef275187a699860f2a22b5a4bb2e21965000fc90
https://github.com/hdgarrood
hdgarroodhttps://github.com/hdgarrood
1b91bdahttps://github.com/purescript/purescript/commit/1b91bda780d8d80906adb16a9d63472718cec1c0
May 18, 2020https://github.com/purescript/purescript/pull/3877#event-3347582115
https://github.com/hdgarrood
hdgarroodhttps://github.com/hdgarrood
May 18, 2020https://github.com/purescript/purescript/pull/3877#issuecomment-630216275
Please reload this pagehttps://github.com/purescript/purescript/pull/3877
https://github.com/paulyoung
paulyounghttps://github.com/paulyoung
May 18, 2020 15:03https://github.com/purescript/purescript/pull/3877#event-3347778199
https://github.com/hdgarrood
hdgarroodhttps://github.com/hdgarrood
May 23, 2020 https://github.com/purescript/purescript/pull/3877#ref-issue-623566093
0.13.7 #3886 https://github.com/purescript/purescript/issues/3886
hdgarroodhttps://github.com/hdgarrood
May 23, 2020 https://github.com/purescript/purescript/pull/3877#ref-commit-47eebec
https://github.com/paulyoung
https://github.com/hdgarrood
Fix CoreFn FromJSON version parsing and add test (https://github.com/purescript/purescript/commit/47eebec10728ec9a08892e3a3b09632ece7bb982
#3877https://github.com/purescript/purescript/pull/3877
)https://github.com/purescript/purescript/commit/47eebec10728ec9a08892e3a3b09632ece7bb982
47eebechttps://github.com/purescript/purescript/commit/47eebec10728ec9a08892e3a3b09632ece7bb982
https://github.com/JordanMartinez
JordanMartinezhttps://github.com/JordanMartinez
Jan 18, 2022 https://github.com/purescript/purescript/pull/3877#ref-pullrequest-1107319816
Update version to v0.15.0 working-group-purescript-es/purescript#4 https://github.com/working-group-purescript-es/purescript/pull/4
https://github.co/hiddenchars
https://github.com/purescript/purescript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript%2Fpurescript%2Fpull%2F3877
https://github.com/kritzcreek
kritzcreek https://github.com/kritzcreek
https://github.com/purescript/purescript/pull/3877/files/ef275187a699860f2a22b5a4bb2e21965000fc90
https://github.com/hdgarrood
hdgarrood https://github.com/hdgarrood
https://github.com/purescript/purescript/pull/3877/files/082ff92d9cd6eeec4797a7fff77f1c2860d2638e
Please reload this pagehttps://github.com/purescript/purescript/pull/3877
Please reload this pagehttps://github.com/purescript/purescript/pull/3877
https://github.com/paulyoung
https://github.com/hdgarrood
https://github.com/kritzcreek
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.