René's URL Explorer Experiment


Title: Check role declarations against inferred roles by hdgarrood · Pull Request #3873 · purescript/purescript · GitHub

Open Graph Title: Check role declarations against inferred roles by hdgarrood · Pull Request #3873 · purescript/purescript

X Title: Check role declarations against inferred roles by hdgarrood · Pull Request #3873 · purescript/purescript

Description: A strongly-typed language that compiles to JavaScript - Check role declarations against inferred roles by hdgarrood · Pull Request #3873 · purescript/purescript

Open Graph Description: Fixes #3867. The main change here is that we are now storing checked roles in the types field of the Environment for data and foreign import data declarations, via the additions to the TypeKind typ...

X Description: Fixes #3867. The main change here is that we are now storing checked roles in the types field of the Environment for data and foreign import data declarations, via the additions to the TypeKind typ...

Opengraph URL: https://github.com/purescript/purescript/pull/3873

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a0da7f5a-cf73-b986-9e23-7232ad6f1782
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB9F2:117C62:29A5A6:38D5FB:6B00C366
html-safe-nonceb55c7d74de2e3c550f76e5915209f8b8376ab6ca1de98202305fcf320f9fea1c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOUYyOjExN0M2MjoyOUE1QTY6MzhENUZCOjZCMDBDMzY2IiwidmlzaXRvcl9pZCI6IjEwMTY4OTQ1NDA2MDg0ODgyOTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacfd4e2015f020727fd2dde9fe71ebac378567497f5e343d936a69db4c5f29c010
hovercard-subject-tagpull_request:417630194
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/purescript/purescript/3873/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d8daf2647c9ec598803108782ece17c6481cff141dcac952365d0751e36ae3e6/purescript/purescript/pull/3873
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d8daf2647c9ec598803108782ece17c6481cff141dcac952365d0751e36ae3e6/purescript/purescript/pull/3873
og:image:altFixes #3867. The main change here is that we are now storing checked roles in the types field of the Environment for data and foreign import data declarations, via the additions to the TypeKind typ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamehdgarrood
hostnamegithub.com
expected-hostnamegithub.com
None93edd3bebc4afb7ce711ee74cb5d2a95927850b082a4d43e212222389cb1c415
turbo-cache-controlno-cache
go-importgithub.com/purescript/purescript git https://github.com/purescript/purescript.git
octolytics-dimension-user_id6556677
octolytics-dimension-user_loginpurescript
octolytics-dimension-repository_id13206906
octolytics-dimension-repository_nwopurescript/purescript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id13206906
octolytics-dimension-repository_network_root_nwopurescript/purescript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release1fee81a280ea86312b69448e261b418189bfd5b5
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/purescript/purescript/pull/3873#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript%2Fpurescript%2Fpull%2F3873
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript%2Fpurescript%2Fpull%2F3873
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=purescript%2Fpurescript
Reloadhttps://github.com/purescript/purescript/pull/3873
Reloadhttps://github.com/purescript/purescript/pull/3873
Reloadhttps://github.com/purescript/purescript/pull/3873
purescripthttps://github.com/purescript
purescripthttps://github.com/purescript/purescript
Codehttps://github.com/purescript/purescript
Issues280 (280)https://github.com/purescript/purescript/issues
Pull requests28 (28)https://github.com/purescript/purescript/pulls
Actionshttps://github.com/purescript/purescript/actions
Projectshttps://github.com/purescript/purescript/projects
Wikihttps://github.com/purescript/purescript/wiki
Security and qualityhttps://github.com/purescript/purescript/security
Insightshttps://github.com/purescript/purescript/insights
https://github.com/purescript/purescript
hdgarroodhttps://github.com/hdgarrood
purescript:masterhttps://github.com/purescript/purescript/tree/master
hdgarrood:check-role-annotationshttps://github.com/hdgarrood/purescript/tree/check-role-annotations
Conversationhttps://github.com/purescript/purescript/pull/3873
Commits9 (9)https://github.com/purescript/purescript/pull/3873/commits
Checkshttps://github.com/purescript/purescript/pull/3873/checks
Files changedhttps://github.com/purescript/purescript/pull/3873/files
Check role declarations against inferred roleshttps://github.com/purescript/purescript/pull/3873#top
hdgarroodhttps://github.com/hdgarrood
purescript:masterhttps://github.com/purescript/purescript/tree/master
hdgarrood:check-role-annotationshttps://github.com/hdgarrood/purescript/tree/check-role-annotations
https://github.com/hdgarrood
hdgarroodhttps://github.com/hdgarrood
May 13, 2020https://github.com/purescript/purescript/pull/3873#issue-617775544
#3867https://github.com/purescript/purescript/issues/3867
Please reload this pagehttps://github.com/purescript/purescript/pull/3873
https://github.com/hdgarrood
Check role declarations against inferred roleshttps://github.com/purescript/purescript/pull/3873/commits/96a048dd40dc5323b874c7c4bd897d165229b239
96a048dhttps://github.com/purescript/purescript/pull/3873/commits/96a048dd40dc5323b874c7c4bd897d165229b239
purescript#3867https://github.com/purescript/purescript/issues/3867
https://github.com/hdgarrood
hdgarroodhttps://github.com/hdgarrood
natefaubionhttps://github.com/natefaubion
May 13, 2020 21:46https://github.com/purescript/purescript/pull/3873#event-3334028877
https://github.com/hdgarrood
hdgarroodhttps://github.com/hdgarrood
May 13, 2020https://github.com/purescript/purescript/pull/3873#issuecomment-628264347
@kl0tlhttps://github.com/kl0tl
Please reload this pagehttps://github.com/purescript/purescript/pull/3873
https://github.com/hdgarrood
hdgarroodhttps://github.com/hdgarrood
May 13, 2020https://github.com/purescript/purescript/pull/3873#issuecomment-628268549
Please reload this pagehttps://github.com/purescript/purescript/pull/3873
https://github.com/hdgarrood
Fix warningshttps://github.com/purescript/purescript/pull/3873/commits/38dbf65db6c2720449571baaa654cedaae4cc2d6
38dbf65https://github.com/purescript/purescript/pull/3873/commits/38dbf65db6c2720449571baaa654cedaae4cc2d6
https://github.com/kl0tl
kl0tlhttps://github.com/kl0tl
May 14, 2020 https://github.com/purescript/purescript/pull/3873#pullrequestreview-412002856
View reviewed changes https://github.com/purescript/purescript/pull/3873/files/38dbf65db6c2720449571baaa654cedaae4cc2d6
kl0tlhttps://github.com/kl0tl
https://github.com/purescript/purescript/pull/3873#pullrequestreview-412002856
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/purescript/purescript/pull/3873
src/Language/PureScript/Errors.hshttps://github.com/purescript/purescript/pull/3873/files/38dbf65db6c2720449571baaa654cedaae4cc2d6#diff-11e3ee9ff014e25b38a3dfdaa1fa18c8d0ca9dab1860d355abad0034978ea04c
Please reload this pagehttps://github.com/purescript/purescript/pull/3873
src/Language/PureScript/TypeChecker.hshttps://github.com/purescript/purescript/pull/3873/files/38dbf65db6c2720449571baaa654cedaae4cc2d6#diff-face7661808c8804ee47e10a0fd05d5ffc7ddebbef1acccffb5463633e08ae7f
Please reload this pagehttps://github.com/purescript/purescript/pull/3873
lib/purescript-ast/src/Language/PureScript/Environment.hshttps://github.com/purescript/purescript/pull/3873/files/38dbf65db6c2720449571baaa654cedaae4cc2d6#diff-e21f83bdc81029e92564dcc5b1a3301d48d6c6bcb78603dc73bf8696dc91a3d9
Please reload this pagehttps://github.com/purescript/purescript/pull/3873
https://github.com/hdgarrood
hdgarroodhttps://github.com/hdgarrood
May 14, 2020https://github.com/purescript/purescript/pull/3873#issuecomment-628817557
Please reload this pagehttps://github.com/purescript/purescript/pull/3873
hdgarroodhttps://github.com/hdgarrood
May 14, 2020 21:03https://github.com/purescript/purescript/pull/3873#commits-pushed-87346f7
https://github.com/hdgarrood
Update error message as suggested in code reviewhttps://github.com/purescript/purescript/pull/3873/commits/87346f70be2152e7e1211106fb306dabc05edd21
87346f7https://github.com/purescript/purescript/pull/3873/commits/87346f70be2152e7e1211106fb306dabc05edd21
https://github.com/hdgarrood
Code review: use withRoleshttps://github.com/purescript/purescript/pull/3873/commits/fdf8c1fa3e982de46041fa10df71d117e548d094
fdf8c1fhttps://github.com/purescript/purescript/pull/3873/commits/fdf8c1fa3e982de46041fa10df71d117e548d094
https://github.com/hdgarrood
Use Nominal role for Prim.TypeError classeshttps://github.com/purescript/purescript/pull/3873/commits/e2ae86c931962f4830bbafe1af26b424dca8e921
e2ae86chttps://github.com/purescript/purescript/pull/3873/commits/e2ae86c931962f4830bbafe1af26b424dca8e921
https://github.com/kl0tl
kl0tlhttps://github.com/kl0tl
May 14, 2020https://github.com/purescript/purescript/pull/3873#issuecomment-628869137
Please reload this pagehttps://github.com/purescript/purescript/pull/3873
https://github.com/hdgarrood
hdgarroodhttps://github.com/hdgarrood
May 14, 2020https://github.com/purescript/purescript/pull/3873#issuecomment-628888746
Please reload this pagehttps://github.com/purescript/purescript/pull/3873
https://github.com/kl0tl
kl0tlhttps://github.com/kl0tl
May 16, 2020 https://github.com/purescript/purescript/pull/3873#ref-pullrequest-610849534
Check roles of mutually recursive types #3860 https://github.com/purescript/purescript/pull/3860
https://github.com/kl0tl
kl0tlhttps://github.com/kl0tl
May 16, 2020 https://github.com/purescript/purescript/pull/3873#pullrequestreview-413083121
View reviewed changes https://github.com/purescript/purescript/pull/3873/files/e2ae86c931962f4830bbafe1af26b424dca8e921
tests/purs/failing/CoercibleRoleMismatch1.purshttps://github.com/purescript/purescript/pull/3873/files/e2ae86c931962f4830bbafe1af26b424dca8e921#diff-c30fdc4c6207270a95d3742695478d6ec3517d7fc8c23c72d673ff132f5bc008
Please reload this pagehttps://github.com/purescript/purescript/pull/3873
https://github.com/kl0tl
kl0tlhttps://github.com/kl0tl
May 16, 2020https://github.com/purescript/purescript/pull/3873#issuecomment-629660064
Please reload this pagehttps://github.com/purescript/purescript/pull/3873
https://github.com/kl0tl
kl0tlhttps://github.com/kl0tl
May 18, 2020 https://github.com/purescript/purescript/pull/3873#ref-issue-615480666
Role inference doesn't account for constrained types #3868 https://github.com/purescript/purescript/issues/3868
hdgarroodhttps://github.com/hdgarrood
May 20, 2020 00:33https://github.com/purescript/purescript/pull/3873#commits-pushed-4aaa9d4
https://github.com/hdgarrood
Remove unnecessary importhttps://github.com/purescript/purescript/pull/3873/commits/4aaa9d4e7d801d8141b4e7871fb8947552165418
4aaa9d4https://github.com/purescript/purescript/pull/3873/commits/4aaa9d4e7d801d8141b4e7871fb8947552165418
https://github.com/hdgarrood
Fix golden testhttps://github.com/purescript/purescript/pull/3873/commits/36c3ea747df138151193a29c1309006ac90846b2
36c3ea7https://github.com/purescript/purescript/pull/3873/commits/36c3ea747df138151193a29c1309006ac90846b2
https://github.com/hdgarrood
hdgarroodhttps://github.com/hdgarrood
May 24, 2020 https://github.com/purescript/purescript/pull/3873#ref-pullrequest-619568788
Solve Coercible constraints on rows #3878 https://github.com/purescript/purescript/pull/3878
https://github.com/kl0tl
kl0tlhttps://github.com/kl0tl
Jun 1, 2020 https://github.com/purescript/purescript/pull/3873#pullrequestreview-421878069
View reviewed changes https://github.com/purescript/purescript/pull/3873/files/36c3ea747df138151193a29c1309006ac90846b2
lib/purescript-ast/src/Language/PureScript/Environment.hshttps://github.com/purescript/purescript/pull/3873/files/36c3ea747df138151193a29c1309006ac90846b2#diff-e21f83bdc81029e92564dcc5b1a3301d48d6c6bcb78603dc73bf8696dc91a3d9
kl0tlhttps://github.com/kl0tl
Jun 1, 2020https://github.com/purescript/purescript/pull/3873#discussion_r433258903
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/purescript/purescript/pull/3873
hdgarroodhttps://github.com/hdgarrood
Jun 3, 2020https://github.com/purescript/purescript/pull/3873#discussion_r434820059
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/purescript/purescript/pull/3873
https://github.com/natefaubion
natefaubionhttps://github.com/natefaubion
Jun 25, 2020 https://github.com/purescript/purescript/pull/3873#pullrequestreview-437649521
View reviewed changes https://github.com/purescript/purescript/pull/3873/files/36c3ea747df138151193a29c1309006ac90846b2
hdgarroodhttps://github.com/hdgarrood
June 25, 2020 17:23https://github.com/purescript/purescript/pull/3873#commits-pushed-519a4f1
https://github.com/hdgarrood
Merge branch 'master' into check-role-annotationshttps://github.com/purescript/purescript/pull/3873/commits/519a4f172394f57f95680ef7829a0e81047ad602
519a4f1https://github.com/purescript/purescript/pull/3873/commits/519a4f172394f57f95680ef7829a0e81047ad602
https://github.com/hdgarrood
Move nominalRolesForKind to Environment.hshttps://github.com/purescript/purescript/pull/3873/commits/d3163cd32eaccb83005f8238e8d33124ceb825f1
d3163cdhttps://github.com/purescript/purescript/pull/3873/commits/d3163cd32eaccb83005f8238e8d33124ceb825f1
https://github.com/hdgarrood
hdgarroodhttps://github.com/hdgarrood
Jun 25, 2020https://github.com/purescript/purescript/pull/3873#issuecomment-649727215
@natefaubionhttps://github.com/natefaubion
@kl0tlhttps://github.com/kl0tl
Please reload this pagehttps://github.com/purescript/purescript/pull/3873
https://github.com/hdgarrood
hdgarroodhttps://github.com/hdgarrood
a7a3f83https://github.com/purescript/purescript/commit/a7a3f83cdea63dfcf8dba0da2f26131aaab5ac51
Jun 25, 2020https://github.com/purescript/purescript/pull/3873#event-3483480531
https://github.com/hdgarrood
hdgarroodhttps://github.com/hdgarrood
June 25, 2020 17:47https://github.com/purescript/purescript/pull/3873#event-3483480756
https://github.com/kl0tl
kl0tlhttps://github.com/kl0tl
Sep 13, 2020 https://github.com/purescript/purescript/pull/3873#ref-pullrequest-700564040
Document roles and Coercible related errors purescript/documentation#352 https://github.com/purescript/documentation/pull/352
https://github.com/JordanMartinez
JordanMartinezhttps://github.com/JordanMartinez
Jan 18, 2022 https://github.com/purescript/purescript/pull/3873#ref-pullrequest-1107319816
Update version to v0.15.0 working-group-purescript-es/purescript#4 https://github.com/working-group-purescript-es/purescript/pull/4
https://github.co/hiddenchars
https://github.com/purescript/purescript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript%2Fpurescript%2Fpull%2F3873
https://github.com/kl0tl
kl0tl https://github.com/kl0tl
https://github.com/purescript/purescript/pull/3873/files/36c3ea747df138151193a29c1309006ac90846b2
https://github.com/natefaubion
natefaubion https://github.com/natefaubion
https://github.com/purescript/purescript/pull/3873/files/36c3ea747df138151193a29c1309006ac90846b2
Please reload this pagehttps://github.com/purescript/purescript/pull/3873
Explicit roles may be more permissive than inferred https://github.com/purescript/purescript/issues/3867
Please reload this pagehttps://github.com/purescript/purescript/pull/3873
https://github.com/hdgarrood
https://github.com/kl0tl
https://github.com/natefaubion
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.