| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:a0da7f5a-cf73-b986-9e23-7232ad6f1782 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B9F2:117C62:29A5A6:38D5FB:6B00C366 |
| html-safe-nonce | b55c7d74de2e3c550f76e5915209f8b8376ab6ca1de98202305fcf320f9fea1c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOUYyOjExN0M2MjoyOUE1QTY6MzhENUZCOjZCMDBDMzY2IiwidmlzaXRvcl9pZCI6IjEwMTY4OTQ1NDA2MDg0ODgyOTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | fd4e2015f020727fd2dde9fe71ebac378567497f5e343d936a69db4c5f29c010 |
| hovercard-subject-tag | pull_request:417630194 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/purescript/purescript/3873/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/d8daf2647c9ec598803108782ece17c6481cff141dcac952365d0751e36ae3e6/purescript/purescript/pull/3873 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d8daf2647c9ec598803108782ece17c6481cff141dcac952365d0751e36ae3e6/purescript/purescript/pull/3873 |
| og:image:alt | Fixes #3867. The main change here is that we are now storing checked
roles in the types field of the Environment for data and
foreign import data declarations, via the additions to the TypeKind
typ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | hdgarrood |
| hostname | github.com |
| expected-hostname | github.com |
| None | 93edd3bebc4afb7ce711ee74cb5d2a95927850b082a4d43e212222389cb1c415 |
| turbo-cache-control | no-cache |
| go-import | github.com/purescript/purescript git https://github.com/purescript/purescript.git |
| octolytics-dimension-user_id | 6556677 |
| octolytics-dimension-user_login | purescript |
| octolytics-dimension-repository_id | 13206906 |
| octolytics-dimension-repository_nwo | purescript/purescript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 13206906 |
| octolytics-dimension-repository_network_root_nwo | purescript/purescript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 1fee81a280ea86312b69448e261b418189bfd5b5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/purescript/purescript/pull/3873#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript%2Fpurescript%2Fpull%2F3873 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript%2Fpurescript%2Fpull%2F3873 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=purescript%2Fpurescript |
| Reload | https://github.com/purescript/purescript/pull/3873 |
| Reload | https://github.com/purescript/purescript/pull/3873 |
| Reload | https://github.com/purescript/purescript/pull/3873 |
| purescript | https://github.com/purescript |
| purescript | https://github.com/purescript/purescript |
| Code | https://github.com/purescript/purescript |
| Issues280 (280) | https://github.com/purescript/purescript/issues |
| Pull requests28 (28) | https://github.com/purescript/purescript/pulls |
| Actions | https://github.com/purescript/purescript/actions |
| Projects | https://github.com/purescript/purescript/projects |
| Wiki | https://github.com/purescript/purescript/wiki |
| Security and quality | https://github.com/purescript/purescript/security |
| Insights | https://github.com/purescript/purescript/insights |
| https://github.com/purescript/purescript |
| hdgarrood | https://github.com/hdgarrood |
| purescript:master | https://github.com/purescript/purescript/tree/master |
| hdgarrood:check-role-annotations | https://github.com/hdgarrood/purescript/tree/check-role-annotations |
| Conversation | https://github.com/purescript/purescript/pull/3873 |
| Commits9 (9) | https://github.com/purescript/purescript/pull/3873/commits |
| Checks | https://github.com/purescript/purescript/pull/3873/checks |
| Files changed | https://github.com/purescript/purescript/pull/3873/files |
| Check role declarations against inferred roles | https://github.com/purescript/purescript/pull/3873#top |
| hdgarrood | https://github.com/hdgarrood |
| purescript:master | https://github.com/purescript/purescript/tree/master |
| hdgarrood:check-role-annotations | https://github.com/hdgarrood/purescript/tree/check-role-annotations |
|
| https://github.com/hdgarrood |
| hdgarrood | https://github.com/hdgarrood |
| May 13, 2020 | https://github.com/purescript/purescript/pull/3873#issue-617775544 |
| #3867 | https://github.com/purescript/purescript/issues/3867 |
| Please reload this page | https://github.com/purescript/purescript/pull/3873 |
|
| https://github.com/hdgarrood |
| Check role declarations against inferred roles | https://github.com/purescript/purescript/pull/3873/commits/96a048dd40dc5323b874c7c4bd897d165229b239 |
| 96a048d | https://github.com/purescript/purescript/pull/3873/commits/96a048dd40dc5323b874c7c4bd897d165229b239 |
| purescript#3867 | https://github.com/purescript/purescript/issues/3867 |
| https://github.com/hdgarrood |
| hdgarrood | https://github.com/hdgarrood |
| natefaubion | https://github.com/natefaubion |
| May 13, 2020 21:46 | https://github.com/purescript/purescript/pull/3873#event-3334028877 |
| https://github.com/hdgarrood |
| hdgarrood | https://github.com/hdgarrood |
| May 13, 2020 | https://github.com/purescript/purescript/pull/3873#issuecomment-628264347 |
| @kl0tl | https://github.com/kl0tl |
| Please reload this page | https://github.com/purescript/purescript/pull/3873 |
| https://github.com/hdgarrood |
| hdgarrood | https://github.com/hdgarrood |
| May 13, 2020 | https://github.com/purescript/purescript/pull/3873#issuecomment-628268549 |
| Please reload this page | https://github.com/purescript/purescript/pull/3873 |
|
| https://github.com/hdgarrood |
| Fix warnings | https://github.com/purescript/purescript/pull/3873/commits/38dbf65db6c2720449571baaa654cedaae4cc2d6 |
| 38dbf65 | https://github.com/purescript/purescript/pull/3873/commits/38dbf65db6c2720449571baaa654cedaae4cc2d6 |
| https://github.com/kl0tl |
| kl0tl | https://github.com/kl0tl |
|
May 14, 2020
| https://github.com/purescript/purescript/pull/3873#pullrequestreview-412002856 |
|
View reviewed changes
| https://github.com/purescript/purescript/pull/3873/files/38dbf65db6c2720449571baaa654cedaae4cc2d6 |
| kl0tl | https://github.com/kl0tl |
| https://github.com/purescript/purescript/pull/3873#pullrequestreview-412002856 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/purescript/purescript/pull/3873 |
| src/Language/PureScript/Errors.hs | https://github.com/purescript/purescript/pull/3873/files/38dbf65db6c2720449571baaa654cedaae4cc2d6#diff-11e3ee9ff014e25b38a3dfdaa1fa18c8d0ca9dab1860d355abad0034978ea04c |
| Please reload this page | https://github.com/purescript/purescript/pull/3873 |
| src/Language/PureScript/TypeChecker.hs | https://github.com/purescript/purescript/pull/3873/files/38dbf65db6c2720449571baaa654cedaae4cc2d6#diff-face7661808c8804ee47e10a0fd05d5ffc7ddebbef1acccffb5463633e08ae7f |
| Please reload this page | https://github.com/purescript/purescript/pull/3873 |
| lib/purescript-ast/src/Language/PureScript/Environment.hs | https://github.com/purescript/purescript/pull/3873/files/38dbf65db6c2720449571baaa654cedaae4cc2d6#diff-e21f83bdc81029e92564dcc5b1a3301d48d6c6bcb78603dc73bf8696dc91a3d9 |
| Please reload this page | https://github.com/purescript/purescript/pull/3873 |
| https://github.com/hdgarrood |
| hdgarrood | https://github.com/hdgarrood |
| May 14, 2020 | https://github.com/purescript/purescript/pull/3873#issuecomment-628817557 |
| Please reload this page | https://github.com/purescript/purescript/pull/3873 |
| hdgarrood | https://github.com/hdgarrood |
| May 14, 2020 21:03 | https://github.com/purescript/purescript/pull/3873#commits-pushed-87346f7 |
|
| https://github.com/hdgarrood |
| Update error message as suggested in code review | https://github.com/purescript/purescript/pull/3873/commits/87346f70be2152e7e1211106fb306dabc05edd21 |
| 87346f7 | https://github.com/purescript/purescript/pull/3873/commits/87346f70be2152e7e1211106fb306dabc05edd21 |
|
| https://github.com/hdgarrood |
| Code review: use withRoles | https://github.com/purescript/purescript/pull/3873/commits/fdf8c1fa3e982de46041fa10df71d117e548d094 |
| fdf8c1f | https://github.com/purescript/purescript/pull/3873/commits/fdf8c1fa3e982de46041fa10df71d117e548d094 |
|
| https://github.com/hdgarrood |
| Use Nominal role for Prim.TypeError classes | https://github.com/purescript/purescript/pull/3873/commits/e2ae86c931962f4830bbafe1af26b424dca8e921 |
| e2ae86c | https://github.com/purescript/purescript/pull/3873/commits/e2ae86c931962f4830bbafe1af26b424dca8e921 |
| https://github.com/kl0tl |
| kl0tl | https://github.com/kl0tl |
| May 14, 2020 | https://github.com/purescript/purescript/pull/3873#issuecomment-628869137 |
| Please reload this page | https://github.com/purescript/purescript/pull/3873 |
| https://github.com/hdgarrood |
| hdgarrood | https://github.com/hdgarrood |
| May 14, 2020 | https://github.com/purescript/purescript/pull/3873#issuecomment-628888746 |
| Please reload this page | https://github.com/purescript/purescript/pull/3873 |
| https://github.com/kl0tl |
| kl0tl | https://github.com/kl0tl |
|
May 16, 2020
| https://github.com/purescript/purescript/pull/3873#ref-pullrequest-610849534 |
|
Check roles of mutually recursive types
#3860
| https://github.com/purescript/purescript/pull/3860 |
| https://github.com/kl0tl |
| kl0tl | https://github.com/kl0tl |
|
May 16, 2020
| https://github.com/purescript/purescript/pull/3873#pullrequestreview-413083121 |
|
View reviewed changes
| https://github.com/purescript/purescript/pull/3873/files/e2ae86c931962f4830bbafe1af26b424dca8e921 |
| tests/purs/failing/CoercibleRoleMismatch1.purs | https://github.com/purescript/purescript/pull/3873/files/e2ae86c931962f4830bbafe1af26b424dca8e921#diff-c30fdc4c6207270a95d3742695478d6ec3517d7fc8c23c72d673ff132f5bc008 |
| Please reload this page | https://github.com/purescript/purescript/pull/3873 |
| https://github.com/kl0tl |
| kl0tl | https://github.com/kl0tl |
| May 16, 2020 | https://github.com/purescript/purescript/pull/3873#issuecomment-629660064 |
| Please reload this page | https://github.com/purescript/purescript/pull/3873 |
| https://github.com/kl0tl |
| kl0tl | https://github.com/kl0tl |
|
May 18, 2020
| https://github.com/purescript/purescript/pull/3873#ref-issue-615480666 |
|
Role inference doesn't account for constrained types
#3868
| https://github.com/purescript/purescript/issues/3868 |
| hdgarrood | https://github.com/hdgarrood |
| May 20, 2020 00:33 | https://github.com/purescript/purescript/pull/3873#commits-pushed-4aaa9d4 |
|
| https://github.com/hdgarrood |
| Remove unnecessary import | https://github.com/purescript/purescript/pull/3873/commits/4aaa9d4e7d801d8141b4e7871fb8947552165418 |
| 4aaa9d4 | https://github.com/purescript/purescript/pull/3873/commits/4aaa9d4e7d801d8141b4e7871fb8947552165418 |
|
| https://github.com/hdgarrood |
| Fix golden test | https://github.com/purescript/purescript/pull/3873/commits/36c3ea747df138151193a29c1309006ac90846b2 |
| 36c3ea7 | https://github.com/purescript/purescript/pull/3873/commits/36c3ea747df138151193a29c1309006ac90846b2 |
| https://github.com/hdgarrood |
| hdgarrood | https://github.com/hdgarrood |
|
May 24, 2020
| https://github.com/purescript/purescript/pull/3873#ref-pullrequest-619568788 |
|
Solve Coercible constraints on rows
#3878
| https://github.com/purescript/purescript/pull/3878 |
| https://github.com/kl0tl |
| kl0tl | https://github.com/kl0tl |
|
Jun 1, 2020
| https://github.com/purescript/purescript/pull/3873#pullrequestreview-421878069 |
|
View reviewed changes
| https://github.com/purescript/purescript/pull/3873/files/36c3ea747df138151193a29c1309006ac90846b2 |
| lib/purescript-ast/src/Language/PureScript/Environment.hs | https://github.com/purescript/purescript/pull/3873/files/36c3ea747df138151193a29c1309006ac90846b2#diff-e21f83bdc81029e92564dcc5b1a3301d48d6c6bcb78603dc73bf8696dc91a3d9 |
| kl0tl | https://github.com/kl0tl |
| Jun 1, 2020 | https://github.com/purescript/purescript/pull/3873#discussion_r433258903 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/purescript/purescript/pull/3873 |
| hdgarrood | https://github.com/hdgarrood |
| Jun 3, 2020 | https://github.com/purescript/purescript/pull/3873#discussion_r434820059 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/purescript/purescript/pull/3873 |
| https://github.com/natefaubion |
| natefaubion | https://github.com/natefaubion |
|
Jun 25, 2020
| https://github.com/purescript/purescript/pull/3873#pullrequestreview-437649521 |
|
View reviewed changes
| https://github.com/purescript/purescript/pull/3873/files/36c3ea747df138151193a29c1309006ac90846b2 |
| hdgarrood | https://github.com/hdgarrood |
| June 25, 2020 17:23 | https://github.com/purescript/purescript/pull/3873#commits-pushed-519a4f1 |
|
| https://github.com/hdgarrood |
| Merge branch 'master' into check-role-annotations | https://github.com/purescript/purescript/pull/3873/commits/519a4f172394f57f95680ef7829a0e81047ad602 |
| 519a4f1 | https://github.com/purescript/purescript/pull/3873/commits/519a4f172394f57f95680ef7829a0e81047ad602 |
|
| https://github.com/hdgarrood |
| Move nominalRolesForKind to Environment.hs | https://github.com/purescript/purescript/pull/3873/commits/d3163cd32eaccb83005f8238e8d33124ceb825f1 |
| d3163cd | https://github.com/purescript/purescript/pull/3873/commits/d3163cd32eaccb83005f8238e8d33124ceb825f1 |
| https://github.com/hdgarrood |
| hdgarrood | https://github.com/hdgarrood |
| Jun 25, 2020 | https://github.com/purescript/purescript/pull/3873#issuecomment-649727215 |
| @natefaubion | https://github.com/natefaubion |
| @kl0tl | https://github.com/kl0tl |
| Please reload this page | https://github.com/purescript/purescript/pull/3873 |
| https://github.com/hdgarrood |
| hdgarrood | https://github.com/hdgarrood |
| a7a3f83 | https://github.com/purescript/purescript/commit/a7a3f83cdea63dfcf8dba0da2f26131aaab5ac51 |
| Jun 25, 2020 | https://github.com/purescript/purescript/pull/3873#event-3483480531 |
| https://github.com/hdgarrood |
| hdgarrood | https://github.com/hdgarrood |
| June 25, 2020 17:47 | https://github.com/purescript/purescript/pull/3873#event-3483480756 |
| https://github.com/kl0tl |
| kl0tl | https://github.com/kl0tl |
|
Sep 13, 2020
| https://github.com/purescript/purescript/pull/3873#ref-pullrequest-700564040 |
|
Document roles and Coercible related errors
purescript/documentation#352
| https://github.com/purescript/documentation/pull/352 |
| https://github.com/JordanMartinez |
| JordanMartinez | https://github.com/JordanMartinez |
|
Jan 18, 2022
| https://github.com/purescript/purescript/pull/3873#ref-pullrequest-1107319816 |
|
Update version to v0.15.0
working-group-purescript-es/purescript#4
| https://github.com/working-group-purescript-es/purescript/pull/4 |
| https://github.co/hiddenchars |
| https://github.com/purescript/purescript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpurescript%2Fpurescript%2Fpull%2F3873 |
|
| https://github.com/kl0tl |
|
kl0tl
| https://github.com/kl0tl |
|
| https://github.com/purescript/purescript/pull/3873/files/36c3ea747df138151193a29c1309006ac90846b2 |
|
| https://github.com/natefaubion |
|
natefaubion
| https://github.com/natefaubion |
|
| https://github.com/purescript/purescript/pull/3873/files/36c3ea747df138151193a29c1309006ac90846b2 |
| Please reload this page | https://github.com/purescript/purescript/pull/3873 |
|
Explicit roles may be more permissive than inferred
| https://github.com/purescript/purescript/issues/3867 |
| Please reload this page | https://github.com/purescript/purescript/pull/3873 |
|
| https://github.com/hdgarrood |
|
| https://github.com/kl0tl |
|
| https://github.com/natefaubion |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |