Title: Add AAAS journals to subplot command by bradyrx · Pull Request #30 · proplot-dev/proplot · GitHub
Open Graph Title: Add AAAS journals to subplot command by bradyrx · Pull Request #30 · proplot-dev/proplot
X Title: Add AAAS journals to subplot command by bradyrx · Pull Request #30 · proplot-dev/proplot
Description: @lukelbd, this PR adds the AAAS journal specs to the proplot.subplots() command. It also has a few minor fixes: Move the journal specs table to the header and change name to JOURNAL_SPECS following PEP (https://www.python.org/dev/peps/pep-0008/#constants). Fix try/except clause in subplots() that was causing certain journal specs to break. Add pytest for all journal specs as a template for future testing. Update changelog and add capability in docs to link from changelog to PR/issue threads. This is a great simple example of pytest's power. I created the test then ran pytest and found consistent errors in certain subsets of the dictionary (TypeError vs. ValueError). Once you get pytest implemented into Travis CI, this will run automatically on PRs and then you have no risk of importing broken code. At least broken journal spec code for now.
Open Graph Description: @lukelbd, this PR adds the AAAS journal specs to the proplot.subplots() command. It also has a few minor fixes: Move the journal specs table to the header and change name to JOURNAL_SPECS followin...
X Description: @lukelbd, this PR adds the AAAS journal specs to the proplot.subplots() command. It also has a few minor fixes: Move the journal specs table to the header and change name to JOURNAL_SPECS followin...
Opengraph URL: https://github.com/proplot-dev/proplot/pull/30
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:b889addf-86e8-2480-c7c1-787040d07956 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8834:F140:643A2D:8A015E:697C7364 |
| html-safe-nonce | 482864e005dea6cf987bb17eac14eac2fe61cd6f25f56af721d14bdef80ab3b5 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4ODM0OkYxNDA6NjQzQTJEOjhBMDE1RTo2OTdDNzM2NCIsInZpc2l0b3JfaWQiOiIyMzE3ODI2Mjc4OTc2OTQyOTQ4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | d1d1fcfb9423267c111cfce93a09f4ae76df1d23c0a64079a03557cd62f43b5e |
| hovercard-subject-tag | pull_request:314251296 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/proplot-dev/proplot/pull/30/files |
| twitter:image | https://avatars.githubusercontent.com/u/8881170?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/8881170?s=400&v=4 |
| og:image:alt | @lukelbd, this PR adds the AAAS journal specs to the proplot.subplots() command. It also has a few minor fixes: Move the journal specs table to the header and change name to JOURNAL_SPECS followin... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 639d2e61e0595a02d145092815d5b5c7345a4476fa7ce7eedc85345f4b0d5bd2 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/proplot-dev/proplot git https://github.com/proplot-dev/proplot.git |
| octolytics-dimension-user_id | 108025793 |
| octolytics-dimension-user_login | proplot-dev |
| octolytics-dimension-repository_id | 113293661 |
| octolytics-dimension-repository_nwo | proplot-dev/proplot |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 113293661 |
| octolytics-dimension-repository_network_root_nwo | proplot-dev/proplot |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 63131d96a4439002c1e480bbbc136f28b7fff962 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width