René's URL Explorer Experiment


Title: Correct nh sample span structure and parsing by vesari · Pull Request #1082 · prometheus/client_python · GitHub

Open Graph Title: Correct nh sample span structure and parsing by vesari · Pull Request #1082 · prometheus/client_python

X Title: Correct nh sample span structure and parsing by vesari · Pull Request #1082 · prometheus/client_python

Description: While working on the exposition part of the issue prometheus/OpenMetrics#279, I realized I made a mistake in the code relative to the NH spans and deltas parsing, in that I was not taking into acco...

Open Graph Description: While working on the exposition part of the issue prometheus/OpenMetrics#279, I realized I made a mistake in the code relative to the NH spans and deltas parsing, in that I was not taking into acco...

X Description: While working on the exposition part of the issue prometheus/OpenMetrics#279, I realized I made a mistake in the code relative to the NH spans and deltas parsing, in that I was not taking into acco...

Opengraph URL: https://github.com/prometheus/client_python/pull/1082

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:324a3369-5a1b-4eca-2b4c-94391eb95827
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAE76:B7306:8C08B7:C3B9CD:696A75C4
html-safe-nonceb6701f55639cf022595a37721b079652ae88a84c92551d0aeb164831b06fe2cb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRTc2OkI3MzA2OjhDMDhCNzpDM0I5Q0Q6Njk2QTc1QzQiLCJ2aXNpdG9yX2lkIjoiODU1ODEyODE0NDczODU3OTkwOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacfb83ac0b769b174f9a9933cd615431b7b3efcb629ae6989d6db4de30436f3f9f
hovercard-subject-tagpull_request:2265829010
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/prometheus/client_python/1082/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/6a562a0ff3348d1035073dc8d1170848c8df02f680e823a5ff7f795991b36f7f/prometheus/client_python/pull/1082
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6a562a0ff3348d1035073dc8d1170848c8df02f680e823a5ff7f795991b36f7f/prometheus/client_python/pull/1082
og:image:altWhile working on the exposition part of the issue prometheus/OpenMetrics#279, I realized I made a mistake in the code relative to the NH spans and deltas parsing, in that I was not taking into acco...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamevesari
hostnamegithub.com
expected-hostnamegithub.com
Nonecfa223d62d272274e0b68350b4bd7741f3ca7498b8c4b8b1bc1e6deabbdbc09d
turbo-cache-controlno-preview
go-importgithub.com/prometheus/client_python git https://github.com/prometheus/client_python.git
octolytics-dimension-user_id3380462
octolytics-dimension-user_loginprometheus
octolytics-dimension-repository_id30618733
octolytics-dimension-repository_nwoprometheus/client_python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id30618733
octolytics-dimension-repository_network_root_nwoprometheus/client_python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release6a0b6893c221f98f607598e939299fdf5763435d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/prometheus/client_python/pull/1082#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fprometheus%2Fclient_python%2Fpull%2F1082
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fprometheus%2Fclient_python%2Fpull%2F1082
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=prometheus%2Fclient_python
Reloadhttps://github.com/prometheus/client_python/pull/1082
Reloadhttps://github.com/prometheus/client_python/pull/1082
Reloadhttps://github.com/prometheus/client_python/pull/1082
prometheus https://github.com/prometheus
client_pythonhttps://github.com/prometheus/client_python
Notifications https://github.com/login?return_to=%2Fprometheus%2Fclient_python
Fork 841 https://github.com/login?return_to=%2Fprometheus%2Fclient_python
Star 4.3k https://github.com/login?return_to=%2Fprometheus%2Fclient_python
Code https://github.com/prometheus/client_python
Issues 108 https://github.com/prometheus/client_python/issues
Pull requests 28 https://github.com/prometheus/client_python/pulls
Discussions https://github.com/prometheus/client_python/discussions
Actions https://github.com/prometheus/client_python/actions
Projects 0 https://github.com/prometheus/client_python/projects
Wiki https://github.com/prometheus/client_python/wiki
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/prometheus/client_python/security
Please reload this pagehttps://github.com/prometheus/client_python/pull/1082
Insights https://github.com/prometheus/client_python/pulse
Code https://github.com/prometheus/client_python
Issues https://github.com/prometheus/client_python/issues
Pull requests https://github.com/prometheus/client_python/pulls
Discussions https://github.com/prometheus/client_python/discussions
Actions https://github.com/prometheus/client_python/actions
Projects https://github.com/prometheus/client_python/projects
Wiki https://github.com/prometheus/client_python/wiki
Security https://github.com/prometheus/client_python/security
Insights https://github.com/prometheus/client_python/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fprometheus%2Fclient_python%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fprometheus%2Fclient_python%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/prometheus/client_python/pull/1082#issue-comment-box
csmarchbankshttps://github.com/csmarchbanks
prometheus:masterhttps://github.com/prometheus/client_python/tree/master
vesari:correct-nh-sample-span-structurehttps://github.com/vesari/client_python/tree/correct-nh-sample-span-structure
Correct nh sample span structure and parsing https://github.com/prometheus/client_python/pull/1082#top
csmarchbankshttps://github.com/csmarchbanks
prometheus:masterhttps://github.com/prometheus/client_python/tree/master
vesari:correct-nh-sample-span-structurehttps://github.com/vesari/client_python/tree/correct-nh-sample-span-structure
Conversation 10 https://github.com/prometheus/client_python/pull/1082
Commits 8 https://github.com/prometheus/client_python/pull/1082/commits
Checks 1 https://github.com/prometheus/client_python/pull/1082/checks
Files changed 3 https://github.com/prometheus/client_python/pull/1082/files
https://github.co/hiddenchars
https://github.com/prometheus/client_python/pull/{{ revealButtonHref }}
https://github.com/vesari
vesarihttps://github.com/vesari
Jan 8, 2025https://github.com/prometheus/client_python/pull/1082#issue-2774984719
prometheus/OpenMetrics#279https://github.com/prometheus/OpenMetrics/issues/279
Please reload this pagehttps://github.com/prometheus/client_python/pull/1082
vesarihttps://github.com/vesari
January 6, 2025 17:57https://github.com/prometheus/client_python/pull/1082#commits-pushed-e043607
https://github.com/vesari
Add test for nh with more spanshttps://github.com/prometheus/client_python/pull/1082/commits/e043607f170542550c920a69d88aa59baf71aad8
e043607https://github.com/prometheus/client_python/pull/1082/commits/e043607f170542550c920a69d88aa59baf71aad8
https://github.com/vesari
Merge remote-tracking branch 'prometheus/master' into correct-nh-samp…https://github.com/prometheus/client_python/pull/1082/commits/2fcf1224ab56e16674449fcb429d0ebfbfef9f0c
2fcf122https://github.com/prometheus/client_python/pull/1082/commits/2fcf1224ab56e16674449fcb429d0ebfbfef9f0c
https://github.com/vesari
Allow for span arrays to be of whatever length and for delta lists to…https://github.com/prometheus/client_python/pull/1082/commits/ac736fb64dec55698fb9705a74aa879f98fdceb5
ac736fbhttps://github.com/prometheus/client_python/pull/1082/commits/ac736fb64dec55698fb9705a74aa879f98fdceb5
https://github.com/vesari
Allow for spans to be None, condense spans and deltas compositionhttps://github.com/prometheus/client_python/pull/1082/commits/7618ee351f3f568b1dc4ab5657f10181b4d870aa
7618ee3https://github.com/prometheus/client_python/pull/1082/commits/7618ee351f3f568b1dc4ab5657f10181b4d870aa
https://github.com/vesari
Comply to lintinghttps://github.com/prometheus/client_python/pull/1082/commits/7606fe74ca876a14fbc32cdbed9665e4da9c16bd
7606fe7https://github.com/prometheus/client_python/pull/1082/commits/7606fe74ca876a14fbc32cdbed9665e4da9c16bd
https://github.com/vesari
vesarihttps://github.com/vesari
csmarchbankshttps://github.com/csmarchbanks
krajoramahttps://github.com/krajorama
ywwghttps://github.com/ywwg
January 8, 2025 10:23https://github.com/prometheus/client_python/pull/1082#event-15851621823
https://github.com/vesari
Add missing white spaceshttps://github.com/prometheus/client_python/pull/1082/commits/4ce92f6c930d5990faa9fc1d5bff90a8ec4ceca8
4ce92f6https://github.com/prometheus/client_python/pull/1082/commits/4ce92f6c930d5990faa9fc1d5bff90a8ec4ceca8
https://github.com/krajorama
krajoramahttps://github.com/krajorama
Jan 10, 2025 https://github.com/prometheus/client_python/pull/1082#pullrequestreview-2542665340
View reviewed changes https://github.com/prometheus/client_python/pull/1082/files/4ce92f6c930d5990faa9fc1d5bff90a8ec4ceca8
prometheus_client/openmetrics/parser.pyhttps://github.com/prometheus/client_python/pull/1082/files/4ce92f6c930d5990faa9fc1d5bff90a8ec4ceca8#diff-b1a4b5cfded17961ba58698e2c923f23af8f6ed3b1dbd86c7f93958b4e43a5d2
krajoramahttps://github.com/krajorama
Jan 10, 2025https://github.com/prometheus/client_python/pull/1082#discussion_r1910499161
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/prometheus/client_python/pull/1082
prometheus_client/openmetrics/parser.pyhttps://github.com/prometheus/client_python/pull/1082/files/4ce92f6c930d5990faa9fc1d5bff90a8ec4ceca8#diff-b1a4b5cfded17961ba58698e2c923f23af8f6ed3b1dbd86c7f93958b4e43a5d2
krajoramahttps://github.com/krajorama
Jan 10, 2025https://github.com/prometheus/client_python/pull/1082#discussion_r1910501986
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/prometheus/client_python/pull/1082
prometheus_client/openmetrics/parser.pyhttps://github.com/prometheus/client_python/pull/1082/files/4ce92f6c930d5990faa9fc1d5bff90a8ec4ceca8#diff-b1a4b5cfded17961ba58698e2c923f23af8f6ed3b1dbd86c7f93958b4e43a5d2
Please reload this pagehttps://github.com/prometheus/client_python/pull/1082
prometheus_client/openmetrics/parser.pyhttps://github.com/prometheus/client_python/pull/1082/files/4ce92f6c930d5990faa9fc1d5bff90a8ec4ceca8#diff-b1a4b5cfded17961ba58698e2c923f23af8f6ed3b1dbd86c7f93958b4e43a5d2
krajoramahttps://github.com/krajorama
Jan 10, 2025https://github.com/prometheus/client_python/pull/1082#discussion_r1910511220
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/prometheus/client_python/pull/1082
https://github.com/vesari
Address style change requestshttps://github.com/prometheus/client_python/pull/1082/commits/3548f6f1a5c305c72de055f325a4f00df74227d1
3548f6fhttps://github.com/prometheus/client_python/pull/1082/commits/3548f6f1a5c305c72de055f325a4f00df74227d1
https://github.com/krajorama
krajoramahttps://github.com/krajorama
Jan 16, 2025 https://github.com/prometheus/client_python/pull/1082#pullrequestreview-2556182030
View reviewed changes https://github.com/prometheus/client_python/pull/1082/files/3548f6f1a5c305c72de055f325a4f00df74227d1
krajoramahttps://github.com/krajorama
https://github.com/prometheus/client_python/pull/1082#pullrequestreview-2556182030
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/prometheus/client_python/pull/1082
prometheus_client/openmetrics/parser.pyhttps://github.com/prometheus/client_python/pull/1082/files/3548f6f1a5c305c72de055f325a4f00df74227d1#diff-b1a4b5cfded17961ba58698e2c923f23af8f6ed3b1dbd86c7f93958b4e43a5d2
krajoramahttps://github.com/krajorama
Jan 16, 2025https://github.com/prometheus/client_python/pull/1082#discussion_r1918573463
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/prometheus/client_python/pull/1082
vesarihttps://github.com/vesari
Jan 17, 2025https://github.com/prometheus/client_python/pull/1082#discussion_r1919729897
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/prometheus/client_python/pull/1082
https://github.com/csmarchbanks
csmarchbankshttps://github.com/csmarchbanks
Jan 16, 2025 https://github.com/prometheus/client_python/pull/1082#pullrequestreview-2557253809
View reviewed changes https://github.com/prometheus/client_python/pull/1082/files/3548f6f1a5c305c72de055f325a4f00df74227d1
csmarchbankshttps://github.com/csmarchbanks
https://github.com/prometheus/client_python/pull/1082#pullrequestreview-2557253809
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/prometheus/client_python/pull/1082
https://github.com/vesari
Add comments to explain functionshttps://github.com/prometheus/client_python/pull/1082/commits/d6be64affa50d56942a56df53b991105bc123d55
d6be64ahttps://github.com/prometheus/client_python/pull/1082/commits/d6be64affa50d56942a56df53b991105bc123d55
https://github.com/csmarchbanks
csmarchbankshttps://github.com/csmarchbanks
Jan 17, 2025 https://github.com/prometheus/client_python/pull/1082#pullrequestreview-2559668540
View reviewed changes https://github.com/prometheus/client_python/pull/1082/files/d6be64affa50d56942a56df53b991105bc123d55
https://github.com/csmarchbanks
csmarchbankshttps://github.com/csmarchbanks
ecf344bhttps://github.com/prometheus/client_python/commit/ecf344b0bfacadcc0f255916bbf7f10b68c7e537
Jan 17, 2025https://github.com/prometheus/client_python/pull/1082#event-15980830194
Please reload this pagehttps://github.com/prometheus/client_python/pull/1082
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fprometheus%2Fclient_python%2Fpull%2F1082
https://github.com/csmarchbanks
csmarchbanks https://github.com/csmarchbanks
https://github.com/prometheus/client_python/pull/1082/files/d6be64affa50d56942a56df53b991105bc123d55
https://github.com/krajorama
krajorama https://github.com/krajorama
https://github.com/prometheus/client_python/pull/1082/files/3548f6f1a5c305c72de055f325a4f00df74227d1
https://github.com/ywwg
ywwg https://github.com/ywwg
Please reload this pagehttps://github.com/prometheus/client_python/pull/1082
https://github.com/vesari
https://github.com/csmarchbanks
https://github.com/krajorama
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.