René's URL Explorer Experiment


Title: Check if labelvalues is in _metrics before deletion in MetricWrapperBase.remove() by GlorifiedPig · Pull Request #1077 · prometheus/client_python · GitHub

Open Graph Title: Check if labelvalues is in _metrics before deletion in MetricWrapperBase.remove() by GlorifiedPig · Pull Request #1077 · prometheus/client_python

X Title: Check if labelvalues is in _metrics before deletion in MetricWrapperBase.remove() by GlorifiedPig · Pull Request #1077 · prometheus/client_python

Description: Currently raises an error if labelvalues is not in _metrics. Since the labelvalues get removed anyways, there isn't really any point of this error, since we would want to assume that after running ...

Open Graph Description: Currently raises an error if labelvalues is not in _metrics. Since the labelvalues get removed anyways, there isn't really any point of this error, since we would want to assume that after runn...

X Description: Currently raises an error if labelvalues is not in _metrics. Since the labelvalues get removed anyways, there isn't really any point of this error, since we would want to assume that after ...

Opengraph URL: https://github.com/prometheus/client_python/pull/1077

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b7a62797-50be-c71c-9211-702dd156577a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC114:139A69:12C7A5B:1A17DD8:696A91AC
html-safe-nonce30f9e41de96d1f2ec37ed5387ea9acdd135e180883971688be264acddce80a91
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMTE0OjEzOUE2OToxMkM3QTVCOjFBMTdERDg6Njk2QTkxQUMiLCJ2aXNpdG9yX2lkIjoiMTIwNDc3MTk1Nzg5MDUxOTQ2OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf9a6e21309c05bc92d5b9b132a247ca4ba6569782cdd8afb61f4b4122bbcf92a
hovercard-subject-tagpull_request:2212865821
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/prometheus/client_python/1077/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/534640592304d6817d24cfa04a1472d92906e6422c7ff05cab233b753a837a72/prometheus/client_python/pull/1077
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/534640592304d6817d24cfa04a1472d92906e6422c7ff05cab233b753a837a72/prometheus/client_python/pull/1077
og:image:altCurrently raises an error if labelvalues is not in _metrics. Since the labelvalues get removed anyways, there isn't really any point of this error, since we would want to assume that after runn...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameGlorifiedPig
hostnamegithub.com
expected-hostnamegithub.com
None4dd496afc954da9c207b2d9fbe86e3074619f565754aa1d9274aec30d9e5b8d7
turbo-cache-controlno-preview
go-importgithub.com/prometheus/client_python git https://github.com/prometheus/client_python.git
octolytics-dimension-user_id3380462
octolytics-dimension-user_loginprometheus
octolytics-dimension-repository_id30618733
octolytics-dimension-repository_nwoprometheus/client_python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id30618733
octolytics-dimension-repository_network_root_nwoprometheus/client_python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release31496a13b80a2f6ad77d6c617ee2255a3545b539
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/prometheus/client_python/pull/1077#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fprometheus%2Fclient_python%2Fpull%2F1077
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fprometheus%2Fclient_python%2Fpull%2F1077
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=prometheus%2Fclient_python
Reloadhttps://github.com/prometheus/client_python/pull/1077
Reloadhttps://github.com/prometheus/client_python/pull/1077
Reloadhttps://github.com/prometheus/client_python/pull/1077
prometheus https://github.com/prometheus
client_pythonhttps://github.com/prometheus/client_python
Notifications https://github.com/login?return_to=%2Fprometheus%2Fclient_python
Fork 841 https://github.com/login?return_to=%2Fprometheus%2Fclient_python
Star 4.3k https://github.com/login?return_to=%2Fprometheus%2Fclient_python
Code https://github.com/prometheus/client_python
Issues 108 https://github.com/prometheus/client_python/issues
Pull requests 28 https://github.com/prometheus/client_python/pulls
Discussions https://github.com/prometheus/client_python/discussions
Actions https://github.com/prometheus/client_python/actions
Projects 0 https://github.com/prometheus/client_python/projects
Wiki https://github.com/prometheus/client_python/wiki
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/prometheus/client_python/security
Please reload this pagehttps://github.com/prometheus/client_python/pull/1077
Insights https://github.com/prometheus/client_python/pulse
Code https://github.com/prometheus/client_python
Issues https://github.com/prometheus/client_python/issues
Pull requests https://github.com/prometheus/client_python/pulls
Discussions https://github.com/prometheus/client_python/discussions
Actions https://github.com/prometheus/client_python/actions
Projects https://github.com/prometheus/client_python/projects
Wiki https://github.com/prometheus/client_python/wiki
Security https://github.com/prometheus/client_python/security
Insights https://github.com/prometheus/client_python/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fprometheus%2Fclient_python%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fprometheus%2Fclient_python%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/prometheus/client_python/pull/1077#issue-comment-box
csmarchbankshttps://github.com/csmarchbanks
prometheus:masterhttps://github.com/prometheus/client_python/tree/master
GlorifiedPig:masterhttps://github.com/GlorifiedPig/client_python/tree/master
Check if labelvalues is in _metrics before deletion in MetricWrapperBase.remove() https://github.com/prometheus/client_python/pull/1077#top
csmarchbankshttps://github.com/csmarchbanks
prometheus:masterhttps://github.com/prometheus/client_python/tree/master
GlorifiedPig:masterhttps://github.com/GlorifiedPig/client_python/tree/master
Conversation 1 https://github.com/prometheus/client_python/pull/1077
Commits 1 https://github.com/prometheus/client_python/pull/1077/commits
Checks 1 https://github.com/prometheus/client_python/pull/1077/checks
Files changed 1 https://github.com/prometheus/client_python/pull/1077/files
https://github.co/hiddenchars
https://github.com/prometheus/client_python/pull/{{ revealButtonHref }}
https://github.com/GlorifiedPig
GlorifiedPighttps://github.com/GlorifiedPig
Dec 3, 2024https://github.com/prometheus/client_python/pull/1077#issue-2715097811
Please reload this pagehttps://github.com/prometheus/client_python/pull/1077
https://github.com/GlorifiedPig
if check before deleting in remove()https://github.com/prometheus/client_python/pull/1077/commits/a3ef4b49e72ed98d3edfc664a2ff35d576f4aade
a3ef4b4https://github.com/prometheus/client_python/pull/1077/commits/a3ef4b49e72ed98d3edfc664a2ff35d576f4aade
https://github.com/GlorifiedPig
GlorifiedPighttps://github.com/GlorifiedPig
force-pushedhttps://github.com/prometheus/client_python/compare/d97db4122c8d64c67fa3fd786048a8efde142d18..a3ef4b49e72ed98d3edfc664a2ff35d576f4aade
d97db41https://github.com/prometheus/client_python/commit/d97db4122c8d64c67fa3fd786048a8efde142d18
a3ef4b4https://github.com/prometheus/client_python/commit/a3ef4b49e72ed98d3edfc664a2ff35d576f4aade
Compare https://github.com/prometheus/client_python/compare/d97db4122c8d64c67fa3fd786048a8efde142d18..a3ef4b49e72ed98d3edfc664a2ff35d576f4aade
December 3, 2024 13:55https://github.com/prometheus/client_python/pull/1077#event-15510220426
https://github.com/csmarchbanks
csmarchbankshttps://github.com/csmarchbanks
Dec 6, 2024 https://github.com/prometheus/client_python/pull/1077#pullrequestreview-2485119537
View reviewed changes https://github.com/prometheus/client_python/pull/1077/files/a3ef4b49e72ed98d3edfc664a2ff35d576f4aade
csmarchbankshttps://github.com/csmarchbanks
https://github.com/prometheus/client_python/pull/1077#pullrequestreview-2485119537
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/prometheus/client_python/pull/1077
https://github.com/csmarchbanks
csmarchbankshttps://github.com/csmarchbanks
92b2397https://github.com/prometheus/client_python/commit/92b23970f032cbc990aa0e501708c425708e51ea
Dec 6, 2024https://github.com/prometheus/client_python/pull/1077#event-15561877788
Please reload this pagehttps://github.com/prometheus/client_python/pull/1077
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fprometheus%2Fclient_python%2Fpull%2F1077
https://github.com/csmarchbanks
csmarchbanks https://github.com/csmarchbanks
https://github.com/prometheus/client_python/pull/1077/files/a3ef4b49e72ed98d3edfc664a2ff35d576f4aade
Please reload this pagehttps://github.com/prometheus/client_python/pull/1077
https://github.com/GlorifiedPig
https://github.com/csmarchbanks
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.