René's URL Explorer Experiment


Title: Add sanity check for label value by andysim3d · Pull Request #1012 · prometheus/client_python · GitHub

Open Graph Title: Add sanity check for label value by andysim3d · Pull Request #1012 · prometheus/client_python

X Title: Add sanity check for label value by andysim3d · Pull Request #1012 · prometheus/client_python

Description: Add a sanity check when set info's label. value can't be null. @csmarchbanks ptal. fix #1011

Open Graph Description: Add a sanity check when set info's label. value can't be null. @csmarchbanks ptal. fix #1011

X Description: Add a sanity check when set info's label. value can't be null. @csmarchbanks ptal. fix #1011

Opengraph URL: https://github.com/prometheus/client_python/pull/1012

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ec3390d5-e8eb-8d25-1e7d-f78791aaf908
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB596:139A69:70BE1D:9CE14D:696A721C
html-safe-noncef345e50c6a22353e39ccf11d699bbe1a289219c10ebc658b2a9c7c2802c09a0a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNTk2OjEzOUE2OTo3MEJFMUQ6OUNFMTREOjY5NkE3MjFDIiwidmlzaXRvcl9pZCI6Ijc4MjcwOTk5Mjc3MzU0NjUyNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac3c665e18022462eb9c7188ddfbb67e7d6d9ab368af3db9a43a0a779306fe895b
hovercard-subject-tagpull_request:1753216813
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/prometheus/client_python/1012/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b008d00dcc25b475e6e89df0239cf1c629349658fe78bdbc4357dd8cff1f6aa0/prometheus/client_python/pull/1012
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b008d00dcc25b475e6e89df0239cf1c629349658fe78bdbc4357dd8cff1f6aa0/prometheus/client_python/pull/1012
og:image:altAdd a sanity check when set info's label. value can't be null. @csmarchbanks ptal. fix #1011
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameandysim3d
hostnamegithub.com
expected-hostnamegithub.com
Nonecfa223d62d272274e0b68350b4bd7741f3ca7498b8c4b8b1bc1e6deabbdbc09d
turbo-cache-controlno-preview
go-importgithub.com/prometheus/client_python git https://github.com/prometheus/client_python.git
octolytics-dimension-user_id3380462
octolytics-dimension-user_loginprometheus
octolytics-dimension-repository_id30618733
octolytics-dimension-repository_nwoprometheus/client_python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id30618733
octolytics-dimension-repository_network_root_nwoprometheus/client_python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release6a0b6893c221f98f607598e939299fdf5763435d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/prometheus/client_python/pull/1012#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fprometheus%2Fclient_python%2Fpull%2F1012
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fprometheus%2Fclient_python%2Fpull%2F1012
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=prometheus%2Fclient_python
Reloadhttps://github.com/prometheus/client_python/pull/1012
Reloadhttps://github.com/prometheus/client_python/pull/1012
Reloadhttps://github.com/prometheus/client_python/pull/1012
prometheus https://github.com/prometheus
client_pythonhttps://github.com/prometheus/client_python
Notifications https://github.com/login?return_to=%2Fprometheus%2Fclient_python
Fork 841 https://github.com/login?return_to=%2Fprometheus%2Fclient_python
Star 4.3k https://github.com/login?return_to=%2Fprometheus%2Fclient_python
Code https://github.com/prometheus/client_python
Issues 108 https://github.com/prometheus/client_python/issues
Pull requests 28 https://github.com/prometheus/client_python/pulls
Discussions https://github.com/prometheus/client_python/discussions
Actions https://github.com/prometheus/client_python/actions
Projects 0 https://github.com/prometheus/client_python/projects
Wiki https://github.com/prometheus/client_python/wiki
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/prometheus/client_python/security
Please reload this pagehttps://github.com/prometheus/client_python/pull/1012
Insights https://github.com/prometheus/client_python/pulse
Code https://github.com/prometheus/client_python
Issues https://github.com/prometheus/client_python/issues
Pull requests https://github.com/prometheus/client_python/pulls
Discussions https://github.com/prometheus/client_python/discussions
Actions https://github.com/prometheus/client_python/actions
Projects https://github.com/prometheus/client_python/projects
Wiki https://github.com/prometheus/client_python/wiki
Security https://github.com/prometheus/client_python/security
Insights https://github.com/prometheus/client_python/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fprometheus%2Fclient_python%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fprometheus%2Fclient_python%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/prometheus/client_python/pull/1012#issue-comment-box
csmarchbankshttps://github.com/csmarchbanks
prometheus:masterhttps://github.com/prometheus/client_python/tree/master
andysim3d:fix_1011https://github.com/andysim3d/client_python/tree/fix_1011
Add sanity check for label value https://github.com/prometheus/client_python/pull/1012#top
csmarchbankshttps://github.com/csmarchbanks
prometheus:masterhttps://github.com/prometheus/client_python/tree/master
andysim3d:fix_1011https://github.com/andysim3d/client_python/tree/fix_1011
Conversation 5 https://github.com/prometheus/client_python/pull/1012
Commits 1 https://github.com/prometheus/client_python/pull/1012/commits
Checks 0 https://github.com/prometheus/client_python/pull/1012/checks
Files changed 2 https://github.com/prometheus/client_python/pull/1012/files
https://github.co/hiddenchars
https://github.com/prometheus/client_python/pull/{{ revealButtonHref }}
https://github.com/andysim3d
andysim3dhttps://github.com/andysim3d
Mar 3, 2024https://github.com/prometheus/client_python/pull/1012#issue-2165134738
@csmarchbankshttps://github.com/csmarchbanks
#1011https://github.com/prometheus/client_python/issues/1011
Please reload this pagehttps://github.com/prometheus/client_python/pull/1012
https://github.com/andysim3d
andysim3dhttps://github.com/andysim3d
force-pushedhttps://github.com/prometheus/client_python/compare/770b6a94a7ccb0b2d80b9cd1b47dfc30e35720f3..b226e4d5ea4fd8d27618159112874c9117cc83e2
770b6a9https://github.com/prometheus/client_python/commit/770b6a94a7ccb0b2d80b9cd1b47dfc30e35720f3
b226e4dhttps://github.com/prometheus/client_python/commit/b226e4d5ea4fd8d27618159112874c9117cc83e2
Compare https://github.com/prometheus/client_python/compare/770b6a94a7ccb0b2d80b9cd1b47dfc30e35720f3..b226e4d5ea4fd8d27618159112874c9117cc83e2
March 3, 2024 04:27https://github.com/prometheus/client_python/pull/1012#event-11989021922
https://github.com/csmarchbanks
csmarchbankshttps://github.com/csmarchbanks
Mar 7, 2024 https://github.com/prometheus/client_python/pull/1012#pullrequestreview-1923582480
View reviewed changes https://github.com/prometheus/client_python/pull/1012/files
csmarchbankshttps://github.com/csmarchbanks
https://github.com/prometheus/client_python/pull/1012#pullrequestreview-1923582480
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/prometheus/client_python/pull/1012
.gitignorehttps://github.com/prometheus/client_python/pull/1012/files#diff-bc37d034bad564583790a46f19d807abfe519c5671395fd494d8cce506c42947
Please reload this pagehttps://github.com/prometheus/client_python/pull/1012
https://github.com/andysim3d
andysim3dhttps://github.com/andysim3d
force-pushedhttps://github.com/prometheus/client_python/compare/b226e4d5ea4fd8d27618159112874c9117cc83e2..5340ed73864a72a4ba7e5f7d0ef541d8294aabce
b226e4dhttps://github.com/prometheus/client_python/commit/b226e4d5ea4fd8d27618159112874c9117cc83e2
5340ed7https://github.com/prometheus/client_python/commit/5340ed73864a72a4ba7e5f7d0ef541d8294aabce
Compare https://github.com/prometheus/client_python/compare/b226e4d5ea4fd8d27618159112874c9117cc83e2..5340ed73864a72a4ba7e5f7d0ef541d8294aabce
March 8, 2024 01:24https://github.com/prometheus/client_python/pull/1012#event-12049997433
https://github.com/csmarchbanks
csmarchbankshttps://github.com/csmarchbanks
Mar 8, 2024 https://github.com/prometheus/client_python/pull/1012#pullrequestreview-1925192267
View reviewed changes https://github.com/prometheus/client_python/pull/1012/files
prometheus_client/metrics.pyhttps://github.com/prometheus/client_python/pull/1012/files#diff-c146acd4b81d5b8995b2567ff78b9c11df02c051971f7e66f44bc6f765031273
Please reload this pagehttps://github.com/prometheus/client_python/pull/1012
https://github.com/andysim3d
update .gitignore to exclude ide related confighttps://github.com/prometheus/client_python/pull/1012/commits/c4135f3f4a98a7fedd74f6b505262082465a3acb
c4135f3https://github.com/prometheus/client_python/pull/1012/commits/c4135f3f4a98a7fedd74f6b505262082465a3acb
https://github.com/andysim3d
andysim3dhttps://github.com/andysim3d
force-pushedhttps://github.com/prometheus/client_python/compare/5340ed73864a72a4ba7e5f7d0ef541d8294aabce..c4135f3f4a98a7fedd74f6b505262082465a3acb
5340ed7https://github.com/prometheus/client_python/commit/5340ed73864a72a4ba7e5f7d0ef541d8294aabce
c4135f3https://github.com/prometheus/client_python/commit/c4135f3f4a98a7fedd74f6b505262082465a3acb
Compare https://github.com/prometheus/client_python/compare/5340ed73864a72a4ba7e5f7d0ef541d8294aabce..c4135f3f4a98a7fedd74f6b505262082465a3acb
March 9, 2024 01:41https://github.com/prometheus/client_python/pull/1012#event-12062005268
https://github.com/csmarchbanks
csmarchbankshttps://github.com/csmarchbanks
Mar 9, 2024 https://github.com/prometheus/client_python/pull/1012#pullrequestreview-1926071808
View reviewed changes https://github.com/prometheus/client_python/pull/1012/files/c4135f3f4a98a7fedd74f6b505262082465a3acb
csmarchbankshttps://github.com/csmarchbanks
https://github.com/prometheus/client_python/pull/1012#pullrequestreview-1926071808
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/prometheus/client_python/pull/1012
https://github.com/csmarchbanks
csmarchbankshttps://github.com/csmarchbanks
4535ce0https://github.com/prometheus/client_python/commit/4535ce0f43097aa48e44a65747d82064f2aadaf5
Mar 9, 2024https://github.com/prometheus/client_python/pull/1012#event-12062073512
btimbyhttps://github.com/btimby
Aug 2, 2024 https://github.com/prometheus/client_python/pull/1012#ref-commit-6d1b172
https://github.com/andysim3d
https://github.com/btimby
Add sanity check for label value (https://github.com/btimby/client_python/commit/6d1b1720a912c3b88c5b42c0473a6d4462c52a80
prometheus#1012https://github.com/prometheus/client_python/pull/1012
)https://github.com/btimby/client_python/commit/6d1b1720a912c3b88c5b42c0473a6d4462c52a80
6d1b172https://github.com/btimby/client_python/commit/6d1b1720a912c3b88c5b42c0473a6d4462c52a80
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fprometheus%2Fclient_python%2Fpull%2F1012
https://github.com/csmarchbanks
csmarchbanks https://github.com/csmarchbanks
https://github.com/prometheus/client_python/pull/1012/files/c4135f3f4a98a7fedd74f6b505262082465a3acb
Using None as a label value breaks exposure of all metrics https://github.com/prometheus/client_python/issues/1011
Please reload this pagehttps://github.com/prometheus/client_python/pull/1012
https://github.com/andysim3d
https://github.com/csmarchbanks
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.