René's URL Explorer Experiment


Title: Removed metric name validation when using a CustomSampleMappingBuilder by LiamClarkeNZ · Pull Request #519 · prometheus/client_java · GitHub

Open Graph Title: Removed metric name validation when using a CustomSampleMappingBuilder by LiamClarkeNZ · Pull Request #519 · prometheus/client_java

X Title: Removed metric name validation when using a CustomSampleMappingBuilder by LiamClarkeNZ · Pull Request #519 · prometheus/client_java

Description: Prometheus instrumentation library for JVM applications - Removed metric name validation when using a CustomSampleMappingBuilder by LiamClarkeNZ · Pull Request #519 · prometheus/client_java

Open Graph Description: The current implementation enforces Graphite metric naming patterns, but not all usages of Dropwizard metrics use these patterns, so I've removed the validation to allow a more widespread use.

X Description: The current implementation enforces Graphite metric naming patterns, but not all usages of Dropwizard metrics use these patterns, so I've removed the validation to allow a more widespread use.

Opengraph URL: https://github.com/prometheus/client_java/pull/519

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8bdd56a0-7521-ec98-7645-3f13f17ca67e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDA94:23FBEE:16E008:1E1695:6AFBB123
html-safe-noncecac47c602f407c7d7a765326f50fbd2edac56bdc210adfe487cf69fb5edeb9d0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQTk0OjIzRkJFRToxNkUwMDg6MUUxNjk1OjZBRkJCMTIzIiwidmlzaXRvcl9pZCI6IjczMjQyNzg3NDQ2NTI5NTE4NDQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac1dc622b6b37df9d2c7624094b3ea619538a657e29a5231ee6e8eeb92b310f59f
hovercard-subject-tagpull_request:356493872
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/prometheus/client_java/519/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/0049646049c7901335e6d44fef7df61ee919248075e29abd7ce815481faa3e85/prometheus/client_java/pull/519
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0049646049c7901335e6d44fef7df61ee919248075e29abd7ce815481faa3e85/prometheus/client_java/pull/519
og:image:altThe current implementation enforces Graphite metric naming patterns, but not all usages of Dropwizard metrics use these patterns, so I've removed the validation to allow a more widespread use.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameLiamClarkeNZ
hostnamegithub.com
expected-hostnamegithub.com
Nonee25fbd830d3e6ad0e8935c105cf4fdc70c593dffcd27bb45b790ae4fece5ea55
turbo-cache-controlno-cache
go-importgithub.com/prometheus/client_java git https://github.com/prometheus/client_java.git
octolytics-dimension-user_id3380462
octolytics-dimension-user_loginprometheus
octolytics-dimension-repository_id7997879
octolytics-dimension-repository_nwoprometheus/client_java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7997879
octolytics-dimension-repository_network_root_nwoprometheus/client_java
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release08c8f17f9d27054a108b8b6254e405de0151f660
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/prometheus/client_java/pull/519#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fprometheus%2Fclient_java%2Fpull%2F519
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fprometheus%2Fclient_java%2Fpull%2F519
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=prometheus%2Fclient_java
Reloadhttps://github.com/prometheus/client_java/pull/519
Reloadhttps://github.com/prometheus/client_java/pull/519
Reloadhttps://github.com/prometheus/client_java/pull/519
prometheushttps://github.com/prometheus
client_javahttps://github.com/prometheus/client_java
Codehttps://github.com/prometheus/client_java
Issues12 (12)https://github.com/prometheus/client_java/issues
Pull requests18 (18)https://github.com/prometheus/client_java/pulls
Actionshttps://github.com/prometheus/client_java/actions
Projectshttps://github.com/prometheus/client_java/projects
Security and qualityhttps://github.com/prometheus/client_java/security
Insightshttps://github.com/prometheus/client_java/pulse
https://github.com/prometheus/client_java
LiamClarkeNZhttps://github.com/LiamClarkeNZ
prometheus:mainhttps://github.com/prometheus/client_java/tree/main
LiamClarkeNZ:NonValidatingDropwizardMappingshttps://github.com/LiamClarkeNZ/client_java/tree/NonValidatingDropwizardMappings
Conversationhttps://github.com/prometheus/client_java/pull/519
Commits1 (1)https://github.com/prometheus/client_java/pull/519/commits
Checkshttps://github.com/prometheus/client_java/pull/519/checks
Files changedhttps://github.com/prometheus/client_java/pull/519/files
Removed metric name validation when using a CustomSampleMappingBuilderhttps://github.com/prometheus/client_java/pull/519#top
LiamClarkeNZhttps://github.com/LiamClarkeNZ
prometheus:mainhttps://github.com/prometheus/client_java/tree/main
LiamClarkeNZ:NonValidatingDropwizardMappingshttps://github.com/LiamClarkeNZ/client_java/tree/NonValidatingDropwizardMappings
https://github.com/LiamClarkeNZ
LiamClarkeNZhttps://github.com/LiamClarkeNZ
Dec 24, 2019https://github.com/prometheus/client_java/pull/519#issue-541955375
Please reload this pagehttps://github.com/prometheus/client_java/pull/519
Removed metric name validation when using a CustomSampleMappingBuilde…https://github.com/prometheus/client_java/pull/519/commits/a2e759f814dc0c6de6c25a5f25c7e0c8c0e662e7
a2e759fhttps://github.com/prometheus/client_java/pull/519/commits/a2e759f814dc0c6de6c25a5f25c7e0c8c0e662e7
https://github.com/LiamClarkeNZ
LiamClarkeNZhttps://github.com/LiamClarkeNZ
force-pushedhttps://github.com/prometheus/client_java/compare/f226c1da699c2a473bed7eed5ebe2249745cf0ee..a2e759f814dc0c6de6c25a5f25c7e0c8c0e662e7
f226c1dhttps://github.com/prometheus/client_java/commit/f226c1da699c2a473bed7eed5ebe2249745cf0ee
a2e759fhttps://github.com/prometheus/client_java/commit/a2e759f814dc0c6de6c25a5f25c7e0c8c0e662e7
Compare https://github.com/prometheus/client_java/compare/f226c1da699c2a473bed7eed5ebe2249745cf0ee..a2e759f814dc0c6de6c25a5f25c7e0c8c0e662e7
December 24, 2019 01:45https://github.com/prometheus/client_java/pull/519#event-2905945510
https://github.com/LiamClarkeNZ
LiamClarkeNZhttps://github.com/LiamClarkeNZ
Dec 24, 2019 https://github.com/prometheus/client_java/pull/519#ref-issue-539406150
Metric pattern validation in simpleclient_dropwizard is overly strict #518 https://github.com/prometheus/client_java/issues/518
https://github.com/brian-brazil
brian-brazilhttps://github.com/brian-brazil
Dec 24, 2019https://github.com/prometheus/client_java/pull/519#issuecomment-568696219
Please reload this pagehttps://github.com/prometheus/client_java/pull/519
https://github.com/peetzen
peetzenhttps://github.com/peetzen
Feb 1, 2020https://github.com/prometheus/client_java/pull/519#issuecomment-581022660
@brian-brazilhttps://github.com/brian-brazil
@LiamClarkeNZhttps://github.com/LiamClarkeNZ
Please reload this pagehttps://github.com/prometheus/client_java/pull/519
https://github.com/brian-brazil
brian-brazilhttps://github.com/brian-brazil
Feb 3, 2020https://github.com/prometheus/client_java/pull/519#issuecomment-581303874
Please reload this pagehttps://github.com/prometheus/client_java/pull/519
https://github.com/LiamClarkeNZ
LiamClarkeNZhttps://github.com/LiamClarkeNZ
Feb 13, 2020https://github.com/prometheus/client_java/pull/519#issuecomment-585540887
Please reload this pagehttps://github.com/prometheus/client_java/pull/519
Please reload this pagehttps://github.com/prometheus/client_java/pull/519
https://github.com/brian-brazil
brian-brazilhttps://github.com/brian-brazil
Feb 13, 2020https://github.com/prometheus/client_java/pull/519#issuecomment-585590153
Please reload this pagehttps://github.com/prometheus/client_java/pull/519
https://github.com/fstab
fstabhttps://github.com/fstab
force-pushedhttps://github.com/prometheus/client_java/compare/3d6f699b5e9f12b35ce506f32215ac3dd8dd80c0..c83877ab01539a34f172d72405db0f1b9b29cc60
3d6f699https://github.com/prometheus/client_java/commit/3d6f699b5e9f12b35ce506f32215ac3dd8dd80c0
c83877ahttps://github.com/prometheus/client_java/commit/c83877ab01539a34f172d72405db0f1b9b29cc60
Compare https://github.com/prometheus/client_java/compare/3d6f699b5e9f12b35ce506f32215ac3dd8dd80c0..c83877ab01539a34f172d72405db0f1b9b29cc60
January 30, 2022 21:12https://github.com/prometheus/client_java/pull/519#event-5977030470
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Mar 5, 2026https://github.com/prometheus/client_java/pull/519#issuecomment-4002619289
Please reload this pagehttps://github.com/prometheus/client_java/pull/519
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
stale https://github.com/prometheus/client_java/issues?q=state%3Aopen%20label%3Astale
Mar 5, 2026https://github.com/prometheus/client_java/pull/519#event-23285315833
https://github.com/LiamClarkeNZ
LiamClarkeNZhttps://github.com/LiamClarkeNZ
Mar 25, 2026https://github.com/prometheus/client_java/pull/519#event-23873996187
https://github.co/hiddenchars
https://github.com/prometheus/client_java/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fprometheus%2Fclient_java%2Fpull%2F519
Please reload this pagehttps://github.com/prometheus/client_java/pull/519
stale https://github.com/prometheus/client_java/issues?q=state%3Aopen%20label%3Astale
Please reload this pagehttps://github.com/prometheus/client_java/pull/519
https://github.com/LiamClarkeNZ
https://github.com/brian-brazil
https://github.com/peetzen
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.