René's URL Explorer Experiment


Title: Added optional "timestamp" value as part of metric sample by felipe-conde-benavides · Pull Request #337 · prometheus/client_java · GitHub

Open Graph Title: Added optional "timestamp" value as part of metric sample by felipe-conde-benavides · Pull Request #337 · prometheus/client_java

X Title: Added optional "timestamp" value as part of metric sample by felipe-conde-benavides · Pull Request #337 · prometheus/client_java

Description: Prometheus instrumentation library for JVM applications - Added optional "timestamp" value as part of metric sample by felipe-conde-benavides · Pull Request #337 · prometheus/client_java

Open Graph Description: I'm using an exporter based on this code and it's working fine. To be honest I'm not using equals() and hashCode() methods, so I haven't test it. One more thing, about hashCode(): I...

X Description: I'm using an exporter based on this code and it's working fine. To be honest I'm not using equals() and hashCode() methods, so I haven't test it. One more thing, abo...

Opengraph URL: https://github.com/prometheus/client_java/pull/337

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:12645478-9f11-e72c-1cb1-a9cda586da69
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id80DA:1D6BC2:20C254:2DE53E:6AFBF241
html-safe-nonced1c7b3adeb22689f1ddce9a9d062e4d8b85784548cd977c7023f13b4020b803f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MERBOjFENkJDMjoyMEMyNTQ6MkRFNTNFOjZBRkJGMjQxIiwidmlzaXRvcl9pZCI6IjMyODcyMTY2NTQxNjA0OTEwNzMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac348af3155d70dc18a0f23fca59f15500c828fc6af6c92619408a5e167d1c9905
hovercard-subject-tagpull_request:166600047
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/prometheus/client_java/337/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/dfd92ca9fe2dbcde3a64f9a361f721803ef8b89e583ee72dbc63d4d8c0e6d7c5/prometheus/client_java/pull/337
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/dfd92ca9fe2dbcde3a64f9a361f721803ef8b89e583ee72dbc63d4d8c0e6d7c5/prometheus/client_java/pull/337
og:image:altI'm using an exporter based on this code and it's working fine. To be honest I'm not using equals() and hashCode() methods, so I haven't test it. One more thing, about hashCode(): I...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamefelipe-conde-benavides
hostnamegithub.com
expected-hostnamegithub.com
Nonefa74413a1d84dac536fcca0740780bcbd3207bafec0e51873b73ff8e8cca032f
turbo-cache-controlno-cache
go-importgithub.com/prometheus/client_java git https://github.com/prometheus/client_java.git
octolytics-dimension-user_id3380462
octolytics-dimension-user_loginprometheus
octolytics-dimension-repository_id7997879
octolytics-dimension-repository_nwoprometheus/client_java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7997879
octolytics-dimension-repository_network_root_nwoprometheus/client_java
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb3b5633a74535d9c23385512d534c66c8fde1907
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/prometheus/client_java/pull/337#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fprometheus%2Fclient_java%2Fpull%2F337
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fprometheus%2Fclient_java%2Fpull%2F337
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=prometheus%2Fclient_java
Reloadhttps://github.com/prometheus/client_java/pull/337
Reloadhttps://github.com/prometheus/client_java/pull/337
Reloadhttps://github.com/prometheus/client_java/pull/337
prometheushttps://github.com/prometheus
client_javahttps://github.com/prometheus/client_java
Codehttps://github.com/prometheus/client_java
Issues12 (12)https://github.com/prometheus/client_java/issues
Pull requests19 (19)https://github.com/prometheus/client_java/pulls
Actionshttps://github.com/prometheus/client_java/actions
Projectshttps://github.com/prometheus/client_java/projects
Security and qualityhttps://github.com/prometheus/client_java/security
Insightshttps://github.com/prometheus/client_java/pulse
https://github.com/prometheus/client_java
brian-brazilhttps://github.com/brian-brazil
prometheus:masterhttps://github.com/prometheus/client_java/tree/master
felipe-conde-benavides:feature-timestamphttps://github.com/felipe-conde-benavides/client_java/tree/feature-timestamp
Conversationhttps://github.com/prometheus/client_java/pull/337
Commits19 (19)https://github.com/prometheus/client_java/pull/337/commits
Checkshttps://github.com/prometheus/client_java/pull/337/checks
Files changedhttps://github.com/prometheus/client_java/pull/337/files
Added optional "timestamp" value as part of metric samplehttps://github.com/prometheus/client_java/pull/337#top
brian-brazilhttps://github.com/brian-brazil
prometheus:masterhttps://github.com/prometheus/client_java/tree/master
felipe-conde-benavides:feature-timestamphttps://github.com/felipe-conde-benavides/client_java/tree/feature-timestamp
https://github.com/felipe-conde-benavides
felipe-conde-benavideshttps://github.com/felipe-conde-benavides
Feb 1, 2018https://github.com/prometheus/client_java/pull/337#issue-293614399
Please reload this pagehttps://github.com/prometheus/client_java/pull/337
Added optional "timestamp" value as part of metric samplehttps://github.com/prometheus/client_java/pull/337/commits/eb2d8d10a89097c873b6f649c38d9faf62922140
eb2d8d1https://github.com/prometheus/client_java/pull/337/commits/eb2d8d10a89097c873b6f649c38d9faf62922140
https://github.com/brian-brazil
brian-brazilhttps://github.com/brian-brazil
Feb 1, 2018https://github.com/prometheus/client_java/pull/337#issuecomment-362340076
Please reload this pagehttps://github.com/prometheus/client_java/pull/337
Method "equals" was wronghttps://github.com/prometheus/client_java/pull/337/commits/4a0db4823cddd80e7112c4541661b5a6efb65d50
4a0db48https://github.com/prometheus/client_java/pull/337/commits/4a0db4823cddd80e7112c4541661b5a6efb65d50
https://github.com/pjfanning
pjfanninghttps://github.com/pjfanning
Feb 2, 2018 https://github.com/prometheus/client_java/pull/337#pullrequestreview-93573168
View reviewed changes https://github.com/prometheus/client_java/pull/337/files/4a0db4823cddd80e7112c4541661b5a6efb65d50
simpleclient/src/main/java/io/prometheus/client/Collector.javahttps://github.com/prometheus/client_java/pull/337/files/4a0db4823cddd80e7112c4541661b5a6efb65d50#diff-b5b368e079b04f16ffb1a62caacf0001aa05595b8f9a2ec999003336b3bf0ca5
pjfanninghttps://github.com/pjfanning
Feb 2, 2018https://github.com/prometheus/client_java/pull/337#discussion_r165605323
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/prometheus/client_java/pull/337
felipe-conde-benavideshttps://github.com/felipe-conde-benavides
Feb 2, 2018https://github.com/prometheus/client_java/pull/337#discussion_r165631013
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/prometheus/client_java/pull/337
pjfanninghttps://github.com/pjfanning
Feb 2, 2018https://github.com/prometheus/client_java/pull/337#discussion_r165632645
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/prometheus/client_java/pull/337
https://github.com/pjfanning
pjfanninghttps://github.com/pjfanning
Feb 2, 2018 https://github.com/prometheus/client_java/pull/337#pullrequestreview-93574672
View reviewed changes https://github.com/prometheus/client_java/pull/337/files/4a0db4823cddd80e7112c4541661b5a6efb65d50
simpleclient/src/main/java/io/prometheus/client/Collector.javahttps://github.com/prometheus/client_java/pull/337/files/4a0db4823cddd80e7112c4541661b5a6efb65d50#diff-b5b368e079b04f16ffb1a62caacf0001aa05595b8f9a2ec999003336b3bf0ca5
pjfanninghttps://github.com/pjfanning
Feb 2, 2018https://github.com/prometheus/client_java/pull/337#discussion_r165606613
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/prometheus/client_java/pull/337
felipe-conde-benavideshttps://github.com/felipe-conde-benavides
Feb 2, 2018https://github.com/prometheus/client_java/pull/337#discussion_r165631251
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/prometheus/client_java/pull/337
https://github.com/pjfanning
pjfanninghttps://github.com/pjfanning
Feb 2, 2018 https://github.com/prometheus/client_java/pull/337#pullrequestreview-93575312
View reviewed changes https://github.com/prometheus/client_java/pull/337/files/4a0db4823cddd80e7112c4541661b5a6efb65d50
simpleclient_common/src/main/java/io/prometheus/client/exporter/common/TextFormat.javahttps://github.com/prometheus/client_java/pull/337/files/4a0db4823cddd80e7112c4541661b5a6efb65d50#diff-3fbc4a397071b57de65b209a667f0e88dd332e6cae8b4f80a09aa1b4f45db23f
pjfanninghttps://github.com/pjfanning
Feb 2, 2018https://github.com/prometheus/client_java/pull/337#discussion_r165607156
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/prometheus/client_java/pull/337
felipe-conde-benavideshttps://github.com/felipe-conde-benavides
Feb 2, 2018https://github.com/prometheus/client_java/pull/337#discussion_r165631343
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/prometheus/client_java/pull/337
February 2, 2018 13:26https://github.com/prometheus/client_java/pull/337#commits-pushed-3510513
changed "tabs" for "spaces"https://github.com/prometheus/client_java/pull/337/commits/35105133797f57ff0f63515e4b2c7e85e8e5812a
3510513https://github.com/prometheus/client_java/pull/337/commits/35105133797f57ff0f63515e4b2c7e85e8e5812a
Added extra check for "null" valueshttps://github.com/prometheus/client_java/pull/337/commits/d0ffe6a0a4e9bc922aecdd599432dcb5c8de8770
d0ffe6ahttps://github.com/prometheus/client_java/pull/337/commits/d0ffe6a0a4e9bc922aecdd599432dcb5c8de8770
https://github.com/pjfanning
pjfanninghttps://github.com/pjfanning
Feb 2, 2018 https://github.com/prometheus/client_java/pull/337#pullrequestreview-93606170
View reviewed changes https://github.com/prometheus/client_java/pull/337/files/d0ffe6a0a4e9bc922aecdd599432dcb5c8de8770
simpleclient/src/main/java/io/prometheus/client/Collector.javahttps://github.com/prometheus/client_java/pull/337/files/d0ffe6a0a4e9bc922aecdd599432dcb5c8de8770#diff-b5b368e079b04f16ffb1a62caacf0001aa05595b8f9a2ec999003336b3bf0ca5
pjfanninghttps://github.com/pjfanning
Feb 2, 2018https://github.com/prometheus/client_java/pull/337#discussion_r165632800
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/prometheus/client_java/pull/337
felipe-conde-benavideshttps://github.com/felipe-conde-benavides
Feb 2, 2018https://github.com/prometheus/client_java/pull/337#discussion_r165635767
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/prometheus/client_java/pull/337
https://github.com/pjfanning
pjfanninghttps://github.com/pjfanning
Feb 2, 2018 https://github.com/prometheus/client_java/pull/337#pullrequestreview-93606247
View reviewed changes https://github.com/prometheus/client_java/pull/337/files/d0ffe6a0a4e9bc922aecdd599432dcb5c8de8770
simpleclient/src/main/java/io/prometheus/client/Collector.javahttps://github.com/prometheus/client_java/pull/337/files/d0ffe6a0a4e9bc922aecdd599432dcb5c8de8770#diff-b5b368e079b04f16ffb1a62caacf0001aa05595b8f9a2ec999003336b3bf0ca5
pjfanninghttps://github.com/pjfanning
Feb 2, 2018https://github.com/prometheus/client_java/pull/337#discussion_r165632870
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/prometheus/client_java/pull/337
felipe-conde-benavideshttps://github.com/felipe-conde-benavides
Feb 2, 2018https://github.com/prometheus/client_java/pull/337#discussion_r165635778
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/prometheus/client_java/pull/337
changed "tabs" for "spaces"https://github.com/prometheus/client_java/pull/337/commits/2acdc292a2e0c193cfb950d223926d122175fa9d
2acdc29https://github.com/prometheus/client_java/pull/337/commits/2acdc292a2e0c193cfb950d223926d122175fa9d
https://github.com/pjfanning
pjfanninghttps://github.com/pjfanning
Feb 2, 2018https://github.com/prometheus/client_java/pull/337#issuecomment-362579708
Please reload this pagehttps://github.com/prometheus/client_java/pull/337
https://github.com/felipe-conde-benavides
felipe-conde-benavideshttps://github.com/felipe-conde-benavides
Feb 2, 2018https://github.com/prometheus/client_java/pull/337#issuecomment-362581578
Please reload this pagehttps://github.com/prometheus/client_java/pull/337
https://github.com/brian-brazil
brian-brazilhttps://github.com/brian-brazil
Feb 2, 2018https://github.com/prometheus/client_java/pull/337#issuecomment-362596235
…https://github.com/prometheus/client_java/pull/337
#337 (comment)https://github.com/prometheus/client_java/pull/337#issuecomment-362581578
https://github.com/notifications/unsubscribe-auth/AGyTdgOnNb2LVkYcqSiaizXLW5DplvZHks5tQwi1gaJpZM4R1-juhttps://github.com/notifications/unsubscribe-auth/AGyTdgOnNb2LVkYcqSiaizXLW5DplvZHks5tQwi1gaJpZM4R1-ju
Please reload this pagehttps://github.com/prometheus/client_java/pull/337
February 5, 2018 12:27https://github.com/prometheus/client_java/pull/337#commits-pushed-b7e20df
Added "timestamp" field into required classeshttps://github.com/prometheus/client_java/pull/337/commits/b7e20df3e9fec88ae03ab6fd3b2f4f402ec8e8e7
b7e20dfhttps://github.com/prometheus/client_java/pull/337/commits/b7e20df3e9fec88ae03ab6fd3b2f4f402ec8e8e7
Fixed code format.https://github.com/prometheus/client_java/pull/337/commits/70fd6db79b73d53f9e8e5d701f279ae488f9b4c8
70fd6dbhttps://github.com/prometheus/client_java/pull/337/commits/70fd6db79b73d53f9e8e5d701f279ae488f9b4c8
Added unit testshttps://github.com/prometheus/client_java/pull/337/commits/7ff6b0658d19d98000ac9067044561eab7eca49e
7ff6b06https://github.com/prometheus/client_java/pull/337/commits/7ff6b0658d19d98000ac9067044561eab7eca49e
https://github.com/pjfanning
pjfanninghttps://github.com/pjfanning
Feb 5, 2018 https://github.com/prometheus/client_java/pull/337#pullrequestreview-93959400
View reviewed changes https://github.com/prometheus/client_java/pull/337/files/7ff6b0658d19d98000ac9067044561eab7eca49e
simpleclient/src/test/java/io/prometheus/client/CounterTest.javahttps://github.com/prometheus/client_java/pull/337/files/70fd6db79b73d53f9e8e5d701f279ae488f9b4c8..7ff6b0658d19d98000ac9067044561eab7eca49e#diff-7879fbd017b303fc6c885cb1dfad174818ea7b13e707d03386e3c8f3df15ecd8
pjfanninghttps://github.com/pjfanning
Feb 5, 2018https://github.com/prometheus/client_java/pull/337#discussion_r165946685
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/prometheus/client_java/pull/337
Changed "tabs" for "spaces"https://github.com/prometheus/client_java/pull/337/commits/873e3613bdd74fa92b7e82038d9e8bbabe3574a9
873e361https://github.com/prometheus/client_java/pull/337/commits/873e3613bdd74fa92b7e82038d9e8bbabe3574a9
https://github.com/brian-brazil
brian-brazilhttps://github.com/brian-brazil
Feb 7, 2018 https://github.com/prometheus/client_java/pull/337#pullrequestreview-94683044
View reviewed changes https://github.com/prometheus/client_java/pull/337/files/873e3613bdd74fa92b7e82038d9e8bbabe3574a9
simpleclient/src/main/java/io/prometheus/client/Collector.javahttps://github.com/prometheus/client_java/pull/337/files/873e3613bdd74fa92b7e82038d9e8bbabe3574a9#diff-b5b368e079b04f16ffb1a62caacf0001aa05595b8f9a2ec999003336b3bf0ca5
brian-brazilhttps://github.com/brian-brazil
Feb 7, 2018https://github.com/prometheus/client_java/pull/337#discussion_r166596939
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/prometheus/client_java/pull/337
felipe-conde-benavideshttps://github.com/felipe-conde-benavides
Feb 7, 2018https://github.com/prometheus/client_java/pull/337#discussion_r166730075
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/prometheus/client_java/pull/337
simpleclient/src/main/java/io/prometheus/client/Collector.javahttps://github.com/prometheus/client_java/pull/337/files/873e3613bdd74fa92b7e82038d9e8bbabe3574a9#diff-b5b368e079b04f16ffb1a62caacf0001aa05595b8f9a2ec999003336b3bf0ca5
brian-brazilhttps://github.com/brian-brazil
Feb 7, 2018https://github.com/prometheus/client_java/pull/337#discussion_r166597569
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/prometheus/client_java/pull/337
felipe-conde-benavideshttps://github.com/felipe-conde-benavides
Feb 7, 2018https://github.com/prometheus/client_java/pull/337#discussion_r166730627
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/prometheus/client_java/pull/337
simpleclient/src/main/java/io/prometheus/client/Counter.javahttps://github.com/prometheus/client_java/pull/337/files/873e3613bdd74fa92b7e82038d9e8bbabe3574a9#diff-317d9fc548d54d7c78f8d194b051a742c2a2edc0b67bcc740099ea99e87221dc
brian-brazilhttps://github.com/brian-brazil
Feb 7, 2018https://github.com/prometheus/client_java/pull/337#discussion_r166597688
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/prometheus/client_java/pull/337
felipe-conde-benavideshttps://github.com/felipe-conde-benavides
Feb 7, 2018https://github.com/prometheus/client_java/pull/337#discussion_r166722234
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/prometheus/client_java/pull/337
brian-brazilhttps://github.com/brian-brazil
Feb 7, 2018https://github.com/prometheus/client_java/pull/337#discussion_r166737543
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/prometheus/client_java/pull/337
felipe-conde-benavideshttps://github.com/felipe-conde-benavides
Feb 7, 2018https://github.com/prometheus/client_java/pull/337#discussion_r166755976
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/prometheus/client_java/pull/337
simpleclient_common/src/main/java/io/prometheus/client/exporter/common/TextFormat.javahttps://github.com/prometheus/client_java/pull/337/files/873e3613bdd74fa92b7e82038d9e8bbabe3574a9#diff-3fbc4a397071b57de65b209a667f0e88dd332e6cae8b4f80a09aa1b4f45db23f
brian-brazilhttps://github.com/brian-brazil
Feb 7, 2018https://github.com/prometheus/client_java/pull/337#discussion_r166597760
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/prometheus/client_java/pull/337
February 7, 2018 20:32https://github.com/prometheus/client_java/pull/337#commits-pushed-908031e
Renamed timestamp property to timestampMs (Added also a note).https://github.com/prometheus/client_java/pull/337/commits/908031e9ed008fbe758c9660eb2e4dde6eb1a909
908031ehttps://github.com/prometheus/client_java/pull/337/commits/908031e9ed008fbe758c9660eb2e4dde6eb1a909
Minor change: Just moved function setTimeStamp() to be located close …https://github.com/prometheus/client_java/pull/337/commits/3dc7855dd06e0012476498803ac767cc76041f13
3dc7855https://github.com/prometheus/client_java/pull/337/commits/3dc7855dd06e0012476498803ac767cc76041f13
Added also getTimestamp()/setTimestamp() to be aligned with the struc…https://github.com/prometheus/client_java/pull/337/commits/88ee313b9a49af811c0b877aed379f6f7945e0a3
88ee313https://github.com/prometheus/client_java/pull/337/commits/88ee313b9a49af811c0b877aed379f6f7945e0a3
Fixed, property name was changed on "simpleclient" project but not here.https://github.com/prometheus/client_java/pull/337/commits/9bf115968cf69eed8cf709848e5408a16d74c2d8
9bf1159https://github.com/prometheus/client_java/pull/337/commits/9bf115968cf69eed8cf709848e5408a16d74c2d8
Fixed and improved Unit Tests with new property name and also using t…https://github.com/prometheus/client_java/pull/337/commits/ee11fb7e48e58e3749d548879d12a8d279adf717
ee11fb7https://github.com/prometheus/client_java/pull/337/commits/ee11fb7e48e58e3749d548879d12a8d279adf717
Added 2 new Unit Tests using timestamps.https://github.com/prometheus/client_java/pull/337/commits/3af44d7fda8fe9f15fb30c4337184e2e6a2450ca
3af44d7https://github.com/prometheus/client_java/pull/337/commits/3af44d7fda8fe9f15fb30c4337184e2e6a2450ca
Unit test added for metric with timestamphttps://github.com/prometheus/client_java/pull/337/commits/5d6af4327a2ad379315a9568284897f71df20220
5d6af43https://github.com/prometheus/client_java/pull/337/commits/5d6af4327a2ad379315a9568284897f71df20220
https://github.com/felipe-conde-benavides
felipe-conde-benavideshttps://github.com/felipe-conde-benavides
Feb 12, 2018https://github.com/prometheus/client_java/pull/337#issuecomment-365041041
Please reload this pagehttps://github.com/prometheus/client_java/pull/337
Please reload this pagehttps://github.com/prometheus/client_java/pull/337
https://github.com/brian-brazil
brian-brazilhttps://github.com/brian-brazil
Feb 13, 2018 https://github.com/prometheus/client_java/pull/337#pullrequestreview-96111708
View reviewed changes https://github.com/prometheus/client_java/pull/337/files/5d6af4327a2ad379315a9568284897f71df20220
brian-brazilhttps://github.com/brian-brazil
https://github.com/prometheus/client_java/pull/337#pullrequestreview-96111708
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/prometheus/client_java/pull/337
simpleclient_common/src/test/java/io/prometheus/client/exporter/common/TextFormatTest.javahttps://github.com/prometheus/client_java/pull/337/files/5d6af4327a2ad379315a9568284897f71df20220#diff-df2a230fa37418c43fcbacc4fe6d560e06963af2905455556acf6fc5a8766c7e
brian-brazilhttps://github.com/brian-brazil
Feb 13, 2018https://github.com/prometheus/client_java/pull/337#discussion_r167838448
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/prometheus/client_java/pull/337
Removed "timestamp" methods and Unit Tests for "Counter" and "Gauge"https://github.com/prometheus/client_java/pull/337/commits/143bc074156f175f4a74a8b1024fc8e1a8d3aa36
143bc07https://github.com/prometheus/client_java/pull/337/commits/143bc074156f175f4a74a8b1024fc8e1a8d3aa36
Typo fixedhttps://github.com/prometheus/client_java/pull/337/commits/c463ae6a5c8101ceb8a659b8ac1cc3c7a9eed3de
c463ae6https://github.com/prometheus/client_java/pull/337/commits/c463ae6a5c8101ceb8a659b8ac1cc3c7a9eed3de
https://github.com/felipe-conde-benavides
felipe-conde-benavideshttps://github.com/felipe-conde-benavides
Feb 13, 2018https://github.com/prometheus/client_java/pull/337#issuecomment-365392791
Please reload this pagehttps://github.com/prometheus/client_java/pull/337
@brian-brazilhttps://github.com/brian-brazil
Please reload this pagehttps://github.com/prometheus/client_java/pull/337
https://github.com/brian-brazil
brian-brazilhttps://github.com/brian-brazil
Feb 14, 2018 https://github.com/prometheus/client_java/pull/337#pullrequestreview-96430503
View reviewed changes https://github.com/prometheus/client_java/pull/337/files/c463ae6a5c8101ceb8a659b8ac1cc3c7a9eed3de
simpleclient_common/src/test/java/io/prometheus/client/exporter/common/TextFormatTest.javahttps://github.com/prometheus/client_java/pull/337/files/c463ae6a5c8101ceb8a659b8ac1cc3c7a9eed3de#diff-df2a230fa37418c43fcbacc4fe6d560e06963af2905455556acf6fc5a8766c7e
brian-brazilhttps://github.com/brian-brazil
Feb 14, 2018https://github.com/prometheus/client_java/pull/337#discussion_r168117259
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/prometheus/client_java/pull/337
Changed timestamp to fixed value instead of dynamic valuehttps://github.com/prometheus/client_java/pull/337/commits/aae6c18272657c917a1d7a0a32e209acb80ab9a4
aae6c18https://github.com/prometheus/client_java/pull/337/commits/aae6c18272657c917a1d7a0a32e209acb80ab9a4
https://github.com/brian-brazil
brian-brazilhttps://github.com/brian-brazil
5b0a275https://github.com/prometheus/client_java/commit/5b0a2752bcb8a168b69a74fd6c230d6a7d74f9c1
Feb 14, 2018https://github.com/prometheus/client_java/pull/337#event-1473454065
https://github.com/brian-brazil
brian-brazilhttps://github.com/brian-brazil
Feb 14, 2018https://github.com/prometheus/client_java/pull/337#issuecomment-365556519
Please reload this pagehttps://github.com/prometheus/client_java/pull/337
https://github.com/felipe-conde-benavides
felipe-conde-benavideshttps://github.com/felipe-conde-benavides
February 14, 2018 10:27https://github.com/prometheus/client_java/pull/337#event-1473484090
exporter/stats/prometheus: java.lang.NoSuchFieldError: timestampMs census-instrumentation/opencensus-java#1215 https://github.com/census-instrumentation/opencensus-java/issues/1215
Got lots of warning logs (java.lang.NoSuchFieldError: timestampMs) when timestamp field is unset #384 https://github.com/prometheus/client_java/issues/384
https://github.co/hiddenchars
https://github.com/prometheus/client_java/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fprometheus%2Fclient_java%2Fpull%2F337
https://github.com/brian-brazil
brian-brazil https://github.com/brian-brazil
https://github.com/prometheus/client_java/pull/337/files/c463ae6a5c8101ceb8a659b8ac1cc3c7a9eed3de
https://github.com/pjfanning
pjfanning https://github.com/pjfanning
https://github.com/prometheus/client_java/pull/337/files/7ff6b0658d19d98000ac9067044561eab7eca49e
Please reload this pagehttps://github.com/prometheus/client_java/pull/337
Please reload this pagehttps://github.com/prometheus/client_java/pull/337
https://github.com/felipe-conde-benavides
https://github.com/brian-brazil
https://github.com/pjfanning
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.