René's URL Explorer Experiment


Title: fix: Relax metric name validation in Dropwizard5 by LiamClarkeNZ · Pull Request #1985 · prometheus/client_java · GitHub

Open Graph Title: fix: Relax metric name validation in Dropwizard5 by LiamClarkeNZ · Pull Request #1985 · prometheus/client_java

X Title: fix: Relax metric name validation in Dropwizard5 by LiamClarkeNZ · Pull Request #1985 · prometheus/client_java

Description: Decided to revisit a very old PR of mine that addressed an issue that seems to reoccur periodically for others. Changes Relaxes overly strict METRIC_GLOB_REGEX in MapperConfig/GraphiteNamePattern to accept a broader range of metric name patterns The CustomMappingSampleBuilder can now remap metrics with underscores, colons, hyphens, and single-level names Still rejects clearly invalid inputs (empty strings, double-star globs, trailing/double dots) Fixes #461: Cannot match a Graphite metric with only one level #518: Custom metric name remapping fails for non-Graphite-style names #645: MapperConfig does not allow : in regex The validation was originally designed for Graphite bridge metrics but is too restrictive for CustomMappingSampleBuilder which needs to handle arbitrary Dropwizard metric names. @fstab @dhoard @zeitlinger @jaydeluca when you have a chance would appreciate your review :)

Open Graph Description: Decided to revisit a very old PR of mine that addressed an issue that seems to reoccur periodically for others. Changes Relaxes overly strict METRIC_GLOB_REGEX in MapperConfig/GraphiteNamePattern ...

X Description: Decided to revisit a very old PR of mine that addressed an issue that seems to reoccur periodically for others. Changes Relaxes overly strict METRIC_GLOB_REGEX in MapperConfig/GraphiteNamePattern ...

Opengraph URL: https://github.com/prometheus/client_java/pull/1985

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e4921297-8266-d971-175f-c2e79fbf58b2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB586:23A0F:E17D3:129FA0:6AFBAEA3
html-safe-nonce3d237f0722ee3bf9b52688980e30a224a9d7f45675a216ca4a6f50ab24be868c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNTg2OjIzQTBGOkUxN0QzOjEyOUZBMDo2QUZCQUVBMyIsInZpc2l0b3JfaWQiOiI3OTU3MjA5NTU1MTY1NDkwODUxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac54a53e9d39556a578db7b50651027690b1183cd083eb9ced19cf38b5190b5706
hovercard-subject-tagpull_request:3442503697
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/prometheus/client_java/pull/1985/files
twitter:imagehttps://avatars.githubusercontent.com/u/11865380?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/11865380?s=400&v=4
og:image:altDecided to revisit a very old PR of mine that addressed an issue that seems to reoccur periodically for others. Changes Relaxes overly strict METRIC_GLOB_REGEX in MapperConfig/GraphiteNamePattern ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonee25fbd830d3e6ad0e8935c105cf4fdc70c593dffcd27bb45b790ae4fece5ea55
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/prometheus/client_java git https://github.com/prometheus/client_java.git
octolytics-dimension-user_id3380462
octolytics-dimension-user_loginprometheus
octolytics-dimension-repository_id7997879
octolytics-dimension-repository_nwoprometheus/client_java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7997879
octolytics-dimension-repository_network_root_nwoprometheus/client_java
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release08c8f17f9d27054a108b8b6254e405de0151f660
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/prometheus/client_java/pull/1985/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fprometheus%2Fclient_java%2Fpull%2F1985%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fprometheus%2Fclient_java%2Fpull%2F1985%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=prometheus%2Fclient_java
Reloadhttps://github.com/prometheus/client_java/pull/1985/files
Reloadhttps://github.com/prometheus/client_java/pull/1985/files
Reloadhttps://github.com/prometheus/client_java/pull/1985/files
prometheushttps://github.com/prometheus
client_javahttps://github.com/prometheus/client_java
Codehttps://github.com/prometheus/client_java
Issues12 (12)https://github.com/prometheus/client_java/issues
Pull requests18 (18)https://github.com/prometheus/client_java/pulls
Actionshttps://github.com/prometheus/client_java/actions
Projectshttps://github.com/prometheus/client_java/projects
Security and qualityhttps://github.com/prometheus/client_java/security
Insightshttps://github.com/prometheus/client_java/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fprometheus%2Fclient_java%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fprometheus%2Fclient_java%2Fissues%2Fnew%2Fchoose
zeitlingerhttps://github.com/zeitlinger
prometheus:mainhttps://github.com/prometheus/client_java/tree/main
LiamClarkeNZ:fix/relax-dropwizard5-metric-name-validationhttps://github.com/LiamClarkeNZ/client_java/tree/fix/relax-dropwizard5-metric-name-validation
Conversation 3 https://github.com/prometheus/client_java/pull/1985
Commits 2 https://github.com/prometheus/client_java/pull/1985/commits
Checks 9 https://github.com/prometheus/client_java/pull/1985/checks
Files changed https://github.com/prometheus/client_java/pull/1985/files
Please reload this pagehttps://github.com/prometheus/client_java/pull/1985/files
fix: Relax metric name validation in Dropwizard5 https://github.com/prometheus/client_java/pull/1985/files#top
Show all changes 2 commits https://github.com/prometheus/client_java/pull/1985/files
6746915 Relax metric name validation in Dropwizard5 CustomMappingSampleBuilder LiamClarkeNZ Mar 25, 2026 https://github.com/prometheus/client_java/pull/1985/commits/674691523089727f8ec45d117e45068ebeb6ca01
73337c1 Simplify regex LiamClarkeNZ Mar 29, 2026 https://github.com/prometheus/client_java/pull/1985/commits/73337c1dc652c0e57b06e54ae79384a57edd9487
Clear filters https://github.com/prometheus/client_java/pull/1985/files
Please reload this pagehttps://github.com/prometheus/client_java/pull/1985/files
Please reload this pagehttps://github.com/prometheus/client_java/pull/1985/files
GraphiteNamePattern.java https://github.com/prometheus/client_java/pull/1985/files#diff-9e3cdd063ac5d612b355889245fdb963b1bea64a414409c4ef6b2159ac2cfaf2
MapperConfig.java https://github.com/prometheus/client_java/pull/1985/files#diff-0f13781b2e358b7e044618c0a0b3805a3f202880ffac3e1d5db9d9f2744e97a8
GraphiteNamePatternTest.java https://github.com/prometheus/client_java/pull/1985/files#diff-490d61a283849df4d74b0bf355b8126b19a2a7eb8f78708ad066f76381f1a52d
MapperConfigTest.java https://github.com/prometheus/client_java/pull/1985/files#diff-e2e39e13401fc87fdc573f565e4fbe8fcde629c649bc878c40db288c35eb0e6c
https://github.com/prometheus/client_java/blob/main/CODEOWNERS#L4
...in/java/io/prometheus/metrics/instrumentation/dropwizard5/labels/GraphiteNamePattern.javahttps://github.com/prometheus/client_java/pull/1985/files#diff-9e3cdd063ac5d612b355889245fdb963b1bea64a414409c4ef6b2159ac2cfaf2
View file https://github.com/LiamClarkeNZ/client_java/blob/73337c1dc652c0e57b06e54ae79384a57edd9487/prometheus-metrics-instrumentation-dropwizard5/src/main/java/io/prometheus/metrics/instrumentation/dropwizard5/labels/GraphiteNamePattern.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/prometheus/client_java/pull/1985/{{ revealButtonHref }}
https://github.com/prometheus/client_java/pull/1985/files#diff-9e3cdd063ac5d612b355889245fdb963b1bea64a414409c4ef6b2159ac2cfaf2
https://github.com/prometheus/client_java/pull/1985/files#diff-9e3cdd063ac5d612b355889245fdb963b1bea64a414409c4ef6b2159ac2cfaf2
https://github.com/prometheus/client_java/pull/1985/files#diff-9e3cdd063ac5d612b355889245fdb963b1bea64a414409c4ef6b2159ac2cfaf2
https://github.com/prometheus/client_java/blob/main/CODEOWNERS#L4
.../src/main/java/io/prometheus/metrics/instrumentation/dropwizard5/labels/MapperConfig.javahttps://github.com/prometheus/client_java/pull/1985/files#diff-0f13781b2e358b7e044618c0a0b3805a3f202880ffac3e1d5db9d9f2744e97a8
View file https://github.com/LiamClarkeNZ/client_java/blob/73337c1dc652c0e57b06e54ae79384a57edd9487/prometheus-metrics-instrumentation-dropwizard5/src/main/java/io/prometheus/metrics/instrumentation/dropwizard5/labels/MapperConfig.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/prometheus/client_java/pull/1985/{{ revealButtonHref }}
https://github.com/prometheus/client_java/pull/1985/files#diff-0f13781b2e358b7e044618c0a0b3805a3f202880ffac3e1d5db9d9f2744e97a8
https://github.com/prometheus/client_java/pull/1985/files#diff-0f13781b2e358b7e044618c0a0b3805a3f202880ffac3e1d5db9d9f2744e97a8
https://github.com/prometheus/client_java/pull/1985/files#diff-0f13781b2e358b7e044618c0a0b3805a3f202880ffac3e1d5db9d9f2744e97a8
https://github.com/prometheus/client_java/pull/1985/files#diff-0f13781b2e358b7e044618c0a0b3805a3f202880ffac3e1d5db9d9f2744e97a8
https://github.com/prometheus/client_java/blob/main/CODEOWNERS#L4
...ava/io/prometheus/metrics/instrumentation/dropwizard5/labels/GraphiteNamePatternTest.javahttps://github.com/prometheus/client_java/pull/1985/files#diff-490d61a283849df4d74b0bf355b8126b19a2a7eb8f78708ad066f76381f1a52d
View file https://github.com/LiamClarkeNZ/client_java/blob/73337c1dc652c0e57b06e54ae79384a57edd9487/prometheus-metrics-instrumentation-dropwizard5/src/test/java/io/prometheus/metrics/instrumentation/dropwizard5/labels/GraphiteNamePatternTest.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/prometheus/client_java/pull/1985/{{ revealButtonHref }}
https://github.com/prometheus/client_java/pull/1985/files#diff-490d61a283849df4d74b0bf355b8126b19a2a7eb8f78708ad066f76381f1a52d
https://github.com/prometheus/client_java/pull/1985/files#diff-490d61a283849df4d74b0bf355b8126b19a2a7eb8f78708ad066f76381f1a52d
https://github.com/prometheus/client_java/pull/1985/files#diff-490d61a283849df4d74b0bf355b8126b19a2a7eb8f78708ad066f76381f1a52d
https://github.com/prometheus/client_java/blob/main/CODEOWNERS#L4
.../test/java/io/prometheus/metrics/instrumentation/dropwizard5/labels/MapperConfigTest.javahttps://github.com/prometheus/client_java/pull/1985/files#diff-e2e39e13401fc87fdc573f565e4fbe8fcde629c649bc878c40db288c35eb0e6c
View file https://github.com/LiamClarkeNZ/client_java/blob/73337c1dc652c0e57b06e54ae79384a57edd9487/prometheus-metrics-instrumentation-dropwizard5/src/test/java/io/prometheus/metrics/instrumentation/dropwizard5/labels/MapperConfigTest.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/prometheus/client_java/pull/1985/{{ revealButtonHref }}
https://github.com/prometheus/client_java/pull/1985/files#diff-e2e39e13401fc87fdc573f565e4fbe8fcde629c649bc878c40db288c35eb0e6c
https://github.com/prometheus/client_java/pull/1985/files#diff-e2e39e13401fc87fdc573f565e4fbe8fcde629c649bc878c40db288c35eb0e6c
Please reload this pagehttps://github.com/prometheus/client_java/pull/1985/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.