René's URL Explorer Experiment


Title: Code quality improvements · Issue #1816 · prometheus/client_java · GitHub

Open Graph Title: Code quality improvements · Issue #1816 · prometheus/client_java

X Title: Code quality improvements · Issue #1816 · prometheus/client_java

Description: Code Quality Improvement Plan This document tracks code quality improvements for the Prometheus Java Client library. Work through these items incrementally across sessions. High Priority 1. Add Missing Test Coverage for Exporter Modules ...

Open Graph Description: Code Quality Improvement Plan This document tracks code quality improvements for the Prometheus Java Client library. Work through these items incrementally across sessions. High Priority 1. Add Mis...

X Description: Code Quality Improvement Plan This document tracks code quality improvements for the Prometheus Java Client library. Work through these items incrementally across sessions. High Priority 1. Add Mis...

Opengraph URL: https://github.com/prometheus/client_java/issues/1816

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Code quality improvements","articleBody":"# Code Quality Improvement Plan\n\nThis document tracks code quality improvements for the Prometheus Java Client library. Work through these items incrementally across sessions.\n\n## High Priority\n\n### 1. Add Missing Test Coverage for Exporter Modules\n- [x] `prometheus-metrics-exporter-common` - base module, no tests\n- [x] `prometheus-metrics-exporter-servlet-jakarta` - no tests\n- [x] `prometheus-metrics-exporter-servlet-javax` - no tests\n- [x] `prometheus-metrics-exporter-opentelemetry-otel-agent-resources` - no tests\n\n### 2. Eliminate Dropwizard Module Duplication\n- [x] Create shared base class or use generics for `prometheus-metrics-instrumentation-dropwizard` and `prometheus-metrics-instrumentation-dropwizard5` (~297 lines each, nearly identical)\n\n### 3. Address Technical Debt (TODOs)\n- [ ] `prometheus-metrics-core/src/main/java/io/prometheus/metrics/core/metrics/Histogram.java:965` - \"reset interval isn't tested yet\"\n- [ ] `prometheus-metrics-core/src/main/java/io/prometheus/metrics/core/metrics/Summary.java:205` - \"Exemplars (are hard-coded as empty)\"\n- [ ] `prometheus-metrics-core/src/main/java/io/prometheus/metrics/core/metrics/SlidingWindow.java:18` - \"synchronized implementation, room for optimization\"\n- [ ] `prometheus-metrics-config/src/main/java/io/prometheus/metrics/config/PrometheusPropertiesLoader.java:105` - \"Add environment variables like EXEMPLARS_ENABLED\"\n- [ ] `prometheus-metrics-exporter-opentelemetry/src/main/java/io/prometheus/metrics/exporter/opentelemetry/PrometheusMetricProducer.java:44` - \"filter configuration for OpenTelemetry exporter\"\n- [ ] `prometheus-metrics-config/src/main/java/io/prometheus/metrics/config/ExporterOpenTelemetryProperties.java:7` - \"JavaDoc missing\"\n\n### 4. Improve Exception Handling\nReplace broad `catch (Exception e)` with specific exception types:\n- [ ] `prometheus-metrics-instrumentation-dropwizard5/src/main/java/.../DropwizardExports.java:237`\n- [ ] `prometheus-metrics-instrumentation-caffeine/src/main/java/.../CacheMetricsCollector.java:229`\n- [ ] `prometheus-metrics-exporter-opentelemetry/src/main/java/.../PrometheusInstrumentationScope.java:47`\n- [ ] `prometheus-metrics-exporter-opentelemetry/src/main/java/.../OtelAutoConfig.java:115`\n- [ ] `prometheus-metrics-instrumentation-jvm/src/main/java/.../JvmNativeMemoryMetrics.java:166`\n- [ ] `prometheus-metrics-exporter-httpserver/src/main/java/.../HttpExchangeAdapter.java:115`\n\n## Medium Priority\n\n### 5. Add Branch Coverage to JaCoCo\n- [ ] Update `pom.xml` to add branch coverage requirement (~50% minimum)\n```xml\n\u003climit>\n  \u003ccounter>BRANCH\u003c/counter>\n  \u003cvalue>COVEREDRATIO\u003c/value>\n  \u003cminimum>0.50\u003c/minimum>\n\u003c/limit>\n```\n\n### 6. Raise Minimum Coverage Thresholds\nCurrent thresholds to review:\n- [ ] `prometheus-metrics-exporter-httpserver` - 45% (raise to 60%)\n- [ ] `prometheus-metrics-instrumentation-dropwizard5` - 50% (raise to 60%)\n- [ ] `prometheus-metrics-exposition-textformats` - 50% (raise to 60%)\n- [ ] `prometheus-metrics-instrumentation-jvm` - 55% (raise to 60%)\n\n### 7. Add SpotBugs\n- [ ] Add `spotbugs-maven-plugin` to `pom.xml`\n- [ ] Configure with appropriate rule set\n\n### 8. Narrow Checkstyle Suppressions\n- [ ] Review `checkstyle-suppressions.xml` - currently suppresses ALL Javadoc checks globally\n- [ ] Narrow to specific packages/classes that need exceptions\n\n## Lower Priority\n\n### 9. Refactor Large Classes\n- [ ] `prometheus-metrics-core/src/main/java/.../Histogram.java` (978 lines) - consider extracting native histogram logic\n\n### 10. Document Configuration Classes\n- [ ] `PrometheusPropertiesLoader` - add JavaDoc\n- [ ] `ExporterProperties` and related classes - add JavaDoc\n- [ ] `ExporterOpenTelemetryProperties` - add JavaDoc (noted in TODO)\n\n### 11. Consolidate Servlet Exporter Duplication\n- [ ] Extract common logic from `servlet-jakarta` and `servlet-javax` into `exporter-common`\n\n### 12. Add Mutation Testing\n- [ ] Add Pitest (`pitest-maven`) for critical modules\n- [ ] Start with `prometheus-metrics-core` and `prometheus-metrics-model`\n\n---\n\n## Progress Notes\n\n_Add notes here as items are completed:_\n\n| Date | Item | Notes |\n|------|------|-------|\n| 2026-01-24 | Missing Test Coverage for Exporter Modules | Added 55 tests across 4 modules: exporter-common (22 tests), servlet-jakarta (14 tests), servlet-javax (14 tests), otel-agent-resources (5 tests). All tests passing. |\n| 2026-01-24 | Eliminate Dropwizard Module Duplication | Created AbstractDropwizardExports base class (267 lines) with generic type parameters. Reduced dropwizard module from 297 to 209 lines (-88 lines, -30%), dropwizard5 module from 297 to 212 lines (-85 lines, -29%). All tests passing (32 tests dropwizard5, 13 tests dropwizard). |\n","author":{"url":"https://github.com/zeitlinger","@type":"Person","name":"zeitlinger"},"datePublished":"2026-01-26T11:58:10Z","url":"https://github.com/prometheus/client_java/issues/1816"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:d44b53bf-dbe4-4275-bdd5-05922e63e59c
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idD796:B6082:292DBD:36A427:6AFBB70B
html-safe-noncea2d14b672eea5dc82cf0f48db4873d6730494f9cc0f7ad6d5df01727dc31762d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENzk2OkI2MDgyOjI5MkRCRDozNkE0Mjc6NkFGQkI3MEIiLCJ2aXNpdG9yX2lkIjoiNDMyMjQ4OTQzOTYzNzcxNDY5OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac5f203078a43207f6eb0d1ea5729c1cc8af908efb487c9e63796fb6e84e53b6ed
hovercard-subject-tagissue:3855664022
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/prometheus/client_java/1816/issue_layout
twitter:imagehttps://opengraph.githubassets.com/92af31db7f8e59fcc9b258e630aad47805470471dc7d0d45f6e9b99a9dc11937/prometheus/client_java/issues/1816
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/92af31db7f8e59fcc9b258e630aad47805470471dc7d0d45f6e9b99a9dc11937/prometheus/client_java/issues/1816
og:image:altCode Quality Improvement Plan This document tracks code quality improvements for the Prometheus Java Client library. Work through these items incrementally across sessions. High Priority 1. Add Mis...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamezeitlinger
hostnamegithub.com
expected-hostnamegithub.com
None2b2ef9c1578c18d8ed27027940544c958743213cf4461659f14d3ccdf51e162c
turbo-cache-controlno-preview
go-importgithub.com/prometheus/client_java git https://github.com/prometheus/client_java.git
octolytics-dimension-user_id3380462
octolytics-dimension-user_loginprometheus
octolytics-dimension-repository_id7997879
octolytics-dimension-repository_nwoprometheus/client_java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7997879
octolytics-dimension-repository_network_root_nwoprometheus/client_java
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee4cce0e99cf61481a318ff12c2e8580153a6c7c6
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/prometheus/client_java/issues/1816#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fprometheus%2Fclient_java%2Fissues%2F1816
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fprometheus%2Fclient_java%2Fissues%2F1816
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=prometheus%2Fclient_java
Reloadhttps://github.com/prometheus/client_java/issues/1816
Reloadhttps://github.com/prometheus/client_java/issues/1816
Reloadhttps://github.com/prometheus/client_java/issues/1816
prometheushttps://github.com/prometheus
client_javahttps://github.com/prometheus/client_java
Codehttps://github.com/prometheus/client_java
Issues12 (12)https://github.com/prometheus/client_java/issues
Pull requests18 (18)https://github.com/prometheus/client_java/pulls
Actionshttps://github.com/prometheus/client_java/actions
Projectshttps://github.com/prometheus/client_java/projects
Security and qualityhttps://github.com/prometheus/client_java/security
Insightshttps://github.com/prometheus/client_java/pulse
https://github.com/prometheus/client_java
New issuehttps://github.com/login?return_to=https://github.com/prometheus/client_java/issues/1816
New issuehttps://github.com/login?return_to=https://github.com/prometheus/client_java/issues/1816
Code quality improvementshttps://github.com/prometheus/client_java/issues/1816#top
https://github.com/zeitlinger
zeitlingerhttps://github.com/zeitlinger
on Jan 26, 2026https://github.com/prometheus/client_java/issues/1816#issue-3855664022
zeitlingerhttps://github.com/zeitlinger
on Jul 28, 2026https://github.com/prometheus/client_java/issues/1816#event-28604906203
feat: support metric name filtering in OpenTelemetry exporter (#2344)https://github.com/prometheus/client_java/commit/9b0ede830fcf233fb9f9c4cb08ed91ef21fbd667
#2344https://github.com/prometheus/client_java/pull/2344
9b0ede8https://github.com/prometheus/client_java/commit/9b0ede830fcf233fb9f9c4cb08ed91ef21fbd667
https://github.com/zeitlinger
zeitlingerhttps://github.com/zeitlinger
on Nov 3, 2026https://github.com/prometheus/client_java/issues/1816#issuecomment-6602541763
#1882https://github.com/prometheus/client_java/issues/1882
zeitlingerhttps://github.com/zeitlinger
completedhttps://github.com/prometheus/client_java/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Nov 3, 2026https://github.com/prometheus/client_java/issues/1816#event-35012043475
Sign up for freehttps://github.com/signup?return_to=https://github.com/prometheus/client_java/issues/1816
Sign in to commenthttps://github.com/login?return_to=https://github.com/prometheus/client_java/issues/1816
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.