Title: Commit message examples in book not using imperative mood · Issue #1271 · progit/progit2 · GitHub
Open Graph Title: Commit message examples in book not using imperative mood · Issue #1271 · progit/progit2
X Title: Commit message examples in book not using imperative mood · Issue #1271 · progit/progit2
Description: Which version of the book is affected? Problem is present in source files. So naturally all that follows from the source files is also affected. Describe the bug: Not all example commit messages in the source files are using the imperati...
Open Graph Description: Which version of the book is affected? Problem is present in source files. So naturally all that follows from the source files is also affected. Describe the bug: Not all example commit messages in...
X Description: Which version of the book is affected? Problem is present in source files. So naturally all that follows from the source files is also affected. Describe the bug: Not all example commit messages in...
Opengraph URL: https://github.com/progit/progit2/issues/1271
X: @github
Domain: github.com
IPv4 address: 140.82.112.4
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Commit message examples in book not using imperative mood","articleBody":"\u003c!-- Before filing a bug please check the following: -->\r\n\u003c!-- * There's no existing/similar bug report. -->\r\n\u003c!-- * This bug report is about a single actionable bug. -->\r\n\u003c!-- * This bug is about the Pro Git book, version 2, English language. -->\r\n\u003c!-- * This bug is about the book as found on the [website](https://www.git-scm.com/book/en/v2) or the pdf. -->\r\n\u003c!-- * If you found a issue in the pdf/epub/mobi files, you've checked if the problem is also present in the Pro Git book on the [website](https://www.git-scm.com/book/en/v2). -->\r\n\u003c!-- * This bug is **not** about a translation, if so please file a bug with the translation project. You can find a table of translation projects here: [progit2/TRANSLATING.md](https://github.com/progit/progit2/blob/master/TRANSLATING.md) -->\r\n\u003c!-- * This bug is **not** about the git-scm.com site, if so please file a bug here: [git-scm.com/issues/new](https://github.com/git/git-scm.com/issues/new) -->\r\n\u003c!-- * This bug is **not** about git the program itself, if so please file a bug here: [git-scm.com/community](https://git-scm.com/community) -->\r\n\u003c!-- * This bug is **not** about Git for Windows, if so please file a bug here: [git-for-windows/git](https://github.com/git-for-windows/git). -->\r\n\r\n**Which version of the book is affected?**\r\n\u003c!-- It's important for us to know if the problem is in the source or in the tooling for the pdf/epub/mobi files. -->\r\n\u003c!-- Therefore, please write whether the problem is with the files, the online book, or both. -->\r\n\r\nProblem is present in source files. So naturally all that follows from the source files is also affected.\r\n\r\n**Describe the bug:**\r\n\u003c!-- A clear and concise description of what the bug is. -->\r\n\r\nNot all example commit messages in the source files are using the imperative mood.\r\n\r\n**Steps to reproduce:**\r\n\u003c!-- Please write the steps needed to reproduce the bug here. -->\r\n\u003c!-- 1. Go to '...' -->\r\n\u003c!-- 2. Click on '....' -->\r\n\u003c!-- 3. Scroll down to '....' -->\r\n\u003c!-- 4. See error -->\r\n\r\n1. Go to https://github.com/progit/progit2/blob/master/book/03-git-branching/sections/basic-branching-and-merging.asc\r\nand search for: \"fixed the broken email address\".\r\n2. Commit message is not written in the imperative mood (the way git talks to you on the command line).\r\n\r\n**Expected behavior:**\r\n\u003c!-- A clear and concise description of what you expected to happen. -->\r\n\r\nI think it would set a good standard if the readers get to see \"proper\" commit messages throughout the book. This way the readers will get familiar with the correct way to write commit messages.\r\n\r\n**Screenshots:**\r\n\u003c!-- If applicable, add screenshots to help explain your problem. -->\r\n\r\n**Additional context:**\r\n\u003c!-- Add any other context about the problem here. -->\r\n\u003c!-- You can also put references to similar bugs here. -->\r\nReference to our style guide for commits:\r\nFrom https://github.com/progit/progit2/blob/master/book/05-distributed-git/sections/contributing.asc\r\nWrite your commit message in the imperative: \"Fix bug\" and not \"Fixed bug\" or \"Fixes bug.\"\r\n\r\nI'm willing to fix the issue, by making new pull-requests, if @ben wants to change the example commit messages too.\r\n\r\nRelated issue #972.","author":{"url":"https://github.com/HonkingGoose","@type":"Person","name":"HonkingGoose"},"datePublished":"2019-06-25T18:46:34Z","url":"https://github.com/progit/progit2/issues/1271"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:97e81149-6bc2-c6d6-1d96-75b1402e7536 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | BA22:B4652:A9E504:D7DFDC:6B036B08 |
| html-safe-nonce | 07db7e62c2af521a29e7e476f8ef558c808e8acbd81c3a1b676f788e563a084c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQTIyOkI0NjUyOkE5RTUwNDpEN0RGREM6NkIwMzZCMDgiLCJ2aXNpdG9yX2lkIjoiMTQwMDY1NTMyMzExNDcyODIwMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | b759c817c807f8643feb976289b492f8c87ad1e95a36f690a594dfd792bc2e45 |
| hovercard-subject-tag | issue:460582300 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/progit/progit2/1271/issue_layout |
| twitter:image | https://opengraph.githubassets.com/84dd24265d416838574e29f6a719d7fe0abbba2a39b362495b8199dcc0cff605/progit/progit2/issues/1271 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/84dd24265d416838574e29f6a719d7fe0abbba2a39b362495b8199dcc0cff605/progit/progit2/issues/1271 |
| og:image:alt | Which version of the book is affected? Problem is present in source files. So naturally all that follows from the source files is also affected. Describe the bug: Not all example commit messages in... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | HonkingGoose |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| go-import | github.com/progit/progit2 git https://github.com/progit/progit2.git |
| octolytics-dimension-user_id | 95588 |
| octolytics-dimension-user_login | progit |
| octolytics-dimension-repository_id | 15400220 |
| octolytics-dimension-repository_nwo | progit/progit2 |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 15400220 |
| octolytics-dimension-repository_network_root_nwo | progit/progit2 |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
| Server | github.com |
| Content-Type | text/html; charset=utf-8 |
| Cache-Control | max-age=0, private, must-revalidate |
Viewport: width=device-width