Title: Resolves: #[1417] Value Now Compares to missingFloat Variable by ericahin · Pull Request #1441 · processing/processing4 · GitHub
Open Graph Title: Resolves: #[1417] Value Now Compares to missingFloat Variable by ericahin · Pull Request #1441 · processing/processing4
X Title: Resolves: #[1417] Value Now Compares to missingFloat Variable by ericahin · Pull Request #1441 · processing/processing4
Description: ✅ Title: clear and descriptive ✅ Resolves: Resolves #1417 ✅ Changes: Changed the comparison on line 4822 that is checking if the float variable "value" is NaN to use the globally declared variable "missingFloat." This was labeled as a TODO. This maintains consistency throughout the document so is anything were to change, this comparison would stay consistent with the rest of the file. ✅ Tests: I created a function in TableTest.java called testGetMaxFloat() which checks all edge cases of Null, negative numbers, 0, positive numbers, etc. I also tested using the "./gradlew test" command, all tests were passed by this code ✅ Checklist: All tests pass and I have pulled/pushed the most recent changes/updates from upstream onto my branch
Open Graph Description: ✅ Title: clear and descriptive ✅ Resolves: Resolves #1417 ✅ Changes: Changed the comparison on line 4822 that is checking if the float variable "value" is NaN to use the globally declared...
X Description: ✅ Title: clear and descriptive ✅ Resolves: Resolves #1417 ✅ Changes: Changed the comparison on line 4822 that is checking if the float variable "value" is NaN to use the globally ...
Opengraph URL: https://github.com/processing/processing4/pull/1441
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:de26ff9f-a742-24ee-da10-dc1d5b3a9cb0 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C4B4:C4790:65F032:892666:6A5FFBC5 |
| html-safe-nonce | 54265592424a88ac1fc7152be0f7dc1ca850ace112f73a805410da83d5427b49 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNEI0OkM0NzkwOjY1RjAzMjo4OTI2NjY6NkE1RkZCQzUiLCJ2aXNpdG9yX2lkIjoiNTk3NDMxMTE1NDE3NzAxNDcyNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | e0e0df64c3b2bec4e81d9a8679e7975309b5109619507b2b6e891307144a68af |
| hovercard-subject-tag | pull_request:3304830370 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/processing/processing4/pull/1441/files |
| twitter:image | https://avatars.githubusercontent.com/u/129220875?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/129220875?s=400&v=4 |
| og:image:alt | ✅ Title: clear and descriptive ✅ Resolves: Resolves #1417 ✅ Changes: Changed the comparison on line 4822 that is checking if the float variable "value" is NaN to use the globally declared... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 79522f2cee5c5409f33a714312a1a68d41ad77a807626020d980fb1eb81def07 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/processing/processing4 git https://github.com/processing/processing4.git |
| octolytics-dimension-user_id | 1617169 |
| octolytics-dimension-user_login | processing |
| octolytics-dimension-repository_id | 844382769 |
| octolytics-dimension-repository_nwo | processing/processing4 |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 844382769 |
| octolytics-dimension-repository_network_root_nwo | processing/processing4 |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3df4fbea9b6b5ead5c6724a99dc5f5b62caa864b |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width