René's URL Explorer Experiment


Title: don't leak GIT_* env into `npm install` for `language: node` by cbirkhold · Pull Request #3774 · pre-commit/pre-commit · GitHub

Open Graph Title: don't leak GIT_* env into `npm install` for `language: node` by cbirkhold · Pull Request #3774 · pre-commit/pre-commit

X Title: don't leak GIT_* env into `npm install` for `language: node` by cbirkhold · Pull Request #3774 · pre-commit/pre-commit

Description: resolves #3773 Regressed in 4.6.1 (b1cc920, #3719). Since then the node install runs npm install git+file://, which clones and checks out with git. when the install happens from git commit inside a submodule, git has exported absolute GIT_DIR / GIT_INDEX_FILE, so the checkout overwrote the submodule's index. With this change applied, the install runs with no_git_env(), as the initial clone in store.py already does. only the npm install call changes. The environment hooks run in is unchanged. The new test fails without the change (the user repository's index ends up with bin/main.js and package.json) and passes with it. #3773 reproduces the issue in a Docker container. The same Dockerfile may be used to demonstrate the fix with: docker build --build-arg PRE_COMMIT=git+https://github.com/cbirkhold/ext-pre-commit@node-no-git-env-npm-install -t pre-commit-submodule-repro:fix . docker run --rm pre-commit-submodule-repro:fix

Open Graph Description: resolves #3773 Regressed in 4.6.1 (b1cc920, #3719). Since then the node install runs npm install git+file://<store clone>, which clones and checks out with git. when the install happens from ...

X Description: resolves #3773 Regressed in 4.6.1 (b1cc920, #3719). Since then the node install runs npm install git+file://&lt;store clone&gt;, which clones and checks out with git. when the install happe...

Opengraph URL: https://github.com/pre-commit/pre-commit/pull/3774

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:4e6739bb-78c9-1ab3-05d5-30eba0beb833
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9538:21AC3F:41637A4:52BA6D0:6B020091
html-safe-nonced14efe0d051f10666e21fc7f0a317ba546e5d94d85a46159d976e81ee18298c4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NTM4OjIxQUMzRjo0MTYzN0E0OjUyQkE2RDA6NkIwMjAwOTEiLCJ2aXNpdG9yX2lkIjoiMjI0NjUyMDA3MTI5MDg4MTQ1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac5507699aef04eaa5e35e64d148358a89ea148e6a268bb4b885a66dcce7028cc9
hovercard-subject-tagpull_request:4796946524
github-keyboard-shortcutsrepository,commits,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/pre-commit/pre-commit/pull/3774/files
twitter:imagehttps://avatars.githubusercontent.com/u/291214?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/291214?s=400&v=4
og:image:altresolves #3773 Regressed in 4.6.1 (b1cc920, #3719). Since then the node install runs npm install git+file://<store clone>, which clones and checks out with git. when the install happens from ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/pre-commit/pre-commit git https://github.com/pre-commit/pre-commit.git
octolytics-dimension-user_id6943086
octolytics-dimension-user_loginpre-commit
octolytics-dimension-repository_id17689377
octolytics-dimension-repository_nwopre-commit/pre-commit
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id17689377
octolytics-dimension-repository_network_root_nwopre-commit/pre-commit
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/pre-commit/pre-commit/pull/3774/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpre-commit%2Fpre-commit%2Fpull%2F3774%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpre-commit%2Fpre-commit%2Fpull%2F3774%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=pre-commit%2Fpre-commit
Reloadhttps://github.com/pre-commit/pre-commit/pull/3774/files
Reloadhttps://github.com/pre-commit/pre-commit/pull/3774/files
Reloadhttps://github.com/pre-commit/pre-commit/pull/3774/files
pre-commithttps://github.com/pre-commit
pre-commithttps://github.com/pre-commit/pre-commit
Codehttps://github.com/pre-commit/pre-commit
Issues17 (17)https://github.com/pre-commit/pre-commit/issues
Pull requests8 (8)https://github.com/pre-commit/pre-commit/pulls
Actionshttps://github.com/pre-commit/pre-commit/actions
Security and qualityhttps://github.com/pre-commit/pre-commit/security
Insightshttps://github.com/pre-commit/pre-commit/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpre-commit%2Fpre-commit%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpre-commit%2Fpre-commit%2Fissues%2Fnew%2Fchoose
asottilehttps://github.com/asottile
pre-commit:mainhttps://github.com/pre-commit/pre-commit/tree/main
cbirkhold:node-no-git-env-npm-installhttps://github.com/cbirkhold/ext-pre-commit/tree/node-no-git-env-npm-install
Conversation 2 https://github.com/pre-commit/pre-commit/pull/3774
Commits 1 https://github.com/pre-commit/pre-commit/pull/3774/commits
Checks 27 https://github.com/pre-commit/pre-commit/pull/3774/checks
Files changed 2 https://github.com/pre-commit/pre-commit/pull/3774/files
don't leak GIT_* env into npm install for language: node https://github.com/pre-commit/pre-commit/pull/3774/files#top
Show all changes 1 commit https://github.com/pre-commit/pre-commit/pull/3774/files
860d07d don't leak GIT_* env into `npm install` for `language: node` cbirkhold Oct 9, 2026 https://github.com/pre-commit/pre-commit/pull/3774/commits/860d07d18211a0154ffaa4e77bf2a43c2b2473a9
Clear filters https://github.com/pre-commit/pre-commit/pull/3774/files
Please reload this pagehttps://github.com/pre-commit/pre-commit/pull/3774/files
Please reload this pagehttps://github.com/pre-commit/pre-commit/pull/3774/files
node.py https://github.com/pre-commit/pre-commit/pull/3774/files#diff-511cea45e7094a2bb5988a8e2c7b8e0110a0550bbdca7baeedda93a2525e840a
node_test.py https://github.com/pre-commit/pre-commit/pull/3774/files#diff-b4982c8cb2bbc227ec96945c7c2a6e2af446953c221181efda9d33c2bd536bf4
pre_commit/languages/node.pyhttps://github.com/pre-commit/pre-commit/pull/3774/files#diff-511cea45e7094a2bb5988a8e2c7b8e0110a0550bbdca7baeedda93a2525e840a
View file https://github.com/cbirkhold/ext-pre-commit/blob/860d07d18211a0154ffaa4e77bf2a43c2b2473a9/pre_commit/languages/node.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pre-commit/pre-commit/pull/3774/{{ revealButtonHref }}
https://github.com/pre-commit/pre-commit/pull/3774/files#diff-511cea45e7094a2bb5988a8e2c7b8e0110a0550bbdca7baeedda93a2525e840a
https://github.com/pre-commit/pre-commit/pull/3774/files#diff-511cea45e7094a2bb5988a8e2c7b8e0110a0550bbdca7baeedda93a2525e840a
https://github.com/pre-commit/pre-commit/pull/3774/files#diff-511cea45e7094a2bb5988a8e2c7b8e0110a0550bbdca7baeedda93a2525e840a
tests/languages/node_test.pyhttps://github.com/pre-commit/pre-commit/pull/3774/files#diff-b4982c8cb2bbc227ec96945c7c2a6e2af446953c221181efda9d33c2bd536bf4
View file https://github.com/cbirkhold/ext-pre-commit/blob/860d07d18211a0154ffaa4e77bf2a43c2b2473a9/tests/languages/node_test.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pre-commit/pre-commit/pull/3774/{{ revealButtonHref }}
https://github.com/pre-commit/pre-commit/pull/3774/files#diff-b4982c8cb2bbc227ec96945c7c2a6e2af446953c221181efda9d33c2bd536bf4
https://github.com/pre-commit/pre-commit/pull/3774/files#diff-b4982c8cb2bbc227ec96945c7c2a6e2af446953c221181efda9d33c2bd536bf4
Please reload this pagehttps://github.com/pre-commit/pre-commit/pull/3774/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.