René's URL Explorer Experiment


Title: Add `--no-textconv` to `git diff` calls by adamchainz · Pull Request #2743 · pre-commit/pre-commit · GitHub

Open Graph Title: Add `--no-textconv` to `git diff` calls by adamchainz · Pull Request #2743 · pre-commit/pre-commit

X Title: Add `--no-textconv` to `git diff` calls by adamchainz · Pull Request #2743 · pre-commit/pre-commit

Description: Fixes #2742. I fixed the one in run.py, fixing the bug. Ithen audited the other git diff calls to consider whether text conversion would be suitable there. Those using --name-only don't need it, since Git skips text conversion in that case. The diff in _run_hooks is for human consumption doesn't need it because it's for the human to read.

Open Graph Description: Fixes #2742. I fixed the one in run.py, fixing the bug. Ithen audited the other git diff calls to consider whether text conversion would be suitable there. Those using --name-only don't need it...

X Description: Fixes #2742. I fixed the one in run.py, fixing the bug. Ithen audited the other git diff calls to consider whether text conversion would be suitable there. Those using --name-only don't nee...

Opengraph URL: https://github.com/pre-commit/pre-commit/pull/2743

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:388da37c-2262-b400-6f29-494359a1dd8c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8680:37AC61:4639A0:612010:6A584A8F
html-safe-nonceb0e1c1badc926d29d991ca4b03e4d703f40abe4bb59b5e0c1711cfaa002e86fa
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NjgwOjM3QUM2MTo0NjM5QTA6NjEyMDEwOjZBNTg0QThGIiwidmlzaXRvcl9pZCI6Ijg2ODM1NjAyNjgwNDIwOTUyNDciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac3e7728205066d7476938f8e63adebc55c2952ab680cb9176d07edbf60830cf6d
hovercard-subject-tagpull_request:1226389753
github-keyboard-shortcutsrepository,commits,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/pre-commit/pre-commit/pull/2743/files
twitter:imagehttps://avatars.githubusercontent.com/u/857609?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/857609?s=400&v=4
og:image:altFixes #2742. I fixed the one in run.py, fixing the bug. Ithen audited the other git diff calls to consider whether text conversion would be suitable there. Those using --name-only don't need it...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5f2a0c7865178af3d91dd9f13b0cdfc3c73a2529c873d2780bb4c01271a57ec6
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/pre-commit/pre-commit git https://github.com/pre-commit/pre-commit.git
octolytics-dimension-user_id6943086
octolytics-dimension-user_loginpre-commit
octolytics-dimension-repository_id17689377
octolytics-dimension-repository_nwopre-commit/pre-commit
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id17689377
octolytics-dimension-repository_network_root_nwopre-commit/pre-commit
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8aae7b8d6caacacf5c66eaeb2702d8dc88d85b4a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/pre-commit/pre-commit/pull/2743/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpre-commit%2Fpre-commit%2Fpull%2F2743%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpre-commit%2Fpre-commit%2Fpull%2F2743%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=pre-commit%2Fpre-commit
Reloadhttps://github.com/pre-commit/pre-commit/pull/2743/files
Reloadhttps://github.com/pre-commit/pre-commit/pull/2743/files
Reloadhttps://github.com/pre-commit/pre-commit/pull/2743/files
Please reload this pagehttps://github.com/pre-commit/pre-commit/pull/2743/files
pre-commit https://github.com/pre-commit
pre-commithttps://github.com/pre-commit/pre-commit
Please reload this pagehttps://github.com/pre-commit/pre-commit/pull/2743/files
Notifications https://github.com/login?return_to=%2Fpre-commit%2Fpre-commit
Fork 986 https://github.com/login?return_to=%2Fpre-commit%2Fpre-commit
Star 15.4k https://github.com/login?return_to=%2Fpre-commit%2Fpre-commit
Code https://github.com/pre-commit/pre-commit
Issues 21 https://github.com/pre-commit/pre-commit/issues
Pull requests 10 https://github.com/pre-commit/pre-commit/pulls
Actions https://github.com/pre-commit/pre-commit/actions
Security and quality 0 https://github.com/pre-commit/pre-commit/security
Insights https://github.com/pre-commit/pre-commit/pulse
Code https://github.com/pre-commit/pre-commit
Issues https://github.com/pre-commit/pre-commit/issues
Pull requests https://github.com/pre-commit/pre-commit/pulls
Actions https://github.com/pre-commit/pre-commit/actions
Security and quality https://github.com/pre-commit/pre-commit/security
Insights https://github.com/pre-commit/pre-commit/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpre-commit%2Fpre-commit%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpre-commit%2Fpre-commit%2Fissues%2Fnew%2Fchoose
asottilehttps://github.com/asottile
pre-commit:mainhttps://github.com/pre-commit/pre-commit/tree/main
adamchainz:issue_2742https://github.com/adamchainz/pre-commit/tree/issue_2742
Conversation 18 https://github.com/pre-commit/pre-commit/pull/2743
Commits 1 https://github.com/pre-commit/pre-commit/pull/2743/commits
Checks 0 https://github.com/pre-commit/pre-commit/pull/2743/checks
Files changed 2 https://github.com/pre-commit/pre-commit/pull/2743/files
Add --no-textconv to git diff calls https://github.com/pre-commit/pre-commit/pull/2743/files#top
Show all changes 1 commit https://github.com/pre-commit/pre-commit/pull/2743/files
7783a3e Add `--no-textconv` to `git diff` calls adamchainz Feb 2, 2023 https://github.com/pre-commit/pre-commit/pull/2743/commits/7783a3e63a18ea3fb073eef5412b985153abdee8
Clear filters https://github.com/pre-commit/pre-commit/pull/2743/files
Please reload this pagehttps://github.com/pre-commit/pre-commit/pull/2743/files
Please reload this pagehttps://github.com/pre-commit/pre-commit/pull/2743/files
run.py https://github.com/pre-commit/pre-commit/pull/2743/files#diff-94a8d858af77f7e9a4784c7befe9630e10e9396bb96d2470a2314e8513c95885
run_test.py https://github.com/pre-commit/pre-commit/pull/2743/files#diff-d31e4c39349ba8e198d3cefa54cec227f4c0eec8289484ef4e3d730674d2fa01
pre_commit/commands/run.pyhttps://github.com/pre-commit/pre-commit/pull/2743/files#diff-94a8d858af77f7e9a4784c7befe9630e10e9396bb96d2470a2314e8513c95885
View file https://github.com/adamchainz/pre-commit/blob/7783a3e63a18ea3fb073eef5412b985153abdee8/pre_commit/commands/run.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pre-commit/pre-commit/pull/2743/{{ revealButtonHref }}
https://github.com/pre-commit/pre-commit/pull/2743/files#diff-94a8d858af77f7e9a4784c7befe9630e10e9396bb96d2470a2314e8513c95885
Please reload this pagehttps://github.com/pre-commit/pre-commit/pull/2743/files
https://github.com/pre-commit/pre-commit/pull/2743/files#diff-94a8d858af77f7e9a4784c7befe9630e10e9396bb96d2470a2314e8513c95885
https://github.com/pre-commit/pre-commit/pull/2743/files#diff-94a8d858af77f7e9a4784c7befe9630e10e9396bb96d2470a2314e8513c95885
https://github.com/pre-commit/pre-commit/pull/2743/files#diff-94a8d858af77f7e9a4784c7befe9630e10e9396bb96d2470a2314e8513c95885
tests/commands/run_test.pyhttps://github.com/pre-commit/pre-commit/pull/2743/files#diff-d31e4c39349ba8e198d3cefa54cec227f4c0eec8289484ef4e3d730674d2fa01
View file https://github.com/adamchainz/pre-commit/blob/7783a3e63a18ea3fb073eef5412b985153abdee8/tests/commands/run_test.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pre-commit/pre-commit/pull/2743/{{ revealButtonHref }}
https://github.com/pre-commit/pre-commit/pull/2743/files#diff-d31e4c39349ba8e198d3cefa54cec227f4c0eec8289484ef4e3d730674d2fa01
https://github.com/pre-commit/pre-commit/pull/2743/files#diff-d31e4c39349ba8e198d3cefa54cec227f4c0eec8289484ef4e3d730674d2fa01
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.