René's URL Explorer Experiment


Title: Fix command normalization when a custom env is passed by taoufik07 · Pull Request #2677 · pre-commit/pre-commit · GitHub

Open Graph Title: Fix command normalization when a custom env is passed by taoufik07 · Pull Request #2677 · pre-commit/pre-commit

X Title: Fix command normalization when a custom env is passed by taoufik07 · Pull Request #2677 · pre-commit/pre-commit

Description: A framework for managing and maintaining multi-language pre-commit hooks. - Fix command normalization when a custom env is passed by taoufik07 · Pull Request #2677 · pre-commit/pre-commit

Open Graph Description: Custom envs can't be passed to normalize_cmd which causes find_executable to default to os.environ -- works as expected when injecting directly os.environ.

X Description: Custom envs can't be passed to normalize_cmd which causes find_executable to default to os.environ -- works as expected when injecting directly os.environ.

Opengraph URL: https://github.com/pre-commit/pre-commit/pull/2677

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2a184f35-18be-73c3-c24f-ee4bef15cb83
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAB9E:3FF32B:49D638:65E18F:6A57D06B
html-safe-nonce852d8805d977e5dc215835aac4f66af86ee5f98d936c0325ac31d12126c83007
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQjlFOjNGRjMyQjo0OUQ2Mzg6NjVFMThGOjZBNTdEMDZCIiwidmlzaXRvcl9pZCI6IjQ0NjQwMjQ4ODEzNjYyOTA1MzkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace3c118314270943e1b9f57c359f5deea2fbffb946ab2673ee1042a614e738175
hovercard-subject-tagpull_request:1186471206
github-keyboard-shortcutsrepository,commits,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/pre-commit/pre-commit/2677/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ff9ef88d387b8ae7e5121bf0759fd9c794cd10b369aaf44586ba5d8367a62ad9/pre-commit/pre-commit/pull/2677
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ff9ef88d387b8ae7e5121bf0759fd9c794cd10b369aaf44586ba5d8367a62ad9/pre-commit/pre-commit/pull/2677
og:image:altCustom envs can't be passed to normalize_cmd which causes find_executable to default to os.environ -- works as expected when injecting directly os.environ.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametaoufik07
hostnamegithub.com
expected-hostnamegithub.com
None5bf9f84655de1d0e9aa064cd3b2bc9703556c68ae53b94e21b872b7e9f1f7cc1
turbo-cache-controlno-cache
go-importgithub.com/pre-commit/pre-commit git https://github.com/pre-commit/pre-commit.git
octolytics-dimension-user_id6943086
octolytics-dimension-user_loginpre-commit
octolytics-dimension-repository_id17689377
octolytics-dimension-repository_nwopre-commit/pre-commit
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id17689377
octolytics-dimension-repository_network_root_nwopre-commit/pre-commit
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef76ee5bea8be15c2aede06f855f5c4c808f6eaf5
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/pre-commit/pre-commit/pull/2677#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpre-commit%2Fpre-commit%2Fpull%2F2677
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpre-commit%2Fpre-commit%2Fpull%2F2677
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=pre-commit%2Fpre-commit
Reloadhttps://github.com/pre-commit/pre-commit/pull/2677
Reloadhttps://github.com/pre-commit/pre-commit/pull/2677
Reloadhttps://github.com/pre-commit/pre-commit/pull/2677
Please reload this pagehttps://github.com/pre-commit/pre-commit/pull/2677
pre-commit https://github.com/pre-commit
pre-commithttps://github.com/pre-commit/pre-commit
Please reload this pagehttps://github.com/pre-commit/pre-commit/pull/2677
Notifications https://github.com/login?return_to=%2Fpre-commit%2Fpre-commit
Fork 986 https://github.com/login?return_to=%2Fpre-commit%2Fpre-commit
Star 15.4k https://github.com/login?return_to=%2Fpre-commit%2Fpre-commit
Code https://github.com/pre-commit/pre-commit
Issues 22 https://github.com/pre-commit/pre-commit/issues
Pull requests 12 https://github.com/pre-commit/pre-commit/pulls
Actions https://github.com/pre-commit/pre-commit/actions
Security and quality 0 https://github.com/pre-commit/pre-commit/security
Insights https://github.com/pre-commit/pre-commit/pulse
Code https://github.com/pre-commit/pre-commit
Issues https://github.com/pre-commit/pre-commit/issues
Pull requests https://github.com/pre-commit/pre-commit/pulls
Actions https://github.com/pre-commit/pre-commit/actions
Security and quality https://github.com/pre-commit/pre-commit/security
Insights https://github.com/pre-commit/pre-commit/pulse
asottilehttps://github.com/asottile
pre-commit:mainhttps://github.com/pre-commit/pre-commit/tree/main
taoufik07:fix_cmd_norm_envhttps://github.com/taoufik07/pre-commit/tree/fix_cmd_norm_env
Conversationhttps://github.com/pre-commit/pre-commit/pull/2677
Commits1 (1)https://github.com/pre-commit/pre-commit/pull/2677/commits
Checkshttps://github.com/pre-commit/pre-commit/pull/2677/checks
Files changedhttps://github.com/pre-commit/pre-commit/pull/2677/files
Fix command normalization when a custom env is passedhttps://github.com/pre-commit/pre-commit/pull/2677#top
asottilehttps://github.com/asottile
pre-commit:mainhttps://github.com/pre-commit/pre-commit/tree/main
taoufik07:fix_cmd_norm_envhttps://github.com/taoufik07/pre-commit/tree/fix_cmd_norm_env
https://github.com/taoufik07
taoufik07https://github.com/taoufik07
Jan 5, 2023https://github.com/pre-commit/pre-commit/pull/2677#issue-1520707320
Please reload this pagehttps://github.com/pre-commit/pre-commit/pull/2677
https://github.com/asottile
asottilehttps://github.com/asottile
Jan 5, 2023 https://github.com/pre-commit/pre-commit/pull/2677#pullrequestreview-1237410865
View reviewed changes https://github.com/pre-commit/pre-commit/pull/2677/files
pre_commit/parse_shebang.pyhttps://github.com/pre-commit/pre-commit/pull/2677/files#diff-6536c1c27810ee3cfac0b2ffdd3b7bf4aeed2f96b92ce0098b876bab4f8bdc9e
asottilehttps://github.com/asottile
Jan 5, 2023https://github.com/pre-commit/pre-commit/pull/2677#discussion_r1062487194
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/pre-commit/pre-commit/pull/2677
taoufik07https://github.com/taoufik07
Jan 5, 2023https://github.com/pre-commit/pre-commit/pull/2677#discussion_r1062936793
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/pre-commit/pre-commit/pull/2677
https://github.com/taoufik07
taoufik07https://github.com/taoufik07
force-pushedhttps://github.com/pre-commit/pre-commit/compare/411ef96f4b1882525cb91a3dc356cd9fa559186f..338de0890f596bb30ad3290ae75670dcc1640246
411ef96https://github.com/pre-commit/pre-commit/commit/411ef96f4b1882525cb91a3dc356cd9fa559186f
338de08https://github.com/pre-commit/pre-commit/commit/338de0890f596bb30ad3290ae75670dcc1640246
Compare https://github.com/pre-commit/pre-commit/compare/411ef96f4b1882525cb91a3dc356cd9fa559186f..338de0890f596bb30ad3290ae75670dcc1640246
January 5, 2023 20:39https://github.com/pre-commit/pre-commit/pull/2677#event-8163780667
https://github.com/asottile
asottilehttps://github.com/asottile
Jan 5, 2023 https://github.com/pre-commit/pre-commit/pull/2677#pullrequestreview-1238060722
View reviewed changes https://github.com/pre-commit/pre-commit/pull/2677/files
tests/commands/install_uninstall_test.pyhttps://github.com/pre-commit/pre-commit/pull/2677/files#diff-810931f96e5f27eb8a12b893d5a58553e6d6aa5bffa120102ac338e0efca9f5f
asottilehttps://github.com/asottile
Jan 5, 2023https://github.com/pre-commit/pre-commit/pull/2677#discussion_r1062903843
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/pre-commit/pre-commit/pull/2677
taoufik07https://github.com/taoufik07
Jan 5, 2023https://github.com/pre-commit/pre-commit/pull/2677#discussion_r1062936533
Please reload this pagehttps://github.com/pre-commit/pre-commit/pull/2677
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
it couldn't find githttps://github.com/pre-commit/pre-commit/actions/runs/3846909004/jobs/6552743634#step:7:117
Please reload this pagehttps://github.com/pre-commit/pre-commit/pull/2677
https://github.com/taoufik07
taoufik07https://github.com/taoufik07
force-pushedhttps://github.com/pre-commit/pre-commit/compare/f7fecc18ba5246b98da9eae913bb16db7bbc4b47..ada060c49045165d2d2b86699b67a378727bc46b
f7fecc1https://github.com/pre-commit/pre-commit/commit/f7fecc18ba5246b98da9eae913bb16db7bbc4b47
ada060chttps://github.com/pre-commit/pre-commit/commit/ada060c49045165d2d2b86699b67a378727bc46b
Compare https://github.com/pre-commit/pre-commit/compare/f7fecc18ba5246b98da9eae913bb16db7bbc4b47..ada060c49045165d2d2b86699b67a378727bc46b
January 5, 2023 22:56https://github.com/pre-commit/pre-commit/pull/2677#event-8164609154
https://github.com/taoufik07
https://github.com/asottile
Fix command normalization when a custom env is passedhttps://github.com/pre-commit/pre-commit/pull/2677/commits/bf1a1fa5fd6de3633b033847964b51a60ffbd0d5
bf1a1fahttps://github.com/pre-commit/pre-commit/pull/2677/commits/bf1a1fa5fd6de3633b033847964b51a60ffbd0d5
https://github.com/asottile
asottilehttps://github.com/asottile
force-pushedhttps://github.com/pre-commit/pre-commit/compare/ada060c49045165d2d2b86699b67a378727bc46b..bf1a1fa5fd6de3633b033847964b51a60ffbd0d5
ada060chttps://github.com/pre-commit/pre-commit/commit/ada060c49045165d2d2b86699b67a378727bc46b
bf1a1fahttps://github.com/pre-commit/pre-commit/commit/bf1a1fa5fd6de3633b033847964b51a60ffbd0d5
Compare https://github.com/pre-commit/pre-commit/compare/ada060c49045165d2d2b86699b67a378727bc46b..bf1a1fa5fd6de3633b033847964b51a60ffbd0d5
January 6, 2023 14:27https://github.com/pre-commit/pre-commit/pull/2677#event-8169738192
https://github.com/asottile
asottilehttps://github.com/asottile
Jan 6, 2023 https://github.com/pre-commit/pre-commit/pull/2677#pullrequestreview-1238909092
View reviewed changes https://github.com/pre-commit/pre-commit/pull/2677/files
asottilehttps://github.com/asottile
https://github.com/pre-commit/pre-commit/pull/2677#pullrequestreview-1238909092
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://camo.githubusercontent.com/83fc746b9abbe018b6689e485de3c90ba9a425c46fdfc4d21eaaab9c46b108aa/68747470733a2f2f692e666c756666792e63632f425067785a6b6d7372676d6663444644434e5743336d3443573067434a4637772e676966
Please reload this pagehttps://github.com/pre-commit/pre-commit/pull/2677
https://github.com/asottile
asottilehttps://github.com/asottile
January 6, 2023 14:28https://github.com/pre-commit/pre-commit/pull/2677#event-8169739771
https://github.com/asottile
asottilehttps://github.com/asottile
dc667abhttps://github.com/pre-commit/pre-commit/commit/dc667ab9fbb75e17f7b57ab1d3c8e39e017df223
Jan 6, 2023https://github.com/pre-commit/pre-commit/pull/2677#event-8169988678
https://github.com/taoufik07
taoufik07https://github.com/taoufik07
Jan 8, 2023 https://github.com/pre-commit/pre-commit/pull/2677#ref-pullrequest-1509787018
Make Golang a first class language #2651 https://github.com/pre-commit/pre-commit/pull/2651
https://github.co/hiddenchars
https://github.com/pre-commit/pre-commit/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpre-commit%2Fpre-commit%2Fpull%2F2677
https://github.com/asottile
asottile https://github.com/asottile
https://github.com/pre-commit/pre-commit/pull/2677/files/ada060c49045165d2d2b86699b67a378727bc46b
Please reload this pagehttps://github.com/pre-commit/pre-commit/pull/2677
https://github.com/taoufik07
https://github.com/asottile
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.