René's URL Explorer Experiment


Title: Fix r hooks when hook repo is a package by lorenzwalthert · Pull Request #1831 · pre-commit/pre-commit · GitHub

Open Graph Title: Fix r hooks when hook repo is a package by lorenzwalthert · Pull Request #1831 · pre-commit/pre-commit

X Title: Fix r hooks when hook repo is a package by lorenzwalthert · Pull Request #1831 · pre-commit/pre-commit

Description: In #1799, we assume env_dir instead of prefix_dir as the package source and install it, which creates a package with the right name (because of DESCRIPTION), but obviously does not expose any API and is hence useless. Hooks that rely on the installed package hence fail. Also removing an (apparently) randomly introduced \ that does not cause any harm.

Open Graph Description: In #1799, we assume env_dir instead of prefix_dir as the package source and install it, which creates a package with the right name (because of DESCRIPTION), but obviously does not expose any API a...

X Description: In #1799, we assume env_dir instead of prefix_dir as the package source and install it, which creates a package with the right name (because of DESCRIPTION), but obviously does not expose any API a...

Opengraph URL: https://github.com/pre-commit/pre-commit/pull/1831

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:5553c4fd-b692-16fd-3fa9-7827ede3d4da
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC930:3D0DAC:7E00AE:B6B4DE:6A55ED77
html-safe-nonce19b8360fc502298ee6bd1d21fb05fbdce31c2c8a25a970ade517efa5d2fbec9c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOTMwOjNEMERBQzo3RTAwQUU6QjZCNERFOjZBNTVFRDc3IiwidmlzaXRvcl9pZCI6IjU1NTIzOTQ4ODI5NDAwMDU3NTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaced2d7d5271036fa8a77e7f32615fec5aef91e32f685fc4c64b35e2624726ad22
hovercard-subject-tagpull_request:586932543
github-keyboard-shortcutsrepository,commits,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/pre-commit/pre-commit/pull/1831/files
twitter:imagehttps://avatars.githubusercontent.com/u/10477073?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/10477073?s=400&v=4
og:image:altIn #1799, we assume env_dir instead of prefix_dir as the package source and install it, which creates a package with the right name (because of DESCRIPTION), but obviously does not expose any API a...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb5665c84831ed9ac4fb79519c16c9c5580ba8092fb8bb6e3e72972ec7197348e
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/pre-commit/pre-commit git https://github.com/pre-commit/pre-commit.git
octolytics-dimension-user_id6943086
octolytics-dimension-user_loginpre-commit
octolytics-dimension-repository_id17689377
octolytics-dimension-repository_nwopre-commit/pre-commit
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id17689377
octolytics-dimension-repository_network_root_nwopre-commit/pre-commit
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3725c7f9b2a6e3a27ef57c5aed13428c0f65e045
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/pre-commit/pre-commit/pull/1831/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpre-commit%2Fpre-commit%2Fpull%2F1831%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpre-commit%2Fpre-commit%2Fpull%2F1831%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=pre-commit%2Fpre-commit
Reloadhttps://github.com/pre-commit/pre-commit/pull/1831/files
Reloadhttps://github.com/pre-commit/pre-commit/pull/1831/files
Reloadhttps://github.com/pre-commit/pre-commit/pull/1831/files
Please reload this pagehttps://github.com/pre-commit/pre-commit/pull/1831/files
pre-commit https://github.com/pre-commit
pre-commithttps://github.com/pre-commit/pre-commit
Please reload this pagehttps://github.com/pre-commit/pre-commit/pull/1831/files
Notifications https://github.com/login?return_to=%2Fpre-commit%2Fpre-commit
Fork 986 https://github.com/login?return_to=%2Fpre-commit%2Fpre-commit
Star 15.4k https://github.com/login?return_to=%2Fpre-commit%2Fpre-commit
Code https://github.com/pre-commit/pre-commit
Issues 22 https://github.com/pre-commit/pre-commit/issues
Pull requests 13 https://github.com/pre-commit/pre-commit/pulls
Actions https://github.com/pre-commit/pre-commit/actions
Security and quality 0 https://github.com/pre-commit/pre-commit/security
Insights https://github.com/pre-commit/pre-commit/pulse
Code https://github.com/pre-commit/pre-commit
Issues https://github.com/pre-commit/pre-commit/issues
Pull requests https://github.com/pre-commit/pre-commit/pulls
Actions https://github.com/pre-commit/pre-commit/actions
Security and quality https://github.com/pre-commit/pre-commit/security
Insights https://github.com/pre-commit/pre-commit/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpre-commit%2Fpre-commit%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpre-commit%2Fpre-commit%2Fissues%2Fnew%2Fchoose
asottilehttps://github.com/asottile
pre-commit:masterhttps://github.com/pre-commit/pre-commit/tree/master
lorenzwalthert:renv-fixhttps://github.com/lorenzwalthert/pre-commit/tree/renv-fix
Conversation 6 https://github.com/pre-commit/pre-commit/pull/1831
Commits 1 https://github.com/pre-commit/pre-commit/pull/1831/commits
Checks 0 https://github.com/pre-commit/pre-commit/pull/1831/checks
Files changed https://github.com/pre-commit/pre-commit/pull/1831/files
Please reload this pagehttps://github.com/pre-commit/pre-commit/pull/1831/files
Fix r hooks when hook repo is a package https://github.com/pre-commit/pre-commit/pull/1831/files#top
Show all changes 1 commit https://github.com/pre-commit/pre-commit/pull/1831/files
cf57e35 install package from prefix_dir, not env_dir (which yields empty pkg) lorenzwalthert Mar 8, 2021 https://github.com/pre-commit/pre-commit/pull/1831/commits/cf57e35e3753ebe62469998c3fbd6cf48acfc651
Clear filters https://github.com/pre-commit/pre-commit/pull/1831/files
Please reload this pagehttps://github.com/pre-commit/pre-commit/pull/1831/files
Please reload this pagehttps://github.com/pre-commit/pre-commit/pull/1831/files
pre_commit/languages/r.pyhttps://github.com/pre-commit/pre-commit/pull/1831/files#diff-813c025754186e7d7af82275ff89a79dd4bce3f2e037190c30c2f5a1aa1c8a9d
View file https://github.com/lorenzwalthert/pre-commit/blob/cf57e35e3753ebe62469998c3fbd6cf48acfc651/pre_commit/languages/r.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/pre-commit/pre-commit/pull/1831/{{ revealButtonHref }}
https://github.com/pre-commit/pre-commit/pull/1831/files#diff-813c025754186e7d7af82275ff89a79dd4bce3f2e037190c30c2f5a1aa1c8a9d
https://github.com/pre-commit/pre-commit/pull/1831/files#diff-813c025754186e7d7af82275ff89a79dd4bce3f2e037190c30c2f5a1aa1c8a9d
https://github.com/pre-commit/pre-commit/pull/1831/files#diff-813c025754186e7d7af82275ff89a79dd4bce3f2e037190c30c2f5a1aa1c8a9d
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.