René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Very poor color contrast with dark themes. Potential fixes included.","articleBody":"I recently discovered this project and I love it, it helps me to catch simple issues, keep my commit history cleaner, and avoid wasting time on failed CI runs. Kudos!\r\n\r\nThe one issue I've had is extremely poor contrast with the color highlighting when using a dark color scheme, very similar to #2268. I've seen the answer given in that issue, and I disagree with the assessment that the terminal color scheme is to blame. I'm using a common color scheme (One Dark) that is widely tested in IDEs, terminals, and editors. I use this color scheme system-wide and I have no problems with the output of any other CLI application, or any elements of my window manager. The issue is 100% down to the implementation of highlighting in pre-commit. I suspect this issue is affecting the users of many common terminal dark themes.\r\n\r\n---\r\n### Solutions\r\n\r\nI can propose two ways of fixing this problem, both could be easily implemented as options:\r\n1. Highlight the text foreground, rather than the background.\r\n2. When using background highlighting, the text foreground color should become the terminal background color. This option wouldn't change the branding of the application in any significant way.\r\n\r\nEither of these solutions could be implemented as simple environment variables, or the latter could possibly be done automatically based on the terminal's foreground and background colors.\r\n\r\n---\r\n### Screenshots\r\n \r\n**Default pre-commit highlighting:**\r\n![pre-commit-default](https://user-images.githubusercontent.com/59636191/161409703-65cc6c66-cf28-48a3-973f-1ca4a86412ce.png)\r\n\r\n**Using only foreground highlighting:**\r\n![pre-commit-fg-no-bg](https://user-images.githubusercontent.com/59636191/161409462-f6afd841-cb2e-4ce9-bc53-ade23025fbb0.png)\r\n\r\n**Using inverse background highlighting:**\r\n![pre-commit-bg-inverted](https://user-images.githubusercontent.com/59636191/161409461-cd39f897-ad33-484e-bb0f-29a13f447d08.png)\r\n\r\n**Full screenshot of my system:**\r\n![vim-screenshot](https://user-images.githubusercontent.com/59636191/161409519-78123747-3aef-40aa-8d55-0fe3b5948573.png)\r\n\r\n---\r\n\r\nAs you can see, it is absolutely nothing to do with my color scheme, and by changing the way pre-commit highlights text it is entirely possible to create a visually pleasing result like you see in the rest of my OS.\r\n\r\nI fully understand if you aren't interested in doing the work for this, as it is a fairly trivial issue and it's likely a lot of work to maintain this project already. However, I do hope you would consider having a discussion about the logistics, and accepting a Pull Request to implement some kind of solution for dark theme users.\r\n\r\nThanks for your time.","author":{"url":"https://github.com/ralgar","@type":"Person","name":"ralgar"},"datePublished":"2022-04-03T04:06:17.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":3},"url":"https://github.com/2325/pre-commit/issues/2325"}