Title: pre-commit Passed badge has very poor contrast (gray on green) · Issue #2268 · pre-commit/pre-commit · GitHub
Open Graph Title: pre-commit Passed badge has very poor contrast (gray on green) · Issue #2268 · pre-commit/pre-commit
X Title: pre-commit Passed badge has very poor contrast (gray on green) · Issue #2268 · pre-commit/pre-commit
Description: describe your issue It seems that the ANSI colors combination used by pre-commit tool to displayed the result of a hook run is using an unfortunate color combination: light-gray on green, something that is hard to read on almost any term...
Open Graph Description: describe your issue It seems that the ANSI colors combination used by pre-commit tool to displayed the result of a hook run is using an unfortunate color combination: light-gray on green, something...
X Description: describe your issue It seems that the ANSI colors combination used by pre-commit tool to displayed the result of a hook run is using an unfortunate color combination: light-gray on green, something...
Opengraph URL: https://github.com/pre-commit/pre-commit/issues/2268
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"pre-commit Passed badge has very poor contrast (gray on green)","articleBody":"### describe your issue\n\nIt seems that the ANSI colors combination used by pre-commit tool to displayed the result of a hook run is using an unfortunate color combination: light-gray on green, something that is hard to read on almost any terminal color theme.\r\n\r\nI do suspect a reason for this is that it does only decides to change the default (transparent) background to green. Those few that are using a white background terminal as less likely to be impacted by the constrast issue, but those on dark backgrounds are high likely to be affected.\r\n\r\nThere are many way this can be avoided, even with avoiding use of background color and sticking just to coloring the text foreground or forcing use of either pure bold-white or black for text color, instead of defaulting to default text.\r\n\r\nDefault text color is usually a non bold/highlighted color, a shade of gray, which is exactly the kind of color that has a bad contrast with green in particular. To a lesser extent the same applies to red background.\r\n\r\nPlease note that I am not suffering from any colour vision deficiency, so we could expect others to find the contrast issue even more than me:\r\n\r\n\u003cimg width=\"158\" alt=\"pre-commit-contrast-issue\" src=\"https://user-images.githubusercontent.com/17796449/156756637-d05e5167-fd2a-41df-b2fc-79f171e17e5d.png\"\u003e\r\n.\n\n### pre-commit --version\n\n2.17.0\n\n### .pre-commit-config.yaml\n\n```yaml\nN/A\n```\n\n\n### ~/.cache/pre-commit/pre-commit.log (if present)\n\n_No response_","author":{"url":"https://github.com/bristea","@type":"Person","name":"bristea"},"datePublished":"2022-03-04T11:38:05.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":3},"url":"https://github.com/2268/pre-commit/issues/2268"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:e93d2ace-818d-bc83-4579-5caf398411c2 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | B9F2:3AFEE:1AF79DD:226BF11:6991B7A5 |
| html-safe-nonce | 17c4b81363fb3de3a5ce0fb49a30e3aac5910cd032142314231f2a5c73d8ca8e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOUYyOjNBRkVFOjFBRjc5REQ6MjI2QkYxMTo2OTkxQjdBNSIsInZpc2l0b3JfaWQiOiIxODYxODY5NzU3ODY2NzgxODEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | fe474f2d20e62a6db6a51fb5783bc806edf55b43d9e5390a6bec376509cc9cb1 |
| hovercard-subject-tag | issue:1159552051 |
| github-keyboard-shortcuts | repository,issues,commits,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/pre-commit/pre-commit/2268/issue_layout |
| twitter:image | https://opengraph.githubassets.com/911cb25dfe65a7130426c35c45e12e97eb17fe85dd718d7744962156f61a89ed/pre-commit/pre-commit/issues/2268 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/911cb25dfe65a7130426c35c45e12e97eb17fe85dd718d7744962156f61a89ed/pre-commit/pre-commit/issues/2268 |
| og:image:alt | describe your issue It seems that the ANSI colors combination used by pre-commit tool to displayed the result of a hook run is using an unfortunate color combination: light-gray on green, something... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bristea |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-preview |
| go-import | github.com/pre-commit/pre-commit git https://github.com/pre-commit/pre-commit.git |
| octolytics-dimension-user_id | 6943086 |
| octolytics-dimension-user_login | pre-commit |
| octolytics-dimension-repository_id | 17689377 |
| octolytics-dimension-repository_nwo | pre-commit/pre-commit |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 17689377 |
| octolytics-dimension-repository_network_root_nwo | pre-commit/pre-commit |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width