René's URL Explorer Experiment


Title: Add support for Go 1.16 · Issue #1815 · pre-commit/pre-commit · GitHub

Open Graph Title: Add support for Go 1.16 · Issue #1815 · pre-commit/pre-commit

X Title: Add support for Go 1.16 · Issue #1815 · pre-commit/pre-commit

Description: Go 1.16 now rejects empty go.mod files (c.f. golang/go@d4986e0). This means that golang hooks cannot be installed anymore: $ pre-commit install-hooks [INFO] Initializing environment for local. [INFO] Installing environment for local. [IN...

Open Graph Description: Go 1.16 now rejects empty go.mod files (c.f. golang/go@d4986e0). This means that golang hooks cannot be installed anymore: $ pre-commit install-hooks [INFO] Initializing environment for local. [INF...

X Description: Go 1.16 now rejects empty go.mod files (c.f. golang/go@d4986e0). This means that golang hooks cannot be installed anymore: $ pre-commit install-hooks [INFO] Initializing environment for local. [INF...

Opengraph URL: https://github.com/pre-commit/pre-commit/issues/1815

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Add support for Go 1.16","articleBody":"Go 1.16 now rejects empty `go.mod` files (c.f. https://github.com/golang/go/commit/d4986e0e1d6e03e1b92e905ca5e01b4c223fbeb3). This means that `golang` hooks cannot be installed anymore:\r\n\r\n```\r\n$ pre-commit install-hooks\r\n[INFO] Initializing environment for local.\r\n[INFO] Installing environment for local.\r\n[INFO] Once installed this environment will be reused.\r\n[INFO] This may take a few minutes...\r\nAn unexpected error has occurred: CalledProcessError: command: ('/usr/local/bin/go', 'get', './...')\r\nreturn code: 1\r\nexpected return code: 0\r\nstdout: (none)\r\nstderr:\r\n    go: no module declaration in go.mod. To specify the module path:\r\n    \tgo mod edit -module=example.com/mod\r\n    \r\nCheck the log at /Users/rdraoui/.cache/pre-commit/pre-commit.log\r\n```\r\n\r\n\r\nI could get it to work by changing `pre_commit/resources/empty_template_go.mod` from an empty file to:\r\n\r\n```\r\nmodule example/mod\r\n```\r\n\r\n\r\nBut I'm not all that familiar with how modules work in different Go versions, so maybe making that change has some other implications that I don't know about. This [Go Wiki entry](https://github.com/golang/go/wiki/Modules#can-an-additional-gomod-exclude-unnecessary-content-do-modules-have-the-equivalent-of-a-gitignore-file) seems to suggest that empty `go.mod` files are legal, but maybe it's outdated... (c.f: https://github.com/pre-commit/pre-commit/pull/1428#pullrequestreview-404547009)\r\n\r\nThe fix is compatible with Go 1.15.\r\n\r\nI tried validating the fix by running the test suite (`pytest tests -k golang`), but I can't get it to pass with Go 1.15 and current `master` branch either.\r\n\r\n","author":{"url":"https://github.com/rafikdraoui","@type":"Person","name":"rafikdraoui"},"datePublished":"2021-02-24T15:49:35.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":5},"url":"https://github.com/1815/pre-commit/issues/1815"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:878b97af-21ed-f4f9-a495-e449d7834791
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idCA44:211953:8A3A07:C908D2:6A549AE5
html-safe-nonce070842d11bdfb4c57f0c2b8f22da6b2bf15aa98632ca979eeb0d7e9786f18e7b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQTQ0OjIxMTk1Mzo4QTNBMDc6QzkwOEQyOjZBNTQ5QUU1IiwidmlzaXRvcl9pZCI6IjUxNzUwODEzMDU5MDY2NDk4MjkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacd3635d4833798bf3c93700c249ee6c2928c2c53199a05ef843bb1c673234777e
hovercard-subject-tagissue:815604651
github-keyboard-shortcutsrepository,issues,commits,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/pre-commit/pre-commit/1815/issue_layout
twitter:imagehttps://opengraph.githubassets.com/ac43193e2f93209ad4b1e23573753553a33e7fdf13d3d67fd3eb1a6910fd20de/pre-commit/pre-commit/issues/1815
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ac43193e2f93209ad4b1e23573753553a33e7fdf13d3d67fd3eb1a6910fd20de/pre-commit/pre-commit/issues/1815
og:image:altGo 1.16 now rejects empty go.mod files (c.f. golang/go@d4986e0). This means that golang hooks cannot be installed anymore: $ pre-commit install-hooks [INFO] Initializing environment for local. [INF...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamerafikdraoui
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
go-importgithub.com/pre-commit/pre-commit git https://github.com/pre-commit/pre-commit.git
octolytics-dimension-user_id6943086
octolytics-dimension-user_loginpre-commit
octolytics-dimension-repository_id17689377
octolytics-dimension-repository_nwopre-commit/pre-commit
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id17689377
octolytics-dimension-repository_network_root_nwopre-commit/pre-commit
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef8cfff6384f62259baea531c7f58bc7040f8dd92
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/pre-commit/pre-commit/issues/1815#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpre-commit%2Fpre-commit%2Fissues%2F1815
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpre-commit%2Fpre-commit%2Fissues%2F1815
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=pre-commit%2Fpre-commit
Reloadhttps://github.com/pre-commit/pre-commit/issues/1815
Reloadhttps://github.com/pre-commit/pre-commit/issues/1815
Reloadhttps://github.com/pre-commit/pre-commit/issues/1815
Please reload this pagehttps://github.com/pre-commit/pre-commit/issues/1815
pre-commit https://github.com/pre-commit
pre-commithttps://github.com/pre-commit/pre-commit
Please reload this pagehttps://github.com/pre-commit/pre-commit/issues/1815
Notifications https://github.com/login?return_to=%2Fpre-commit%2Fpre-commit
Fork 985 https://github.com/login?return_to=%2Fpre-commit%2Fpre-commit
Star 15.4k https://github.com/login?return_to=%2Fpre-commit%2Fpre-commit
Code https://github.com/pre-commit/pre-commit
Issues 22 https://github.com/pre-commit/pre-commit/issues
Pull requests 12 https://github.com/pre-commit/pre-commit/pulls
Actions https://github.com/pre-commit/pre-commit/actions
Security and quality 0 https://github.com/pre-commit/pre-commit/security
Insights https://github.com/pre-commit/pre-commit/pulse
Code https://github.com/pre-commit/pre-commit
Issues https://github.com/pre-commit/pre-commit/issues
Pull requests https://github.com/pre-commit/pre-commit/pulls
Actions https://github.com/pre-commit/pre-commit/actions
Security and quality https://github.com/pre-commit/pre-commit/security
Insights https://github.com/pre-commit/pre-commit/pulse
#1818https://github.com/pre-commit/pre-commit/pull/1818
Add support for Go 1.16https://github.com/pre-commit/pre-commit/issues/1815#top
#1818https://github.com/pre-commit/pre-commit/pull/1818
bughttps://github.com/pre-commit/pre-commit/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com/rafikdraoui
rafikdraouihttps://github.com/rafikdraoui
on Feb 24, 2021https://github.com/pre-commit/pre-commit/issues/1815#issue-815604651
golang/go@d4986e0https://github.com/golang/go/commit/d4986e0e1d6e03e1b92e905ca5e01b4c223fbeb3
Go Wiki entryhttps://github.com/golang/go/wiki/Modules#can-an-additional-gomod-exclude-unnecessary-content-do-modules-have-the-equivalent-of-a-gitignore-file
#1428 (review)https://github.com/pre-commit/pre-commit/pull/1428#pullrequestreview-404547009
bughttps://github.com/pre-commit/pre-commit/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.