Title: Do version numbers have to have a '.'? · Issue #1794 · pre-commit/pre-commit · GitHub
Open Graph Title: Do version numbers have to have a '.'? · Issue #1794 · pre-commit/pre-commit
X Title: Do version numbers have to have a '.'? · Issue #1794 · pre-commit/pre-commit
Description: Looking at this line it looks to be testing for the presence of a dot in the version number pre-commit/pre_commit/clientlib.py Line 124 in d827e9a if '.' not in rev and not re.match(r'^[a-fA-F0-9]+$', rev): but what if a repo is just fol...
Open Graph Description: Looking at this line it looks to be testing for the presence of a dot in the version number pre-commit/pre_commit/clientlib.py Line 124 in d827e9a if '.' not in rev and not re.match(r'^[a-fA-F0-9]+...
X Description: Looking at this line it looks to be testing for the presence of a dot in the version number pre-commit/pre_commit/clientlib.py Line 124 in d827e9a if '.' not in rev and not re.match(r'^...
Opengraph URL: https://github.com/pre-commit/pre-commit/issues/1794
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Do version numbers have to have a '.'?","articleBody":"Looking at this line it looks to be testing for the presence of a dot in the version number https://github.com/pre-commit/pre-commit/blob/d827e9aa7211456965bf7d16f06ac6a85b0f2984/pre_commit/clientlib.py#L124 but what if a repo is just following a simple `v1`/`v2` model?\r\n\r\nI'm using this repo https://gitlab.salort.eu/jsalort/latexhook/-/tags which has a `v1` tag. My `.pre-commit-config.yaml` looks like this:\r\n```\r\nrepos:\r\n - repo: https://gitlab.salort.eu/jsalort/latexhook\r\n rev: v1\r\n hooks:\r\n - id: latexindent\r\n```\r\n\r\nThis means every time i commit I get this error at the top\r\n\r\n\r\nMy version is `pre-commit==2.10.1` and I don't think this used to happen","author":{"url":"https://github.com/paddyroddy","@type":"Person","name":"paddyroddy"},"datePublished":"2021-02-09T12:35:51.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":7},"url":"https://github.com/1794/pre-commit/issues/1794"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:cb8fc699-27d2-96ce-35c4-4fec36d5c178 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | D86C:2C29DE:12DA329:1991829:6A571E00 |
| html-safe-nonce | 772b9807cd10a0ea29de6caee3b58002407c4aedf7d5d026b084f152f6b16bb3 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEODZDOjJDMjlERToxMkRBMzI5OjE5OTE4Mjk6NkE1NzFFMDAiLCJ2aXNpdG9yX2lkIjoiODg3MDMzNjMxNDAwMjA1NDY1NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 007162124985fc03dc2c428117fbd9024162bcd6a7921b93696cf9c5e280cea0 |
| hovercard-subject-tag | issue:804512619 |
| github-keyboard-shortcuts | repository,issues,commits,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/pre-commit/pre-commit/1794/issue_layout |
| twitter:image | https://opengraph.githubassets.com/0334c7563e604ad63bcd5073ca73c46259e40bcbb6b1d102058d1895fc9f61ae/pre-commit/pre-commit/issues/1794 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/0334c7563e604ad63bcd5073ca73c46259e40bcbb6b1d102058d1895fc9f61ae/pre-commit/pre-commit/issues/1794 |
| og:image:alt | Looking at this line it looks to be testing for the presence of a dot in the version number pre-commit/pre_commit/clientlib.py Line 124 in d827e9a if '.' not in rev and not re.match(r'^[a-fA-F0-9]+... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | paddyroddy |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4e7a7296a3830877cf21a6ad2a972c9e618a48915e03966cf0c53eb08e5aad98 |
| turbo-cache-control | no-preview |
| go-import | github.com/pre-commit/pre-commit git https://github.com/pre-commit/pre-commit.git |
| octolytics-dimension-user_id | 6943086 |
| octolytics-dimension-user_login | pre-commit |
| octolytics-dimension-repository_id | 17689377 |
| octolytics-dimension-repository_nwo | pre-commit/pre-commit |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 17689377 |
| octolytics-dimension-repository_network_root_nwo | pre-commit/pre-commit |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2576d1f0198cf1588faf2edf27f1ed120903be10 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width