| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:886c7bf6-1ccf-663f-dac7-be80edc23de7 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B8D6:245004:162BC67:205CC3E:6A5623BC |
| html-safe-nonce | d5840234201b8664e2968cb99ff91a8b1fd010089f1bc57b46c974e6e9b84911 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOEQ2OjI0NTAwNDoxNjJCQzY3OjIwNUNDM0U6NkE1NjIzQkMiLCJ2aXNpdG9yX2lkIjoiMTQ5ODEzNTAwMDM2NTAxNTk5NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 859fdb4012cb56d4ee116f5e98639457f04b3183cd45a61e6152a5edba79a995 |
| hovercard-subject-tag | pull_request:373945280 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/plotly/plotly.py/2183/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/3c5d30a2b99bc895a2bf04847b9582e0b256624f979f80b87ccb9d08eaaa5e89/plotly/plotly.py/pull/2183 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/3c5d30a2b99bc895a2bf04847b9582e0b256624f979f80b87ccb9d08eaaa5e89/plotly/plotly.py/pull/2183 |
| og:image:alt | closes #2168
The purpose of this PR is to prevent the creation of new px.default properties at run time.
Testing Plan:
Prior to this PR, the following code does not throw an exception:
import plotl... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jdamiba |
| hostname | github.com |
| expected-hostname | github.com |
| None | eeb71977be324ce2bc7c4afd597296b8e3527d8922ad94632edd7a7296f8031b |
| turbo-cache-control | no-cache |
| go-import | github.com/plotly/plotly.py git https://github.com/plotly/plotly.py.git |
| octolytics-dimension-user_id | 5997976 |
| octolytics-dimension-user_login | plotly |
| octolytics-dimension-repository_id | 14579099 |
| octolytics-dimension-repository_nwo | plotly/plotly.py |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 14579099 |
| octolytics-dimension-repository_network_root_nwo | plotly/plotly.py |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3e7957744c8a44d05ff1e464dc5d119e60b98fae |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/plotly/plotly.py/pull/2183#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.py%2Fpull%2F2183 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.py%2Fpull%2F2183 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=plotly%2Fplotly.py |
| Reload | https://github.com/plotly/plotly.py/pull/2183 |
| Reload | https://github.com/plotly/plotly.py/pull/2183 |
| Reload | https://github.com/plotly/plotly.py/pull/2183 |
| Please reload this page | https://github.com/plotly/plotly.py/pull/2183 |
|
plotly
| https://github.com/plotly |
| plotly.py | https://github.com/plotly/plotly.py |
| Please reload this page | https://github.com/plotly/plotly.py/pull/2183 |
|
Notifications
| https://github.com/login?return_to=%2Fplotly%2Fplotly.py |
|
Fork
2.8k
| https://github.com/login?return_to=%2Fplotly%2Fplotly.py |
|
Star
18.7k
| https://github.com/login?return_to=%2Fplotly%2Fplotly.py |
|
Code
| https://github.com/plotly/plotly.py |
|
Issues
721
| https://github.com/plotly/plotly.py/issues |
|
Pull requests
53
| https://github.com/plotly/plotly.py/pulls |
|
Actions
| https://github.com/plotly/plotly.py/actions |
|
Security and quality
0
| https://github.com/plotly/plotly.py/security |
|
Insights
| https://github.com/plotly/plotly.py/pulse |
|
Code
| https://github.com/plotly/plotly.py |
|
Issues
| https://github.com/plotly/plotly.py/issues |
|
Pull requests
| https://github.com/plotly/plotly.py/pulls |
|
Actions
| https://github.com/plotly/plotly.py/actions |
|
Security and quality
| https://github.com/plotly/plotly.py/security |
|
Insights
| https://github.com/plotly/plotly.py/pulse |
| jdamiba | https://github.com/jdamiba |
| master | https://github.com/plotly/plotly.py/tree/master |
| px-permissive-defaults | https://github.com/plotly/plotly.py/tree/px-permissive-defaults |
| Conversation | https://github.com/plotly/plotly.py/pull/2183 |
| Commits7 (7) | https://github.com/plotly/plotly.py/pull/2183/commits |
| Checks | https://github.com/plotly/plotly.py/pull/2183/checks |
| Files changed | https://github.com/plotly/plotly.py/pull/2183/files |
| prevent the creation of new px.default properties at run time | https://github.com/plotly/plotly.py/pull/2183#top |
| jdamiba | https://github.com/jdamiba |
| master | https://github.com/plotly/plotly.py/tree/master |
| px-permissive-defaults | https://github.com/plotly/plotly.py/tree/px-permissive-defaults |
|
| https://github.com/jdamiba |
| jdamiba | https://github.com/jdamiba |
| Feb 11, 2020 | https://github.com/plotly/plotly.py/pull/2183#issue-563568630 |
| Please reload this page | https://github.com/plotly/plotly.py/pull/2183 |
| #2168 | https://github.com/plotly/plotly.py/issues/2168 |
| Please reload this page | https://github.com/plotly/plotly.py/pull/2183 |
| February 11, 2020 17:50 | https://github.com/plotly/plotly.py/pull/2183#commits-pushed-00c3238 |
| prevent creation of new px.default properties at run time | https://github.com/plotly/plotly.py/pull/2183/commits/00c3238b3fd1bda6c39b72897dc42b671b9b2d1b |
| 00c3238 | https://github.com/plotly/plotly.py/pull/2183/commits/00c3238b3fd1bda6c39b72897dc42b671b9b2d1b |
| prevent creation of new px.default properties at run time | https://github.com/plotly/plotly.py/pull/2183/commits/0eda9f828253eed40c821a03609e5c20fa56a89e |
| 0eda9f8 | https://github.com/plotly/plotly.py/pull/2183/commits/0eda9f828253eed40c821a03609e5c20fa56a89e |
| run black | https://github.com/plotly/plotly.py/pull/2183/commits/633c2da5fd861086df4e5ff8581b5617f05e71a1 |
| 633c2da | https://github.com/plotly/plotly.py/pull/2183/commits/633c2da5fd861086df4e5ff8581b5617f05e71a1 |
| https://github.com/jdamiba |
| jdamiba | https://github.com/jdamiba |
| emmanuelle | https://github.com/emmanuelle |
| February 11, 2020 22:59 | https://github.com/plotly/plotly.py/pull/2183#event-3028575588 |
| https://github.com/emmanuelle |
| emmanuelle | https://github.com/emmanuelle |
| Feb 11, 2020 | https://github.com/plotly/plotly.py/pull/2183#issuecomment-584903727 |
| https://github.com/plotly/plotly.py/blob/master/packages/python/plotly/plotly/tests/test_core/test_px/test_px.py | https://github.com/plotly/plotly.py/blob/master/packages/python/plotly/plotly/tests/test_core/test_px/test_px.py |
| https://github.com/plotly/plotly.py/blob/master/packages/python/plotly/plotly/tests/test_core/test_px/test_px_functions.py#L159 | https://github.com/plotly/plotly.py/blob/master/packages/python/plotly/plotly/tests/test_core/test_px/test_px_functions.py#L159 |
| Please reload this page | https://github.com/plotly/plotly.py/pull/2183 |
| February 11, 2020 20:33 | https://github.com/plotly/plotly.py/pull/2183#commits-pushed-bae0483 |
| add test for permissive defaults | https://github.com/plotly/plotly.py/pull/2183/commits/bae04837dfda371c407c9617ad151b4aac7f3c27 |
| bae0483 | https://github.com/plotly/plotly.py/pull/2183/commits/bae04837dfda371c407c9617ad151b4aac7f3c27 |
| formatting | https://github.com/plotly/plotly.py/pull/2183/commits/58aeb32627669340a9e7b01ae83973c109d260c7 |
| 58aeb32 | https://github.com/plotly/plotly.py/pull/2183/commits/58aeb32627669340a9e7b01ae83973c109d260c7 |
| formatting | https://github.com/plotly/plotly.py/pull/2183/commits/756f09bd3419713910ff27ce192039307dd646db |
| 756f09b | https://github.com/plotly/plotly.py/pull/2183/commits/756f09bd3419713910ff27ce192039307dd646db |
| https://github.com/jdamiba |
| jdamiba | https://github.com/jdamiba |
| Feb 12, 2020 | https://github.com/plotly/plotly.py/pull/2183#issuecomment-584974776 |
| @emmanuelle | https://github.com/emmanuelle |
| Please reload this page | https://github.com/plotly/plotly.py/pull/2183 |
| https://github.com/emmanuelle |
| emmanuelle | https://github.com/emmanuelle |
|
Feb 12, 2020
| https://github.com/plotly/plotly.py/pull/2183#pullrequestreview-357555462 |
|
View reviewed changes
| https://github.com/plotly/plotly.py/pull/2183/files/756f09bd3419713910ff27ce192039307dd646db |
| packages/python/plotly/plotly/tests/test_core/test_px/test_px.py | https://github.com/plotly/plotly.py/pull/2183/files/756f09bd3419713910ff27ce192039307dd646db#diff-00b4425043028cb9ef81b5ee1a48f6865984649b23bf9536ecbccbe9d6ca4cec |
| emmanuelle | https://github.com/emmanuelle |
| Feb 12, 2020 | https://github.com/plotly/plotly.py/pull/2183#discussion_r378331263 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.py/pull/2183 |
| jdamiba | https://github.com/jdamiba |
| Feb 12, 2020 | https://github.com/plotly/plotly.py/pull/2183#discussion_r378347431 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.py/pull/2183 |
| emmanuelle | https://github.com/emmanuelle |
| Feb 12, 2020 | https://github.com/plotly/plotly.py/pull/2183#discussion_r378350002 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.py/pull/2183 |
| make sure new test is picked up by pytest | https://github.com/plotly/plotly.py/pull/2183/commits/bdda85167e0bde72bda70d0f5f18ec9a6554fd78 |
| bdda851 | https://github.com/plotly/plotly.py/pull/2183/commits/bdda85167e0bde72bda70d0f5f18ec9a6554fd78 |
| https://github.com/emmanuelle |
| emmanuelle | https://github.com/emmanuelle |
| Feb 12, 2020 | https://github.com/plotly/plotly.py/pull/2183#issuecomment-585277757 |
| @jdamiba | https://github.com/jdamiba |
| Please reload this page | https://github.com/plotly/plotly.py/pull/2183 |
| https://github.com/jdamiba |
| jdamiba | https://github.com/jdamiba |
| f4a005d | https://github.com/plotly/plotly.py/commit/f4a005de7d650f9d9594c85b2a972b262dd9979c |
| Feb 12, 2020 | https://github.com/plotly/plotly.py/pull/2183#event-3031710906 |
| https://github.com/jdamiba |
| jdamiba | https://github.com/jdamiba |
| February 12, 2020 17:17 | https://github.com/plotly/plotly.py/pull/2183#event-3031711164 |
| https://github.com/nicolaskruchten |
| nicolaskruchten | https://github.com/nicolaskruchten |
| v4.5.1 | https://github.com/plotly/plotly.py/milestone/27 |
| Feb 19, 2020 | https://github.com/plotly/plotly.py/pull/2183#event-3053086330 |
| https://github.co/hiddenchars |
| https://github.com/plotly/plotly.py/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.py%2Fpull%2F2183 |
|
| https://github.com/emmanuelle |
|
emmanuelle
| https://github.com/emmanuelle |
|
| https://github.com/plotly/plotly.py/pull/2183/files/bdda85167e0bde72bda70d0f5f18ec9a6554fd78 |
|
v4.5.1
| https://github.com/plotly/plotly.py/milestone/27 |
|
px.defaults too permissive
| https://github.com/plotly/plotly.py/issues/2168 |
| Please reload this page | https://github.com/plotly/plotly.py/pull/2183 |
|
| https://github.com/jdamiba |
|
| https://github.com/emmanuelle |
|
| https://github.com/nicolaskruchten |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |