René's URL Explorer Experiment


Title: Improve padding logic for updatemenus by rreusser · Pull Request #989 · plotly/plotly.js · GitHub

Open Graph Title: Improve padding logic for updatemenus by rreusser · Pull Request #989 · plotly/plotly.js

X Title: Improve padding logic for updatemenus by rreusser · Pull Request #989 · plotly/plotly.js

Description: Open-source JavaScript charting library behind Plotly and Dash - Improve padding logic for updatemenus by rreusser · Pull Request #989 · plotly/plotly.js

Open Graph Description: See #985 cc @etpinard This PR improves padding logic for updatemenus. It implements pad: {t, r, b, l} at the individual-updatemenu level. I didn't apply unit testing, but did beef up the image ...

X Description: See #985 cc @etpinard This PR improves padding logic for updatemenus. It implements pad: {t, r, b, l} at the individual-updatemenu level. I didn't apply unit testing, but did beef up the im...

Opengraph URL: https://github.com/plotly/plotly.js/pull/989

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:3d3de7db-d8b1-641f-38f3-e33afa986246
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAC9E:6365:327A567:435E391:6B01F81B
html-safe-nonce6ed6d115845d432db04cf92c77bd2241b6c8d9a668cc156e4ebd1c435a1a2d87
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQzlFOjYzNjU6MzI3QTU2Nzo0MzVFMzkxOjZCMDFGODFCIiwidmlzaXRvcl9pZCI6IjM0MTI4Mzg3NzM5MTcwODc3NzEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac1925e3a42ff614698f8621ec24ba6bb1f334c4000569d5975b9cdf21758be438
hovercard-subject-tagpull_request:87204764
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/plotly/plotly.js/989/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/22892a36c6c2a10d7f80e9fbad73b31cf82109c0f61010260cbb1fc26b412b93/plotly/plotly.js/pull/989
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/22892a36c6c2a10d7f80e9fbad73b31cf82109c0f61010260cbb1fc26b412b93/plotly/plotly.js/pull/989
og:image:altSee #985 cc @etpinard This PR improves padding logic for updatemenus. It implements pad: {t, r, b, l} at the individual-updatemenu level. I didn't apply unit testing, but did beef up the image ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamerreusser
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/plotly/plotly.js git https://github.com/plotly/plotly.js.git
octolytics-dimension-user_id5997976
octolytics-dimension-user_loginplotly
octolytics-dimension-repository_id45646037
octolytics-dimension-repository_nwoplotly/plotly.js
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id45646037
octolytics-dimension-repository_network_root_nwoplotly/plotly.js
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/plotly/plotly.js/pull/989#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F989
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F989
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=plotly%2Fplotly.js
Reloadhttps://github.com/plotly/plotly.js/pull/989
Reloadhttps://github.com/plotly/plotly.js/pull/989
Reloadhttps://github.com/plotly/plotly.js/pull/989
plotlyhttps://github.com/plotly
plotly.jshttps://github.com/plotly/plotly.js
Codehttps://github.com/plotly/plotly.js
Issues726 (726)https://github.com/plotly/plotly.js/issues
Pull requests84 (84)https://github.com/plotly/plotly.js/pulls
Actionshttps://github.com/plotly/plotly.js/actions
Security and qualityhttps://github.com/plotly/plotly.js/security
Insightshttps://github.com/plotly/plotly.js/insights
https://github.com/plotly/plotly.js
rreusserhttps://github.com/rreusser
masterhttps://github.com/plotly/plotly.js/tree/master
fix-updatemenus-paddinghttps://github.com/plotly/plotly.js/tree/fix-updatemenus-padding
Conversationhttps://github.com/plotly/plotly.js/pull/989
Commits2 (2)https://github.com/plotly/plotly.js/pull/989/commits
Checkshttps://github.com/plotly/plotly.js/pull/989/checks
Files changedhttps://github.com/plotly/plotly.js/pull/989/files
Improve padding logic for updatemenushttps://github.com/plotly/plotly.js/pull/989#top
rreusserhttps://github.com/rreusser
masterhttps://github.com/plotly/plotly.js/tree/master
fix-updatemenus-paddinghttps://github.com/plotly/plotly.js/tree/fix-updatemenus-padding
https://github.com/rreusser
rreusserhttps://github.com/rreusser
Sep 28, 2016https://github.com/plotly/plotly.js/pull/989#issue-179894582
Please reload this pagehttps://github.com/plotly/plotly.js/pull/989
#985https://github.com/plotly/plotly.js/issues/985
@etpinardhttps://github.com/etpinard
https://cloud.githubusercontent.com/assets/572717/18933182/8c917256-85a1-11e6-83b9-be8b4674bf16.png
Please reload this pagehttps://github.com/plotly/plotly.js/pull/989
https://github.com/rreusser
Improve padding logic for updatemenushttps://github.com/plotly/plotly.js/pull/989/commits/05ac5863c1b135df2c5f456f0fd30cd6ff50b2de
05ac586https://github.com/plotly/plotly.js/pull/989/commits/05ac5863c1b135df2c5f456f0fd30cd6ff50b2de
https://github.com/rreusser
rreusserhttps://github.com/rreusser
Sep 28, 2016https://github.com/plotly/plotly.js/pull/989#issuecomment-250308930
Please reload this pagehttps://github.com/plotly/plotly.js/pull/989
https://github.com/rreusser
rreusserhttps://github.com/rreusser
Sep 28, 2016https://github.com/plotly/plotly.js/pull/989#issuecomment-250315278
Please reload this pagehttps://github.com/plotly/plotly.js/pull/989
Please reload this pagehttps://github.com/plotly/plotly.js/pull/989
https://github.com/rreusser
rreusserhttps://github.com/rreusser
status: reviewable https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22status%3A%20reviewable%22
Sep 28, 2016https://github.com/plotly/plotly.js/pull/989#event-806181852
https://github.com/etpinard
etpinardhttps://github.com/etpinard
feature https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Afeature
Sep 28, 2016https://github.com/plotly/plotly.js/pull/989#event-806202935
https://github.com/etpinard
etpinardhttps://github.com/etpinard
v1.18.0https://github.com/plotly/plotly.js/milestone/11
Sep 28, 2016https://github.com/plotly/plotly.js/pull/989#event-806202984
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Sep 28, 2016 https://github.com/plotly/plotly.js/pull/989#pullrequestreview-2041994
View reviewed changes https://github.com/plotly/plotly.js/pull/989/files/05ac5863c1b135df2c5f456f0fd30cd6ff50b2de
etpinardhttps://github.com/etpinard
https://github.com/plotly/plotly.js/pull/989#pullrequestreview-2041994
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@rreusserhttps://github.com/rreusser
Please reload this pagehttps://github.com/plotly/plotly.js/pull/989
src/components/updatemenus/attributes.jshttps://github.com/plotly/plotly.js/pull/989/files/05ac5863c1b135df2c5f456f0fd30cd6ff50b2de#diff-3b2151073590f4f3a8ffab98ae72bee9faf607902b72f73229cc1f77f540e227
etpinardhttps://github.com/etpinard
Sep 28, 2016https://github.com/plotly/plotly.js/pull/989#discussion_r81031185
Please reload this pagehttps://github.com/plotly/plotly.js/pull/989
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/989
rreusserhttps://github.com/rreusser
Sep 28, 2016https://github.com/plotly/plotly.js/pull/989#discussion_r81033020
Please reload this pagehttps://github.com/plotly/plotly.js/pull/989
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/989
etpinardhttps://github.com/etpinard
Sep 29, 2016https://github.com/plotly/plotly.js/pull/989#discussion_r81050285
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/989
src/components/updatemenus/draw.jshttps://github.com/plotly/plotly.js/pull/989/files/05ac5863c1b135df2c5f456f0fd30cd6ff50b2de#diff-14e1814f826e54c32acaceda12ec44f769db57969b7b868e0a60575fb5c2add3
etpinardhttps://github.com/etpinard
Sep 28, 2016https://github.com/plotly/plotly.js/pull/989#discussion_r81032532
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/989
https://github.com/rreusser
rreusserhttps://github.com/rreusser
Sep 28, 2016https://github.com/plotly/plotly.js/pull/989#issuecomment-250322330
@etpinardhttps://github.com/etpinard
Please reload this pagehttps://github.com/plotly/plotly.js/pull/989
https://github.com/rreusser
Add jasmine tests for updatemenus paddinghttps://github.com/plotly/plotly.js/pull/989/commits/46043418e883ed838dda44ebc04c69f64a282bec
4604341https://github.com/plotly/plotly.js/pull/989/commits/46043418e883ed838dda44ebc04c69f64a282bec
https://github.com/rreusser
rreusserhttps://github.com/rreusser
Sep 29, 2016https://github.com/plotly/plotly.js/pull/989#issuecomment-250458998
@etpinardhttps://github.com/etpinard
Please reload this pagehttps://github.com/plotly/plotly.js/pull/989
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Sep 29, 2016 https://github.com/plotly/plotly.js/pull/989#pullrequestreview-2162832
View reviewed changes https://github.com/plotly/plotly.js/pull/989/files/46043418e883ed838dda44ebc04c69f64a282bec
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Sep 29, 2016https://github.com/plotly/plotly.js/pull/989#issuecomment-250498892
@rreusserhttps://github.com/rreusser
Please reload this pagehttps://github.com/plotly/plotly.js/pull/989
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Sep 29, 2016 https://github.com/plotly/plotly.js/pull/989#ref-issue-180081949
Unify component pad logic #997 https://github.com/plotly/plotly.js/issues/997
https://github.com/rreusser
rreusserhttps://github.com/rreusser
fce36fahttps://github.com/plotly/plotly.js/commit/fce36fa46bd53fa5ebe4e4892479258040783409
Sep 29, 2016https://github.com/plotly/plotly.js/pull/989#event-807255352
https://github.com/rreusser
rreusserhttps://github.com/rreusser
September 29, 2016 16:24https://github.com/plotly/plotly.js/pull/989#event-807271894
https://github.co/hiddenchars
https://github.com/plotly/plotly.js/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F989
https://github.com/etpinard
etpinard https://github.com/etpinard
https://github.com/plotly/plotly.js/pull/989/files/46043418e883ed838dda44ebc04c69f64a282bec
Please reload this pagehttps://github.com/plotly/plotly.js/pull/989
feature https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Afeature
v1.18.0 https://github.com/plotly/plotly.js/milestone/11
Please reload this pagehttps://github.com/plotly/plotly.js/pull/989
https://github.com/rreusser
https://github.com/etpinard
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.