| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:3d3de7db-d8b1-641f-38f3-e33afa986246 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AC9E:6365:327A567:435E391:6B01F81B |
| html-safe-nonce | 6ed6d115845d432db04cf92c77bd2241b6c8d9a668cc156e4ebd1c435a1a2d87 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQzlFOjYzNjU6MzI3QTU2Nzo0MzVFMzkxOjZCMDFGODFCIiwidmlzaXRvcl9pZCI6IjM0MTI4Mzg3NzM5MTcwODc3NzEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 1925e3a42ff614698f8621ec24ba6bb1f334c4000569d5975b9cdf21758be438 |
| hovercard-subject-tag | pull_request:87204764 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/plotly/plotly.js/989/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/22892a36c6c2a10d7f80e9fbad73b31cf82109c0f61010260cbb1fc26b412b93/plotly/plotly.js/pull/989 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/22892a36c6c2a10d7f80e9fbad73b31cf82109c0f61010260cbb1fc26b412b93/plotly/plotly.js/pull/989 |
| og:image:alt | See #985
cc @etpinard
This PR improves padding logic for updatemenus. It implements pad: {t, r, b, l} at the individual-updatemenu level. I didn't apply unit testing, but did beef up the image ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | rreusser |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-cache |
| go-import | github.com/plotly/plotly.js git https://github.com/plotly/plotly.js.git |
| octolytics-dimension-user_id | 5997976 |
| octolytics-dimension-user_login | plotly |
| octolytics-dimension-repository_id | 45646037 |
| octolytics-dimension-repository_nwo | plotly/plotly.js |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 45646037 |
| octolytics-dimension-repository_network_root_nwo | plotly/plotly.js |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/plotly/plotly.js/pull/989#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F989 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F989 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=plotly%2Fplotly.js |
| Reload | https://github.com/plotly/plotly.js/pull/989 |
| Reload | https://github.com/plotly/plotly.js/pull/989 |
| Reload | https://github.com/plotly/plotly.js/pull/989 |
| plotly | https://github.com/plotly |
| plotly.js | https://github.com/plotly/plotly.js |
| Code | https://github.com/plotly/plotly.js |
| Issues726 (726) | https://github.com/plotly/plotly.js/issues |
| Pull requests84 (84) | https://github.com/plotly/plotly.js/pulls |
| Actions | https://github.com/plotly/plotly.js/actions |
| Security and quality | https://github.com/plotly/plotly.js/security |
| Insights | https://github.com/plotly/plotly.js/insights |
| https://github.com/plotly/plotly.js |
| rreusser | https://github.com/rreusser |
| master | https://github.com/plotly/plotly.js/tree/master |
| fix-updatemenus-padding | https://github.com/plotly/plotly.js/tree/fix-updatemenus-padding |
| Conversation | https://github.com/plotly/plotly.js/pull/989 |
| Commits2 (2) | https://github.com/plotly/plotly.js/pull/989/commits |
| Checks | https://github.com/plotly/plotly.js/pull/989/checks |
| Files changed | https://github.com/plotly/plotly.js/pull/989/files |
| Improve padding logic for updatemenus | https://github.com/plotly/plotly.js/pull/989#top |
| rreusser | https://github.com/rreusser |
| master | https://github.com/plotly/plotly.js/tree/master |
| fix-updatemenus-padding | https://github.com/plotly/plotly.js/tree/fix-updatemenus-padding |
|
| https://github.com/rreusser |
| rreusser | https://github.com/rreusser |
| Sep 28, 2016 | https://github.com/plotly/plotly.js/pull/989#issue-179894582 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/989 |
| #985 | https://github.com/plotly/plotly.js/issues/985 |
| @etpinard | https://github.com/etpinard |
| https://cloud.githubusercontent.com/assets/572717/18933182/8c917256-85a1-11e6-83b9-be8b4674bf16.png |
| Please reload this page | https://github.com/plotly/plotly.js/pull/989 |
|
| https://github.com/rreusser |
| Improve padding logic for updatemenus | https://github.com/plotly/plotly.js/pull/989/commits/05ac5863c1b135df2c5f456f0fd30cd6ff50b2de |
| 05ac586 | https://github.com/plotly/plotly.js/pull/989/commits/05ac5863c1b135df2c5f456f0fd30cd6ff50b2de |
| https://github.com/rreusser |
| rreusser | https://github.com/rreusser |
| Sep 28, 2016 | https://github.com/plotly/plotly.js/pull/989#issuecomment-250308930 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/989 |
| https://github.com/rreusser |
| rreusser | https://github.com/rreusser |
| Sep 28, 2016 | https://github.com/plotly/plotly.js/pull/989#issuecomment-250315278 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/989 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/989 |
| https://github.com/rreusser |
| rreusser | https://github.com/rreusser |
|
status: reviewable
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22status%3A%20reviewable%22 |
| Sep 28, 2016 | https://github.com/plotly/plotly.js/pull/989#event-806181852 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
feature
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Afeature |
| Sep 28, 2016 | https://github.com/plotly/plotly.js/pull/989#event-806202935 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| v1.18.0 | https://github.com/plotly/plotly.js/milestone/11 |
| Sep 28, 2016 | https://github.com/plotly/plotly.js/pull/989#event-806202984 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Sep 28, 2016
| https://github.com/plotly/plotly.js/pull/989#pullrequestreview-2041994 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/989/files/05ac5863c1b135df2c5f456f0fd30cd6ff50b2de |
| etpinard | https://github.com/etpinard |
| https://github.com/plotly/plotly.js/pull/989#pullrequestreview-2041994 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @rreusser | https://github.com/rreusser |
| Please reload this page | https://github.com/plotly/plotly.js/pull/989 |
| src/components/updatemenus/attributes.js | https://github.com/plotly/plotly.js/pull/989/files/05ac5863c1b135df2c5f456f0fd30cd6ff50b2de#diff-3b2151073590f4f3a8ffab98ae72bee9faf607902b72f73229cc1f77f540e227 |
| etpinard | https://github.com/etpinard |
| Sep 28, 2016 | https://github.com/plotly/plotly.js/pull/989#discussion_r81031185 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/989 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/989 |
| rreusser | https://github.com/rreusser |
| Sep 28, 2016 | https://github.com/plotly/plotly.js/pull/989#discussion_r81033020 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/989 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/989 |
| etpinard | https://github.com/etpinard |
| Sep 29, 2016 | https://github.com/plotly/plotly.js/pull/989#discussion_r81050285 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/989 |
| src/components/updatemenus/draw.js | https://github.com/plotly/plotly.js/pull/989/files/05ac5863c1b135df2c5f456f0fd30cd6ff50b2de#diff-14e1814f826e54c32acaceda12ec44f769db57969b7b868e0a60575fb5c2add3 |
| etpinard | https://github.com/etpinard |
| Sep 28, 2016 | https://github.com/plotly/plotly.js/pull/989#discussion_r81032532 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/989 |
| https://github.com/rreusser |
| rreusser | https://github.com/rreusser |
| Sep 28, 2016 | https://github.com/plotly/plotly.js/pull/989#issuecomment-250322330 |
| @etpinard | https://github.com/etpinard |
| Please reload this page | https://github.com/plotly/plotly.js/pull/989 |
|
| https://github.com/rreusser |
| Add jasmine tests for updatemenus padding | https://github.com/plotly/plotly.js/pull/989/commits/46043418e883ed838dda44ebc04c69f64a282bec |
| 4604341 | https://github.com/plotly/plotly.js/pull/989/commits/46043418e883ed838dda44ebc04c69f64a282bec |
| https://github.com/rreusser |
| rreusser | https://github.com/rreusser |
| Sep 29, 2016 | https://github.com/plotly/plotly.js/pull/989#issuecomment-250458998 |
| @etpinard | https://github.com/etpinard |
| Please reload this page | https://github.com/plotly/plotly.js/pull/989 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Sep 29, 2016
| https://github.com/plotly/plotly.js/pull/989#pullrequestreview-2162832 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/989/files/46043418e883ed838dda44ebc04c69f64a282bec |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| Sep 29, 2016 | https://github.com/plotly/plotly.js/pull/989#issuecomment-250498892 |
| @rreusser | https://github.com/rreusser |
| Please reload this page | https://github.com/plotly/plotly.js/pull/989 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Sep 29, 2016
| https://github.com/plotly/plotly.js/pull/989#ref-issue-180081949 |
|
Unify component pad logic
#997
| https://github.com/plotly/plotly.js/issues/997 |
| https://github.com/rreusser |
| rreusser | https://github.com/rreusser |
| fce36fa | https://github.com/plotly/plotly.js/commit/fce36fa46bd53fa5ebe4e4892479258040783409 |
| Sep 29, 2016 | https://github.com/plotly/plotly.js/pull/989#event-807255352 |
| https://github.com/rreusser |
| rreusser | https://github.com/rreusser |
| September 29, 2016 16:24 | https://github.com/plotly/plotly.js/pull/989#event-807271894 |
| https://github.co/hiddenchars |
| https://github.com/plotly/plotly.js/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F989 |
|
| https://github.com/etpinard |
|
etpinard
| https://github.com/etpinard |
|
| https://github.com/plotly/plotly.js/pull/989/files/46043418e883ed838dda44ebc04c69f64a282bec |
| Please reload this page | https://github.com/plotly/plotly.js/pull/989 |
|
feature
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Afeature |
|
v1.18.0
| https://github.com/plotly/plotly.js/milestone/11 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/989 |
|
| https://github.com/rreusser |
|
| https://github.com/etpinard |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |