| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:d3921f8c-81da-e2a1-04c3-2dc504d3dcc8 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9272:363D8E:39B301A:49368D1:6B01E0BD |
| html-safe-nonce | c251b28f02a079b59c7585d01c2aaed8b1fd4e80f7c1f01515f99c60c73594ed |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MjcyOjM2M0Q4RTozOUIzMDFBOjQ5MzY4RDE6NkIwMUUwQkQiLCJ2aXNpdG9yX2lkIjoiNDIzNDcxMDIyOTQ4MjMzMjM1MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | cd61fb559d7bff266bb0d897d6fdccac6ee5cd092d0ba4644eb499e031f94c22 |
| hovercard-subject-tag | pull_request:87063814 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/plotly/plotly.js/986/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/5c92e095c9f9000ab742fe52edfbcdabb37fcd30ddb71330203508b64f1369fa/plotly/plotly.js/pull/986 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/5c92e095c9f9000ab742fe52edfbcdabb37fcd30ddb71330203508b64f1369fa/plotly/plotly.js/pull/986 |
| og:image:alt | This PR implements a first cut at sliders #742
cc @etpinard
It has most of the necessary features (including hooking into the internal event dispatcher 🎉) and seems reasonably stable. It needs:
d... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | rreusser |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/plotly/plotly.js git https://github.com/plotly/plotly.js.git |
| octolytics-dimension-user_id | 5997976 |
| octolytics-dimension-user_login | plotly |
| octolytics-dimension-repository_id | 45646037 |
| octolytics-dimension-repository_nwo | plotly/plotly.js |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 45646037 |
| octolytics-dimension-repository_network_root_nwo | plotly/plotly.js |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/plotly/plotly.js/pull/986#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F986 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F986 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=plotly%2Fplotly.js |
| Reload | https://github.com/plotly/plotly.js/pull/986 |
| Reload | https://github.com/plotly/plotly.js/pull/986 |
| Reload | https://github.com/plotly/plotly.js/pull/986 |
| plotly | https://github.com/plotly |
| plotly.js | https://github.com/plotly/plotly.js |
| Code | https://github.com/plotly/plotly.js |
| Issues726 (726) | https://github.com/plotly/plotly.js/issues |
| Pull requests84 (84) | https://github.com/plotly/plotly.js/pulls |
| Actions | https://github.com/plotly/plotly.js/actions |
| Security and quality | https://github.com/plotly/plotly.js/security |
| Insights | https://github.com/plotly/plotly.js/insights |
| https://github.com/plotly/plotly.js |
| rreusser | https://github.com/rreusser |
| master | https://github.com/plotly/plotly.js/tree/master |
| slider-component | https://github.com/plotly/plotly.js/tree/slider-component |
| Conversation | https://github.com/plotly/plotly.js/pull/986 |
| Commits43 (43) | https://github.com/plotly/plotly.js/pull/986/commits |
| Checks | https://github.com/plotly/plotly.js/pull/986/checks |
| Files changed | https://github.com/plotly/plotly.js/pull/986/files |
| Slider component | https://github.com/plotly/plotly.js/pull/986#top |
| rreusser | https://github.com/rreusser |
| master | https://github.com/plotly/plotly.js/tree/master |
| slider-component | https://github.com/plotly/plotly.js/tree/slider-component |
|
| https://github.com/rreusser |
| rreusser | https://github.com/rreusser |
| Sep 28, 2016 | https://github.com/plotly/plotly.js/pull/986#issue-179693916 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| #742 | https://github.com/plotly/plotly.js/issues/742 |
| @etpinard | https://github.com/etpinard |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| rreusser | https://github.com/rreusser |
| September 27, 2016 23:56 | https://github.com/plotly/plotly.js/pull/986#commits-pushed-f5bccd5 |
|
| https://github.com/rreusser |
| First cut at slider | https://github.com/plotly/plotly.js/pull/986/commits/f5bccd5c07c1f58fe23827431dc631c810da5576 |
| f5bccd5 | https://github.com/plotly/plotly.js/pull/986/commits/f5bccd5c07c1f58fe23827431dc631c810da5576 |
|
| https://github.com/rreusser |
| Fix lint errors in slider | https://github.com/plotly/plotly.js/pull/986/commits/83483fd052f375871b8cd6a4b7076684bda2b42e |
| 83483fd | https://github.com/plotly/plotly.js/pull/986/commits/83483fd052f375871b8cd6a4b7076684bda2b42e |
| https://github.com/rreusser |
| rreusser | https://github.com/rreusser |
|
status: in progress
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22status%3A%20in%20progress%22 |
| Sep 28, 2016 | https://github.com/plotly/plotly.js/pull/986#event-804995360 |
| rreusser | https://github.com/rreusser |
| September 28, 2016 03:35 | https://github.com/plotly/plotly.js/pull/986#commits-pushed-f69a328 |
|
| https://github.com/rreusser |
| Add slider transitions | https://github.com/plotly/plotly.js/pull/986/commits/f69a3280317e00d370c75d77933951d588aea2b6 |
| f69a328 | https://github.com/plotly/plotly.js/pull/986/commits/f69a3280317e00d370c75d77933951d588aea2b6 |
|
| https://github.com/rreusser |
| Expand touchable slider area | https://github.com/plotly/plotly.js/pull/986/commits/82ea5581ae7cd96b636f0d062cc98a6bd61e9b36 |
| 82ea558 | https://github.com/plotly/plotly.js/pull/986/commits/82ea5581ae7cd96b636f0d062cc98a6bd61e9b36 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
feature
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Afeature |
| Sep 28, 2016 | https://github.com/plotly/plotly.js/pull/986#event-805458256 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| Sep 28, 2016 | https://github.com/plotly/plotly.js/pull/986#issuecomment-250174473 |
| @rreusser | https://github.com/rreusser |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| https://github.com/rreusser |
| rreusser | https://github.com/rreusser |
| Sep 28, 2016 | https://github.com/plotly/plotly.js/pull/986#issuecomment-250175532 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| https://cloud.githubusercontent.com/assets/572717/18916541/b96e9a18-8562-11e6-9da4-cf14e505304b.png |
| https://cloud.githubusercontent.com/assets/572717/18916535/b607baf8-8562-11e6-945a-abb8c7cb0e14.png |
| https://cloud.githubusercontent.com/assets/572717/18916702/4a28c452-8563-11e6-97ba-833f460da3ac.png |
| https://cloud.githubusercontent.com/assets/572717/18916947/43673120-8564-11e6-8cc0-2309a00fa581.png |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
|
| https://github.com/rreusser |
| Add slider mock | https://github.com/plotly/plotly.js/pull/986/commits/ca5f9f556c96499c1a08859e4f2ff20ed0b26060 |
| ca5f9f5 | https://github.com/plotly/plotly.js/pull/986/commits/ca5f9f556c96499c1a08859e4f2ff20ed0b26060 |
| https://github.com/rreusser |
| rreusser | https://github.com/rreusser |
| Sep 28, 2016 | https://github.com/plotly/plotly.js/pull/986#issuecomment-250188888 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| @etpinard | https://github.com/etpinard |
| https://cloud.githubusercontent.com/assets/572717/18918486/0021286c-8569-11e6-9018-ed143bed0c9c.png |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| https://github.com/rreusser |
| rreusser | https://github.com/rreusser |
|
Sep 28, 2016
| https://github.com/plotly/plotly.js/pull/986#pullrequestreview-1954333 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/986/files/ca5f9f556c96499c1a08859e4f2ff20ed0b26060 |
| src/components/slider/draw.js | https://github.com/plotly/plotly.js/pull/986/files/ca5f9f556c96499c1a08859e4f2ff20ed0b26060#diff-56a1c9b6ae594bd7a9fc67e5ea1500259c4a30c29a66e9789c81fecc0afb145c |
| rreusser | https://github.com/rreusser |
| Sep 28, 2016 | https://github.com/plotly/plotly.js/pull/986#discussion_r80936898 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| etpinard | https://github.com/etpinard |
| Sep 28, 2016 | https://github.com/plotly/plotly.js/pull/986#discussion_r80938860 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| https://github.com/rreusser |
| rreusser | https://github.com/rreusser |
|
Sep 28, 2016
| https://github.com/plotly/plotly.js/pull/986#pullrequestreview-1954677 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/986/files/ca5f9f556c96499c1a08859e4f2ff20ed0b26060 |
| src/components/slider/attributes.js | https://github.com/plotly/plotly.js/pull/986/files/ca5f9f556c96499c1a08859e4f2ff20ed0b26060#diff-9aeea51bfcc1c77160e63efe9df7b891cee6970f4ddf752ce22db8e4d8d33ec1 |
| rreusser | https://github.com/rreusser |
| Sep 28, 2016 | https://github.com/plotly/plotly.js/pull/986#discussion_r80937252 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| etpinard | https://github.com/etpinard |
| Sep 28, 2016 | https://github.com/plotly/plotly.js/pull/986#discussion_r80938970 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| https://github.com/rreusser |
| rreusser | https://github.com/rreusser |
|
Sep 28, 2016
| https://github.com/plotly/plotly.js/pull/986#pullrequestreview-1954857 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/986/files/ca5f9f556c96499c1a08859e4f2ff20ed0b26060 |
| src/components/slider/draw.js | https://github.com/plotly/plotly.js/pull/986/files/ca5f9f556c96499c1a08859e4f2ff20ed0b26060#diff-56a1c9b6ae594bd7a9fc67e5ea1500259c4a30c29a66e9789c81fecc0afb145c |
| rreusser | https://github.com/rreusser |
| Sep 28, 2016 | https://github.com/plotly/plotly.js/pull/986#discussion_r80937455 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| etpinard | https://github.com/etpinard |
| Sep 28, 2016 | https://github.com/plotly/plotly.js/pull/986#discussion_r80939043 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| https://github.com/rreusser |
| rreusser | https://github.com/rreusser |
|
Sep 28, 2016
| https://github.com/plotly/plotly.js/pull/986#pullrequestreview-1955281 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/986/files/ca5f9f556c96499c1a08859e4f2ff20ed0b26060 |
| src/components/slider/draw.js | https://github.com/plotly/plotly.js/pull/986/files/ca5f9f556c96499c1a08859e4f2ff20ed0b26060#diff-56a1c9b6ae594bd7a9fc67e5ea1500259c4a30c29a66e9789c81fecc0afb145c |
| rreusser | https://github.com/rreusser |
| Sep 28, 2016 | https://github.com/plotly/plotly.js/pull/986#discussion_r80937919 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| rreusser | https://github.com/rreusser |
| Sep 29, 2016 | https://github.com/plotly/plotly.js/pull/986#discussion_r81178531 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Sep 28, 2016
| https://github.com/plotly/plotly.js/pull/986#pullrequestreview-1940907 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/986/files/f5bccd5c07c1f58fe23827431dc631c810da5576 |
| etpinard | https://github.com/etpinard |
| https://github.com/plotly/plotly.js/pull/986#pullrequestreview-1940907 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @rreusser | https://github.com/rreusser |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| src/components/slider/attributes.js | https://github.com/plotly/plotly.js/pull/986/files/f5bccd5c07c1f58fe23827431dc631c810da5576#diff-9aeea51bfcc1c77160e63efe9df7b891cee6970f4ddf752ce22db8e4d8d33ec1 |
| etpinard | https://github.com/etpinard |
| Sep 28, 2016 | https://github.com/plotly/plotly.js/pull/986#discussion_r80922532 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| src/components/slider/attributes.js | https://github.com/plotly/plotly.js/pull/986/files/f5bccd5c07c1f58fe23827431dc631c810da5576#diff-9aeea51bfcc1c77160e63efe9df7b891cee6970f4ddf752ce22db8e4d8d33ec1 |
| etpinard | https://github.com/etpinard |
| Sep 28, 2016 | https://github.com/plotly/plotly.js/pull/986#discussion_r80922743 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| src/components/slider/attributes.js | https://github.com/plotly/plotly.js/pull/986/files/f5bccd5c07c1f58fe23827431dc631c810da5576#diff-9aeea51bfcc1c77160e63efe9df7b891cee6970f4ddf752ce22db8e4d8d33ec1 |
| etpinard | https://github.com/etpinard |
| Sep 28, 2016 | https://github.com/plotly/plotly.js/pull/986#discussion_r80924058 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Lib.nestedProperty | https://github.com/plotly/plotly.js/blob/708e0ffd9ee827fd2640334a072f86605dcb2f5d/src/lib/nested_property.js#L29 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| src/components/slider/attributes.js | https://github.com/plotly/plotly.js/pull/986/files/f5bccd5c07c1f58fe23827431dc631c810da5576#diff-9aeea51bfcc1c77160e63efe9df7b891cee6970f4ddf752ce22db8e4d8d33ec1 |
| etpinard | https://github.com/etpinard |
| Sep 28, 2016 | https://github.com/plotly/plotly.js/pull/986#discussion_r80924456 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| rreusser | https://github.com/rreusser |
| Sep 28, 2016 | https://github.com/plotly/plotly.js/pull/986#discussion_r80939154 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| src/components/slider/draw.js | https://github.com/plotly/plotly.js/pull/986/files/82ea5581ae7cd96b636f0d062cc98a6bd61e9b36#diff-56a1c9b6ae594bd7a9fc67e5ea1500259c4a30c29a66e9789c81fecc0afb145c |
| etpinard | https://github.com/etpinard |
| Sep 28, 2016 | https://github.com/plotly/plotly.js/pull/986#discussion_r80926965 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| etpinard | https://github.com/etpinard |
| Sep 28, 2016 | https://github.com/plotly/plotly.js/pull/986#discussion_r80927003 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| rreusser | https://github.com/rreusser |
| Sep 28, 2016 | https://github.com/plotly/plotly.js/pull/986#discussion_r80939260 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| src/components/updatemenus/draw.js | https://github.com/plotly/plotly.js/pull/986/files/82ea5581ae7cd96b636f0d062cc98a6bd61e9b36#diff-14e1814f826e54c32acaceda12ec44f769db57969b7b868e0a60575fb5c2add3 |
| etpinard | https://github.com/etpinard |
| Sep 28, 2016 | https://github.com/plotly/plotly.js/pull/986#discussion_r80927806 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| rreusser | https://github.com/rreusser |
| Sep 28, 2016 | https://github.com/plotly/plotly.js/pull/986#discussion_r80940616 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| src/components/slider/index.js | https://github.com/plotly/plotly.js/pull/986/files/82ea5581ae7cd96b636f0d062cc98a6bd61e9b36#diff-492a6fdbaa8f3cd3e78ec73ba1533305598e6118f99e7965d315e68941e92783 |
| etpinard | https://github.com/etpinard |
| Sep 28, 2016 | https://github.com/plotly/plotly.js/pull/986#discussion_r80927951 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| rreusser | https://github.com/rreusser |
| Oct 6, 2016 | https://github.com/plotly/plotly.js/pull/986#discussion_r82198325 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| src/components/slider/draw.js | https://github.com/plotly/plotly.js/pull/986/files/82ea5581ae7cd96b636f0d062cc98a6bd61e9b36#diff-56a1c9b6ae594bd7a9fc67e5ea1500259c4a30c29a66e9789c81fecc0afb145c |
| etpinard | https://github.com/etpinard |
| Sep 28, 2016 | https://github.com/plotly/plotly.js/pull/986#discussion_r80929001 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| etpinard | https://github.com/etpinard |
| Sep 28, 2016 | https://github.com/plotly/plotly.js/pull/986#discussion_r80939245 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| rreusser | https://github.com/rreusser |
| Oct 6, 2016 | https://github.com/plotly/plotly.js/pull/986#discussion_r82198216 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| src/components/slider/draw.js | https://github.com/plotly/plotly.js/pull/986/files/82ea5581ae7cd96b636f0d062cc98a6bd61e9b36#diff-56a1c9b6ae594bd7a9fc67e5ea1500259c4a30c29a66e9789c81fecc0afb145c |
| etpinard | https://github.com/etpinard |
| Sep 28, 2016 | https://github.com/plotly/plotly.js/pull/986#discussion_r80931733 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| here | https://github.com/plotly/plotly.js/pull/962/files#r79949182 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| etpinard | https://github.com/etpinard |
| Sep 28, 2016 | https://github.com/plotly/plotly.js/pull/986#discussion_r80937949 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| rreusser | https://github.com/rreusser |
| Sep 28, 2016 | https://github.com/plotly/plotly.js/pull/986#discussion_r80940138 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| src/components/slider/draw.js | https://github.com/plotly/plotly.js/pull/986/files/82ea5581ae7cd96b636f0d062cc98a6bd61e9b36#diff-56a1c9b6ae594bd7a9fc67e5ea1500259c4a30c29a66e9789c81fecc0afb145c |
| etpinard | https://github.com/etpinard |
| Sep 28, 2016 | https://github.com/plotly/plotly.js/pull/986#discussion_r80931956 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| Sep 28, 2016 | https://github.com/plotly/plotly.js/pull/986#issuecomment-250195275 |
| @jackparmer | https://github.com/jackparmer |
| @delekru | https://github.com/delekru |
| #986 (comment) | https://github.com/plotly/plotly.js/pull/986#issuecomment-250175532 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| https://github.com/rreusser |
| rreusser | https://github.com/rreusser |
| Sep 28, 2016 | https://github.com/plotly/plotly.js/pull/986#issuecomment-250197007 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| @etpinard | https://github.com/etpinard |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| Sep 28, 2016 | https://github.com/plotly/plotly.js/pull/986#issuecomment-250198877 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| https://github.com/rreusser |
| rreusser | https://github.com/rreusser |
| Sep 28, 2016 | https://github.com/plotly/plotly.js/pull/986#issuecomment-250199265 |
| @etpinard | https://github.com/etpinard |
| https://cloud.githubusercontent.com/assets/572717/18919780/5b43f3b0-856d-11e6-955f-dc6e36c1a2f9.gif |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| rreusser | https://github.com/rreusser |
| September 28, 2016 11:57 | https://github.com/plotly/plotly.js/pull/986#commits-pushed-c6a3e11 |
|
| https://github.com/rreusser |
| Rename sliders and bump circular require tolerance | https://github.com/plotly/plotly.js/pull/986/commits/c6a3e11bf1662b23783c29379cdf88bbbc295a27 |
| c6a3e11 | https://github.com/plotly/plotly.js/pull/986/commits/c6a3e11bf1662b23783c29379cdf88bbbc295a27 |
|
| https://github.com/rreusser |
| Add trbl padding to sliders | https://github.com/plotly/plotly.js/pull/986/commits/5b74652486fee6ae5e12547e0ff9294166d53598 |
| 5b74652 | https://github.com/plotly/plotly.js/pull/986/commits/5b74652486fee6ae5e12547e0ff9294166d53598 |
|
| https://github.com/rreusser |
| Remove fanciness from slider constants | https://github.com/plotly/plotly.js/pull/986/commits/e13e0eea87b744d2176b3a0af47e6634bf8f2a59 |
| e13e0ee | https://github.com/plotly/plotly.js/pull/986/commits/e13e0eea87b744d2176b3a0af47e6634bf8f2a59 |
|
| https://github.com/rreusser |
| Tweak slider behavior to avoid event -> method loops | https://github.com/plotly/plotly.js/pull/986/commits/8fe184269ec3a37cc8d0e76dad9f123e9477b902 |
| 8fe1842 | https://github.com/plotly/plotly.js/pull/986/commits/8fe184269ec3a37cc8d0e76dad9f123e9477b902 |
|
| https://github.com/rreusser |
| Improve padding logic for updatemenus | https://github.com/plotly/plotly.js/pull/986/commits/05ac5863c1b135df2c5f456f0fd30cd6ff50b2de |
| 05ac586 | https://github.com/plotly/plotly.js/pull/986/commits/05ac5863c1b135df2c5f456f0fd30cd6ff50b2de |
| https://github.com/jackparmer |
| jackparmer | https://github.com/jackparmer |
| Sep 28, 2016 | https://github.com/plotly/plotly.js/pull/986#issuecomment-250333967 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| rreusser | https://github.com/rreusser |
| September 29, 2016 08:52 | https://github.com/plotly/plotly.js/pull/986#commits-pushed-4604341 |
|
| https://github.com/rreusser |
| Add jasmine tests for updatemenus padding | https://github.com/plotly/plotly.js/pull/986/commits/46043418e883ed838dda44ebc04c69f64a282bec |
| 4604341 | https://github.com/plotly/plotly.js/pull/986/commits/46043418e883ed838dda44ebc04c69f64a282bec |
|
| https://github.com/cldougl |
| add streaming maxpoints max and dflt | https://github.com/plotly/plotly.js/pull/986/commits/8558be8ef4d0b3e3dc6366b4a872b75d0af97656 |
| 8558be8 | https://github.com/plotly/plotly.js/pull/986/commits/8558be8ef4d0b3e3dc6366b4a872b75d0af97656 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Sep 29, 2016
| https://github.com/plotly/plotly.js/pull/986#ref-issue-180081949 |
|
Unify component pad logic
#997
| https://github.com/plotly/plotly.js/issues/997 |
|
| https://github.com/cldougl |
| Merge pull request | https://github.com/plotly/plotly.js/pull/986/commits/c673afe0c088ca3a548b469d6874bbbbcfaa457a |
| #996 | https://github.com/plotly/plotly.js/pull/996 |
| from plotly/maxpt_dflt | https://github.com/plotly/plotly.js/pull/986/commits/c673afe0c088ca3a548b469d6874bbbbcfaa457a |
| c673afe | https://github.com/plotly/plotly.js/pull/986/commits/c673afe0c088ca3a548b469d6874bbbbcfaa457a |
| rreusser | https://github.com/rreusser |
| October 3, 2016 15:36 | https://github.com/plotly/plotly.js/pull/986#commits-pushed-4775a47 |
|
| https://github.com/rreusser |
| Test updateevent for sliders | https://github.com/plotly/plotly.js/pull/986/commits/4775a47e94aee888d730bca810e423e33a12da7b |
| 4775a47 | https://github.com/plotly/plotly.js/pull/986/commits/4775a47e94aee888d730bca810e423e33a12da7b |
|
| https://github.com/rreusser |
| Update sliders baseline to reflect bugfix | https://github.com/plotly/plotly.js/pull/986/commits/a08f08431c3fafa605fd00fe6af491ac1e910000 |
| a08f084 | https://github.com/plotly/plotly.js/pull/986/commits/a08f08431c3fafa605fd00fe6af491ac1e910000 |
|
| https://github.com/rreusser |
| Fix plot schema error | https://github.com/plotly/plotly.js/pull/986/commits/5816c240f9e361e98b650139b44fa7cf3566ed41 |
| 5816c24 | https://github.com/plotly/plotly.js/pull/986/commits/5816c240f9e361e98b650139b44fa7cf3566ed41 |
| https://github.com/rreusser |
| rreusser | https://github.com/rreusser |
|
Oct 4, 2016
| https://github.com/plotly/plotly.js/pull/986#ref-issue-180917144 |
|
Bindings
#1002
| https://github.com/plotly/plotly.js/issues/1002 |
| rreusser | https://github.com/rreusser |
| October 4, 2016 14:45 | https://github.com/plotly/plotly.js/pull/986#commits-pushed-2cfa81b |
|
| https://github.com/rreusser |
| Remove unneeded lines from sliders test | https://github.com/plotly/plotly.js/pull/986/commits/2cfa81b3b83eeb62b2df531da20839efc67b3bc9 |
| 2cfa81b | https://github.com/plotly/plotly.js/pull/986/commits/2cfa81b3b83eeb62b2df531da20839efc67b3bc9 |
|
| https://github.com/rreusser |
| Remove updatevalue and updateevent | https://github.com/plotly/plotly.js/pull/986/commits/1d52b51e18aab1a2cea6c164043be5d3aa931937 |
| 1d52b51 | https://github.com/plotly/plotly.js/pull/986/commits/1d52b51e18aab1a2cea6c164043be5d3aa931937 |
|
| https://github.com/rreusser |
| Removed unused slider function | https://github.com/plotly/plotly.js/pull/986/commits/892583de207ea8f2a0b1cf8fac326cdb615dacf4 |
| 892583d | https://github.com/plotly/plotly.js/pull/986/commits/892583de207ea8f2a0b1cf8fac326cdb615dacf4 |
|
| https://github.com/rreusser |
| Clean up slider options | https://github.com/plotly/plotly.js/pull/986/commits/5015710e502c39f4ef28521ddefeb0ff98f6ab05 |
| 5015710 | https://github.com/plotly/plotly.js/pull/986/commits/5015710e502c39f4ef28521ddefeb0ff98f6ab05 |
| https://github.com/rreusser |
| rreusser | https://github.com/rreusser |
| Oct 6, 2016 | https://github.com/plotly/plotly.js/pull/986#issuecomment-251974341 |
| @etpinard | https://github.com/etpinard |
| https://cloud.githubusercontent.com/assets/572717/19155650/37209b8c-8bad-11e6-8b39-6dd8028be3b3.png |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
|
| https://github.com/rreusser |
| Remove unneeded/failing slider test | https://github.com/plotly/plotly.js/pull/986/commits/582c6432d4c67860db7abac23d8a0ee6a70a21a1 |
| 582c643 | https://github.com/plotly/plotly.js/pull/986/commits/582c6432d4c67860db7abac23d8a0ee6a70a21a1 |
| https://github.com/rreusser |
| rreusser | https://github.com/rreusser |
|
status: reviewable
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22status%3A%20reviewable%22 |
|
status: in progress
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22status%3A%20in%20progress%22 |
| Oct 6, 2016 | https://github.com/plotly/plotly.js/pull/986#event-814840931 |
| https://github.com/rreusser |
| rreusser | https://github.com/rreusser |
|
Oct 6, 2016
| https://github.com/plotly/plotly.js/pull/986#ref-pullrequest-181451359 |
|
Common interface to interpret and execute API methods
#1016
| https://github.com/plotly/plotly.js/pull/1016 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Oct 6, 2016
| https://github.com/plotly/plotly.js/pull/986#pullrequestreview-3137151 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/986/files/5015710e502c39f4ef28521ddefeb0ff98f6ab05 |
| etpinard | https://github.com/etpinard |
| https://github.com/plotly/plotly.js/pull/986#pullrequestreview-3137151 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @rreusser | https://github.com/rreusser |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| src/components/sliders/attributes.js | https://github.com/plotly/plotly.js/pull/986/files/892583de207ea8f2a0b1cf8fac326cdb615dacf4..5015710e502c39f4ef28521ddefeb0ff98f6ab05#diff-ac12b9eb24f4472b25768ee4729e20eed8b4103f64585291488fde86633f7c35 |
| etpinard | https://github.com/etpinard |
| Oct 6, 2016 | https://github.com/plotly/plotly.js/pull/986#discussion_r82214163 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| src/components/sliders/defaults.js | https://github.com/plotly/plotly.js/pull/986/files/892583de207ea8f2a0b1cf8fac326cdb615dacf4..5015710e502c39f4ef28521ddefeb0ff98f6ab05#diff-8c817c295fee9884a32a43bbb3e881f613438b8fcf2465c92b3538f517271c72 |
| etpinard | https://github.com/etpinard |
| Oct 6, 2016 | https://github.com/plotly/plotly.js/pull/986#discussion_r82214541 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| rreusser | https://github.com/rreusser |
| Oct 6, 2016 | https://github.com/plotly/plotly.js/pull/986#discussion_r82227123 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| rreusser | https://github.com/rreusser |
| Oct 6, 2016 | https://github.com/plotly/plotly.js/pull/986#discussion_r82227418 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| etpinard | https://github.com/etpinard |
| Oct 6, 2016 | https://github.com/plotly/plotly.js/pull/986#discussion_r82227566 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| src/components/sliders/attributes.js | https://github.com/plotly/plotly.js/pull/986/files/582c6432d4c67860db7abac23d8a0ee6a70a21a1#diff-ac12b9eb24f4472b25768ee4729e20eed8b4103f64585291488fde86633f7c35 |
| etpinard | https://github.com/etpinard |
| Oct 6, 2016 | https://github.com/plotly/plotly.js/pull/986#discussion_r82215272 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| src/components/sliders/attributes.js | https://github.com/plotly/plotly.js/pull/986/files/582c6432d4c67860db7abac23d8a0ee6a70a21a1#diff-ac12b9eb24f4472b25768ee4729e20eed8b4103f64585291488fde86633f7c35 |
| etpinard | https://github.com/etpinard |
| Oct 6, 2016 | https://github.com/plotly/plotly.js/pull/986#discussion_r82215679 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| rreusser | https://github.com/rreusser |
| Oct 6, 2016 | https://github.com/plotly/plotly.js/pull/986#discussion_r82226855 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| rreusser | https://github.com/rreusser |
| Oct 6, 2016 | https://github.com/plotly/plotly.js/pull/986#discussion_r82238032 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| src/components/sliders/defaults.js | https://github.com/plotly/plotly.js/pull/986/files/582c6432d4c67860db7abac23d8a0ee6a70a21a1#diff-8c817c295fee9884a32a43bbb3e881f613438b8fcf2465c92b3538f517271c72 |
| etpinard | https://github.com/etpinard |
| Oct 6, 2016 | https://github.com/plotly/plotly.js/pull/986#discussion_r82216797 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| rreusser | https://github.com/rreusser |
| Oct 6, 2016 | https://github.com/plotly/plotly.js/pull/986#discussion_r82242796 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| src/components/sliders/defaults.js | https://github.com/plotly/plotly.js/pull/986/files/582c6432d4c67860db7abac23d8a0ee6a70a21a1#diff-8c817c295fee9884a32a43bbb3e881f613438b8fcf2465c92b3538f517271c72 |
| etpinard | https://github.com/etpinard |
| Oct 6, 2016 | https://github.com/plotly/plotly.js/pull/986#discussion_r82217077 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| rreusser | https://github.com/rreusser |
| Oct 6, 2016 | https://github.com/plotly/plotly.js/pull/986#discussion_r82242741 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| test/image/mocks/sliders.json | https://github.com/plotly/plotly.js/pull/986/files/582c6432d4c67860db7abac23d8a0ee6a70a21a1#diff-4252ed99abb7004a77ab1226b40f19b57bb4a24964b98d75539d2eba69badebb |
| etpinard | https://github.com/etpinard |
| Oct 6, 2016 | https://github.com/plotly/plotly.js/pull/986#discussion_r82217496 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| rreusser | https://github.com/rreusser |
| Oct 6, 2016 | https://github.com/plotly/plotly.js/pull/986#discussion_r82233883 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| test/jasmine/assets/fail_test.js | https://github.com/plotly/plotly.js/pull/986/files/582c6432d4c67860db7abac23d8a0ee6a70a21a1#diff-e3924444381c8aa39c3e1cf595cf1e89b9f33aa3f3d546615352bce43d6b1058 |
| etpinard | https://github.com/etpinard |
| Oct 6, 2016 | https://github.com/plotly/plotly.js/pull/986#discussion_r82217609 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| test/jasmine/tests/sliders_test.js | https://github.com/plotly/plotly.js/pull/986/files/582c6432d4c67860db7abac23d8a0ee6a70a21a1#diff-09276d81835ab1fc83e8eb085e4faae2de13348f4be40367cb03276a3f651cbf |
| etpinard | https://github.com/etpinard |
| Oct 6, 2016 | https://github.com/plotly/plotly.js/pull/986#discussion_r82217929 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| test/jasmine/tests/sliders_test.js | https://github.com/plotly/plotly.js/pull/986/files/582c6432d4c67860db7abac23d8a0ee6a70a21a1#diff-09276d81835ab1fc83e8eb085e4faae2de13348f4be40367cb03276a3f651cbf |
| etpinard | https://github.com/etpinard |
| Oct 6, 2016 | https://github.com/plotly/plotly.js/pull/986#discussion_r82218684 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| rreusser | https://github.com/rreusser |
| Oct 6, 2016 | https://github.com/plotly/plotly.js/pull/986#discussion_r82251854 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Oct 6, 2016
| https://github.com/plotly/plotly.js/pull/986#pullrequestreview-3142536 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/986/files/582c6432d4c67860db7abac23d8a0ee6a70a21a1 |
| etpinard | https://github.com/etpinard |
| https://github.com/plotly/plotly.js/pull/986#pullrequestreview-3142536 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @rreusser | https://github.com/rreusser |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| https://github.com/rreusser |
| rreusser | https://github.com/rreusser |
| Oct 6, 2016 | https://github.com/plotly/plotly.js/pull/986#issuecomment-252027998 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| https://cloud.githubusercontent.com/assets/572717/19162567/5e11bcda-8bc6-11e6-886d-873c55978f75.gif |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| rreusser | https://github.com/rreusser |
| October 6, 2016 13:14 | https://github.com/plotly/plotly.js/pull/986#commits-pushed-70610ec |
|
| https://github.com/rreusser |
| Add suffix to currentvalue slider label | https://github.com/plotly/plotly.js/pull/986/commits/70610ec80a1ea8eb8ff85bd5da48093e97ffc016 |
| 70610ec | https://github.com/plotly/plotly.js/pull/986/commits/70610ec80a1ea8eb8ff85bd5da48093e97ffc016 |
|
| https://github.com/rreusser |
| don't coerce slider currentvalue attrs when !visible | https://github.com/plotly/plotly.js/pull/986/commits/f25127cce9c2f556a0fb28376973b5f66bb1f1e1 |
| f25127c | https://github.com/plotly/plotly.js/pull/986/commits/f25127cce9c2f556a0fb28376973b5f66bb1f1e1 |
|
| https://github.com/rreusser |
| Be more specific about *all* unused slider attrs not set | https://github.com/plotly/plotly.js/pull/986/commits/4b608eeb29e9c737f831491ffa7bda3b7987153c |
| 4b608ee | https://github.com/plotly/plotly.js/pull/986/commits/4b608eeb29e9c737f831491ffa7bda3b7987153c |
|
| https://github.com/rreusser |
| Test mouse movement for sliders | https://github.com/plotly/plotly.js/pull/986/commits/6c9034d64fdbee21f42483fbfb338c1f4a749ec1 |
| 6c9034d | https://github.com/plotly/plotly.js/pull/986/commits/6c9034d64fdbee21f42483fbfb338c1f4a749ec1 |
| https://github.com/rreusser |
| rreusser | https://github.com/rreusser |
| Oct 6, 2016 | https://github.com/plotly/plotly.js/pull/986#issuecomment-252049310 |
| @etpinard | https://github.com/etpinard |
| 70610ec | https://github.com/plotly/plotly.js/pull/986/commits/70610ec80a1ea8eb8ff85bd5da48093e97ffc016 |
| f25127c | https://github.com/plotly/plotly.js/pull/986/commits/f25127cce9c2f556a0fb28376973b5f66bb1f1e1 |
| 4b608ee | https://github.com/plotly/plotly.js/pull/986/commits/4b608eeb29e9c737f831491ffa7bda3b7987153c |
| 6c9034d | https://github.com/plotly/plotly.js/pull/986/commits/6c9034d64fdbee21f42483fbfb338c1f4a749ec1 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Oct 6, 2016
| https://github.com/plotly/plotly.js/pull/986#pullrequestreview-3182138 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/986/files/6c9034d64fdbee21f42483fbfb338c1f4a749ec1 |
| test/jasmine/tests/sliders_test.js | https://github.com/plotly/plotly.js/pull/986/files/4b608eeb29e9c737f831491ffa7bda3b7987153c..6c9034d64fdbee21f42483fbfb338c1f4a749ec1#diff-09276d81835ab1fc83e8eb085e4faae2de13348f4be40367cb03276a3f651cbf |
| etpinard | https://github.com/etpinard |
| Oct 6, 2016 | https://github.com/plotly/plotly.js/pull/986#discussion_r82261918 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| rreusser | https://github.com/rreusser |
| Oct 6, 2016 | https://github.com/plotly/plotly.js/pull/986#discussion_r82262149 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| Oct 6, 2016 | https://github.com/plotly/plotly.js/pull/986#issuecomment-252060099 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| https://github.com/rreusser |
| rreusser | https://github.com/rreusser |
| Oct 6, 2016 | https://github.com/plotly/plotly.js/pull/986#issuecomment-252060895 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| Oct 6, 2016 | https://github.com/plotly/plotly.js/pull/986#issuecomment-252063401 |
| @rreusser | https://github.com/rreusser |
| https://cloud.githubusercontent.com/assets/6675409/19167251/cda8a8e4-8bd8-11e6-9489-a10ac13bcc2a.gif |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Oct 6, 2016
| https://github.com/plotly/plotly.js/pull/986#pullrequestreview-3184628 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/986/files/6c9034d64fdbee21f42483fbfb338c1f4a749ec1 |
|
| https://github.com/rreusser |
| Make sure slider Drawing.bBox calls fall back to defined | https://github.com/plotly/plotly.js/pull/986/commits/21e2f997586f2018e36a438cc3bf8fd101181c22 |
| 21e2f99 | https://github.com/plotly/plotly.js/pull/986/commits/21e2f997586f2018e36a438cc3bf8fd101181c22 |
| https://github.com/rreusser |
| rreusser | https://github.com/rreusser |
| Oct 6, 2016 | https://github.com/plotly/plotly.js/pull/986#issuecomment-252066728 |
| @etpinard | https://github.com/etpinard |
| https://cloud.githubusercontent.com/assets/572717/19167708/ecb582dc-8bda-11e6-95f9-410f4126e946.gif |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
| https://github.com/rreusser |
| rreusser | https://github.com/rreusser |
| cb293c7 | https://github.com/plotly/plotly.js/commit/cb293c752792b7f0d7aca9e597c3796dbda4358a |
| Oct 6, 2016 | https://github.com/plotly/plotly.js/pull/986#event-815317308 |
| https://github.com/rreusser |
| rreusser | https://github.com/rreusser |
| October 6, 2016 19:59 | https://github.com/plotly/plotly.js/pull/986#event-815317356 |
| https://github.co/hiddenchars |
| https://github.com/plotly/plotly.js/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F986 |
|
| https://github.com/etpinard |
|
etpinard
| https://github.com/etpinard |
|
| https://github.com/plotly/plotly.js/pull/986/files/6c9034d64fdbee21f42483fbfb338c1f4a749ec1 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
|
feature
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Afeature |
|
v1.18.0
| https://github.com/plotly/plotly.js/milestone/11 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/986 |
|
| https://github.com/rreusser |
|
| https://github.com/etpinard |
|
| https://github.com/jackparmer |
|
| https://github.com/delekru |
|
| https://github.com/cldougl |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |