| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:1ac6f44d-0806-a6d8-fb08-616cd7f48aa1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CA7E:DDD15:132FE5F:1BBAF1D:6A58BDCA |
| html-safe-nonce | 5c35442d41286804cdc35240ffe4a0958435b6f4bc47e3880e0a32c1072c3f1f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQTdFOkRERDE1OjEzMkZFNUY6MUJCQUYxRDo2QTU4QkRDQSIsInZpc2l0b3JfaWQiOiIyMTQ0NjY3NjIwMTE2ODM5ODgyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 8110cf6f8658a22a7642cae0c638f731f07f0110e3c141a0ac37f5c094fc481d |
| hovercard-subject-tag | pull_request:85484525 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/plotly/plotly.js/946/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/a2d50655edf0cb5a222be39442b149182df996e7a991b9fe423f2f704bf63941/plotly/plotly.js/pull/946 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a2d50655edf0cb5a222be39442b149182df996e7a991b9fe423f2f704bf63941/plotly/plotly.js/pull/946 |
| og:image:alt | resolves #634
In trying to make the cartesian plot routine a little more reusable for range slider 2.0, I ran into these
// in plot_api.js
var subplots = Plotly.Axes.getSubplots(gd).join(''... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | etpinard |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f2a0c7865178af3d91dd9f13b0cdfc3c73a2529c873d2780bb4c01271a57ec6 |
| turbo-cache-control | no-cache |
| go-import | github.com/plotly/plotly.js git https://github.com/plotly/plotly.js.git |
| octolytics-dimension-user_id | 5997976 |
| octolytics-dimension-user_login | plotly |
| octolytics-dimension-repository_id | 45646037 |
| octolytics-dimension-repository_nwo | plotly/plotly.js |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 45646037 |
| octolytics-dimension-repository_network_root_nwo | plotly/plotly.js |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8aae7b8d6caacacf5c66eaeb2702d8dc88d85b4a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/plotly/plotly.js/pull/946#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F946 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F946 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=plotly%2Fplotly.js |
| Reload | https://github.com/plotly/plotly.js/pull/946 |
| Reload | https://github.com/plotly/plotly.js/pull/946 |
| Reload | https://github.com/plotly/plotly.js/pull/946 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/946 |
|
plotly
| https://github.com/plotly |
| plotly.js | https://github.com/plotly/plotly.js |
| Please reload this page | https://github.com/plotly/plotly.js/pull/946 |
|
Notifications
| https://github.com/login?return_to=%2Fplotly%2Fplotly.js |
|
Fork
2k
| https://github.com/login?return_to=%2Fplotly%2Fplotly.js |
|
Star
18.3k
| https://github.com/login?return_to=%2Fplotly%2Fplotly.js |
|
Code
| https://github.com/plotly/plotly.js |
|
Issues
773
| https://github.com/plotly/plotly.js/issues |
|
Pull requests
56
| https://github.com/plotly/plotly.js/pulls |
|
Actions
| https://github.com/plotly/plotly.js/actions |
|
Security and quality
0
| https://github.com/plotly/plotly.js/security |
|
Insights
| https://github.com/plotly/plotly.js/pulse |
|
Code
| https://github.com/plotly/plotly.js |
|
Issues
| https://github.com/plotly/plotly.js/issues |
|
Pull requests
| https://github.com/plotly/plotly.js/pulls |
|
Actions
| https://github.com/plotly/plotly.js/actions |
|
Security and quality
| https://github.com/plotly/plotly.js/security |
|
Insights
| https://github.com/plotly/plotly.js/pulse |
| etpinard | https://github.com/etpinard |
| master | https://github.com/plotly/plotly.js/tree/master |
| cartesian-per-subplot | https://github.com/plotly/plotly.js/tree/cartesian-per-subplot |
| Conversation | https://github.com/plotly/plotly.js/pull/946 |
| Commits17 (17) | https://github.com/plotly/plotly.js/pull/946/commits |
| Checks | https://github.com/plotly/plotly.js/pull/946/checks |
| Files changed | https://github.com/plotly/plotly.js/pull/946/files |
| Cartesian subplot updates using data joins | https://github.com/plotly/plotly.js/pull/946#top |
| etpinard | https://github.com/etpinard |
| master | https://github.com/plotly/plotly.js/tree/master |
| cartesian-per-subplot | https://github.com/plotly/plotly.js/tree/cartesian-per-subplot |
|
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| Sep 15, 2016 | https://github.com/plotly/plotly.js/pull/946#issue-177295585 |
| #634 | https://github.com/plotly/plotly.js/issues/634 |
| #634 | https://github.com/plotly/plotly.js/issues/634 |
| @rreusser | https://github.com/rreusser |
| @alexcjohnson | https://github.com/alexcjohnson |
| Please reload this page | https://github.com/plotly/plotly.js/pull/946 |
| etpinard | https://github.com/etpinard |
| September 15, 2016 17:12 | https://github.com/plotly/plotly.js/pull/946#commits-pushed-c877c27 |
|
| https://github.com/etpinard |
| move subplot creation from makePlotFramework -> Cartesian.plot | https://github.com/plotly/plotly.js/pull/946/commits/c877c27ac523466007a4df7f992346757a16124f |
| c877c27 | https://github.com/plotly/plotly.js/pull/946/commits/c877c27ac523466007a4df7f992346757a16124f |
|
| https://github.com/etpinard |
| rm some early-Plotly.plot logic regarding makePlotFramwork | https://github.com/plotly/plotly.js/pull/946/commits/ff26691c3cff92316c0af5daf758ff6b40f1ca4b |
| ff26691 | https://github.com/plotly/plotly.js/pull/946/commits/ff26691c3cff92316c0af5daf758ff6b40f1ca4b |
|
| https://github.com/etpinard |
| plots: add linkSubplot method | https://github.com/plotly/plotly.js/pull/946/commits/40fc7f90d0c8c7e7d90982746dcab4e226e2c4d3 |
| 40fc7f9 | https://github.com/plotly/plotly.js/pull/946/commits/40fc7f90d0c8c7e7d90982746dcab4e226e2c4d3 |
|
| https://github.com/etpinard |
| first try at making the new cartesian subplot paradigm work | https://github.com/plotly/plotly.js/pull/946/commits/652b90537747c3623f61f218cd608676cac6ebb1 |
| 652b905 | https://github.com/plotly/plotly.js/pull/946/commits/652b90537747c3623f61f218cd608676cac6ebb1 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
type: maintenance
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22type%3A%20maintenance%22 |
| Sep 15, 2016 | https://github.com/plotly/plotly.js/pull/946#event-791382952 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| Sep 15, 2016 | https://github.com/plotly/plotly.js/pull/946#issuecomment-247463103 |
| Axes.doTicks | https://github.com/plotly/plotly.js/blob/920a333283b1ad9506e804a2e872eaa7f77c3f2e/src/plots/cartesian/axes.js#L1355 |
| layoutStyles | https://github.com/plotly/plotly.js/blob/920a333283b1ad9506e804a2e872eaa7f77c3f2e/src/plot_api/subroutines.js#L27 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/946 |
| etpinard | https://github.com/etpinard |
| September 15, 2016 17:55 | https://github.com/plotly/plotly.js/pull/946#commits-pushed-e85a6c7 |
|
| https://github.com/etpinard |
| keep ref to subplot image/shape layers in main drawData | https://github.com/plotly/plotly.js/pull/946/commits/e85a6c73d7b8980a2b4360155d0d69629634fd64 |
| e85a6c7 | https://github.com/plotly/plotly.js/pull/946/commits/e85a6c73d7b8980a2b4360155d0d69629634fd64 |
|
| https://github.com/etpinard |
| lint | https://github.com/plotly/plotly.js/pull/946/commits/43d227adc9537dfd26b27961153b5737b4f70691 |
| 43d227a | https://github.com/plotly/plotly.js/pull/946/commits/43d227adc9537dfd26b27961153b5737b4f70691 |
|
| https://github.com/etpinard |
| add baseModule drawFramework step | https://github.com/plotly/plotly.js/pull/946/commits/937c54b53e6558060215b73c8fea440ee6ad0d47 |
| 937c54b | https://github.com/plotly/plotly.js/pull/946/commits/937c54b53e6558060215b73c8fea440ee6ad0d47 |
|
| https://github.com/etpinard |
| plots: add a cartesian subplot purge step | https://github.com/plotly/plotly.js/pull/946/commits/78faa3fe4399d13c37207499c451c82e7da701af |
| 78faa3f | https://github.com/plotly/plotly.js/pull/946/commits/78faa3fe4399d13c37207499c451c82e7da701af |
|
| https://github.com/etpinard |
| test: adapt relinkPrivateKeys test | https://github.com/plotly/plotly.js/pull/946/commits/f8017f25af7227e5aff14c3330c03e17ed2b025e |
| f8017f2 | https://github.com/plotly/plotly.js/pull/946/commits/f8017f25af7227e5aff14c3330c03e17ed2b025e |
|
| https://github.com/etpinard |
| test: adapt legend scroll test | https://github.com/plotly/plotly.js/pull/946/commits/c239602000b937afe00f64fecbfae283f544a908 |
| c239602 | https://github.com/plotly/plotly.js/pull/946/commits/c239602000b937afe00f64fecbfae283f544a908 |
|
| https://github.com/etpinard |
| test: adapt gd._ keys ordering | https://github.com/plotly/plotly.js/pull/946/commits/f4aee1e92c07ea7d0583ae12fb34e5408c9a147d |
| f4aee1e | https://github.com/plotly/plotly.js/pull/946/commits/f4aee1e92c07ea7d0583ae12fb34e5408c9a147d |
|
| https://github.com/etpinard |
| test: check clip path & dragger counts in cartesian plots | https://github.com/plotly/plotly.js/pull/946/commits/ab964229be20dab6b82a7c009006f8ab9afbe59c |
| ab96422 | https://github.com/plotly/plotly.js/pull/946/commits/ab964229be20dab6b82a7c009006f8ab9afbe59c |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Sep 16, 2016
| https://github.com/plotly/plotly.js/pull/946#pullrequestreview-437330 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/946/files/ab964229be20dab6b82a7c009006f8ab9afbe59c |
| src/plots/cartesian/index.js | https://github.com/plotly/plotly.js/pull/946/files/ab964229be20dab6b82a7c009006f8ab9afbe59c#diff-8235b6d0b87fca3c0caaed994db8375802da313c433ec62a4d27e4a3fd8c5e8d |
| etpinard | https://github.com/etpinard |
| Sep 16, 2016 | https://github.com/plotly/plotly.js/pull/946#discussion_r79261191 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| http://codepen.io/etpinard/pen/mAEBVz | http://codepen.io/etpinard/pen/mAEBVz |
| Please reload this page | https://github.com/plotly/plotly.js/pull/946 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
status: reviewable
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22status%3A%20reviewable%22 |
|
status: in progress
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22status%3A%20in%20progress%22 |
| Sep 16, 2016 | https://github.com/plotly/plotly.js/pull/946#event-792746980 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| Sep 16, 2016 | https://github.com/plotly/plotly.js/pull/946#issuecomment-247723831 |
| 937c54b | https://github.com/plotly/plotly.js/commit/937c54b53e6558060215b73c8fea440ee6ad0d47 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/946 |
|
| https://github.com/etpinard |
| Merge branch 'master' into cartesian-per-subplot | https://github.com/plotly/plotly.js/pull/946/commits/8c09af25195f7ed0ab6340190ff94507c323f587 |
| 8c09af2 | https://github.com/plotly/plotly.js/pull/946/commits/8c09af25195f7ed0ab6340190ff94507c323f587 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Sep 16, 2016
| https://github.com/plotly/plotly.js/pull/946#pullrequestreview-438593 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/946/files/f8017f25af7227e5aff14c3330c03e17ed2b025e |
| test/jasmine/tests/plots_test.js | https://github.com/plotly/plotly.js/pull/946/files/78faa3fe4399d13c37207499c451c82e7da701af..f8017f25af7227e5aff14c3330c03e17ed2b025e#diff-0ec5ead8ef5f115baa4c93a063456fd8c59ffae75ff98feeea490d207e039d72 |
| etpinard | https://github.com/etpinard |
| Sep 16, 2016 | https://github.com/plotly/plotly.js/pull/946#discussion_r79262587 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @rreusser | https://github.com/rreusser |
| Please reload this page | https://github.com/plotly/plotly.js/pull/946 |
| rreusser | https://github.com/rreusser |
| Oct 5, 2016 | https://github.com/plotly/plotly.js/pull/946#discussion_r82048967 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/946 |
| etpinard | https://github.com/etpinard |
| Oct 6, 2016 | https://github.com/plotly/plotly.js/pull/946#discussion_r82106929 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/946 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Sep 16, 2016
| https://github.com/plotly/plotly.js/pull/946#pullrequestreview-438740 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/946/files/c239602000b937afe00f64fecbfae283f544a908 |
| test/jasmine/tests/legend_scroll_test.js | https://github.com/plotly/plotly.js/pull/946/files/f8017f25af7227e5aff14c3330c03e17ed2b025e..c239602000b937afe00f64fecbfae283f544a908#diff-1c9011cecef7c5fa1a9ae135b7282735601013c5e703ee0da2f47853c0f462ba |
| etpinard | https://github.com/etpinard |
| Sep 16, 2016 | https://github.com/plotly/plotly.js/pull/946#discussion_r79262745 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/946 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Sep 16, 2016
| https://github.com/plotly/plotly.js/pull/946#pullrequestreview-438885 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/946/files/8c09af25195f7ed0ab6340190ff94507c323f587 |
| src/plot_api/plot_api.js | https://github.com/plotly/plotly.js/pull/946/files/8c09af25195f7ed0ab6340190ff94507c323f587#diff-4cc342865f02fea8acedf92e7c0855b4c805c9824b4b4aaf0f587dba2506c9e7 |
| etpinard | https://github.com/etpinard |
| Sep 16, 2016 | https://github.com/plotly/plotly.js/pull/946#discussion_r79262903 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @alexcjohnson | https://github.com/alexcjohnson |
| Please reload this page | https://github.com/plotly/plotly.js/pull/946 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Sep 16, 2016
| https://github.com/plotly/plotly.js/pull/946#pullrequestreview-438988 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/946/files/8c09af25195f7ed0ab6340190ff94507c323f587 |
| src/plot_api/plot_api.js | https://github.com/plotly/plotly.js/pull/946/files/8c09af25195f7ed0ab6340190ff94507c323f587#diff-4cc342865f02fea8acedf92e7c0855b4c805c9824b4b4aaf0f587dba2506c9e7 |
| etpinard | https://github.com/etpinard |
| Sep 16, 2016 | https://github.com/plotly/plotly.js/pull/946#discussion_r79263020 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/946 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Sep 16, 2016
| https://github.com/plotly/plotly.js/pull/946#pullrequestreview-439038 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/946/files/8c09af25195f7ed0ab6340190ff94507c323f587 |
| src/plots/cartesian/index.js | https://github.com/plotly/plotly.js/pull/946/files/8c09af25195f7ed0ab6340190ff94507c323f587#diff-8235b6d0b87fca3c0caaed994db8375802da313c433ec62a4d27e4a3fd8c5e8d |
| etpinard | https://github.com/etpinard |
| Sep 16, 2016 | https://github.com/plotly/plotly.js/pull/946#discussion_r79263069 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/946 |
| rreusser | https://github.com/rreusser |
| Oct 5, 2016 | https://github.com/plotly/plotly.js/pull/946#discussion_r82048108 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/946 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/946 |
| etpinard | https://github.com/etpinard |
| Oct 6, 2016 | https://github.com/plotly/plotly.js/pull/946#discussion_r82107314 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/946 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Sep 16, 2016
| https://github.com/plotly/plotly.js/pull/946#pullrequestreview-439144 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/946/files/8c09af25195f7ed0ab6340190ff94507c323f587 |
| src/plots/plots.js | https://github.com/plotly/plotly.js/pull/946/files/8c09af25195f7ed0ab6340190ff94507c323f587#diff-bb59a2aa90fd14ef3218544010e7fe42f370e10f0c8ee702b3f85ab86887d970 |
| etpinard | https://github.com/etpinard |
| Sep 16, 2016 | https://github.com/plotly/plotly.js/pull/946#discussion_r79263166 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/946 |
| etpinard | https://github.com/etpinard |
| Sep 16, 2016 | https://github.com/plotly/plotly.js/pull/946#discussion_r79263181 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @rreusser | https://github.com/rreusser |
| Please reload this page | https://github.com/plotly/plotly.js/pull/946 |
| etpinard | https://github.com/etpinard |
| Oct 4, 2016 | https://github.com/plotly/plotly.js/pull/946#discussion_r81868365 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| 2b05978 | https://github.com/plotly/plotly.js/commit/2b05978ae25f3c43603e971d2ae56cb43d0db34a |
| Please reload this page | https://github.com/plotly/plotly.js/pull/946 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Sep 16, 2016
| https://github.com/plotly/plotly.js/pull/946#pullrequestreview-439236 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/946/files/8c09af25195f7ed0ab6340190ff94507c323f587 |
| src/plots/plots.js | https://github.com/plotly/plotly.js/pull/946/files/8c09af25195f7ed0ab6340190ff94507c323f587#diff-bb59a2aa90fd14ef3218544010e7fe42f370e10f0c8ee702b3f85ab86887d970 |
| etpinard | https://github.com/etpinard |
| Sep 16, 2016 | https://github.com/plotly/plotly.js/pull/946#discussion_r79263272 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/946 |
| etpinard | https://github.com/etpinard |
| Oct 4, 2016 | https://github.com/plotly/plotly.js/pull/946#discussion_r81868586 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| 2b05978 | https://github.com/plotly/plotly.js/commit/2b05978ae25f3c43603e971d2ae56cb43d0db34a |
| Please reload this page | https://github.com/plotly/plotly.js/pull/946 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Sep 21, 2016
| https://github.com/plotly/plotly.js/pull/946#ref-pullrequest-178480282 |
|
Range slider second iteration (part 1)
#962
| https://github.com/plotly/plotly.js/pull/962 |
|
| https://github.com/etpinard |
| Merge branch 'master' into cartesian-per-subplot | https://github.com/plotly/plotly.js/pull/946/commits/b00d716454ecf6788b000dcdbef0e437386d979d |
| b00d716 | https://github.com/plotly/plotly.js/pull/946/commits/b00d716454ecf6788b000dcdbef0e437386d979d |
|
| https://github.com/etpinard |
| replace plotinfo.x() -> plotinfo.xaxis | https://github.com/plotly/plotly.js/pull/946/commits/ae3ab5554219f5ad93f77d8f83355d79f34fe79a |
| ae3ab55 | https://github.com/plotly/plotly.js/pull/946/commits/ae3ab5554219f5ad93f77d8f83355d79f34fe79a |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| force-pushed | https://github.com/plotly/plotly.js/compare/2b05978ae25f3c43603e971d2ae56cb43d0db34a..ae3ab5554219f5ad93f77d8f83355d79f34fe79a |
| 2b05978 | https://github.com/plotly/plotly.js/commit/2b05978ae25f3c43603e971d2ae56cb43d0db34a |
| ae3ab55 | https://github.com/plotly/plotly.js/commit/ae3ab5554219f5ad93f77d8f83355d79f34fe79a |
|
Compare
| https://github.com/plotly/plotly.js/compare/2b05978ae25f3c43603e971d2ae56cb43d0db34a..ae3ab5554219f5ad93f77d8f83355d79f34fe79a |
| October 4, 2016 22:34 | https://github.com/plotly/plotly.js/pull/946#event-812516000 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| v1.18.0 | https://github.com/plotly/plotly.js/milestone/11 |
| Oct 5, 2016 | https://github.com/plotly/plotly.js/pull/946#event-813459680 |
| https://github.com/rreusser |
| rreusser | https://github.com/rreusser |
|
Oct 5, 2016
| https://github.com/plotly/plotly.js/pull/946#pullrequestreview-2980238 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/946/files/ae3ab5554219f5ad93f77d8f83355d79f34fe79a |
| rreusser | https://github.com/rreusser |
| https://github.com/plotly/plotly.js/pull/946#pullrequestreview-2980238 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/946 |
| src/components/errorbars/plot.js | https://github.com/plotly/plotly.js/pull/946/files/ae3ab5554219f5ad93f77d8f83355d79f34fe79a#diff-210cc52497d141efe63963af776e6b9f6ce414989a153e46fbe073956c49889e |
| rreusser | https://github.com/rreusser |
| Oct 5, 2016 | https://github.com/plotly/plotly.js/pull/946#discussion_r82045328 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/946 |
| src/plot_api/plot_api.js | https://github.com/plotly/plotly.js/pull/946/files/ae3ab5554219f5ad93f77d8f83355d79f34fe79a#diff-4cc342865f02fea8acedf92e7c0855b4c805c9824b4b4aaf0f587dba2506c9e7 |
| rreusser | https://github.com/rreusser |
| Oct 5, 2016 | https://github.com/plotly/plotly.js/pull/946#discussion_r82046110 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/946 |
| etpinard | https://github.com/etpinard |
| Oct 6, 2016 | https://github.com/plotly/plotly.js/pull/946#discussion_r82106086 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/946 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/946 |
| src/plot_api/plot_api.js | https://github.com/plotly/plotly.js/pull/946/files/ae3ab5554219f5ad93f77d8f83355d79f34fe79a#diff-4cc342865f02fea8acedf92e7c0855b4c805c9824b4b4aaf0f587dba2506c9e7 |
| rreusser | https://github.com/rreusser |
| Oct 5, 2016 | https://github.com/plotly/plotly.js/pull/946#discussion_r82047155 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/946 |
| etpinard | https://github.com/etpinard |
| Oct 6, 2016 | https://github.com/plotly/plotly.js/pull/946#discussion_r82106126 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/946 |
| src/plots/cartesian/axes.js | https://github.com/plotly/plotly.js/pull/946/files/ae3ab5554219f5ad93f77d8f83355d79f34fe79a#diff-5f001ae7bd55867b9cfbe23508ea18384159d46c141298fa7d177cfd76194695 |
| rreusser | https://github.com/rreusser |
| Oct 5, 2016 | https://github.com/plotly/plotly.js/pull/946#discussion_r82047556 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/946 |
| src/plots/cartesian/index.js | https://github.com/plotly/plotly.js/pull/946/files/8c09af25195f7ed0ab6340190ff94507c323f587#diff-8235b6d0b87fca3c0caaed994db8375802da313c433ec62a4d27e4a3fd8c5e8d |
| rreusser | https://github.com/rreusser |
| Oct 5, 2016 | https://github.com/plotly/plotly.js/pull/946#discussion_r82048108 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/946 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/946 |
| test/jasmine/tests/plots_test.js | https://github.com/plotly/plotly.js/pull/946/files/78faa3fe4399d13c37207499c451c82e7da701af..f8017f25af7227e5aff14c3330c03e17ed2b025e#diff-0ec5ead8ef5f115baa4c93a063456fd8c59ffae75ff98feeea490d207e039d72 |
| rreusser | https://github.com/rreusser |
| Oct 5, 2016 | https://github.com/plotly/plotly.js/pull/946#discussion_r82048967 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/946 |
|
| https://github.com/etpinard |
| make makeSubplotLayer agnostic to fullLayout | https://github.com/plotly/plotly.js/pull/946/commits/a708381b4b21bb5a071b444d7d55b879d2561cb4 |
| a708381 | https://github.com/plotly/plotly.js/pull/946/commits/a708381b4b21bb5a071b444d7d55b879d2561cb4 |
| https://github.com/rreusser |
| rreusser | https://github.com/rreusser |
| Oct 6, 2016 | https://github.com/plotly/plotly.js/pull/946#issuecomment-251849998 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/946 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/946 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Oct 6, 2016
| https://github.com/plotly/plotly.js/pull/946#pullrequestreview-3036784 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/946/files/a708381b4b21bb5a071b444d7d55b879d2561cb4 |
| src/plots/cartesian/index.js | https://github.com/plotly/plotly.js/pull/946/files/a708381b4b21bb5a071b444d7d55b879d2561cb4#diff-8235b6d0b87fca3c0caaed994db8375802da313c433ec62a4d27e4a3fd8c5e8d |
| etpinard | https://github.com/etpinard |
| Oct 6, 2016 | https://github.com/plotly/plotly.js/pull/946#discussion_r82106623 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/946 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/946 |
| rreusser | https://github.com/rreusser |
| Oct 6, 2016 | https://github.com/plotly/plotly.js/pull/946#discussion_r82106811 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/946 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Oct 6, 2016
| https://github.com/plotly/plotly.js/pull/946#ref-issue-148184726 |
|
Bumping d3
#424
| https://github.com/plotly/plotly.js/issues/424 |
|
| https://github.com/etpinard |
| rm useless return in makePlotFramework | https://github.com/plotly/plotly.js/pull/946/commits/e78b0994c2a829f59f6612e70e6f9c0461eca058 |
| e78b099 | https://github.com/plotly/plotly.js/pull/946/commits/e78b0994c2a829f59f6612e70e6f9c0461eca058 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| 5a08fbc | https://github.com/plotly/plotly.js/commit/5a08fbcf5c5ca17d05316bbe2c3e053b4250abde |
| Oct 6, 2016 | https://github.com/plotly/plotly.js/pull/946#event-814178029 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| October 6, 2016 02:50 | https://github.com/plotly/plotly.js/pull/946#event-814178057 |
| https://github.com/rreusser |
| rreusser | https://github.com/rreusser |
| Oct 6, 2016 | https://github.com/plotly/plotly.js/pull/946#issuecomment-251854791 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/946 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/946 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| Oct 6, 2016 | https://github.com/plotly/plotly.js/pull/946#issuecomment-251856023 |
| https://github.com/plotly/plotly.js/blob/master/src/plot_api/plot_api.js#L2772 |
| here | https://github.com/plotly/plotly.js/blob/5a08fbcf5c5ca17d05316bbe2c3e053b4250abde/src/plot_api/plot_api.js#L2787 |
| here | https://github.com/plotly/plotly.js/blob/5a08fbcf5c5ca17d05316bbe2c3e053b4250abde/src/plot_api/plot_api.js#L162 |
| here | https://github.com/plotly/plotly.js/blob/5a08fbcf5c5ca17d05316bbe2c3e053b4250abde/src/plot_api/plot_api.js#L280 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/946 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Oct 6, 2016
| https://github.com/plotly/plotly.js/pull/946#ref-pullrequest-181498152 |
|
Range slider second iteration (part 2: on-par range plots !!!)
#1017
| https://github.com/plotly/plotly.js/pull/1017 |
|
Cartesian subplot fixes
#1049
| https://github.com/plotly/plotly.js/pull/1049 |
|
Fix dendrogram
#1063
| https://github.com/plotly/plotly.js/pull/1063 |
| etpinard | https://github.com/etpinard |
|
Jan 10, 2017
| https://github.com/plotly/plotly.js/pull/946#ref-commit-92119bb |
|
| https://github.com/etpinard |
| rm (now useless) logic for ternary make plot framework | https://github.com/plotly/plotly.js/commit/92119bb6593c87b6bf4e8a1f0ab3468b233cd4cb |
| 92119bb | https://github.com/plotly/plotly.js/commit/92119bb6593c87b6bf4e8a1f0ab3468b233cd4cb |
| #946 | https://github.com/plotly/plotly.js/pull/946 |
| etpinard | https://github.com/etpinard |
|
Jul 6, 2017
| https://github.com/plotly/plotly.js/pull/946#ref-commit-3bf58db |
|
| https://github.com/etpinard |
| fix overlaying axis layers | https://github.com/plotly/plotly.js/commit/3bf58dbc72771f32be3c7ad6827dc7d1172dc950 |
| 3bf58db | https://github.com/plotly/plotly.js/commit/3bf58dbc72771f32be3c7ad6827dc7d1172dc950 |
| #946 | https://github.com/plotly/plotly.js/pull/946 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Jul 6, 2017
| https://github.com/plotly/plotly.js/pull/946#ref-pullrequest-240988713 |
|
Fix overlaying axis layers
#1855
| https://github.com/plotly/plotly.js/pull/1855 |
| https://github.co/hiddenchars |
| https://github.com/plotly/plotly.js/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F946 |
|
| https://github.com/rreusser |
|
rreusser
| https://github.com/rreusser |
|
| https://github.com/plotly/plotly.js/pull/946/files/a708381b4b21bb5a071b444d7d55b879d2561cb4 |
|
v1.18.0
| https://github.com/plotly/plotly.js/milestone/11 |
|
Make sure that fullLayout._plots is updated on relayout
| https://github.com/plotly/plotly.js/issues/634 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/946 |
|
| https://github.com/etpinard |
|
| https://github.com/rreusser |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |