| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:3e0f544e-2bb3-cdbc-19e1-c3d0fdf931cf |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CB84:10FE26:2556A63:3254A5C:6A59AAF0 |
| html-safe-nonce | 0af6ef07b177061f9c2e9d8595587256cc237542342d5b903785e368ddf21781 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQjg0OjEwRkUyNjoyNTU2QTYzOjMyNTRBNUM6NkE1OUFBRjAiLCJ2aXNpdG9yX2lkIjoiNjYxNDAwMDg0MzA1MzcwNTk2OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 4d1bc15e490ee584e74f16840d667a8cd9c238027b72311a0942ef1612ecdfdb |
| hovercard-subject-tag | pull_request:641770116 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/plotly/plotly.js/5653/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/161e14f2848f4fd084ba75fb51089a8395bf39d35873ee9eccce7c24cdcb13f8/plotly/plotly.js/pull/5653 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/161e14f2848f4fd084ba75fb51089a8395bf39d35873ee9eccce7c24cdcb13f8/plotly/plotly.js/pull/5653 |
| og:image:alt | Followup of #4762.
Addressing #4733.
Thanks to #5411, now we could node.js for our mock validation 🎉
It is now feasible to run validation tests both locally namely when contributors add new mocks/f... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | archmoj |
| hostname | github.com |
| expected-hostname | github.com |
| None | ba3976babb66479b1c943a8edc0777d96157da48fadc0161f9ddb219deee8353 |
| turbo-cache-control | no-cache |
| go-import | github.com/plotly/plotly.js git https://github.com/plotly/plotly.js.git |
| octolytics-dimension-user_id | 5997976 |
| octolytics-dimension-user_login | plotly |
| octolytics-dimension-repository_id | 45646037 |
| octolytics-dimension-repository_nwo | plotly/plotly.js |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 45646037 |
| octolytics-dimension-repository_network_root_nwo | plotly/plotly.js |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | ab680789ae4a316cdaf0d5a292a1760140931cc4 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/plotly/plotly.js/pull/5653#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F5653 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F5653 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=plotly%2Fplotly.js |
| Reload | https://github.com/plotly/plotly.js/pull/5653 |
| Reload | https://github.com/plotly/plotly.js/pull/5653 |
| Reload | https://github.com/plotly/plotly.js/pull/5653 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5653 |
|
plotly
| https://github.com/plotly |
| plotly.js | https://github.com/plotly/plotly.js |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5653 |
|
Notifications
| https://github.com/login?return_to=%2Fplotly%2Fplotly.js |
|
Fork
2k
| https://github.com/login?return_to=%2Fplotly%2Fplotly.js |
|
Star
18.3k
| https://github.com/login?return_to=%2Fplotly%2Fplotly.js |
|
Code
| https://github.com/plotly/plotly.js |
|
Issues
773
| https://github.com/plotly/plotly.js/issues |
|
Pull requests
57
| https://github.com/plotly/plotly.js/pulls |
|
Actions
| https://github.com/plotly/plotly.js/actions |
|
Security and quality
0
| https://github.com/plotly/plotly.js/security |
|
Insights
| https://github.com/plotly/plotly.js/pulse |
|
Code
| https://github.com/plotly/plotly.js |
|
Issues
| https://github.com/plotly/plotly.js/issues |
|
Pull requests
| https://github.com/plotly/plotly.js/pulls |
|
Actions
| https://github.com/plotly/plotly.js/actions |
|
Security and quality
| https://github.com/plotly/plotly.js/security |
|
Insights
| https://github.com/plotly/plotly.js/pulse |
| archmoj | https://github.com/archmoj |
| master | https://github.com/plotly/plotly.js/tree/master |
| improve-mock-validation | https://github.com/plotly/plotly.js/tree/improve-mock-validation |
| Conversation | https://github.com/plotly/plotly.js/pull/5653 |
| Commits7 (7) | https://github.com/plotly/plotly.js/pull/5653/commits |
| Checks | https://github.com/plotly/plotly.js/pull/5653/checks |
| Files changed | https://github.com/plotly/plotly.js/pull/5653/files |
| Mock validation utility | https://github.com/plotly/plotly.js/pull/5653#top |
| archmoj | https://github.com/archmoj |
| master | https://github.com/plotly/plotly.js/tree/master |
| improve-mock-validation | https://github.com/plotly/plotly.js/tree/improve-mock-validation |
|
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
| May 11, 2021 | https://github.com/plotly/plotly.js/pull/5653#issue-888592552 |
| #4762 | https://github.com/plotly/plotly.js/pull/4762 |
| #4733 | https://github.com/plotly/plotly.js/issues/4733 |
| #5411 | https://github.com/plotly/plotly.js/pull/5411 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5653 |
| archmoj | https://github.com/archmoj |
| May 11, 2021 14:56 | https://github.com/plotly/plotly.js/pull/5653#commits-pushed-3491867 |
|
| https://github.com/archmoj |
| move mock test from jasmine to tasks | https://github.com/plotly/plotly.js/pull/5653/commits/34918677ff8ccc461d47603cf699dd5f4a447fe6 |
| 3491867 | https://github.com/plotly/plotly.js/pull/5653/commits/34918677ff8ccc461d47603cf699dd5f4a447fe6 |
|
| https://github.com/archmoj |
| mock validation using node.js | https://github.com/plotly/plotly.js/pull/5653/commits/c5c1c26a2ccd661aa84bcb37f6875f911b285902 |
| c5c1c26 | https://github.com/plotly/plotly.js/pull/5653/commits/c5c1c26a2ccd661aa84bcb37f6875f911b285902 |
|
| https://github.com/archmoj |
| add npm run command for mock validation test | https://github.com/plotly/plotly.js/pull/5653/commits/c3197d327aa45f7d9f15680b113ec07a8b331c9f |
| c3197d3 | https://github.com/plotly/plotly.js/pull/5653/commits/c3197d327aa45f7d9f15680b113ec07a8b331c9f |
|
| https://github.com/archmoj |
| point plain_obj and mock tests to use build instead of dist | https://github.com/plotly/plotly.js/pull/5653/commits/142e66148c024ad946e95474d0c6caf620e1cd89 |
| 142e661 | https://github.com/plotly/plotly.js/pull/5653/commits/142e66148c024ad946e95474d0c6caf620e1cd89 |
|
| https://github.com/archmoj |
| config circleci to validate mocks | https://github.com/plotly/plotly.js/pull/5653/commits/569910d12634b636e107c7ccb1c8b5b41a99ff66 |
| 569910d | https://github.com/plotly/plotly.js/pull/5653/commits/569910d12634b636e107c7ccb1c8b5b41a99ff66 |
|
| https://github.com/archmoj |
| improve contributing readme on how to validate mocks | https://github.com/plotly/plotly.js/pull/5653/commits/a0ec7fe56bfc6de0111a960e571a9ba882c45ad4 |
| a0ec7fe | https://github.com/plotly/plotly.js/pull/5653/commits/a0ec7fe56bfc6de0111a960e571a9ba882c45ad4 |
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
|
type: maintenance
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22type%3A%20maintenance%22 |
| May 11, 2021 | https://github.com/plotly/plotly.js/pull/5653#event-4731386612 |
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
| NEXT | https://github.com/plotly/plotly.js/milestone/60 |
| May 11, 2021 | https://github.com/plotly/plotly.js/pull/5653#event-4731386632 |
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
| alexcjohnson | https://github.com/alexcjohnson |
| May 11, 2021 20:46 | https://github.com/plotly/plotly.js/pull/5653#event-4731386660 |
| https://github.com/alexcjohnson |
| alexcjohnson | https://github.com/alexcjohnson |
| May 11, 2021 | https://github.com/plotly/plotly.js/pull/5653#issuecomment-839207136 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5653 |
|
| https://github.com/archmoj |
| add option to test desired mocks only | https://github.com/plotly/plotly.js/pull/5653/commits/2e8ce24430a7fa8d7ecb0251ddb0fe263e77e326 |
| 2e8ce24 | https://github.com/plotly/plotly.js/pull/5653/commits/2e8ce24430a7fa8d7ecb0251ddb0fe263e77e326 |
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
| May 12, 2021 | https://github.com/plotly/plotly.js/pull/5653#issuecomment-839814774 |
| 2e8ce24 | https://github.com/plotly/plotly.js/commit/2e8ce24430a7fa8d7ecb0251ddb0fe263e77e326 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5653 |
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
| May 12, 2021 | https://github.com/plotly/plotly.js/pull/5653#issuecomment-839834253 |
| https://app.circleci.com/pipelines/github/plotly/plotly.js/3826/workflows/b8864a65-0b2a-4382-8f02-0743146be98e/jobs/112705/parallel-runs/0/steps/0-103 | https://app.circleci.com/pipelines/github/plotly/plotly.js/3826/workflows/b8864a65-0b2a-4382-8f02-0743146be98e/jobs/112705/parallel-runs/0/steps/0-103 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5653 |
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
| May 12, 2021 | https://github.com/plotly/plotly.js/pull/5653#event-4736810705 |
| https://github.com/alexcjohnson |
| alexcjohnson | https://github.com/alexcjohnson |
|
May 12, 2021
| https://github.com/plotly/plotly.js/pull/5653#pullrequestreview-657988196 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/5653/files/2e8ce24430a7fa8d7ecb0251ddb0fe263e77e326 |
| alexcjohnson | https://github.com/alexcjohnson |
| https://github.com/plotly/plotly.js/pull/5653#pullrequestreview-657988196 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5653 |
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
| 84bf2bc | https://github.com/plotly/plotly.js/commit/84bf2bc20dedf0d748ac78d76aea8673dfd98813 |
| May 12, 2021 | https://github.com/plotly/plotly.js/pull/5653#event-4736855413 |
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
| May 12, 2021 14:56 | https://github.com/plotly/plotly.js/pull/5653#event-4736856575 |
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
|
May 12, 2021
| https://github.com/plotly/plotly.js/pull/5653#ref-pullrequest-829446224 |
|
Icicle Trace
#5546
| https://github.com/plotly/plotly.js/pull/5546 |
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
|
May 20, 2021
| https://github.com/plotly/plotly.js/pull/5653#ref-pullrequest-896143930 |
|
Validate few more mocks
#5671
| https://github.com/plotly/plotly.js/pull/5671 |
| https://github.co/hiddenchars |
| https://github.com/plotly/plotly.js/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F5653 |
|
| https://github.com/alexcjohnson |
|
alexcjohnson
| https://github.com/alexcjohnson |
|
| https://github.com/plotly/plotly.js/pull/5653/files/2e8ce24430a7fa8d7ecb0251ddb0fe263e77e326 |
|
v2.0.0
| https://github.com/plotly/plotly.js/milestone/60 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5653 |
|
| https://github.com/archmoj |
|
| https://github.com/alexcjohnson |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |