René's URL Explorer Experiment


Title: Bring back roles with value object by archmoj · Pull Request #5432 · plotly/plotly.js · GitHub

Open Graph Title: Bring back roles with value object by archmoj · Pull Request #5432 · plotly/plotly.js

X Title: Bring back roles with value object by archmoj · Pull Request #5432 · plotly/plotly.js

Description: Open-source JavaScript charting library behind Plotly and Dash - Bring back roles with value object by archmoj · Pull Request #5432 · plotly/plotly.js

Open Graph Description: In #5425 we drop all role keys. In this PR we revert parts of the changes so that role: 'object' remains in the v2 API. cc: #5395 @plotly/plotly_js

X Description: In #5425 we drop all role keys. In this PR we revert parts of the changes so that role: 'object' remains in the v2 API. cc: #5395 @plotly/plotly_js

Opengraph URL: https://github.com/plotly/plotly.js/pull/5432

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:576f5c67-d4ad-43f1-5b13-984d6e6d0ead
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB3E4:14ECB:B19F21:E33AE9:6B00F797
html-safe-nonce4cbd942bfe9e30c74efa166e06120903a7344e869a8b5d4ade9437d568664d17
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCM0U0OjE0RUNCOkIxOUYyMTpFMzNBRTk6NkIwMEY3OTciLCJ2aXNpdG9yX2lkIjoiODAzMDQ3NDE2Mzg2Mjk2MDAyMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb74f395c75fbefa9de1e714248381a31a3176cf8733a6f011f86b1728931cdc6
hovercard-subject-tagpull_request:559691715
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/plotly/plotly.js/5432/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/84ad557dc55a903c3cc8dc76280e74423b43ff78bbed12de85c5d22d92b82043/plotly/plotly.js/pull/5432
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/84ad557dc55a903c3cc8dc76280e74423b43ff78bbed12de85c5d22d92b82043/plotly/plotly.js/pull/5432
og:image:altIn #5425 we drop all role keys. In this PR we revert parts of the changes so that role: 'object' remains in the v2 API. cc: #5395 @plotly/plotly_js
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamearchmoj
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-cache
go-importgithub.com/plotly/plotly.js git https://github.com/plotly/plotly.js.git
octolytics-dimension-user_id5997976
octolytics-dimension-user_loginplotly
octolytics-dimension-repository_id45646037
octolytics-dimension-repository_nwoplotly/plotly.js
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id45646037
octolytics-dimension-repository_network_root_nwoplotly/plotly.js
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/plotly/plotly.js/pull/5432#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F5432
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F5432
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=plotly%2Fplotly.js
Reloadhttps://github.com/plotly/plotly.js/pull/5432
Reloadhttps://github.com/plotly/plotly.js/pull/5432
Reloadhttps://github.com/plotly/plotly.js/pull/5432
plotlyhttps://github.com/plotly
plotly.jshttps://github.com/plotly/plotly.js
Codehttps://github.com/plotly/plotly.js
Issues726 (726)https://github.com/plotly/plotly.js/issues
Pull requests84 (84)https://github.com/plotly/plotly.js/pulls
Actionshttps://github.com/plotly/plotly.js/actions
Security and qualityhttps://github.com/plotly/plotly.js/security
Insightshttps://github.com/plotly/plotly.js/insights
https://github.com/plotly/plotly.js
archmojhttps://github.com/archmoj
masterhttps://github.com/plotly/plotly.js/tree/master
bring-back-object-rolehttps://github.com/plotly/plotly.js/tree/bring-back-object-role
Conversationhttps://github.com/plotly/plotly.js/pull/5432
Commits7 (7)https://github.com/plotly/plotly.js/pull/5432/commits
Checkshttps://github.com/plotly/plotly.js/pull/5432/checks
Files changedhttps://github.com/plotly/plotly.js/pull/5432/files
Bring back roles with value objecthttps://github.com/plotly/plotly.js/pull/5432#top
archmojhttps://github.com/archmoj
masterhttps://github.com/plotly/plotly.js/tree/master
bring-back-object-rolehttps://github.com/plotly/plotly.js/tree/bring-back-object-role
https://github.com/archmoj
archmojhttps://github.com/archmoj
Jan 22, 2021https://github.com/plotly/plotly.js/pull/5432#issue-791672494
#5425https://github.com/plotly/plotly.js/pull/5425
#5395https://github.com/plotly/plotly.js/issues/5395
Please reload this pagehttps://github.com/plotly/plotly.js/pull/5432
archmojhttps://github.com/archmoj
January 21, 2021 21:37https://github.com/plotly/plotly.js/pull/5432#commits-pushed-d3d8db7
https://github.com/archmoj
Revert "adapt tests"https://github.com/plotly/plotly.js/pull/5432/commits/d3d8db767efa27433f1c0de7ade29e6b30aca0ea
d3d8db7https://github.com/plotly/plotly.js/pull/5432/commits/d3d8db767efa27433f1c0de7ade29e6b30aca0ea
bd47920https://github.com/plotly/plotly.js/commit/bd47920f31ac1a5b26b7a9eeac0fe3a58141959a
https://github.com/archmoj
Revert "more role removal"https://github.com/plotly/plotly.js/pull/5432/commits/295c8ed7a1cefb87b61c7954d7d66a083fe9b5f9
295c8edhttps://github.com/plotly/plotly.js/pull/5432/commits/295c8ed7a1cefb87b61c7954d7d66a083fe9b5f9
65da615https://github.com/plotly/plotly.js/commit/65da615ef39fc84389015d2a088df692a54a8c2a
https://github.com/archmoj
revert data and layout role to be objecthttps://github.com/plotly/plotly.js/pull/5432/commits/655508a7309da2bd89265c1ab469bae7034a56a4
655508ahttps://github.com/plotly/plotly.js/pull/5432/commits/655508a7309da2bd89265c1ab469bae7034a56a4
https://github.com/archmoj
adjustments to bring object role onlyhttps://github.com/plotly/plotly.js/pull/5432/commits/4efc5aec1f166ebf5afb09ba9a45d5281a3cef37
4efc5aehttps://github.com/plotly/plotly.js/pull/5432/commits/4efc5aec1f166ebf5afb09ba9a45d5281a3cef37
https://github.com/archmoj
archmojhttps://github.com/archmoj
status: reviewable https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22status%3A%20reviewable%22
Jan 22, 2021https://github.com/plotly/plotly.js/pull/5432#event-4236677566
https://github.com/archmoj
archmojhttps://github.com/archmoj
NEXThttps://github.com/plotly/plotly.js/milestone/60
Jan 22, 2021https://github.com/plotly/plotly.js/pull/5432#event-4236677573
https://github.com/archmoj
archmojhttps://github.com/archmoj
Jan 22, 2021 https://github.com/plotly/plotly.js/pull/5432#pullrequestreview-574246567
View reviewed changes https://github.com/plotly/plotly.js/pull/5432/files/655508a7309da2bd89265c1ab469bae7034a56a4
src/plots/frame_attributes.jshttps://github.com/plotly/plotly.js/pull/5432/files/295c8ed7a1cefb87b61c7954d7d66a083fe9b5f9..655508a7309da2bd89265c1ab469bae7034a56a4#diff-0b2b5a2037dd98a2d0545d229558288ebdbd3151b7774cea03bd30f125f1fde3
Please reload this pagehttps://github.com/plotly/plotly.js/pull/5432
https://github.com/archmoj
archmojhttps://github.com/archmoj
Jan 22, 2021 https://github.com/plotly/plotly.js/pull/5432#pullrequestreview-574246889
View reviewed changes https://github.com/plotly/plotly.js/pull/5432/files/655508a7309da2bd89265c1ab469bae7034a56a4
src/plots/frame_attributes.jshttps://github.com/plotly/plotly.js/pull/5432/files/295c8ed7a1cefb87b61c7954d7d66a083fe9b5f9..655508a7309da2bd89265c1ab469bae7034a56a4#diff-0b2b5a2037dd98a2d0545d229558288ebdbd3151b7774cea03bd30f125f1fde3
Please reload this pagehttps://github.com/plotly/plotly.js/pull/5432
archmojhttps://github.com/archmoj
January 22, 2021 09:54https://github.com/plotly/plotly.js/pull/5432#commits-pushed-9c7bf87
https://github.com/archmoj
add tests to ensure deprecated roles are undefinedhttps://github.com/plotly/plotly.js/pull/5432/commits/9c7bf87f646b52e4a9196f0f2aaddbe7219cf50b
9c7bf87https://github.com/plotly/plotly.js/pull/5432/commits/9c7bf87f646b52e4a9196f0f2aaddbe7219cf50b
https://github.com/archmoj
use former instead of deprecated for retired v1 roleshttps://github.com/plotly/plotly.js/pull/5432/commits/fb07d6670c944f4790f4f8994905cac460f0708b
fb07d66https://github.com/plotly/plotly.js/pull/5432/commits/fb07d6670c944f4790f4f8994905cac460f0708b
https://github.com/archmoj
archmojhttps://github.com/archmoj
alexcjohnsonhttps://github.com/alexcjohnson
January 22, 2021 16:15https://github.com/plotly/plotly.js/pull/5432#event-4239319733
https://github.com/archmoj
Revert "revert data and layout role to be object"https://github.com/plotly/plotly.js/pull/5432/commits/a363aecf61ea49d67c3e3f74baa949e7e3e9f458
a363aechttps://github.com/plotly/plotly.js/pull/5432/commits/a363aecf61ea49d67c3e3f74baa949e7e3e9f458
655508ahttps://github.com/plotly/plotly.js/commit/655508a7309da2bd89265c1ab469bae7034a56a4
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
Jan 22, 2021 https://github.com/plotly/plotly.js/pull/5432#pullrequestreview-574466967
View reviewed changes https://github.com/plotly/plotly.js/pull/5432/files/a363aecf61ea49d67c3e3f74baa949e7e3e9f458
alexcjohnsonhttps://github.com/alexcjohnson
https://github.com/plotly/plotly.js/pull/5432#pullrequestreview-574466967
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/5432
https://github.com/archmoj
archmojhttps://github.com/archmoj
f8f08cfhttps://github.com/plotly/plotly.js/commit/f8f08cf2f0547b813defb09094befa1e57f953c6
Jan 22, 2021https://github.com/plotly/plotly.js/pull/5432#event-4239667396
https://github.com/archmoj
archmojhttps://github.com/archmoj
January 22, 2021 17:37https://github.com/plotly/plotly.js/pull/5432#event-4239667704
https://github.co/hiddenchars
https://github.com/plotly/plotly.js/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F5432
https://github.com/alexcjohnson
alexcjohnson https://github.com/alexcjohnson
https://github.com/plotly/plotly.js/pull/5432/files/a363aecf61ea49d67c3e3f74baa949e7e3e9f458
Please reload this pagehttps://github.com/plotly/plotly.js/pull/5432
v2.0.0 https://github.com/plotly/plotly.js/milestone/60
Please reload this pagehttps://github.com/plotly/plotly.js/pull/5432
https://github.com/archmoj
https://github.com/alexcjohnson
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.