| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:576f5c67-d4ad-43f1-5b13-984d6e6d0ead |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B3E4:14ECB:B19F21:E33AE9:6B00F797 |
| html-safe-nonce | 4cbd942bfe9e30c74efa166e06120903a7344e869a8b5d4ade9437d568664d17 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCM0U0OjE0RUNCOkIxOUYyMTpFMzNBRTk6NkIwMEY3OTciLCJ2aXNpdG9yX2lkIjoiODAzMDQ3NDE2Mzg2Mjk2MDAyMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | b74f395c75fbefa9de1e714248381a31a3176cf8733a6f011f86b1728931cdc6 |
| hovercard-subject-tag | pull_request:559691715 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/plotly/plotly.js/5432/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/84ad557dc55a903c3cc8dc76280e74423b43ff78bbed12de85c5d22d92b82043/plotly/plotly.js/pull/5432 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/84ad557dc55a903c3cc8dc76280e74423b43ff78bbed12de85c5d22d92b82043/plotly/plotly.js/pull/5432 |
| og:image:alt | In #5425 we drop all role keys.
In this PR we revert parts of the changes so that role: 'object' remains in the v2 API.
cc: #5395
@plotly/plotly_js |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | archmoj |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc |
| turbo-cache-control | no-cache |
| go-import | github.com/plotly/plotly.js git https://github.com/plotly/plotly.js.git |
| octolytics-dimension-user_id | 5997976 |
| octolytics-dimension-user_login | plotly |
| octolytics-dimension-repository_id | 45646037 |
| octolytics-dimension-repository_nwo | plotly/plotly.js |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 45646037 |
| octolytics-dimension-repository_network_root_nwo | plotly/plotly.js |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9983dd5da06943f833c971dd5b6bc988e2858be5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/plotly/plotly.js/pull/5432#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F5432 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F5432 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=plotly%2Fplotly.js |
| Reload | https://github.com/plotly/plotly.js/pull/5432 |
| Reload | https://github.com/plotly/plotly.js/pull/5432 |
| Reload | https://github.com/plotly/plotly.js/pull/5432 |
| plotly | https://github.com/plotly |
| plotly.js | https://github.com/plotly/plotly.js |
| Code | https://github.com/plotly/plotly.js |
| Issues726 (726) | https://github.com/plotly/plotly.js/issues |
| Pull requests84 (84) | https://github.com/plotly/plotly.js/pulls |
| Actions | https://github.com/plotly/plotly.js/actions |
| Security and quality | https://github.com/plotly/plotly.js/security |
| Insights | https://github.com/plotly/plotly.js/insights |
| https://github.com/plotly/plotly.js |
| archmoj | https://github.com/archmoj |
| master | https://github.com/plotly/plotly.js/tree/master |
| bring-back-object-role | https://github.com/plotly/plotly.js/tree/bring-back-object-role |
| Conversation | https://github.com/plotly/plotly.js/pull/5432 |
| Commits7 (7) | https://github.com/plotly/plotly.js/pull/5432/commits |
| Checks | https://github.com/plotly/plotly.js/pull/5432/checks |
| Files changed | https://github.com/plotly/plotly.js/pull/5432/files |
| Bring back roles with value object | https://github.com/plotly/plotly.js/pull/5432#top |
| archmoj | https://github.com/archmoj |
| master | https://github.com/plotly/plotly.js/tree/master |
| bring-back-object-role | https://github.com/plotly/plotly.js/tree/bring-back-object-role |
|
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
| Jan 22, 2021 | https://github.com/plotly/plotly.js/pull/5432#issue-791672494 |
| #5425 | https://github.com/plotly/plotly.js/pull/5425 |
| #5395 | https://github.com/plotly/plotly.js/issues/5395 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5432 |
| archmoj | https://github.com/archmoj |
| January 21, 2021 21:37 | https://github.com/plotly/plotly.js/pull/5432#commits-pushed-d3d8db7 |
|
| https://github.com/archmoj |
| Revert "adapt tests" | https://github.com/plotly/plotly.js/pull/5432/commits/d3d8db767efa27433f1c0de7ade29e6b30aca0ea |
| d3d8db7 | https://github.com/plotly/plotly.js/pull/5432/commits/d3d8db767efa27433f1c0de7ade29e6b30aca0ea |
| bd47920 | https://github.com/plotly/plotly.js/commit/bd47920f31ac1a5b26b7a9eeac0fe3a58141959a |
|
| https://github.com/archmoj |
| Revert "more role removal" | https://github.com/plotly/plotly.js/pull/5432/commits/295c8ed7a1cefb87b61c7954d7d66a083fe9b5f9 |
| 295c8ed | https://github.com/plotly/plotly.js/pull/5432/commits/295c8ed7a1cefb87b61c7954d7d66a083fe9b5f9 |
| 65da615 | https://github.com/plotly/plotly.js/commit/65da615ef39fc84389015d2a088df692a54a8c2a |
|
| https://github.com/archmoj |
| revert data and layout role to be object | https://github.com/plotly/plotly.js/pull/5432/commits/655508a7309da2bd89265c1ab469bae7034a56a4 |
| 655508a | https://github.com/plotly/plotly.js/pull/5432/commits/655508a7309da2bd89265c1ab469bae7034a56a4 |
|
| https://github.com/archmoj |
| adjustments to bring object role only | https://github.com/plotly/plotly.js/pull/5432/commits/4efc5aec1f166ebf5afb09ba9a45d5281a3cef37 |
| 4efc5ae | https://github.com/plotly/plotly.js/pull/5432/commits/4efc5aec1f166ebf5afb09ba9a45d5281a3cef37 |
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
|
status: reviewable
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22status%3A%20reviewable%22 |
| Jan 22, 2021 | https://github.com/plotly/plotly.js/pull/5432#event-4236677566 |
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
| NEXT | https://github.com/plotly/plotly.js/milestone/60 |
| Jan 22, 2021 | https://github.com/plotly/plotly.js/pull/5432#event-4236677573 |
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
|
Jan 22, 2021
| https://github.com/plotly/plotly.js/pull/5432#pullrequestreview-574246567 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/5432/files/655508a7309da2bd89265c1ab469bae7034a56a4 |
| src/plots/frame_attributes.js | https://github.com/plotly/plotly.js/pull/5432/files/295c8ed7a1cefb87b61c7954d7d66a083fe9b5f9..655508a7309da2bd89265c1ab469bae7034a56a4#diff-0b2b5a2037dd98a2d0545d229558288ebdbd3151b7774cea03bd30f125f1fde3 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5432 |
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
|
Jan 22, 2021
| https://github.com/plotly/plotly.js/pull/5432#pullrequestreview-574246889 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/5432/files/655508a7309da2bd89265c1ab469bae7034a56a4 |
| src/plots/frame_attributes.js | https://github.com/plotly/plotly.js/pull/5432/files/295c8ed7a1cefb87b61c7954d7d66a083fe9b5f9..655508a7309da2bd89265c1ab469bae7034a56a4#diff-0b2b5a2037dd98a2d0545d229558288ebdbd3151b7774cea03bd30f125f1fde3 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5432 |
| archmoj | https://github.com/archmoj |
| January 22, 2021 09:54 | https://github.com/plotly/plotly.js/pull/5432#commits-pushed-9c7bf87 |
|
| https://github.com/archmoj |
| add tests to ensure deprecated roles are undefined | https://github.com/plotly/plotly.js/pull/5432/commits/9c7bf87f646b52e4a9196f0f2aaddbe7219cf50b |
| 9c7bf87 | https://github.com/plotly/plotly.js/pull/5432/commits/9c7bf87f646b52e4a9196f0f2aaddbe7219cf50b |
|
| https://github.com/archmoj |
| use former instead of deprecated for retired v1 roles | https://github.com/plotly/plotly.js/pull/5432/commits/fb07d6670c944f4790f4f8994905cac460f0708b |
| fb07d66 | https://github.com/plotly/plotly.js/pull/5432/commits/fb07d6670c944f4790f4f8994905cac460f0708b |
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
| alexcjohnson | https://github.com/alexcjohnson |
| January 22, 2021 16:15 | https://github.com/plotly/plotly.js/pull/5432#event-4239319733 |
|
| https://github.com/archmoj |
| Revert "revert data and layout role to be object" | https://github.com/plotly/plotly.js/pull/5432/commits/a363aecf61ea49d67c3e3f74baa949e7e3e9f458 |
| a363aec | https://github.com/plotly/plotly.js/pull/5432/commits/a363aecf61ea49d67c3e3f74baa949e7e3e9f458 |
| 655508a | https://github.com/plotly/plotly.js/commit/655508a7309da2bd89265c1ab469bae7034a56a4 |
| https://github.com/alexcjohnson |
| alexcjohnson | https://github.com/alexcjohnson |
|
Jan 22, 2021
| https://github.com/plotly/plotly.js/pull/5432#pullrequestreview-574466967 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/5432/files/a363aecf61ea49d67c3e3f74baa949e7e3e9f458 |
| alexcjohnson | https://github.com/alexcjohnson |
| https://github.com/plotly/plotly.js/pull/5432#pullrequestreview-574466967 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5432 |
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
| f8f08cf | https://github.com/plotly/plotly.js/commit/f8f08cf2f0547b813defb09094befa1e57f953c6 |
| Jan 22, 2021 | https://github.com/plotly/plotly.js/pull/5432#event-4239667396 |
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
| January 22, 2021 17:37 | https://github.com/plotly/plotly.js/pull/5432#event-4239667704 |
| https://github.co/hiddenchars |
| https://github.com/plotly/plotly.js/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F5432 |
|
| https://github.com/alexcjohnson |
|
alexcjohnson
| https://github.com/alexcjohnson |
|
| https://github.com/plotly/plotly.js/pull/5432/files/a363aecf61ea49d67c3e3f74baa949e7e3e9f458 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5432 |
|
v2.0.0
| https://github.com/plotly/plotly.js/milestone/60 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5432 |
|
| https://github.com/archmoj |
|
| https://github.com/alexcjohnson |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |