| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:3af705c9-48c1-eb51-7396-924425b2ece0 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CC14:3897F3:BC26C1:F44067:6B00EE3E |
| html-safe-nonce | fe83cbc8bafeb6fd2191068fa1a13ce7f772abaf8d630edcd173afb19af99834 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQzE0OjM4OTdGMzpCQzI2QzE6RjQ0MDY3OjZCMDBFRTNFIiwidmlzaXRvcl9pZCI6IjQzMDg0MTE0OTAzMjQ1MDgyMjIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 03cabee5fdc61d6dfac40407dd0b1e3bf362b264658758773d6b9ffd21e39030 |
| hovercard-subject-tag | pull_request:544382021 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/plotly/plotly.js/5359/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/ba517fe45bd73f13a57a6fb4a25db8cd6ead810488b92bdba4b4c04637075621/plotly/plotly.js/pull/5359 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ba517fe45bd73f13a57a6fb4a25db8cd6ead810488b92bdba4b4c04637075621/plotly/plotly.js/pull/5359 |
| og:image:alt | As mentioned in #897 (comment) d3@3.5.17 (as well as d3-dsv use function constructors in the source.
This PR suggests refactoring d3 to avoid using function constructors.
Demo
@plotly/plotly_js |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | archmoj |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc |
| turbo-cache-control | no-cache |
| go-import | github.com/plotly/plotly.js git https://github.com/plotly/plotly.js.git |
| octolytics-dimension-user_id | 5997976 |
| octolytics-dimension-user_login | plotly |
| octolytics-dimension-repository_id | 45646037 |
| octolytics-dimension-repository_nwo | plotly/plotly.js |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 45646037 |
| octolytics-dimension-repository_network_root_nwo | plotly/plotly.js |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9983dd5da06943f833c971dd5b6bc988e2858be5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/plotly/plotly.js/pull/5359#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F5359 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F5359 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=plotly%2Fplotly.js |
| Reload | https://github.com/plotly/plotly.js/pull/5359 |
| Reload | https://github.com/plotly/plotly.js/pull/5359 |
| Reload | https://github.com/plotly/plotly.js/pull/5359 |
| plotly | https://github.com/plotly |
| plotly.js | https://github.com/plotly/plotly.js |
| Code | https://github.com/plotly/plotly.js |
| Issues726 (726) | https://github.com/plotly/plotly.js/issues |
| Pull requests84 (84) | https://github.com/plotly/plotly.js/pulls |
| Actions | https://github.com/plotly/plotly.js/actions |
| Security and quality | https://github.com/plotly/plotly.js/security |
| Insights | https://github.com/plotly/plotly.js/insights |
| https://github.com/plotly/plotly.js |
| archmoj | https://github.com/archmoj |
| master | https://github.com/plotly/plotly.js/tree/master |
| d3-v3-no-eval-func | https://github.com/plotly/plotly.js/tree/d3-v3-no-eval-func |
| Conversation | https://github.com/plotly/plotly.js/pull/5359 |
| Commits1 (1) | https://github.com/plotly/plotly.js/pull/5359/commits |
| Checks | https://github.com/plotly/plotly.js/pull/5359/checks |
| Files changed | https://github.com/plotly/plotly.js/pull/5359/files |
| Avoid function constructor in d3 | https://github.com/plotly/plotly.js/pull/5359#top |
| archmoj | https://github.com/archmoj |
| master | https://github.com/plotly/plotly.js/tree/master |
| d3-v3-no-eval-func | https://github.com/plotly/plotly.js/tree/d3-v3-no-eval-func |
|
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
| Dec 22, 2020 | https://github.com/plotly/plotly.js/pull/5359#issue-773262937 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5359 |
| #897 (comment) | https://github.com/plotly/plotly.js/issues/897#issuecomment-744512711 |
| d3-dsv | https://www.npmjs.com/package/d3-dsv |
| Demo | https://codepen.io/MojtabaSamimi/pen/mdrBOjr |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5359 |
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
|
type: maintenance
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22type%3A%20maintenance%22 |
| Dec 22, 2020 | https://github.com/plotly/plotly.js/pull/5359#event-4141818992 |
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
|
Dec 22, 2020
| https://github.com/plotly/plotly.js/pull/5359#pullrequestreview-557376201 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/5359/files |
| package.json | https://github.com/plotly/plotly.js/pull/5359/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5359 |
| https://github.com/alexcjohnson |
| alexcjohnson | https://github.com/alexcjohnson |
|
Dec 27, 2020
| https://github.com/plotly/plotly.js/pull/5359#pullrequestreview-558899891 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/5359/files |
| alexcjohnson | https://github.com/alexcjohnson |
| https://github.com/plotly/plotly.js/pull/5359#pullrequestreview-558899891 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5359 |
|
| https://github.com/archmoj |
| install and require @plotly/d3 fork | https://github.com/plotly/plotly.js/pull/5359/commits/d2f726981671a5540841c93697751f778d63ff86 |
| d2f7269 | https://github.com/plotly/plotly.js/pull/5359/commits/d2f726981671a5540841c93697751f778d63ff86 |
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
| force-pushed | https://github.com/plotly/plotly.js/compare/9f348eb6a639d0c3195b8d5f8c5ebe8057635df5..d2f726981671a5540841c93697751f778d63ff86 |
| 9f348eb | https://github.com/plotly/plotly.js/commit/9f348eb6a639d0c3195b8d5f8c5ebe8057635df5 |
| d2f7269 | https://github.com/plotly/plotly.js/commit/d2f726981671a5540841c93697751f778d63ff86 |
|
Compare
| https://github.com/plotly/plotly.js/compare/9f348eb6a639d0c3195b8d5f8c5ebe8057635df5..d2f726981671a5540841c93697751f778d63ff86 |
| January 4, 2021 14:20 | https://github.com/plotly/plotly.js/pull/5359#event-4165174556 |
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
| alexcjohnson | https://github.com/alexcjohnson |
| January 4, 2021 14:21 | https://github.com/plotly/plotly.js/pull/5359#event-4165177851 |
| https://github.com/alexcjohnson |
| alexcjohnson | https://github.com/alexcjohnson |
|
Jan 4, 2021
| https://github.com/plotly/plotly.js/pull/5359#pullrequestreview-561099396 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/5359/files/d2f726981671a5540841c93697751f778d63ff86 |
| alexcjohnson | https://github.com/alexcjohnson |
| https://github.com/plotly/plotly.js/pull/5359#pullrequestreview-561099396 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5359 |
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
| c72264c | https://github.com/plotly/plotly.js/commit/c72264cfa66dde899a0dfcd4da08c79dedb75ff7 |
| Jan 4, 2021 | https://github.com/plotly/plotly.js/pull/5359#event-4165372744 |
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
| January 4, 2021 15:04 | https://github.com/plotly/plotly.js/pull/5359#event-4165373028 |
| https://github.com/nicolaskruchten |
| nicolaskruchten | https://github.com/nicolaskruchten |
| Jan 4, 2021 | https://github.com/plotly/plotly.js/pull/5359#issuecomment-754044202 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5359 |
| https://github.com/nicolaskruchten |
| nicolaskruchten | https://github.com/nicolaskruchten |
| Jan 5, 2021 | https://github.com/plotly/plotly.js/pull/5359#issuecomment-754694184 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5359 |
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
| 1.59.0 | https://github.com/plotly/plotly.js/milestone/60 |
| Jan 5, 2021 | https://github.com/plotly/plotly.js/pull/5359#event-4171240742 |
|
Unexpected character in some bundles
#5382
| https://github.com/plotly/plotly.js/issues/5382 |
|
Add publish test for avoiding function constructors in non-gl(2d|3d) partial bundles
#5383
| https://github.com/plotly/plotly.js/pull/5383 |
| https://github.co/hiddenchars |
| https://github.com/plotly/plotly.js/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F5359 |
|
| https://github.com/alexcjohnson |
|
alexcjohnson
| https://github.com/alexcjohnson |
|
| https://github.com/plotly/plotly.js/pull/5359/files/d2f726981671a5540841c93697751f778d63ff86 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5359 |
|
v2.0.0
| https://github.com/plotly/plotly.js/milestone/60 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5359 |
|
| https://github.com/archmoj |
|
| https://github.com/nicolaskruchten |
|
| https://github.com/alexcjohnson |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |