René's URL Explorer Experiment


Title: Avoid function constructor in d3 by archmoj · Pull Request #5359 · plotly/plotly.js · GitHub

Open Graph Title: Avoid function constructor in d3 by archmoj · Pull Request #5359 · plotly/plotly.js

X Title: Avoid function constructor in d3 by archmoj · Pull Request #5359 · plotly/plotly.js

Description: Open-source JavaScript charting library behind Plotly and Dash - Avoid function constructor in d3 by archmoj · Pull Request #5359 · plotly/plotly.js

Open Graph Description: As mentioned in #897 (comment) d3@3.5.17 (as well as d3-dsv use function constructors in the source. This PR suggests refactoring d3 to avoid using function constructors. Demo @plotly/plotly_js

X Description: As mentioned in #897 (comment) d3@3.5.17 (as well as d3-dsv use function constructors in the source. This PR suggests refactoring d3 to avoid using function constructors. Demo @plotly/plotly_js

Opengraph URL: https://github.com/plotly/plotly.js/pull/5359

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:3af705c9-48c1-eb51-7396-924425b2ece0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCC14:3897F3:BC26C1:F44067:6B00EE3E
html-safe-noncefe83cbc8bafeb6fd2191068fa1a13ce7f772abaf8d630edcd173afb19af99834
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQzE0OjM4OTdGMzpCQzI2QzE6RjQ0MDY3OjZCMDBFRTNFIiwidmlzaXRvcl9pZCI6IjQzMDg0MTE0OTAzMjQ1MDgyMjIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac03cabee5fdc61d6dfac40407dd0b1e3bf362b264658758773d6b9ffd21e39030
hovercard-subject-tagpull_request:544382021
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/plotly/plotly.js/5359/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ba517fe45bd73f13a57a6fb4a25db8cd6ead810488b92bdba4b4c04637075621/plotly/plotly.js/pull/5359
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ba517fe45bd73f13a57a6fb4a25db8cd6ead810488b92bdba4b4c04637075621/plotly/plotly.js/pull/5359
og:image:altAs mentioned in #897 (comment) d3@3.5.17 (as well as d3-dsv use function constructors in the source. This PR suggests refactoring d3 to avoid using function constructors. Demo @plotly/plotly_js
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamearchmoj
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-cache
go-importgithub.com/plotly/plotly.js git https://github.com/plotly/plotly.js.git
octolytics-dimension-user_id5997976
octolytics-dimension-user_loginplotly
octolytics-dimension-repository_id45646037
octolytics-dimension-repository_nwoplotly/plotly.js
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id45646037
octolytics-dimension-repository_network_root_nwoplotly/plotly.js
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/plotly/plotly.js/pull/5359#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F5359
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F5359
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=plotly%2Fplotly.js
Reloadhttps://github.com/plotly/plotly.js/pull/5359
Reloadhttps://github.com/plotly/plotly.js/pull/5359
Reloadhttps://github.com/plotly/plotly.js/pull/5359
plotlyhttps://github.com/plotly
plotly.jshttps://github.com/plotly/plotly.js
Codehttps://github.com/plotly/plotly.js
Issues726 (726)https://github.com/plotly/plotly.js/issues
Pull requests84 (84)https://github.com/plotly/plotly.js/pulls
Actionshttps://github.com/plotly/plotly.js/actions
Security and qualityhttps://github.com/plotly/plotly.js/security
Insightshttps://github.com/plotly/plotly.js/insights
https://github.com/plotly/plotly.js
archmojhttps://github.com/archmoj
masterhttps://github.com/plotly/plotly.js/tree/master
d3-v3-no-eval-funchttps://github.com/plotly/plotly.js/tree/d3-v3-no-eval-func
Conversationhttps://github.com/plotly/plotly.js/pull/5359
Commits1 (1)https://github.com/plotly/plotly.js/pull/5359/commits
Checkshttps://github.com/plotly/plotly.js/pull/5359/checks
Files changedhttps://github.com/plotly/plotly.js/pull/5359/files
Avoid function constructor in d3https://github.com/plotly/plotly.js/pull/5359#top
archmojhttps://github.com/archmoj
masterhttps://github.com/plotly/plotly.js/tree/master
d3-v3-no-eval-funchttps://github.com/plotly/plotly.js/tree/d3-v3-no-eval-func
https://github.com/archmoj
archmojhttps://github.com/archmoj
Dec 22, 2020https://github.com/plotly/plotly.js/pull/5359#issue-773262937
Please reload this pagehttps://github.com/plotly/plotly.js/pull/5359
#897 (comment)https://github.com/plotly/plotly.js/issues/897#issuecomment-744512711
d3-dsvhttps://www.npmjs.com/package/d3-dsv
Demohttps://codepen.io/MojtabaSamimi/pen/mdrBOjr
Please reload this pagehttps://github.com/plotly/plotly.js/pull/5359
https://github.com/archmoj
archmojhttps://github.com/archmoj
type: maintenance https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22type%3A%20maintenance%22
Dec 22, 2020https://github.com/plotly/plotly.js/pull/5359#event-4141818992
https://github.com/archmoj
archmojhttps://github.com/archmoj
Dec 22, 2020 https://github.com/plotly/plotly.js/pull/5359#pullrequestreview-557376201
View reviewed changes https://github.com/plotly/plotly.js/pull/5359/files
package.jsonhttps://github.com/plotly/plotly.js/pull/5359/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
Please reload this pagehttps://github.com/plotly/plotly.js/pull/5359
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
Dec 27, 2020 https://github.com/plotly/plotly.js/pull/5359#pullrequestreview-558899891
View reviewed changes https://github.com/plotly/plotly.js/pull/5359/files
alexcjohnsonhttps://github.com/alexcjohnson
https://github.com/plotly/plotly.js/pull/5359#pullrequestreview-558899891
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/5359
https://github.com/archmoj
install and require @plotly/d3 forkhttps://github.com/plotly/plotly.js/pull/5359/commits/d2f726981671a5540841c93697751f778d63ff86
d2f7269https://github.com/plotly/plotly.js/pull/5359/commits/d2f726981671a5540841c93697751f778d63ff86
https://github.com/archmoj
archmojhttps://github.com/archmoj
force-pushedhttps://github.com/plotly/plotly.js/compare/9f348eb6a639d0c3195b8d5f8c5ebe8057635df5..d2f726981671a5540841c93697751f778d63ff86
9f348ebhttps://github.com/plotly/plotly.js/commit/9f348eb6a639d0c3195b8d5f8c5ebe8057635df5
d2f7269https://github.com/plotly/plotly.js/commit/d2f726981671a5540841c93697751f778d63ff86
Compare https://github.com/plotly/plotly.js/compare/9f348eb6a639d0c3195b8d5f8c5ebe8057635df5..d2f726981671a5540841c93697751f778d63ff86
January 4, 2021 14:20https://github.com/plotly/plotly.js/pull/5359#event-4165174556
https://github.com/archmoj
archmojhttps://github.com/archmoj
alexcjohnsonhttps://github.com/alexcjohnson
January 4, 2021 14:21https://github.com/plotly/plotly.js/pull/5359#event-4165177851
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
Jan 4, 2021 https://github.com/plotly/plotly.js/pull/5359#pullrequestreview-561099396
View reviewed changes https://github.com/plotly/plotly.js/pull/5359/files/d2f726981671a5540841c93697751f778d63ff86
alexcjohnsonhttps://github.com/alexcjohnson
https://github.com/plotly/plotly.js/pull/5359#pullrequestreview-561099396
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/5359
https://github.com/archmoj
archmojhttps://github.com/archmoj
c72264chttps://github.com/plotly/plotly.js/commit/c72264cfa66dde899a0dfcd4da08c79dedb75ff7
Jan 4, 2021https://github.com/plotly/plotly.js/pull/5359#event-4165372744
https://github.com/archmoj
archmojhttps://github.com/archmoj
January 4, 2021 15:04https://github.com/plotly/plotly.js/pull/5359#event-4165373028
https://github.com/nicolaskruchten
nicolaskruchtenhttps://github.com/nicolaskruchten
Jan 4, 2021https://github.com/plotly/plotly.js/pull/5359#issuecomment-754044202
Please reload this pagehttps://github.com/plotly/plotly.js/pull/5359
https://github.com/nicolaskruchten
nicolaskruchtenhttps://github.com/nicolaskruchten
Jan 5, 2021https://github.com/plotly/plotly.js/pull/5359#issuecomment-754694184
Please reload this pagehttps://github.com/plotly/plotly.js/pull/5359
https://github.com/archmoj
archmojhttps://github.com/archmoj
1.59.0https://github.com/plotly/plotly.js/milestone/60
Jan 5, 2021https://github.com/plotly/plotly.js/pull/5359#event-4171240742
Unexpected character in some bundles #5382 https://github.com/plotly/plotly.js/issues/5382
Add publish test for avoiding function constructors in non-gl(2d|3d) partial bundles #5383 https://github.com/plotly/plotly.js/pull/5383
https://github.co/hiddenchars
https://github.com/plotly/plotly.js/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F5359
https://github.com/alexcjohnson
alexcjohnson https://github.com/alexcjohnson
https://github.com/plotly/plotly.js/pull/5359/files/d2f726981671a5540841c93697751f778d63ff86
Please reload this pagehttps://github.com/plotly/plotly.js/pull/5359
v2.0.0 https://github.com/plotly/plotly.js/milestone/60
Please reload this pagehttps://github.com/plotly/plotly.js/pull/5359
https://github.com/archmoj
https://github.com/nicolaskruchten
https://github.com/alexcjohnson
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.