| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:bd2ed397-8b98-5773-a00d-ba6f78a5f0db |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C2A2:3C21B:F05465:13587C4:6B00FCC1 |
| html-safe-nonce | f2ab1d7f8c47688e2de49fd945040b270af16ac41a9f0d140c9dd27948658827 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMkEyOjNDMjFCOkYwNTQ2NToxMzU4N0M0OjZCMDBGQ0MxIiwidmlzaXRvcl9pZCI6IjcxNjIzMzM0ODUxNzk0MDM0NTgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 5ffb33845d7e11bfcd2c336114d970062ff9835229b86b2f614d30a735392b3d |
| hovercard-subject-tag | pull_request:529000599 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/plotly/plotly.js/5308/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/06c501ab4a9a4611cd7a8a3c76a96661554e29bc24a901665c06749f243d631a/plotly/plotly.js/pull/5308 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/06c501ab4a9a4611cd7a8a3c76a96661554e29bc24a901665c06749f243d631a/plotly/plotly.js/pull/5308 |
| og:image:alt | Overview
This PR builds off of #5230, with a candidate solution to the problem outlined in #5230 (comment).
Architecture Details
The approach is to perform the typed array decoding in coerce (befor... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jonmmease |
| hostname | github.com |
| expected-hostname | github.com |
| None | e208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187 |
| turbo-cache-control | no-cache |
| go-import | github.com/plotly/plotly.js git https://github.com/plotly/plotly.js.git |
| octolytics-dimension-user_id | 5997976 |
| octolytics-dimension-user_login | plotly |
| octolytics-dimension-repository_id | 45646037 |
| octolytics-dimension-repository_nwo | plotly/plotly.js |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 45646037 |
| octolytics-dimension-repository_network_root_nwo | plotly/plotly.js |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7dafd017fb7809a839c443dba08622af38e63c09 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/plotly/plotly.js/pull/5308#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F5308 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F5308 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=plotly%2Fplotly.js |
| Reload | https://github.com/plotly/plotly.js/pull/5308 |
| Reload | https://github.com/plotly/plotly.js/pull/5308 |
| Reload | https://github.com/plotly/plotly.js/pull/5308 |
| plotly | https://github.com/plotly |
| plotly.js | https://github.com/plotly/plotly.js |
| Code | https://github.com/plotly/plotly.js |
| Issues726 (726) | https://github.com/plotly/plotly.js/issues |
| Pull requests84 (84) | https://github.com/plotly/plotly.js/pulls |
| Actions | https://github.com/plotly/plotly.js/actions |
| Security and quality | https://github.com/plotly/plotly.js/security |
| Insights | https://github.com/plotly/plotly.js/insights |
| https://github.com/plotly/plotly.js |
| archmoj | https://github.com/archmoj |
| handle-coded-typed-arrays | https://github.com/plotly/plotly.js/tree/handle-coded-typed-arrays |
| jonmmease_typed_array_encoding | https://github.com/plotly/plotly.js/tree/jonmmease_typed_array_encoding |
| Conversation | https://github.com/plotly/plotly.js/pull/5308 |
| Commits9 (9) | https://github.com/plotly/plotly.js/pull/5308/commits |
| Checks | https://github.com/plotly/plotly.js/pull/5308/checks |
| Files changed | https://github.com/plotly/plotly.js/pull/5308/files |
| WIP: Typed array encoding in supplyDefaults with Caching | https://github.com/plotly/plotly.js/pull/5308#top |
| archmoj | https://github.com/archmoj |
| handle-coded-typed-arrays | https://github.com/plotly/plotly.js/tree/handle-coded-typed-arrays |
| jonmmease_typed_array_encoding | https://github.com/plotly/plotly.js/tree/jonmmease_typed_array_encoding |
|
| https://github.com/jonmmease |
| jonmmease | https://github.com/jonmmease |
| Nov 28, 2020 | https://github.com/plotly/plotly.js/pull/5308#issue-752754108 |
| #5230 | https://github.com/plotly/plotly.js/pull/5230 |
| #5230 (comment) | https://github.com/plotly/plotly.js/pull/5230#issuecomment-735271393 |
| #5230 | https://github.com/plotly/plotly.js/pull/5230 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5308 |
| jonmmease | https://github.com/jonmmease |
| November 28, 2020 09:34 | https://github.com/plotly/plotly.js/pull/5308#commits-pushed-67ccac9 |
|
| https://github.com/jonmmease |
| Revert trace changes | https://github.com/plotly/plotly.js/pull/5308/commits/67ccac94e30ceb9063dd4db6edf469b55988c0a4 |
| 67ccac9 | https://github.com/plotly/plotly.js/pull/5308/commits/67ccac94e30ceb9063dd4db6edf469b55988c0a4 |
|
| https://github.com/jonmmease |
| WIP of decoding in calc. | https://github.com/plotly/plotly.js/pull/5308/commits/712a124ea14702629ae6aecbcbf32c8cb5d6dcbb |
| 712a124 | https://github.com/plotly/plotly.js/pull/5308/commits/712a124ea14702629ae6aecbcbf32c8cb5d6dcbb |
|
| https://github.com/jonmmease |
| Back to decoding in coerce | https://github.com/plotly/plotly.js/pull/5308/commits/4d5b3820f191a4b8a2e80d5d3659d76b3c7d2feb |
| 4d5b382 | https://github.com/plotly/plotly.js/pull/5308/commits/4d5b3820f191a4b8a2e80d5d3659d76b3c7d2feb |
|
| https://github.com/jonmmease |
| Cache base64 decoded ArrayBuffers and keep decoding in coerce / suppl… | https://github.com/plotly/plotly.js/pull/5308/commits/7233f34e25735a7ab66d4d8271701f96e64dc5b0 |
| 7233f34 | https://github.com/plotly/plotly.js/pull/5308/commits/7233f34e25735a7ab66d4d8271701f96e64dc5b0 |
| https://github.com/jonmmease |
| jonmmease | https://github.com/jonmmease |
| November 28, 2020 19:46 | https://github.com/plotly/plotly.js/pull/5308#event-4048387178 |
| jonmmease | https://github.com/jonmmease |
| November 28, 2020 15:09 | https://github.com/plotly/plotly.js/pull/5308#commits-pushed-5079fc7 |
|
| https://github.com/jonmmease |
| bvals -> buffer | https://github.com/plotly/plotly.js/pull/5308/commits/5079fc79aa9a3f573d910bd534b8cce70fe42ebf |
| 5079fc7 | https://github.com/plotly/plotly.js/pull/5308/commits/5079fc79aa9a3f573d910bd534b8cce70fe42ebf |
|
| https://github.com/jonmmease |
| remove big for consistency | https://github.com/plotly/plotly.js/pull/5308/commits/38e10bb6b313ca667a29dfd12e3bd6acbef4d6fe |
| 38e10bb | https://github.com/plotly/plotly.js/pull/5308/commits/38e10bb6b313ca667a29dfd12e3bd6acbef4d6fe |
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
|
status: reviewable
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22status%3A%20reviewable%22 |
|
feature
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Afeature |
| Nov 28, 2020 | https://github.com/plotly/plotly.js/pull/5308#event-4048423857 |
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
|
Nov 28, 2020
| https://github.com/plotly/plotly.js/pull/5308#pullrequestreview-540416427 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/5308/files/5079fc79aa9a3f573d910bd534b8cce70fe42ebf |
| src/lib/array.js | https://github.com/plotly/plotly.js/pull/5308/files/5079fc79aa9a3f573d910bd534b8cce70fe42ebf#diff-459a89970d7ac2d1323f78c770d768ecbbfb9f698b0d1e25e8010e0eb73f56ed |
| archmoj | https://github.com/archmoj |
| Nov 28, 2020 | https://github.com/plotly/plotly.js/pull/5308#discussion_r532104168 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5308 |
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
|
Nov 28, 2020
| https://github.com/plotly/plotly.js/pull/5308#pullrequestreview-540417058 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/5308/files/5079fc79aa9a3f573d910bd534b8cce70fe42ebf |
| src/lib/array.js | https://github.com/plotly/plotly.js/pull/5308/files/5079fc79aa9a3f573d910bd534b8cce70fe42ebf#diff-459a89970d7ac2d1323f78c770d768ecbbfb9f698b0d1e25e8010e0eb73f56ed |
| archmoj | https://github.com/archmoj |
| Nov 28, 2020 | https://github.com/plotly/plotly.js/pull/5308#discussion_r532105407 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5308 |
| jonmmease | https://github.com/jonmmease |
| Nov 28, 2020 | https://github.com/plotly/plotly.js/pull/5308#discussion_r532106957 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5308 |
| jonmmease | https://github.com/jonmmease |
| November 28, 2020 16:05 | https://github.com/plotly/plotly.js/pull/5308#commits-pushed-1043827 |
|
| https://github.com/jonmmease |
| Revert "bvals -> buffer" | https://github.com/plotly/plotly.js/pull/5308/commits/104382711ee192f4de488f3c3e4497901a5c6430 |
| 1043827 | https://github.com/plotly/plotly.js/pull/5308/commits/104382711ee192f4de488f3c3e4497901a5c6430 |
| 5079fc7 | https://github.com/plotly/plotly.js/commit/5079fc79aa9a3f573d910bd534b8cce70fe42ebf |
|
| https://github.com/jonmmease |
| Run isArray1D on decoded array not spec | https://github.com/plotly/plotly.js/pull/5308/commits/8d84f3e212c2203825a1a9ce4ca6d73f19520d58 |
| 8d84f3e | https://github.com/plotly/plotly.js/pull/5308/commits/8d84f3e212c2203825a1a9ce4ca6d73f19520d58 |
|
| https://github.com/jonmmease |
| Plotly.js doesn't currently handle BigInt64/BigUint64 arrays. | https://github.com/plotly/plotly.js/pull/5308/commits/2381debfb89d4e7e638165021b4577fe35935c13 |
| 2381deb | https://github.com/plotly/plotly.js/pull/5308/commits/2381debfb89d4e7e638165021b4577fe35935c13 |
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
| Nov 29, 2020 | https://github.com/plotly/plotly.js/pull/5308#issuecomment-735435170 |
| #5230 | https://github.com/plotly/plotly.js/pull/5230 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5308 |
| https://github.com/jonmmease |
| jonmmease | https://github.com/jonmmease |
| November 29, 2020 20:01 | https://github.com/plotly/plotly.js/pull/5308#event-4049363015 |
| https://github.com/jonmmease |
| jonmmease | https://github.com/jonmmease |
| Nov 29, 2020 | https://github.com/plotly/plotly.js/pull/5308#issuecomment-735446013 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5308 |
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
| Nov 29, 2020 | https://github.com/plotly/plotly.js/pull/5308#issuecomment-735446352 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5308 |
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
| November 29, 2020 20:10 | https://github.com/plotly/plotly.js/pull/5308#event-4049370130 |
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
| a0d980e | https://github.com/plotly/plotly.js/commit/a0d980ed8863d286d225957b044aeff119718c99 |
| Nov 29, 2020 | https://github.com/plotly/plotly.js/pull/5308#event-4049370551 |
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
| November 29, 2020 20:11 | https://github.com/plotly/plotly.js/pull/5308#event-4049370650 |
| https://github.co/hiddenchars |
| https://github.com/plotly/plotly.js/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F5308 |
|
| https://github.com/archmoj |
|
archmoj
| https://github.com/archmoj |
|
| https://github.com/plotly/plotly.js/pull/5308/files/5079fc79aa9a3f573d910bd534b8cce70fe42ebf |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5308 |
|
feature
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Afeature |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5308 |
|
| https://github.com/jonmmease |
|
| https://github.com/archmoj |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |